From: Johan Hovold <johan@kernel.org>
To: Yann Garras <yann.garras@y3s.fr>
Cc: Johan Hovold <johan@kernel.org>, linux-usb@vger.kernel.org
Subject: Re: [PATCH] USB: serial: option: creating of the missings constants for Telit products
Date: Wed, 4 Nov 2020 11:40:56 +0100 [thread overview]
Message-ID: <20201104104056.GV4085@localhost> (raw)
In-Reply-To: <CACosQq_fHtfdp9sevpVz4jn0uao1m2S5Lmd_27p3LGbFRwScLw@mail.gmail.com>
On Fri, Oct 30, 2020 at 06:22:20PM +0100, Yann Garras wrote:
> Hi,
> Thank you for your response.
>
> Personally, I find more valuable to read :
> { USB_DEVICE_INTERFACE_CLASS(TELIT_VENDOR_ID, TELIT_PRODUCT_LE910C1_EUX,
> 0xff),
> .driver_info = NCTRL(0) | RSVD(3) },
>
> Rather than
> { USB_DEVICE_INTERFACE_CLASS(TELIT_VENDOR_ID, 0x1031, 0xff),
> .driver_info = NCTRL(0) | RSVD(3) },
Sure, but we try to keep the model name in a comment after the entry.
That way you get a more compact notation (one line less) and you can
still find the model name easily.
> But where I agree with you, is to make a choice and apply it.
Yeah, the current half-measure isn't optimal.
Johan
prev parent reply other threads:[~2020-11-04 10:40 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-30 15:39 [PATCH] USB: serial: option: creating of the missings constants for Telit products Yann GARRAS
2020-10-30 15:44 ` Johan Hovold
[not found] ` <CACosQq_fHtfdp9sevpVz4jn0uao1m2S5Lmd_27p3LGbFRwScLw@mail.gmail.com>
2020-11-04 10:40 ` Johan Hovold [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201104104056.GV4085@localhost \
--to=johan@kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=yann.garras@y3s.fr \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.