From: "Philippe Mathieu-Daudé" <philmd@redhat.com>
To: qemu-devel@nongnu.org
Cc: "Fam Zheng" <fam@euphon.net>, "Thomas Huth" <thuth@redhat.com>,
"Daniel P . Berrange" <berrange@redhat.com>,
"Matthew Rosato" <mjrosato@linux.ibm.com>,
"David Hildenbrand" <david@redhat.com>,
"Alex Bennée" <alex.bennee@linaro.org>,
"Cornelia Huck" <cohuck@redhat.com>,
"Christian Schoenebeck" <qemu_oss@crudebyte.com>,
"Greg Kurz" <groug@kaod.org>,
"Wainer dos Santos Moschetta" <wainersm@redhat.com>,
"Halil Pasic" <pasic@linux.ibm.com>,
"Christian Borntraeger" <borntraeger@de.ibm.com>,
qemu-s390x@nongnu.org, "Paolo Bonzini" <pbonzini@redhat.com>,
"Philippe Mathieu-Daudé" <philmd@redhat.com>,
"Richard Henderson" <rth@twiddle.net>
Subject: [PATCH-for-5.2 v3 1/4] s390x: fix build for --without-default-devices
Date: Wed, 4 Nov 2020 12:57:03 +0100 [thread overview]
Message-ID: <20201104115706.3101190-2-philmd@redhat.com> (raw)
In-Reply-To: <20201104115706.3101190-1-philmd@redhat.com>
From: Cornelia Huck <cohuck@redhat.com>
s390-pci-vfio.c calls into the vfio code, so we need it to be
built conditionally on vfio (which implies CONFIG_LINUX).
Reported-by: Philippe Mathieu-Daudé <philmd@redhat.com>
Fixes: cd7498d07fbb ("s390x/pci: Add routine to get the vfio dma available count")
Signed-off-by: Cornelia Huck <cohuck@redhat.com>
Message-Id: <20201103123237.718242-1-cohuck@redhat.com>
Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
Tested-by: Philippe Mathieu-Daudé <philmd@redhat.com>
Acked-by: Greg Kurz <groug@kaod.org>
Tested-by: Greg Kurz <groug@kaod.org>
Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
---
include/hw/s390x/s390-pci-vfio.h | 3 ++-
hw/s390x/meson.build | 2 +-
2 files changed, 3 insertions(+), 2 deletions(-)
diff --git a/include/hw/s390x/s390-pci-vfio.h b/include/hw/s390x/s390-pci-vfio.h
index c7984905b3b..ff708aef500 100644
--- a/include/hw/s390x/s390-pci-vfio.h
+++ b/include/hw/s390x/s390-pci-vfio.h
@@ -13,8 +13,9 @@
#define HW_S390_PCI_VFIO_H
#include "hw/s390x/s390-pci-bus.h"
+#include CONFIG_DEVICES
-#ifdef CONFIG_LINUX
+#ifdef CONFIG_VFIO
bool s390_pci_update_dma_avail(int fd, unsigned int *avail);
S390PCIDMACount *s390_pci_start_dma_count(S390pciState *s,
S390PCIBusDevice *pbdev);
diff --git a/hw/s390x/meson.build b/hw/s390x/meson.build
index f4663a83551..2a7818d94b9 100644
--- a/hw/s390x/meson.build
+++ b/hw/s390x/meson.build
@@ -27,7 +27,7 @@
))
s390x_ss.add(when: 'CONFIG_S390_CCW_VIRTIO', if_true: files('s390-virtio-ccw.c'))
s390x_ss.add(when: 'CONFIG_TERMINAL3270', if_true: files('3270-ccw.c'))
-s390x_ss.add(when: 'CONFIG_LINUX', if_true: files('s390-pci-vfio.c'))
+s390x_ss.add(when: 'CONFIG_VFIO', if_true: files('s390-pci-vfio.c'))
virtio_ss = ss.source_set()
virtio_ss.add(files('virtio-ccw.c'))
--
2.26.2
next prev parent reply other threads:[~2020-11-04 11:58 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-04 11:57 [PATCH-for-5.2 v3 0/4] ci: Move --without-default-devices job from Travis to GitLab Philippe Mathieu-Daudé
2020-11-04 11:57 ` Philippe Mathieu-Daudé [this message]
2020-11-04 17:25 ` [PATCH-for-5.2 v3 1/4] s390x: fix build for --without-default-devices Cornelia Huck
2020-11-05 11:58 ` Philippe Mathieu-Daudé
2020-11-05 12:01 ` Cornelia Huck
2020-11-05 14:43 ` Cornelia Huck
2020-11-04 11:57 ` [PATCH-for-5.2 v3 2/4] hw/9pfs: Fix Kconfig dependency problem between 9pfs and Xen Philippe Mathieu-Daudé
2020-11-04 11:57 ` Philippe Mathieu-Daudé
2020-11-04 12:18 ` Christian Schoenebeck
2020-11-04 17:54 ` Greg Kurz
2020-11-04 17:54 ` Greg Kurz
2020-11-05 12:15 ` Philippe Mathieu-Daudé
2020-11-05 12:15 ` Philippe Mathieu-Daudé
2020-11-05 12:23 ` Greg Kurz
2020-11-05 12:23 ` Greg Kurz
2020-11-05 12:28 ` Christian Schoenebeck
2020-11-05 15:06 ` Christian Schoenebeck
2020-11-04 11:57 ` [PATCH-for-5.2 v3 3/4] gitlab-ci: Add a job to cover the --without-default-devices config Philippe Mathieu-Daudé
2020-11-04 12:12 ` Wainer dos Santos Moschetta
2020-11-04 11:57 ` [PATCH-for-5.2 v3 4/4] travis-ci: Remove the --without-default-devices job Philippe Mathieu-Daudé
2020-11-04 12:16 ` Wainer dos Santos Moschetta
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201104115706.3101190-2-philmd@redhat.com \
--to=philmd@redhat.com \
--cc=alex.bennee@linaro.org \
--cc=berrange@redhat.com \
--cc=borntraeger@de.ibm.com \
--cc=cohuck@redhat.com \
--cc=david@redhat.com \
--cc=fam@euphon.net \
--cc=groug@kaod.org \
--cc=mjrosato@linux.ibm.com \
--cc=pasic@linux.ibm.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-s390x@nongnu.org \
--cc=qemu_oss@crudebyte.com \
--cc=rth@twiddle.net \
--cc=thuth@redhat.com \
--cc=wainersm@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.