From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.7 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1BBBFC2D0A3 for ; Wed, 4 Nov 2020 11:58:25 +0000 (UTC) Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 49F7620759 for ; Wed, 4 Nov 2020 11:58:23 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=alsa-project.org header.i=@alsa-project.org header.b="jCVdqsVL"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="gBW/wRXV" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 49F7620759 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linuxfoundation.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=alsa-devel-bounces@alsa-project.org Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id 969A0166C; Wed, 4 Nov 2020 12:57:31 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz 969A0166C DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1604491101; bh=goCd/FsixsuhFDQdIYZUh9ms1ET37ZuEkEzXEWKQDgY=; h=Date:From:To:Subject:References:In-Reply-To:Cc:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=jCVdqsVLD6AWXbjyHW/e3y/c9j2z65TEKwPXw+Rxht48S2r27LEp3ECZ8aOOc8isK 0PuD7Nniwj8KPFlAdGo2xnUX43XuN+gIyHCRGJzTZXRMtze8lynNU7zM8L2VC/NCCR LIeR7cGuQw86hwy3HeO5QXmg5pyiXWQGhVsh0GpA= Received: from alsa1.perex.cz (localhost.localdomain [127.0.0.1]) by alsa1.perex.cz (Postfix) with ESMTP id 2EFB1F8015A; Wed, 4 Nov 2020 12:57:31 +0100 (CET) Received: by alsa1.perex.cz (Postfix, from userid 50401) id 58AB6F8023E; Wed, 4 Nov 2020 12:57:29 +0100 (CET) Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id 62436F8015A for ; Wed, 4 Nov 2020 12:57:22 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz 62436F8015A Authentication-Results: alsa1.perex.cz; dkim=pass (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="gBW/wRXV" Received: from localhost (83-86-74-64.cable.dynamic.v4.ziggo.nl [83.86.74.64]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 2641220759; Wed, 4 Nov 2020 11:57:18 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1604491039; bh=goCd/FsixsuhFDQdIYZUh9ms1ET37ZuEkEzXEWKQDgY=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=gBW/wRXVSiC3ZN6j4jEa4wzxZdeawe1Jr5n7hg1AfVtBWXSQ4PgdUePxIxKaFFmqd BYrL61Hsw718XoSK/cieL5MBCZzyqXcuaca9+r161xvqJwKKntBjZzedVzuSvsLGY8 K6Oc10fjc7M1RmAwTVBIbPB5loOBd47cQ4e5yzF8= Date: Wed, 4 Nov 2020 12:58:10 +0100 From: Greg KH To: "Gorski, Mateusz" Subject: Re: [PATCH] ASoC: Intel: Skylake: Add alternative topology binary name Message-ID: <20201104115810.GA1694250@kroah.com> References: <20201103141047.15053-1-mateusz.gorski@linux.intel.com> <20201103153541.GC3267686@kroah.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Cc: cezary.rojewski@intel.com, alsa-devel@alsa-project.org, Mark Brown , linux-kernel@vger.kernel.org, stable@vger.kernel.org X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" On Wed, Nov 04, 2020 at 12:46:36PM +0100, Gorski, Mateusz wrote: > > > > [ Upstream commit 1b290ef023b3eeb4f4688b582fecb773915ef937 ] > > > > > > Add alternative topology binary file name based on used machine driver > > > and fallback to use this name after failed attempt to load topology file > > > with name based on NHLT. > > > This change addresses multiple issues with current mechanism, for > > > example - there are devices without NHLT table, and that currently > > > results in tplg_name being empty. > > > > > > Signed-off-by: Mateusz Gorski > > > Reviewed-by: Cezary Rojewski > > > Reviewed-by: Pierre-Louis Bossart > > > Link: https://lore.kernel.org/r/20200427132727.24942-2-mateusz.gorski@linux.intel.com > > > Signed-off-by: Mark Brown > > > --- > > > > > > This functionality is merged on upstream kernel and widely used. Merging > > > it to LTS kernel would improve the user experience and resolve some of the > > > problems regarding topology naming that the users are facing. > > What problems are people facing, and what kernel(s) are you asking for > > this to be ported to, and why can't people just use 5.8 or newer if they > > have this new hardware? > > > > thanks, > > > > greg k-h > > I forgot to add - I wanted this change to be merged to stable 5.4 kernel. > Please let me know if I should resend this patch with this information > included. > > As for the user issues - topology binary file name is currently created > according to information from NHLT. The problem is, that some laptops (for > example Dell XPS 13) do not have NHLT at all. This results in topology > binary name being empty (" "). > This patch adds alternative name based on loaded machine driver. > > It applies not only to new hardware, please note that the mentioned Dell XPS > 13 is based on Kabylake. This issue existed on upstream from the beginning > of Skylake driver and was only recently addressed. When was that laptop released and is this the only change that is needed in order for the 5.4.y kernel to work properly on it? thanks, greg k-h From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 15995C2D0A3 for ; Wed, 4 Nov 2020 11:57:29 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 999172236F for ; Wed, 4 Nov 2020 11:57:28 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1604491048; bh=goCd/FsixsuhFDQdIYZUh9ms1ET37ZuEkEzXEWKQDgY=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=b8SUIMGVH0/Esj2DlAcNq3svMMx0diPDWLyl999rZ5Cafc28kzxH8Qr2r2qZhwFQY zbWWnQLZ1k+ZyOqGLVodPjihO0N2RRERoCqPRDmEv4li4HHi6i4EIxhsg4dSQxsXSv 6N+yNuqHDvQVhLbe8Uz9QHUA1wHjH67EDzavwwSc= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729818AbgKDL51 (ORCPT ); Wed, 4 Nov 2020 06:57:27 -0500 Received: from mail.kernel.org ([198.145.29.99]:34664 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728645AbgKDL5U (ORCPT ); Wed, 4 Nov 2020 06:57:20 -0500 Received: from localhost (83-86-74-64.cable.dynamic.v4.ziggo.nl [83.86.74.64]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 2641220759; Wed, 4 Nov 2020 11:57:18 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1604491039; bh=goCd/FsixsuhFDQdIYZUh9ms1ET37ZuEkEzXEWKQDgY=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=gBW/wRXVSiC3ZN6j4jEa4wzxZdeawe1Jr5n7hg1AfVtBWXSQ4PgdUePxIxKaFFmqd BYrL61Hsw718XoSK/cieL5MBCZzyqXcuaca9+r161xvqJwKKntBjZzedVzuSvsLGY8 K6Oc10fjc7M1RmAwTVBIbPB5loOBd47cQ4e5yzF8= Date: Wed, 4 Nov 2020 12:58:10 +0100 From: Greg KH To: "Gorski, Mateusz" Cc: stable@vger.kernel.org, linux-kernel@vger.kernel.org, alsa-devel@alsa-project.org, cezary.rojewski@intel.com, Mark Brown Subject: Re: [PATCH] ASoC: Intel: Skylake: Add alternative topology binary name Message-ID: <20201104115810.GA1694250@kroah.com> References: <20201103141047.15053-1-mateusz.gorski@linux.intel.com> <20201103153541.GC3267686@kroah.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Nov 04, 2020 at 12:46:36PM +0100, Gorski, Mateusz wrote: > > > > [ Upstream commit 1b290ef023b3eeb4f4688b582fecb773915ef937 ] > > > > > > Add alternative topology binary file name based on used machine driver > > > and fallback to use this name after failed attempt to load topology file > > > with name based on NHLT. > > > This change addresses multiple issues with current mechanism, for > > > example - there are devices without NHLT table, and that currently > > > results in tplg_name being empty. > > > > > > Signed-off-by: Mateusz Gorski > > > Reviewed-by: Cezary Rojewski > > > Reviewed-by: Pierre-Louis Bossart > > > Link: https://lore.kernel.org/r/20200427132727.24942-2-mateusz.gorski@linux.intel.com > > > Signed-off-by: Mark Brown > > > --- > > > > > > This functionality is merged on upstream kernel and widely used. Merging > > > it to LTS kernel would improve the user experience and resolve some of the > > > problems regarding topology naming that the users are facing. > > What problems are people facing, and what kernel(s) are you asking for > > this to be ported to, and why can't people just use 5.8 or newer if they > > have this new hardware? > > > > thanks, > > > > greg k-h > > I forgot to add - I wanted this change to be merged to stable 5.4 kernel. > Please let me know if I should resend this patch with this information > included. > > As for the user issues - topology binary file name is currently created > according to information from NHLT. The problem is, that some laptops (for > example Dell XPS 13) do not have NHLT at all. This results in topology > binary name being empty (" "). > This patch adds alternative name based on loaded machine driver. > > It applies not only to new hardware, please note that the mentioned Dell XPS > 13 is based on Kabylake. This issue existed on upstream from the beginning > of Skylake driver and was only recently addressed. When was that laptop released and is this the only change that is needed in order for the 5.4.y kernel to work properly on it? thanks, greg k-h