From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from list by lists.gnu.org with archive (Exim 4.90_1) id 1kaHdp-0006ln-Sw for mharc-grub-devel@gnu.org; Wed, 04 Nov 2020 07:11:53 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:34278) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kaHdo-0006lA-BC for grub-devel@gnu.org; Wed, 04 Nov 2020 07:11:52 -0500 Received: from mail-wr1-x442.google.com ([2a00:1450:4864:20::442]:43830) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kaHdm-0007hV-I2 for grub-devel@gnu.org; Wed, 04 Nov 2020 07:11:52 -0500 Received: by mail-wr1-x442.google.com with SMTP id g12so21758878wrp.10 for ; Wed, 04 Nov 2020 04:11:49 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nuviainc-com.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=EWBXgJnP6ZMmAVaJhl+iR2yivrPLX4y7qTlVADqn+sQ=; b=02EU0SugVCvcNv5FZKpz4AouKz2Hd0mP5NCdXYWBe8Ow8wnnu2Gb9V3HBWS3pkIqC2 AaSSsxieSHboL/jsVD4YWTW+VTwa2z1i5whvLZFzVz/J2tMQFok6LxDslPK1Fen7v2WL Lcxm8dOiLEPzA1M1Il0a4ehrzZHUagIq63dawoeay9OQ5FHV1ElKgHHAWghWtdwhgyrF KVLiV0cIdoOhLWDz2xdht4cMrsekFZsxIVcVORqeWNsEpJx9C1zTAjYaOyL3RZyN49kL A9DD+L3R8MmUqOMl3An3C3g6rHPi6nOeP2PTAMmkHMCBLEbiWuBlrwepvZavkDtjwFVn BDLg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=EWBXgJnP6ZMmAVaJhl+iR2yivrPLX4y7qTlVADqn+sQ=; b=cwCctFxjYNPx0iLV4+HsFkfbKShCx9Y/7X+Q0AsnX05fJjF7eblRVsu3EMHzT3psU5 IgEIh0oT9dk/ViS9tYd30sGP7We834pUlf5jTe5gQxk/M9rxZxkIACiLjc74gtuA2kRC 1+5UfQDTspKny9jexY4AnHxSBxh2Qm+3pjVrUWSHt2cA2Ur5ulHumXeQ5ew0YcpQcd/N TdGma0znJrzfyEMialzPFnME/HEeHurLCLvM3Vq246LlHvgom0FVfW4G5kM0MQzyGfPN 6HDrIjasg1fR5uASJefDGF7A1jNzjPSNrX8GID6Plj88LKRaAyJtT8PTzndwM4z7zNe0 l3CA== X-Gm-Message-State: AOAM531+Lm4QLsmo0nWXR9iBcoo8ZSKB5VvQC4Dsaxk201KVTUhsyZqq LfvvYJLogJvF5wm4+x+AZg4pJA== X-Google-Smtp-Source: ABdhPJwcW7xxOT2fCMTy+ARJtIrMwVEjH9MT8L56YudRzFer8fExYnGFG+7EcvahcnaTdASFqcPtcw== X-Received: by 2002:adf:f1c1:: with SMTP id z1mr32315036wro.331.1604491908650; Wed, 04 Nov 2020 04:11:48 -0800 (PST) Received: from vanye (cpc92880-cmbg19-2-0-cust79.5-4.cable.virginm.net. [82.27.104.80]) by smtp.gmail.com with ESMTPSA id u15sm2133387wrm.77.2020.11.04.04.11.47 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 04 Nov 2020 04:11:48 -0800 (PST) Date: Wed, 4 Nov 2020 12:11:46 +0000 From: Leif Lindholm To: Ard Biesheuvel Cc: linux-efi@vger.kernel.org, grub-devel@gnu.org, daniel.kiper@oracle.com Subject: Re: [PATCH v2 1/8] linux/arm: fix ARM Linux header layout Message-ID: <20201104121146.GT1664@vanye> References: <20201025134941.4805-1-ard.biesheuvel@arm.com> <20201025134941.4805-2-ard.biesheuvel@arm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20201025134941.4805-2-ard.biesheuvel@arm.com> User-Agent: Mutt/1.10.1 (2018-07-13) Received-SPF: pass client-ip=2a00:1450:4864:20::442; envelope-from=leif@nuviainc.com; helo=mail-wr1-x442.google.com X-detected-operating-system: by eggs.gnu.org: No matching host in p0f cache. That's all we know. X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: The development of GNU GRUB List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 04 Nov 2020 12:11:52 -0000 On Sun, Oct 25, 2020 at 14:49:34 +0100, Ard Biesheuvel wrote: > The hdr_offset member of the ARM Linux image header appears at > offset 0x3c, matching the PE/COFF spec's placement of the COFF > header offset in the MS-DOS header. We're currently off by four, > so fix that. > > Signed-off-by: Ard Biesheuvel > --- > include/grub/arm/linux.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/include/grub/arm/linux.h b/include/grub/arm/linux.h > index 2e98a6689696..bcd5a7eb186e 100644 > --- a/include/grub/arm/linux.h > +++ b/include/grub/arm/linux.h > @@ -30,7 +30,7 @@ struct linux_arm_kernel_header { > grub_uint32_t magic; > grub_uint32_t start; /* _start */ > grub_uint32_t end; /* _edata */ > - grub_uint32_t reserved2[4]; > + grub_uint32_t reserved2[3]; > grub_uint32_t hdr_offset; How did this ever work? / Leif > }; > > -- > 2.17.1 >