From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.2 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6FFD5C2D0A3 for ; Wed, 4 Nov 2020 13:27:14 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 1321722243 for ; Wed, 4 Nov 2020 13:27:13 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729847AbgKDN1N (ORCPT ); Wed, 4 Nov 2020 08:27:13 -0500 Received: from foss.arm.com ([217.140.110.172]:37138 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729794AbgKDN1N (ORCPT ); Wed, 4 Nov 2020 08:27:13 -0500 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 56447139F; Wed, 4 Nov 2020 05:27:12 -0800 (PST) Received: from localhost (unknown [10.1.198.32]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id EC37A3F719; Wed, 4 Nov 2020 05:27:11 -0800 (PST) Date: Wed, 4 Nov 2020 13:27:10 +0000 From: Ionela Voinescu To: Dmitry Baryshkov Cc: Bjorn Andersson , Andy Gross , Catalin Marinas , Will Deacon , linux-arm-msm@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH 1/4] arm64: defconfig: enable INTERCONNECT for Qualcomm chipsets Message-ID: <20201104132655.GA1951@arm.com> References: <20200917203913.3250205-1-dmitry.baryshkov@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200917203913.3250205-1-dmitry.baryshkov@linaro.org> User-Agent: Mutt/1.9.4 (2018-02-28) Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org Hi guys, On Thursday 17 Sep 2020 at 23:39:10 (+0300), Dmitry Baryshkov wrote: > Enable CONFIG_INTERCONNECT and interconnect drivers for several Qualcomm > chipsets to enable bus bandwidth control on these SoCs. > > Signed-off-by: Dmitry Baryshkov > --- > arch/arm64/configs/defconfig | 6 ++++++ > 1 file changed, 6 insertions(+) > > diff --git a/arch/arm64/configs/defconfig b/arch/arm64/configs/defconfig > index 63003ec116ee..2e746ebb9245 100644 > --- a/arch/arm64/configs/defconfig > +++ b/arch/arm64/configs/defconfig > @@ -1023,6 +1023,12 @@ CONFIG_SLIMBUS=m > CONFIG_SLIM_QCOM_CTRL=m > CONFIG_SLIM_QCOM_NGD_CTRL=m > CONFIG_MUX_MMIO=y > +CONFIG_INTERCONNECT=y > +CONFIG_INTERCONNECT_QCOM=y > +CONFIG_INTERCONNECT_QCOM_MSM8916=m > +CONFIG_INTERCONNECT_QCOM_SDM845=m > +CONFIG_INTERCONNECT_QCOM_SM8150=m > +CONFIG_INTERCONNECT_QCOM_SM8250=m This needs an additional +CONFIG_INTERCONNECT_QCOM_OSM_L3=m or +CONFIG_INTERCONNECT_QCOM_OSM_L3=y Without it cpufreq fails to initialize on DB845c. When CONFIG_INTERCONNECT_QCOM_OSM_L3=n (which is what it will default to when doing ARCH=arm64 make defcofnig), the osm_l3 is not registered as a provider and therefore will not be found when doing: qcom_cpufreq_hw_driver_probe() -> dev_pm_opp_of_find_icc_paths() -> of_icc_get_by_index(). This being said, it also does not feel right for cpufreq enablement to depend on L3 scaling enablement, so better error filtering might be needed in the drivers instead. But I'll leave that decision to you, while the above is only a quick fix. The issue is reproduced with linux next 20201104, after applying the iommu patches at [1]. Hope it helps, Ionela. [1] https://lore.kernel.org/lkml/160399513141.1314250.8831514745970142969.b4-ty@kernel.org/ > CONFIG_EXT2_FS=y > CONFIG_EXT3_FS=y > CONFIG_EXT4_FS_POSIX_ACL=y > -- > 2.28.0 > > > _______________________________________________ > linux-arm-kernel mailing list > linux-arm-kernel@lists.infradead.org > http://lists.infradead.org/mailman/listinfo/linux-arm-kernel From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.2 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2162FC2D0A3 for ; Wed, 4 Nov 2020 13:28:37 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id B6A7420867 for ; Wed, 4 Nov 2020 13:28:36 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="FJGKRI1T" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org B6A7420867 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=arm.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=gt8d5drR+JPLIm+4SVxIHTIUyahKxWNcYN+zfUmDigU=; b=FJGKRI1TmRnqKV8SKhBFOfNsW f1pgtf69/wEX22IDr3CLrCTfeIIcfczmGHgxGV2aS0lrwTqhrXztrtmhLPcdMypkhjl5iaJFjALDM k5c36xM/n61ICwbaUwfxU1hdGt55kFbR4xjGMbDf1qFFExVn8mKcYudPA3qG2v8AHErs+XH+QEVEl Zs8qmUqQankLIouLjFYySYIhBBaoiRSvmCd5h9+bwuCHnIg2LZOeTYJlwqiPC9DXTlAtZ2vwybgS7 qFY8Th8hRQz7ZNeMYhxOzbUyyWTXkTLBTijPASJsRZj8eZ3F6jnUCJnVMaeoOLsIe3/hb/8SJOLlV /j8zABENg==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kaIoo-0000d6-0I; Wed, 04 Nov 2020 13:27:18 +0000 Received: from foss.arm.com ([217.140.110.172]) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kaIol-0000c1-GS for linux-arm-kernel@lists.infradead.org; Wed, 04 Nov 2020 13:27:16 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 56447139F; Wed, 4 Nov 2020 05:27:12 -0800 (PST) Received: from localhost (unknown [10.1.198.32]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id EC37A3F719; Wed, 4 Nov 2020 05:27:11 -0800 (PST) Date: Wed, 4 Nov 2020 13:27:10 +0000 From: Ionela Voinescu To: Dmitry Baryshkov Subject: Re: [PATCH 1/4] arm64: defconfig: enable INTERCONNECT for Qualcomm chipsets Message-ID: <20201104132655.GA1951@arm.com> References: <20200917203913.3250205-1-dmitry.baryshkov@linaro.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20200917203913.3250205-1-dmitry.baryshkov@linaro.org> User-Agent: Mutt/1.9.4 (2018-02-28) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20201104_082715_616652_89E35E3C X-CRM114-Status: GOOD ( 20.54 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Catalin Marinas , Bjorn Andersson , Andy Gross , linux-arm-msm@vger.kernel.org, Will Deacon , linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi guys, On Thursday 17 Sep 2020 at 23:39:10 (+0300), Dmitry Baryshkov wrote: > Enable CONFIG_INTERCONNECT and interconnect drivers for several Qualcomm > chipsets to enable bus bandwidth control on these SoCs. > > Signed-off-by: Dmitry Baryshkov > --- > arch/arm64/configs/defconfig | 6 ++++++ > 1 file changed, 6 insertions(+) > > diff --git a/arch/arm64/configs/defconfig b/arch/arm64/configs/defconfig > index 63003ec116ee..2e746ebb9245 100644 > --- a/arch/arm64/configs/defconfig > +++ b/arch/arm64/configs/defconfig > @@ -1023,6 +1023,12 @@ CONFIG_SLIMBUS=m > CONFIG_SLIM_QCOM_CTRL=m > CONFIG_SLIM_QCOM_NGD_CTRL=m > CONFIG_MUX_MMIO=y > +CONFIG_INTERCONNECT=y > +CONFIG_INTERCONNECT_QCOM=y > +CONFIG_INTERCONNECT_QCOM_MSM8916=m > +CONFIG_INTERCONNECT_QCOM_SDM845=m > +CONFIG_INTERCONNECT_QCOM_SM8150=m > +CONFIG_INTERCONNECT_QCOM_SM8250=m This needs an additional +CONFIG_INTERCONNECT_QCOM_OSM_L3=m or +CONFIG_INTERCONNECT_QCOM_OSM_L3=y Without it cpufreq fails to initialize on DB845c. When CONFIG_INTERCONNECT_QCOM_OSM_L3=n (which is what it will default to when doing ARCH=arm64 make defcofnig), the osm_l3 is not registered as a provider and therefore will not be found when doing: qcom_cpufreq_hw_driver_probe() -> dev_pm_opp_of_find_icc_paths() -> of_icc_get_by_index(). This being said, it also does not feel right for cpufreq enablement to depend on L3 scaling enablement, so better error filtering might be needed in the drivers instead. But I'll leave that decision to you, while the above is only a quick fix. The issue is reproduced with linux next 20201104, after applying the iommu patches at [1]. Hope it helps, Ionela. [1] https://lore.kernel.org/lkml/160399513141.1314250.8831514745970142969.b4-ty@kernel.org/ > CONFIG_EXT2_FS=y > CONFIG_EXT3_FS=y > CONFIG_EXT4_FS_POSIX_ACL=y > -- > 2.28.0 > > > _______________________________________________ > linux-arm-kernel mailing list > linux-arm-kernel@lists.infradead.org > http://lists.infradead.org/mailman/listinfo/linux-arm-kernel _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel