From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.7 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6469BC2D0A3 for ; Wed, 4 Nov 2020 13:42:04 +0000 (UTC) Received: from lists.ozlabs.org (lists.ozlabs.org [203.11.71.2]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 8B69F20870 for ; Wed, 4 Nov 2020 13:42:03 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 8B69F20870 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=lunn.ch Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Received: from bilbo.ozlabs.org (lists.ozlabs.org [IPv6:2401:3900:2:1::3]) by lists.ozlabs.org (Postfix) with ESMTP id 4CR79f4FqVzDqZp for ; Thu, 5 Nov 2020 00:41:58 +1100 (AEDT) Authentication-Results: lists.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=lunn.ch (client-ip=185.16.172.187; helo=vps0.lunn.ch; envelope-from=andrew@lunn.ch; receiver=) Authentication-Results: lists.ozlabs.org; dmarc=none (p=none dis=none) header.from=lunn.ch Received: from vps0.lunn.ch (vps0.lunn.ch [185.16.172.187]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-256) server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 4CR75c0wZpzDqBy for ; Thu, 5 Nov 2020 00:38:27 +1100 (AEDT) Received: from andrew by vps0.lunn.ch with local (Exim 4.94) (envelope-from ) id 1kaIzP-005DCl-S7; Wed, 04 Nov 2020 14:38:15 +0100 Date: Wed, 4 Nov 2020 14:38:15 +0100 From: Andrew Lunn To: Lee Jones Subject: Re: [PATCH 09/12] net: ethernet: ibm: ibmvnic: Fix some kernel-doc misdemeanours Message-ID: <20201104133815.GC933237@lunn.ch> References: <20201104090610.1446616-1-lee.jones@linaro.org> <20201104090610.1446616-10-lee.jones@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20201104090610.1446616-10-lee.jones@linaro.org> X-BeenThere: linuxppc-dev@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Thomas Falcon , linux-kernel@vger.kernel.org, Santiago Leon , John Allen , Lijun Pan , linux-arm-kernel@lists.infradead.org, netdev@vger.kernel.org, Dany Madden , kuba@kernel.org, Sukadev Bhattiprolu , linuxppc-dev@lists.ozlabs.org, davem@davemloft.net, Paul Mackerras Errors-To: linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Sender: "Linuxppc-dev" On Wed, Nov 04, 2020 at 09:06:07AM +0000, Lee Jones wrote: > Fixes the following W=1 kernel build warning(s): > > from drivers/net/ethernet/ibm/ibmvnic.c:35: > inlined from ‘handle_vpd_rsp’ at drivers/net/ethernet/ibm/ibmvnic.c:4124:3: > drivers/net/ethernet/ibm/ibmvnic.c:1362: warning: Function parameter or member 'hdr_field' not described in 'build_hdr_data' > drivers/net/ethernet/ibm/ibmvnic.c:1362: warning: Function parameter or member 'skb' not described in 'build_hdr_data' > drivers/net/ethernet/ibm/ibmvnic.c:1362: warning: Function parameter or member 'hdr_len' not described in 'build_hdr_data' > drivers/net/ethernet/ibm/ibmvnic.c:1362: warning: Function parameter or member 'hdr_data' not described in 'build_hdr_data' > drivers/net/ethernet/ibm/ibmvnic.c:1423: warning: Function parameter or member 'hdr_field' not described in 'create_hdr_descs' > drivers/net/ethernet/ibm/ibmvnic.c:1423: warning: Function parameter or member 'hdr_data' not described in 'create_hdr_descs' > drivers/net/ethernet/ibm/ibmvnic.c:1423: warning: Function parameter or member 'len' not described in 'create_hdr_descs' > drivers/net/ethernet/ibm/ibmvnic.c:1423: warning: Function parameter or member 'hdr_len' not described in 'create_hdr_descs' > drivers/net/ethernet/ibm/ibmvnic.c:1423: warning: Function parameter or member 'scrq_arr' not described in 'create_hdr_descs' > drivers/net/ethernet/ibm/ibmvnic.c:1474: warning: Function parameter or member 'txbuff' not described in 'build_hdr_descs_arr' > drivers/net/ethernet/ibm/ibmvnic.c:1474: warning: Function parameter or member 'num_entries' not described in 'build_hdr_descs_arr' > drivers/net/ethernet/ibm/ibmvnic.c:1474: warning: Function parameter or member 'hdr_field' not described in 'build_hdr_descs_arr' > drivers/net/ethernet/ibm/ibmvnic.c:1832: warning: Function parameter or member 'adapter' not described in 'do_change_param_reset' > drivers/net/ethernet/ibm/ibmvnic.c:1832: warning: Function parameter or member 'rwi' not described in 'do_change_param_reset' > drivers/net/ethernet/ibm/ibmvnic.c:1832: warning: Function parameter or member 'reset_state' not described in 'do_change_param_reset' > drivers/net/ethernet/ibm/ibmvnic.c:1911: warning: Function parameter or member 'adapter' not described in 'do_reset' > drivers/net/ethernet/ibm/ibmvnic.c:1911: warning: Function parameter or member 'rwi' not described in 'do_reset' > drivers/net/ethernet/ibm/ibmvnic.c:1911: warning: Function parameter or member 'reset_state' not described in 'do_reset' > > Cc: Dany Madden > Cc: Lijun Pan > Cc: Sukadev Bhattiprolu > Cc: Michael Ellerman > Cc: Benjamin Herrenschmidt > Cc: Paul Mackerras > Cc: "David S. Miller" > Cc: Jakub Kicinski > Cc: Santiago Leon > Cc: Thomas Falcon > Cc: John Allen > Cc: netdev@vger.kernel.org > Cc: linuxppc-dev@lists.ozlabs.org > Signed-off-by: Lee Jones Reviewed-by: Andrew Lunn Andrew From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A950FC2D0A3 for ; Wed, 4 Nov 2020 13:39:08 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 2AB4520867 for ; Wed, 4 Nov 2020 13:39:08 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="PfVhAppQ" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 2AB4520867 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=lunn.ch Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=wdV3NxxgKrWWzQawDBCEN4EPpAAQKM122uhWe/lSGtY=; b=PfVhAppQAjjxaZP4kX+rVluYG 1vwb6LRoLGog7+7U7EfU/VNX5gNJMQF85RsDKHCSFla+u/mjG3qb1cMw9MPmEi6bnTTfwmLI+NZA6 mwW0HTH47qn/dLPg7ZkNf0YFkBouoTzuGmK5fzdWSPdhaf7OQZYRu7EOJK+awOdsZ1FArBLr1soHM mV91lNFeBaKblSi7Ejqn/d12BTBpLxGsxUkG8Ea8xwCGd6EuxMy0y0TKBmox7QdDUuKi+lSS+moZy lNNRUhA0ugaJH5kW1Yi5vlxXB654zCuljjfgfbyhcGCqqSXmk/Xcgo04O0jvOIx0WoeklGA9wdS0f zijpOQ6Fg==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kaIzn-0003aI-Di; Wed, 04 Nov 2020 13:38:39 +0000 Received: from vps0.lunn.ch ([185.16.172.187]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kaIzk-0003Yi-5Z for linux-arm-kernel@lists.infradead.org; Wed, 04 Nov 2020 13:38:36 +0000 Received: from andrew by vps0.lunn.ch with local (Exim 4.94) (envelope-from ) id 1kaIzP-005DCl-S7; Wed, 04 Nov 2020 14:38:15 +0100 Date: Wed, 4 Nov 2020 14:38:15 +0100 From: Andrew Lunn To: Lee Jones Subject: Re: [PATCH 09/12] net: ethernet: ibm: ibmvnic: Fix some kernel-doc misdemeanours Message-ID: <20201104133815.GC933237@lunn.ch> References: <20201104090610.1446616-1-lee.jones@linaro.org> <20201104090610.1446616-10-lee.jones@linaro.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20201104090610.1446616-10-lee.jones@linaro.org> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20201104_083836_230478_C27FC91E X-CRM114-Status: GOOD ( 10.45 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Thomas Falcon , Michael Ellerman , linux-kernel@vger.kernel.org, Santiago Leon , John Allen , Lijun Pan , linux-arm-kernel@lists.infradead.org, netdev@vger.kernel.org, Dany Madden , kuba@kernel.org, Sukadev Bhattiprolu , linuxppc-dev@lists.ozlabs.org, davem@davemloft.net, Paul Mackerras , Benjamin Herrenschmidt Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org T24gV2VkLCBOb3YgMDQsIDIwMjAgYXQgMDk6MDY6MDdBTSArMDAwMCwgTGVlIEpvbmVzIHdyb3Rl Ogo+IEZpeGVzIHRoZSBmb2xsb3dpbmcgVz0xIGtlcm5lbCBidWlsZCB3YXJuaW5nKHMpOgo+IAo+ ICBmcm9tIGRyaXZlcnMvbmV0L2V0aGVybmV0L2libS9pYm12bmljLmM6MzU6Cj4gIGlubGluZWQg ZnJvbSDigJhoYW5kbGVfdnBkX3JzcOKAmSBhdCBkcml2ZXJzL25ldC9ldGhlcm5ldC9pYm0vaWJt dm5pYy5jOjQxMjQ6MzoKPiAgZHJpdmVycy9uZXQvZXRoZXJuZXQvaWJtL2libXZuaWMuYzoxMzYy OiB3YXJuaW5nOiBGdW5jdGlvbiBwYXJhbWV0ZXIgb3IgbWVtYmVyICdoZHJfZmllbGQnIG5vdCBk ZXNjcmliZWQgaW4gJ2J1aWxkX2hkcl9kYXRhJwo+ICBkcml2ZXJzL25ldC9ldGhlcm5ldC9pYm0v aWJtdm5pYy5jOjEzNjI6IHdhcm5pbmc6IEZ1bmN0aW9uIHBhcmFtZXRlciBvciBtZW1iZXIgJ3Nr Yicgbm90IGRlc2NyaWJlZCBpbiAnYnVpbGRfaGRyX2RhdGEnCj4gIGRyaXZlcnMvbmV0L2V0aGVy bmV0L2libS9pYm12bmljLmM6MTM2Mjogd2FybmluZzogRnVuY3Rpb24gcGFyYW1ldGVyIG9yIG1l bWJlciAnaGRyX2xlbicgbm90IGRlc2NyaWJlZCBpbiAnYnVpbGRfaGRyX2RhdGEnCj4gIGRyaXZl cnMvbmV0L2V0aGVybmV0L2libS9pYm12bmljLmM6MTM2Mjogd2FybmluZzogRnVuY3Rpb24gcGFy YW1ldGVyIG9yIG1lbWJlciAnaGRyX2RhdGEnIG5vdCBkZXNjcmliZWQgaW4gJ2J1aWxkX2hkcl9k YXRhJwo+ICBkcml2ZXJzL25ldC9ldGhlcm5ldC9pYm0vaWJtdm5pYy5jOjE0MjM6IHdhcm5pbmc6 IEZ1bmN0aW9uIHBhcmFtZXRlciBvciBtZW1iZXIgJ2hkcl9maWVsZCcgbm90IGRlc2NyaWJlZCBp biAnY3JlYXRlX2hkcl9kZXNjcycKPiAgZHJpdmVycy9uZXQvZXRoZXJuZXQvaWJtL2libXZuaWMu YzoxNDIzOiB3YXJuaW5nOiBGdW5jdGlvbiBwYXJhbWV0ZXIgb3IgbWVtYmVyICdoZHJfZGF0YScg bm90IGRlc2NyaWJlZCBpbiAnY3JlYXRlX2hkcl9kZXNjcycKPiAgZHJpdmVycy9uZXQvZXRoZXJu ZXQvaWJtL2libXZuaWMuYzoxNDIzOiB3YXJuaW5nOiBGdW5jdGlvbiBwYXJhbWV0ZXIgb3IgbWVt YmVyICdsZW4nIG5vdCBkZXNjcmliZWQgaW4gJ2NyZWF0ZV9oZHJfZGVzY3MnCj4gIGRyaXZlcnMv bmV0L2V0aGVybmV0L2libS9pYm12bmljLmM6MTQyMzogd2FybmluZzogRnVuY3Rpb24gcGFyYW1l dGVyIG9yIG1lbWJlciAnaGRyX2xlbicgbm90IGRlc2NyaWJlZCBpbiAnY3JlYXRlX2hkcl9kZXNj cycKPiAgZHJpdmVycy9uZXQvZXRoZXJuZXQvaWJtL2libXZuaWMuYzoxNDIzOiB3YXJuaW5nOiBG dW5jdGlvbiBwYXJhbWV0ZXIgb3IgbWVtYmVyICdzY3JxX2Fycicgbm90IGRlc2NyaWJlZCBpbiAn Y3JlYXRlX2hkcl9kZXNjcycKPiAgZHJpdmVycy9uZXQvZXRoZXJuZXQvaWJtL2libXZuaWMuYzox NDc0OiB3YXJuaW5nOiBGdW5jdGlvbiBwYXJhbWV0ZXIgb3IgbWVtYmVyICd0eGJ1ZmYnIG5vdCBk ZXNjcmliZWQgaW4gJ2J1aWxkX2hkcl9kZXNjc19hcnInCj4gIGRyaXZlcnMvbmV0L2V0aGVybmV0 L2libS9pYm12bmljLmM6MTQ3NDogd2FybmluZzogRnVuY3Rpb24gcGFyYW1ldGVyIG9yIG1lbWJl ciAnbnVtX2VudHJpZXMnIG5vdCBkZXNjcmliZWQgaW4gJ2J1aWxkX2hkcl9kZXNjc19hcnInCj4g IGRyaXZlcnMvbmV0L2V0aGVybmV0L2libS9pYm12bmljLmM6MTQ3NDogd2FybmluZzogRnVuY3Rp b24gcGFyYW1ldGVyIG9yIG1lbWJlciAnaGRyX2ZpZWxkJyBub3QgZGVzY3JpYmVkIGluICdidWls ZF9oZHJfZGVzY3NfYXJyJwo+ICBkcml2ZXJzL25ldC9ldGhlcm5ldC9pYm0vaWJtdm5pYy5jOjE4 MzI6IHdhcm5pbmc6IEZ1bmN0aW9uIHBhcmFtZXRlciBvciBtZW1iZXIgJ2FkYXB0ZXInIG5vdCBk ZXNjcmliZWQgaW4gJ2RvX2NoYW5nZV9wYXJhbV9yZXNldCcKPiAgZHJpdmVycy9uZXQvZXRoZXJu ZXQvaWJtL2libXZuaWMuYzoxODMyOiB3YXJuaW5nOiBGdW5jdGlvbiBwYXJhbWV0ZXIgb3IgbWVt YmVyICdyd2knIG5vdCBkZXNjcmliZWQgaW4gJ2RvX2NoYW5nZV9wYXJhbV9yZXNldCcKPiAgZHJp dmVycy9uZXQvZXRoZXJuZXQvaWJtL2libXZuaWMuYzoxODMyOiB3YXJuaW5nOiBGdW5jdGlvbiBw YXJhbWV0ZXIgb3IgbWVtYmVyICdyZXNldF9zdGF0ZScgbm90IGRlc2NyaWJlZCBpbiAnZG9fY2hh bmdlX3BhcmFtX3Jlc2V0Jwo+ICBkcml2ZXJzL25ldC9ldGhlcm5ldC9pYm0vaWJtdm5pYy5jOjE5 MTE6IHdhcm5pbmc6IEZ1bmN0aW9uIHBhcmFtZXRlciBvciBtZW1iZXIgJ2FkYXB0ZXInIG5vdCBk ZXNjcmliZWQgaW4gJ2RvX3Jlc2V0Jwo+ICBkcml2ZXJzL25ldC9ldGhlcm5ldC9pYm0vaWJtdm5p Yy5jOjE5MTE6IHdhcm5pbmc6IEZ1bmN0aW9uIHBhcmFtZXRlciBvciBtZW1iZXIgJ3J3aScgbm90 IGRlc2NyaWJlZCBpbiAnZG9fcmVzZXQnCj4gIGRyaXZlcnMvbmV0L2V0aGVybmV0L2libS9pYm12 bmljLmM6MTkxMTogd2FybmluZzogRnVuY3Rpb24gcGFyYW1ldGVyIG9yIG1lbWJlciAncmVzZXRf c3RhdGUnIG5vdCBkZXNjcmliZWQgaW4gJ2RvX3Jlc2V0Jwo+IAo+IENjOiBEYW55IE1hZGRlbiA8 ZHJ0QGxpbnV4LmlibS5jb20+Cj4gQ2M6IExpanVuIFBhbiA8bGpwQGxpbnV4LmlibS5jb20+Cj4g Q2M6IFN1a2FkZXYgQmhhdHRpcHJvbHUgPHN1a2FkZXZAbGludXguaWJtLmNvbT4KPiBDYzogTWlj aGFlbCBFbGxlcm1hbiA8bXBlQGVsbGVybWFuLmlkLmF1Pgo+IENjOiBCZW5qYW1pbiBIZXJyZW5z Y2htaWR0IDxiZW5oQGtlcm5lbC5jcmFzaGluZy5vcmc+Cj4gQ2M6IFBhdWwgTWFja2VycmFzIDxw YXVsdXNAc2FtYmEub3JnPgo+IENjOiAiRGF2aWQgUy4gTWlsbGVyIiA8ZGF2ZW1AZGF2ZW1sb2Z0 Lm5ldD4KPiBDYzogSmFrdWIgS2ljaW5za2kgPGt1YmFAa2VybmVsLm9yZz4KPiBDYzogU2FudGlh Z28gTGVvbiA8c2FudGlfbGVvbkB5YWhvby5jb20+Cj4gQ2M6IFRob21hcyBGYWxjb24gPHRsZmFs Y29uQGxpbnV4LnZuZXQuaWJtLmNvbT4KPiBDYzogSm9obiBBbGxlbiA8amFsbGVuQGxpbnV4LnZu ZXQuaWJtLmNvbT4KPiBDYzogbmV0ZGV2QHZnZXIua2VybmVsLm9yZwo+IENjOiBsaW51eHBwYy1k ZXZAbGlzdHMub3psYWJzLm9yZwo+IFNpZ25lZC1vZmYtYnk6IExlZSBKb25lcyA8bGVlLmpvbmVz QGxpbmFyby5vcmc+CgpSZXZpZXdlZC1ieTogQW5kcmV3IEx1bm4gPGFuZHJld0BsdW5uLmNoPgoK ICAgIEFuZHJldwoKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X18KbGludXgtYXJtLWtlcm5lbCBtYWlsaW5nIGxpc3QKbGludXgtYXJtLWtlcm5lbEBsaXN0cy5p bmZyYWRlYWQub3JnCmh0dHA6Ly9saXN0cy5pbmZyYWRlYWQub3JnL21haWxtYW4vbGlzdGluZm8v bGludXgtYXJtLWtlcm5lbAo= From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.7 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7F9FCC2D0A3 for ; Wed, 4 Nov 2020 13:38:35 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 257E12222C for ; Wed, 4 Nov 2020 13:38:35 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730082AbgKDNie (ORCPT ); Wed, 4 Nov 2020 08:38:34 -0500 Received: from vps0.lunn.ch ([185.16.172.187]:34898 "EHLO vps0.lunn.ch" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729584AbgKDNid (ORCPT ); Wed, 4 Nov 2020 08:38:33 -0500 Received: from andrew by vps0.lunn.ch with local (Exim 4.94) (envelope-from ) id 1kaIzP-005DCl-S7; Wed, 04 Nov 2020 14:38:15 +0100 Date: Wed, 4 Nov 2020 14:38:15 +0100 From: Andrew Lunn To: Lee Jones Cc: davem@davemloft.net, kuba@kernel.org, Thomas Falcon , Michael Ellerman , linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org, Santiago Leon , John Allen , netdev@vger.kernel.org, Lijun Pan , Benjamin Herrenschmidt , Dany Madden , Paul Mackerras , Sukadev Bhattiprolu , linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH 09/12] net: ethernet: ibm: ibmvnic: Fix some kernel-doc misdemeanours Message-ID: <20201104133815.GC933237@lunn.ch> References: <20201104090610.1446616-1-lee.jones@linaro.org> <20201104090610.1446616-10-lee.jones@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20201104090610.1446616-10-lee.jones@linaro.org> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Nov 04, 2020 at 09:06:07AM +0000, Lee Jones wrote: > Fixes the following W=1 kernel build warning(s): > > from drivers/net/ethernet/ibm/ibmvnic.c:35: > inlined from ‘handle_vpd_rsp’ at drivers/net/ethernet/ibm/ibmvnic.c:4124:3: > drivers/net/ethernet/ibm/ibmvnic.c:1362: warning: Function parameter or member 'hdr_field' not described in 'build_hdr_data' > drivers/net/ethernet/ibm/ibmvnic.c:1362: warning: Function parameter or member 'skb' not described in 'build_hdr_data' > drivers/net/ethernet/ibm/ibmvnic.c:1362: warning: Function parameter or member 'hdr_len' not described in 'build_hdr_data' > drivers/net/ethernet/ibm/ibmvnic.c:1362: warning: Function parameter or member 'hdr_data' not described in 'build_hdr_data' > drivers/net/ethernet/ibm/ibmvnic.c:1423: warning: Function parameter or member 'hdr_field' not described in 'create_hdr_descs' > drivers/net/ethernet/ibm/ibmvnic.c:1423: warning: Function parameter or member 'hdr_data' not described in 'create_hdr_descs' > drivers/net/ethernet/ibm/ibmvnic.c:1423: warning: Function parameter or member 'len' not described in 'create_hdr_descs' > drivers/net/ethernet/ibm/ibmvnic.c:1423: warning: Function parameter or member 'hdr_len' not described in 'create_hdr_descs' > drivers/net/ethernet/ibm/ibmvnic.c:1423: warning: Function parameter or member 'scrq_arr' not described in 'create_hdr_descs' > drivers/net/ethernet/ibm/ibmvnic.c:1474: warning: Function parameter or member 'txbuff' not described in 'build_hdr_descs_arr' > drivers/net/ethernet/ibm/ibmvnic.c:1474: warning: Function parameter or member 'num_entries' not described in 'build_hdr_descs_arr' > drivers/net/ethernet/ibm/ibmvnic.c:1474: warning: Function parameter or member 'hdr_field' not described in 'build_hdr_descs_arr' > drivers/net/ethernet/ibm/ibmvnic.c:1832: warning: Function parameter or member 'adapter' not described in 'do_change_param_reset' > drivers/net/ethernet/ibm/ibmvnic.c:1832: warning: Function parameter or member 'rwi' not described in 'do_change_param_reset' > drivers/net/ethernet/ibm/ibmvnic.c:1832: warning: Function parameter or member 'reset_state' not described in 'do_change_param_reset' > drivers/net/ethernet/ibm/ibmvnic.c:1911: warning: Function parameter or member 'adapter' not described in 'do_reset' > drivers/net/ethernet/ibm/ibmvnic.c:1911: warning: Function parameter or member 'rwi' not described in 'do_reset' > drivers/net/ethernet/ibm/ibmvnic.c:1911: warning: Function parameter or member 'reset_state' not described in 'do_reset' > > Cc: Dany Madden > Cc: Lijun Pan > Cc: Sukadev Bhattiprolu > Cc: Michael Ellerman > Cc: Benjamin Herrenschmidt > Cc: Paul Mackerras > Cc: "David S. Miller" > Cc: Jakub Kicinski > Cc: Santiago Leon > Cc: Thomas Falcon > Cc: John Allen > Cc: netdev@vger.kernel.org > Cc: linuxppc-dev@lists.ozlabs.org > Signed-off-by: Lee Jones Reviewed-by: Andrew Lunn Andrew