From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.6 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5DA76C55179 for ; Wed, 4 Nov 2020 16:52:23 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 04F18207BB for ; Wed, 4 Nov 2020 16:52:22 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="eT9AdSwY" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731607AbgKDQuJ (ORCPT ); Wed, 4 Nov 2020 11:50:09 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39828 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1731600AbgKDQuI (ORCPT ); Wed, 4 Nov 2020 11:50:08 -0500 Received: from mail-lf1-x144.google.com (mail-lf1-x144.google.com [IPv6:2a00:1450:4864:20::144]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B2A91C0613D3; Wed, 4 Nov 2020 08:50:07 -0800 (PST) Received: by mail-lf1-x144.google.com with SMTP id i6so28061172lfd.1; Wed, 04 Nov 2020 08:50:07 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=XpnLgrE/KIZ6J0eMhnY4ffyEk5qfjR4pbUa1URS1+kQ=; b=eT9AdSwY6QmiNL/vh22cX2gun3H6hYmlPxQL21b8k+N8lGwXf8hg+x01H6hGJJeSD2 9EUrNpzI68qPfbP7bk+MnfoB63VGTSIdAMnZzp3WubJ1CTvOv/OfOLyBokFQIwsehqB8 ULSI7PNCmlN7nmqhypp5A72fF2k2sTJhCXh99djwo5UGum+j4isMp46NypiO+NSbi9/t 8QlRzYPcWiw2iHnSmCYHCWPfulcYnIvR/UMJLgI9MiJg8p1U7OzO8qzrvOkDXel1O+JO wgnvfAyIz//nPWaC2agyavBrK6rLDeIESmugfMPjEAp8BuUyXRArlh/HsYZQBZPiHhtl cPjg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=XpnLgrE/KIZ6J0eMhnY4ffyEk5qfjR4pbUa1URS1+kQ=; b=hAV5efvX8IqNQ/lGqKR5mv6UujUxdHnJ6zPxgRAefV2Ppp+tpjx2qTosHC2r6Eacxg w3D+qCi3TDsF5mQQnHu6g4bEVuXREeFaw8PlHT//XrqdGg9n0lung5U2xywtliwDPL2W Y4i3Yg7FBTqlGANsjZeAqoyGYj8FBgM4C+DO6F6qD54g9cpcEt0Fbjq42E30w0sWV14A Uh9C3g8hdqKoBG/mQTtl+OMoJsPkw/kDZGpbvLQl5dh4gg+OFvojk9B/qfQ6QYSq9v/D mdtMwlTzd9yVWs396eLtswaI4vlNQNZ4+3xJBw/O+c8FxEHn0y7fJTVb628P8Uqnq8pb 0lkw== X-Gm-Message-State: AOAM532xrWFeE4d1crn1LnL6XAaXgrVVbzbSaVsFijwLli+W2xAfiQ4j +byWPxo0oBf5z9UvWGGW/OU= X-Google-Smtp-Source: ABdhPJwi0Z2sWnIE3B1pjc2HPoqa6Q3lOJz48bunHlnvZxcpP08LOm7VVfPYpiy7FyQK5rHj4Z6xiQ== X-Received: by 2002:ac2:5b50:: with SMTP id i16mr1164553lfp.586.1604508606218; Wed, 04 Nov 2020 08:50:06 -0800 (PST) Received: from localhost.localdomain (109-252-192-83.dynamic.spd-mgts.ru. [109.252.192.83]) by smtp.gmail.com with ESMTPSA id m2sm454587lfo.25.2020.11.04.08.50.05 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 04 Nov 2020 08:50:05 -0800 (PST) From: Dmitry Osipenko To: Thierry Reding , Jonathan Hunter , Georgi Djakov , Rob Herring , Michael Turquette , Stephen Boyd , Peter De Schrijver , MyungJoo Ham , Kyungmin Park , Chanwoo Choi , Mikko Perttunen , Viresh Kumar , Peter Geis , Nicolas Chauvet , Krzysztof Kozlowski Cc: linux-tegra@vger.kernel.org, linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, devicetree@vger.kernel.org Subject: [PATCH v7 30/47] memory: tegra: Remove superfluous error messages around platform_get_irq() Date: Wed, 4 Nov 2020 19:49:06 +0300 Message-Id: <20201104164923.21238-31-digetx@gmail.com> X-Mailer: git-send-email 2.27.0 In-Reply-To: <20201104164923.21238-1-digetx@gmail.com> References: <20201104164923.21238-1-digetx@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org The platform_get_irq() prints error message telling that interrupt is missing, hence there is no need to duplicated that message in the drivers. Signed-off-by: Dmitry Osipenko --- drivers/memory/tegra/mc.c | 4 +--- drivers/memory/tegra/tegra20-emc.c | 1 - drivers/memory/tegra/tegra30-emc.c | 5 ++--- 3 files changed, 3 insertions(+), 7 deletions(-) diff --git a/drivers/memory/tegra/mc.c b/drivers/memory/tegra/mc.c index a72cdcafc933..998f9148ecb8 100644 --- a/drivers/memory/tegra/mc.c +++ b/drivers/memory/tegra/mc.c @@ -707,10 +707,8 @@ static int tegra_mc_probe(struct platform_device *pdev) } mc->irq = platform_get_irq(pdev, 0); - if (mc->irq < 0) { - dev_err(&pdev->dev, "interrupt not specified\n"); + if (mc->irq < 0) return mc->irq; - } WARN(!mc->soc->client_id_mask, "missing client ID mask for this SoC\n"); diff --git a/drivers/memory/tegra/tegra20-emc.c b/drivers/memory/tegra/tegra20-emc.c index 5ba4e495bfc3..c9fe58a724ee 100644 --- a/drivers/memory/tegra/tegra20-emc.c +++ b/drivers/memory/tegra/tegra20-emc.c @@ -665,7 +665,6 @@ static int tegra_emc_probe(struct platform_device *pdev) irq = platform_get_irq(pdev, 0); if (irq < 0) { - dev_err(&pdev->dev, "interrupt not specified\n"); dev_err(&pdev->dev, "please update your device tree\n"); return irq; } diff --git a/drivers/memory/tegra/tegra30-emc.c b/drivers/memory/tegra/tegra30-emc.c index c58cf31cb27b..1be28e28ec34 100644 --- a/drivers/memory/tegra/tegra30-emc.c +++ b/drivers/memory/tegra/tegra30-emc.c @@ -1299,10 +1299,9 @@ static int tegra_emc_probe(struct platform_device *pdev) return err; err = platform_get_irq(pdev, 0); - if (err < 0) { - dev_err(&pdev->dev, "interrupt not specified: %d\n", err); + if (err < 0) return err; - } + emc->irq = err; err = devm_request_irq(&pdev->dev, emc->irq, tegra_emc_isr, 0, -- 2.27.0 From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.3 required=3.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED,DKIM_INVALID,DKIM_SIGNED,FREEMAIL_FORGED_FROMDOMAIN, FREEMAIL_FROM,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9D7C6C4742C for ; Thu, 5 Nov 2020 08:21:04 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 3CF5321741 for ; Thu, 5 Nov 2020 08:21:04 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="eT9AdSwY" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 3CF5321741 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 568966E9C7; Thu, 5 Nov 2020 08:20:08 +0000 (UTC) Received: from mail-lf1-x142.google.com (mail-lf1-x142.google.com [IPv6:2a00:1450:4864:20::142]) by gabe.freedesktop.org (Postfix) with ESMTPS id BDE316E239 for ; Wed, 4 Nov 2020 16:50:07 +0000 (UTC) Received: by mail-lf1-x142.google.com with SMTP id y184so26066387lfa.12 for ; Wed, 04 Nov 2020 08:50:07 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=XpnLgrE/KIZ6J0eMhnY4ffyEk5qfjR4pbUa1URS1+kQ=; b=eT9AdSwY6QmiNL/vh22cX2gun3H6hYmlPxQL21b8k+N8lGwXf8hg+x01H6hGJJeSD2 9EUrNpzI68qPfbP7bk+MnfoB63VGTSIdAMnZzp3WubJ1CTvOv/OfOLyBokFQIwsehqB8 ULSI7PNCmlN7nmqhypp5A72fF2k2sTJhCXh99djwo5UGum+j4isMp46NypiO+NSbi9/t 8QlRzYPcWiw2iHnSmCYHCWPfulcYnIvR/UMJLgI9MiJg8p1U7OzO8qzrvOkDXel1O+JO wgnvfAyIz//nPWaC2agyavBrK6rLDeIESmugfMPjEAp8BuUyXRArlh/HsYZQBZPiHhtl cPjg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=XpnLgrE/KIZ6J0eMhnY4ffyEk5qfjR4pbUa1URS1+kQ=; b=ozGDhdFt/TE3fxizjdugAX05WtG2OFL7Ocdl5T0IDiyHMKzczDbpi4xZwU4XfklwXp lgOXatBNBq+iAJlpdfcfcs2XuvQbeHERirKtw2f0VOAuK9eRn7qAOfJv0tzEDT1HSKnO Uj8TqwtYin/lQJGDf5e7IyOYG8K1afX2F2/87TgY644ZQygxaClHBWRy5HqenYPjXyi+ FjWaDLm+L+dfAs3pd1FLEMKeZPas/jna8xaYyHHxuk2opLq0J76+12a6RXHvpRBKrcCP ICdnzK/dw8oB59kmuas1QgHW1WdIVza61rISHaL4Wy3xlYU9mqcle6UC+FFcLZH9Lh8r zpGg== X-Gm-Message-State: AOAM531vom/dV35tZUKDpe/lFaOYUSRQspPyq3JUDEVboSX4jp29hODf PsdZUxdxvpG8/LrMvWb2UK4= X-Google-Smtp-Source: ABdhPJwi0Z2sWnIE3B1pjc2HPoqa6Q3lOJz48bunHlnvZxcpP08LOm7VVfPYpiy7FyQK5rHj4Z6xiQ== X-Received: by 2002:ac2:5b50:: with SMTP id i16mr1164553lfp.586.1604508606218; Wed, 04 Nov 2020 08:50:06 -0800 (PST) Received: from localhost.localdomain (109-252-192-83.dynamic.spd-mgts.ru. [109.252.192.83]) by smtp.gmail.com with ESMTPSA id m2sm454587lfo.25.2020.11.04.08.50.05 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 04 Nov 2020 08:50:05 -0800 (PST) From: Dmitry Osipenko To: Thierry Reding , Jonathan Hunter , Georgi Djakov , Rob Herring , Michael Turquette , Stephen Boyd , Peter De Schrijver , MyungJoo Ham , Kyungmin Park , Chanwoo Choi , Mikko Perttunen , Viresh Kumar , Peter Geis , Nicolas Chauvet , Krzysztof Kozlowski Subject: [PATCH v7 30/47] memory: tegra: Remove superfluous error messages around platform_get_irq() Date: Wed, 4 Nov 2020 19:49:06 +0300 Message-Id: <20201104164923.21238-31-digetx@gmail.com> X-Mailer: git-send-email 2.27.0 In-Reply-To: <20201104164923.21238-1-digetx@gmail.com> References: <20201104164923.21238-1-digetx@gmail.com> MIME-Version: 1.0 X-Mailman-Approved-At: Thu, 05 Nov 2020 08:20:03 +0000 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-tegra@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-pm@vger.kernel.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" The platform_get_irq() prints error message telling that interrupt is missing, hence there is no need to duplicated that message in the drivers. Signed-off-by: Dmitry Osipenko --- drivers/memory/tegra/mc.c | 4 +--- drivers/memory/tegra/tegra20-emc.c | 1 - drivers/memory/tegra/tegra30-emc.c | 5 ++--- 3 files changed, 3 insertions(+), 7 deletions(-) diff --git a/drivers/memory/tegra/mc.c b/drivers/memory/tegra/mc.c index a72cdcafc933..998f9148ecb8 100644 --- a/drivers/memory/tegra/mc.c +++ b/drivers/memory/tegra/mc.c @@ -707,10 +707,8 @@ static int tegra_mc_probe(struct platform_device *pdev) } mc->irq = platform_get_irq(pdev, 0); - if (mc->irq < 0) { - dev_err(&pdev->dev, "interrupt not specified\n"); + if (mc->irq < 0) return mc->irq; - } WARN(!mc->soc->client_id_mask, "missing client ID mask for this SoC\n"); diff --git a/drivers/memory/tegra/tegra20-emc.c b/drivers/memory/tegra/tegra20-emc.c index 5ba4e495bfc3..c9fe58a724ee 100644 --- a/drivers/memory/tegra/tegra20-emc.c +++ b/drivers/memory/tegra/tegra20-emc.c @@ -665,7 +665,6 @@ static int tegra_emc_probe(struct platform_device *pdev) irq = platform_get_irq(pdev, 0); if (irq < 0) { - dev_err(&pdev->dev, "interrupt not specified\n"); dev_err(&pdev->dev, "please update your device tree\n"); return irq; } diff --git a/drivers/memory/tegra/tegra30-emc.c b/drivers/memory/tegra/tegra30-emc.c index c58cf31cb27b..1be28e28ec34 100644 --- a/drivers/memory/tegra/tegra30-emc.c +++ b/drivers/memory/tegra/tegra30-emc.c @@ -1299,10 +1299,9 @@ static int tegra_emc_probe(struct platform_device *pdev) return err; err = platform_get_irq(pdev, 0); - if (err < 0) { - dev_err(&pdev->dev, "interrupt not specified: %d\n", err); + if (err < 0) return err; - } + emc->irq = err; err = devm_request_irq(&pdev->dev, emc->irq, tegra_emc_isr, 0, -- 2.27.0 _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel