From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.5 required=3.0 tests=BAYES_00,DKIM_ADSP_CUSTOM_MED, DKIM_INVALID,DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 81566C4742C for ; Wed, 4 Nov 2020 18:36:44 +0000 (UTC) Received: from mm01.cs.columbia.edu (mm01.cs.columbia.edu [128.59.11.253]) by mail.kernel.org (Postfix) with ESMTP id AE55420719 for ; Wed, 4 Nov 2020 18:36:43 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=google.com header.i=@google.com header.b="l6wxGTW9" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org AE55420719 Authentication-Results: mail.kernel.org; dmarc=fail (p=reject dis=none) header.from=google.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=kvmarm-bounces@lists.cs.columbia.edu Received: from localhost (localhost [127.0.0.1]) by mm01.cs.columbia.edu (Postfix) with ESMTP id DFEF44B543; Wed, 4 Nov 2020 13:36:42 -0500 (EST) X-Virus-Scanned: at lists.cs.columbia.edu Authentication-Results: mm01.cs.columbia.edu (amavisd-new); dkim=softfail (fail, message has been altered) header.i=@google.com Received: from mm01.cs.columbia.edu ([127.0.0.1]) by localhost (mm01.cs.columbia.edu [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id v-E651+Ok4Rw; Wed, 4 Nov 2020 13:36:41 -0500 (EST) Received: from mm01.cs.columbia.edu (localhost [127.0.0.1]) by mm01.cs.columbia.edu (Postfix) with ESMTP id C8FB64B6D6; Wed, 4 Nov 2020 13:36:41 -0500 (EST) Received: from localhost (localhost [127.0.0.1]) by mm01.cs.columbia.edu (Postfix) with ESMTP id 2F4C64B55A for ; Wed, 4 Nov 2020 13:36:40 -0500 (EST) X-Virus-Scanned: at lists.cs.columbia.edu Received: from mm01.cs.columbia.edu ([127.0.0.1]) by localhost (mm01.cs.columbia.edu [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id qWkBULua4O2h for ; Wed, 4 Nov 2020 13:36:38 -0500 (EST) Received: from mail-wm1-f68.google.com (mail-wm1-f68.google.com [209.85.128.68]) by mm01.cs.columbia.edu (Postfix) with ESMTPS id C662F4B543 for ; Wed, 4 Nov 2020 13:36:38 -0500 (EST) Received: by mail-wm1-f68.google.com with SMTP id d142so3349195wmd.4 for ; Wed, 04 Nov 2020 10:36:38 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=9bnsPOxn9yGq928zTuAG9ePIv/5JkrABhmxyp7kCDgs=; b=l6wxGTW9/LgEK7XEkr5CmOoS+dYbC2prLnazJg1dUjb83k2tfBbIuo1MO4xfZuYuq2 sdCXNTy3SkxO9ZDbZMd3NOEHJs6ugqJAtzosfyql8vY74UHap4MybGlDLWijiRZXgNL2 ukXB3rZMzB4hfoEZDlt1s11vC2vnIaVIKJNFHYOoH9vUcjoIXfy1vRSHptzTvVN+B5SZ 4nCASvL0GV20ahufoXLFL+HdwJO1PLsbLwPV0JNLmWxWUMdIIbkL9NGUdfqAk9XstiEY 3sEQ4PgP50Nx7Z3YaYwq+KXRrQaOS0rD6uHN3wn+AKch4N4pP8rsBwWw8K+ZWGmb4isW YE1A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=9bnsPOxn9yGq928zTuAG9ePIv/5JkrABhmxyp7kCDgs=; b=Wn+v5aYhUrzAjyset4KmSJNpnkdaNhsMhiFSIprWZSONS93OZfc3alcxMF4UmV/0eu VB5NI/4r0d+neTTzQ+kn4jA4s53ERliwLc5bnRprR6SE9tYg5R+oKICw3qs4Zv+tF81t 67wN6X9LEFHWER/Q/RsAbSHUVryDn2ANyubP7t6WeOJRSwRUEcvtlkeCBgBehVaJI5ao kkszIWk9DSbIZ0LoEu4jpta3b3yRAZW5f4Nzx6cfkk7+p2qHimyUp25OOwpsldh62apQ xQF6nuRRY/HyJAQJl3d4eaz5oD1vRHaVEpSBLtOrmmVlKXZ3hWV6ipPWAV9+6yMIVzMB 5/tw== X-Gm-Message-State: AOAM533j1W+pTyaYXKfUSdHm1UCljmuZA6oLcPsTYN7/yZvaLd53FVVl F34RQteBeoup7svgj+wa2ZwzxLlu85TWukpv X-Google-Smtp-Source: ABdhPJzETxfQOiqTB15tW/fCe98/ypLF2uI3mbgefn2W2p6cqFwsV46hT/Ypd/7K3nRZPYbyiOyf9g== X-Received: by 2002:a1c:18b:: with SMTP id 133mr1119334wmb.157.1604514996877; Wed, 04 Nov 2020 10:36:36 -0800 (PST) Received: from localhost ([2a01:4b00:8523:2d03:c8d2:30f2:53c6:bc2]) by smtp.gmail.com with ESMTPSA id d8sm3267985wmb.11.2020.11.04.10.36.35 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 04 Nov 2020 10:36:35 -0800 (PST) From: David Brazdil To: kvmarm@lists.cs.columbia.edu Subject: [RFC PATCH 00/26] kvm: arm64: Always-on nVHE hypervisor Date: Wed, 4 Nov 2020 18:36:04 +0000 Message-Id: <20201104183630.27513-1-dbrazdil@google.com> X-Mailer: git-send-email 2.29.1 MIME-Version: 1.0 Cc: Lorenzo Pieralisi , kernel-team@android.com, Marc Zyngier , linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Catalin Marinas , Tejun Heo , Dennis Zhou , Christoph Lameter , Will Deacon X-BeenThere: kvmarm@lists.cs.columbia.edu X-Mailman-Version: 2.1.14 Precedence: list List-Id: Where KVM/ARM decisions are made List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: kvmarm-bounces@lists.cs.columbia.edu Sender: kvmarm-bounces@lists.cs.columbia.edu As we progress towards being able to keep guest state private to the host running nVHE hypervisor, this series allows the hypervisor to install itself on newly booted CPUs before the host is allowed to run on them. To this end, the hypervisor starts trapping host SMCs and intercepting host's PSCI CPU_ON/OFF/SUSPEND calls. It replaces the host's entry point with its own, initializes the EL2 state of the new CPU and installs the nVHE hyp vector before ERETing to the host's entry point. Other PSCI SMCs are forwarded to EL3, though only the known set of SMCs implemented in the kernel is allowed. Non-PSCI SMCs are also forwarded to EL3. Future changes will need to ensure the safety of all SMCs wrt. private guests. The host is still allowed to reset EL2 back to the stub vector, eg. for hibernation or kexec, but will not disable nVHE when there are no VMs. Tested on Rock Pi 4b. Sending this as an RFC to get feedback on the following decisions: 1) The kernel checks new cores' features against the finalized system capabilities. To avoid the need to move this code/data to EL2, the implementation only allows to boot cores that were online at the time of KVM initialization. 2) Trapping and forwarding SMCs cannot be switched off. This could cause issues eg. if EL3 always returned to EL1. A kernel command line flag may be needed to turn the feature off on such platforms. -David David Brazdil (25): psci: Export configured PSCI version psci: Export configured PSCI function IDs psci: Export psci_cpu_suspend_feature arm64: Move MAIR_EL1_SET to asm/memory.h kvm: arm64: Initialize MAIR_EL2 using a constant kvm: arm64: Add .hyp.data ELF section kvm: arm64: Support per_cpu_ptr in nVHE hyp code kvm: arm64: Create nVHE copy of cpu_logical_map kvm: arm64: Move hyp-init params to a per-CPU struct kvm: arm64: Refactor handle_trap to use a switch kvm: arm64: Extract parts of el2_setup into a macro kvm: arm64: Add SMC handler in nVHE EL2 kvm: arm64: Bootstrap PSCI SMC handler in nVHE EL2 kvm: arm64: Forward safe PSCI SMCs coming from host kvm: arm64: Add offset for hyp VA <-> PA conversion kvm: arm64: Bootstrap PSCI power state of host CPUs kvm: arm64: Intercept PSCI_CPU_OFF host SMC calls kvm: arm64: Extract __do_hyp_init into a helper function kvm: arm64: Add CPU entry point in nVHE hyp kvm: arm64: Add function to enter host from KVM nVHE hyp code kvm: arm64: Intercept PSCI_CPU_ON host SMC calls kvm: arm64: Intercept host's CPU_SUSPEND PSCI SMCs kvm: arm64: Keep nVHE EL2 vector installed kvm: arm64: Trap host SMCs kvm: arm64: Fix EL2 mode availability checks Will Deacon (1): arm64: kvm: Add standalone ticket spinlock implementation for use at hyp arch/arm64/include/asm/kvm_arm.h | 3 +- arch/arm64/include/asm/kvm_asm.h | 142 +++++++++ arch/arm64/include/asm/kvm_hyp.h | 10 + arch/arm64/include/asm/memory.h | 13 + arch/arm64/include/asm/percpu.h | 6 + arch/arm64/include/asm/sections.h | 1 + arch/arm64/include/asm/virt.h | 16 + arch/arm64/kernel/asm-offsets.c | 5 + arch/arm64/kernel/head.S | 140 +-------- arch/arm64/kernel/image-vars.h | 3 + arch/arm64/kernel/vmlinux.lds.S | 10 + arch/arm64/kvm/arm.c | 109 ++++++- arch/arm64/kvm/hyp/include/nvhe/spinlock.h | 96 ++++++ arch/arm64/kvm/hyp/nvhe/Makefile | 3 +- arch/arm64/kvm/hyp/nvhe/host.S | 9 + arch/arm64/kvm/hyp/nvhe/hyp-init.S | 82 ++++- arch/arm64/kvm/hyp/nvhe/hyp-main.c | 57 +++- arch/arm64/kvm/hyp/nvhe/hyp.lds.S | 3 + arch/arm64/kvm/hyp/nvhe/percpu.c | 38 +++ arch/arm64/kvm/hyp/nvhe/psci.c | 333 +++++++++++++++++++++ arch/arm64/mm/proc.S | 13 - drivers/firmware/psci/psci.c | 27 +- include/linux/psci.h | 20 ++ include/uapi/linux/psci.h | 8 + 24 files changed, 948 insertions(+), 199 deletions(-) create mode 100644 arch/arm64/kvm/hyp/include/nvhe/spinlock.h create mode 100644 arch/arm64/kvm/hyp/nvhe/percpu.c create mode 100644 arch/arm64/kvm/hyp/nvhe/psci.c -- 2.29.1.341.ge80a0c044ae-goog _______________________________________________ kvmarm mailing list kvmarm@lists.cs.columbia.edu https://lists.cs.columbia.edu/mailman/listinfo/kvmarm From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.7 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_ADSP_CUSTOM_MED,DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5A6F7C55178 for ; Wed, 4 Nov 2020 18:38:28 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id DDA5120719 for ; Wed, 4 Nov 2020 18:38:27 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="y65UdVX4"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=google.com header.i=@google.com header.b="l6wxGTW9" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org DDA5120719 Authentication-Results: mail.kernel.org; dmarc=fail (p=reject dis=none) header.from=google.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:Message-Id:Date:Subject:To:From: Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender :Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References:List-Owner; bh=+N1AKegcSuI/6qHmfuW9BIG40ygfC51sCIHueLiDRBo=; b=y65UdVX4KmAh9euVp124wMgRlp BOAbjHZKw/TEhMjIz6oWYp2hnrxz+cVcLInMqQyshte7YtIw9hR/i+jbwuTrtPs4UNKVzf+aS6nGv 9NwkCI5FK8SEJ+bnRSGHfidXcooslFdLdkC69lCCoglkxmqGIffQQni5ZLZODfUfGukwhtxpTQTxN PfeSKAPU3OvFHCUPZr3nGoEKt5IAAXutN5TXTJ2my6LzbQNhTj7vyIXXOTPYBpEYTID2TMIEWq+BR h7hOtVEPo4YSmSm02OjC7F5FEepFeECb4c/OpnNoineH53B0scGxJxdcjxMjNViWm7CAHUwnI+mMG L/Mkz2oQ==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kaNeG-0001df-F7; Wed, 04 Nov 2020 18:36:44 +0000 Received: from mail-wm1-x344.google.com ([2a00:1450:4864:20::344]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kaNeD-0001co-JA for linux-arm-kernel@lists.infradead.org; Wed, 04 Nov 2020 18:36:42 +0000 Received: by mail-wm1-x344.google.com with SMTP id e2so3292425wme.1 for ; Wed, 04 Nov 2020 10:36:37 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=9bnsPOxn9yGq928zTuAG9ePIv/5JkrABhmxyp7kCDgs=; b=l6wxGTW9/LgEK7XEkr5CmOoS+dYbC2prLnazJg1dUjb83k2tfBbIuo1MO4xfZuYuq2 sdCXNTy3SkxO9ZDbZMd3NOEHJs6ugqJAtzosfyql8vY74UHap4MybGlDLWijiRZXgNL2 ukXB3rZMzB4hfoEZDlt1s11vC2vnIaVIKJNFHYOoH9vUcjoIXfy1vRSHptzTvVN+B5SZ 4nCASvL0GV20ahufoXLFL+HdwJO1PLsbLwPV0JNLmWxWUMdIIbkL9NGUdfqAk9XstiEY 3sEQ4PgP50Nx7Z3YaYwq+KXRrQaOS0rD6uHN3wn+AKch4N4pP8rsBwWw8K+ZWGmb4isW YE1A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=9bnsPOxn9yGq928zTuAG9ePIv/5JkrABhmxyp7kCDgs=; b=et1RK9BUDyjzUSYCnp3xdNJeQhWS8H2qYLRSf7wmXkj812E+0GEvRYxJ+44jGGh4ek OgQM5znujBxM20v2Qx0test2LjW1Ov2uy5If1Has7y7upavA/4REILF//hswG9Zq6KpC URQjh4dtLdJDqGYcAGo7qx+hGUldv3pLOrNwjQDVTWqKZpbYpENWmmgS0Cfz+HBAJenC oVm8/AbZsLLEglh7RyC6l8ciufX1D7gVSDU5ox+A3XE5ksWvpEuhF4imBv/1GzFQHL9w Klj7i5j/Go7NuIjlwYQCRdeQelOcuCgGuwQK+zgWQR1Ms7HwCBICUjwIHUB8rzECvKwE NIOQ== X-Gm-Message-State: AOAM530Ebdtp9CZO35PON/jVk8iNyYTgb2ABifoQ5OL+utUG4TYI6hCM 5Sub7XXcOjBLlFz2wLA7L4MIFQ== X-Google-Smtp-Source: ABdhPJzETxfQOiqTB15tW/fCe98/ypLF2uI3mbgefn2W2p6cqFwsV46hT/Ypd/7K3nRZPYbyiOyf9g== X-Received: by 2002:a1c:18b:: with SMTP id 133mr1119334wmb.157.1604514996877; Wed, 04 Nov 2020 10:36:36 -0800 (PST) Received: from localhost ([2a01:4b00:8523:2d03:c8d2:30f2:53c6:bc2]) by smtp.gmail.com with ESMTPSA id d8sm3267985wmb.11.2020.11.04.10.36.35 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 04 Nov 2020 10:36:35 -0800 (PST) From: David Brazdil To: kvmarm@lists.cs.columbia.edu Subject: [RFC PATCH 00/26] kvm: arm64: Always-on nVHE hypervisor Date: Wed, 4 Nov 2020 18:36:04 +0000 Message-Id: <20201104183630.27513-1-dbrazdil@google.com> X-Mailer: git-send-email 2.29.1 MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20201104_133641_681067_CBA6D31C X-CRM114-Status: GOOD ( 20.52 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Mark Rutland , Lorenzo Pieralisi , kernel-team@android.com, Suzuki K Poulose , Marc Zyngier , Quentin Perret , linux-kernel@vger.kernel.org, James Morse , linux-arm-kernel@lists.infradead.org, Catalin Marinas , Tejun Heo , Dennis Zhou , Christoph Lameter , David Brazdil , Will Deacon , Julien Thierry , Andrew Scull Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org As we progress towards being able to keep guest state private to the host running nVHE hypervisor, this series allows the hypervisor to install itself on newly booted CPUs before the host is allowed to run on them. To this end, the hypervisor starts trapping host SMCs and intercepting host's PSCI CPU_ON/OFF/SUSPEND calls. It replaces the host's entry point with its own, initializes the EL2 state of the new CPU and installs the nVHE hyp vector before ERETing to the host's entry point. Other PSCI SMCs are forwarded to EL3, though only the known set of SMCs implemented in the kernel is allowed. Non-PSCI SMCs are also forwarded to EL3. Future changes will need to ensure the safety of all SMCs wrt. private guests. The host is still allowed to reset EL2 back to the stub vector, eg. for hibernation or kexec, but will not disable nVHE when there are no VMs. Tested on Rock Pi 4b. Sending this as an RFC to get feedback on the following decisions: 1) The kernel checks new cores' features against the finalized system capabilities. To avoid the need to move this code/data to EL2, the implementation only allows to boot cores that were online at the time of KVM initialization. 2) Trapping and forwarding SMCs cannot be switched off. This could cause issues eg. if EL3 always returned to EL1. A kernel command line flag may be needed to turn the feature off on such platforms. -David David Brazdil (25): psci: Export configured PSCI version psci: Export configured PSCI function IDs psci: Export psci_cpu_suspend_feature arm64: Move MAIR_EL1_SET to asm/memory.h kvm: arm64: Initialize MAIR_EL2 using a constant kvm: arm64: Add .hyp.data ELF section kvm: arm64: Support per_cpu_ptr in nVHE hyp code kvm: arm64: Create nVHE copy of cpu_logical_map kvm: arm64: Move hyp-init params to a per-CPU struct kvm: arm64: Refactor handle_trap to use a switch kvm: arm64: Extract parts of el2_setup into a macro kvm: arm64: Add SMC handler in nVHE EL2 kvm: arm64: Bootstrap PSCI SMC handler in nVHE EL2 kvm: arm64: Forward safe PSCI SMCs coming from host kvm: arm64: Add offset for hyp VA <-> PA conversion kvm: arm64: Bootstrap PSCI power state of host CPUs kvm: arm64: Intercept PSCI_CPU_OFF host SMC calls kvm: arm64: Extract __do_hyp_init into a helper function kvm: arm64: Add CPU entry point in nVHE hyp kvm: arm64: Add function to enter host from KVM nVHE hyp code kvm: arm64: Intercept PSCI_CPU_ON host SMC calls kvm: arm64: Intercept host's CPU_SUSPEND PSCI SMCs kvm: arm64: Keep nVHE EL2 vector installed kvm: arm64: Trap host SMCs kvm: arm64: Fix EL2 mode availability checks Will Deacon (1): arm64: kvm: Add standalone ticket spinlock implementation for use at hyp arch/arm64/include/asm/kvm_arm.h | 3 +- arch/arm64/include/asm/kvm_asm.h | 142 +++++++++ arch/arm64/include/asm/kvm_hyp.h | 10 + arch/arm64/include/asm/memory.h | 13 + arch/arm64/include/asm/percpu.h | 6 + arch/arm64/include/asm/sections.h | 1 + arch/arm64/include/asm/virt.h | 16 + arch/arm64/kernel/asm-offsets.c | 5 + arch/arm64/kernel/head.S | 140 +-------- arch/arm64/kernel/image-vars.h | 3 + arch/arm64/kernel/vmlinux.lds.S | 10 + arch/arm64/kvm/arm.c | 109 ++++++- arch/arm64/kvm/hyp/include/nvhe/spinlock.h | 96 ++++++ arch/arm64/kvm/hyp/nvhe/Makefile | 3 +- arch/arm64/kvm/hyp/nvhe/host.S | 9 + arch/arm64/kvm/hyp/nvhe/hyp-init.S | 82 ++++- arch/arm64/kvm/hyp/nvhe/hyp-main.c | 57 +++- arch/arm64/kvm/hyp/nvhe/hyp.lds.S | 3 + arch/arm64/kvm/hyp/nvhe/percpu.c | 38 +++ arch/arm64/kvm/hyp/nvhe/psci.c | 333 +++++++++++++++++++++ arch/arm64/mm/proc.S | 13 - drivers/firmware/psci/psci.c | 27 +- include/linux/psci.h | 20 ++ include/uapi/linux/psci.h | 8 + 24 files changed, 948 insertions(+), 199 deletions(-) create mode 100644 arch/arm64/kvm/hyp/include/nvhe/spinlock.h create mode 100644 arch/arm64/kvm/hyp/nvhe/percpu.c create mode 100644 arch/arm64/kvm/hyp/nvhe/psci.c -- 2.29.1.341.ge80a0c044ae-goog _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-14.4 required=3.0 tests=BAYES_00,DKIMWL_WL_MED, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT,USER_IN_DEF_DKIM_WL autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E9A53C2D0A3 for ; Wed, 4 Nov 2020 18:36:41 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 7801C20719 for ; Wed, 4 Nov 2020 18:36:41 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="l6wxGTW9" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1732405AbgKDSgk (ORCPT ); Wed, 4 Nov 2020 13:36:40 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56406 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726225AbgKDSgk (ORCPT ); Wed, 4 Nov 2020 13:36:40 -0500 Received: from mail-wm1-x343.google.com (mail-wm1-x343.google.com [IPv6:2a00:1450:4864:20::343]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6BCCAC0613D3 for ; Wed, 4 Nov 2020 10:36:38 -0800 (PST) Received: by mail-wm1-x343.google.com with SMTP id h2so727924wmm.0 for ; Wed, 04 Nov 2020 10:36:38 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=9bnsPOxn9yGq928zTuAG9ePIv/5JkrABhmxyp7kCDgs=; b=l6wxGTW9/LgEK7XEkr5CmOoS+dYbC2prLnazJg1dUjb83k2tfBbIuo1MO4xfZuYuq2 sdCXNTy3SkxO9ZDbZMd3NOEHJs6ugqJAtzosfyql8vY74UHap4MybGlDLWijiRZXgNL2 ukXB3rZMzB4hfoEZDlt1s11vC2vnIaVIKJNFHYOoH9vUcjoIXfy1vRSHptzTvVN+B5SZ 4nCASvL0GV20ahufoXLFL+HdwJO1PLsbLwPV0JNLmWxWUMdIIbkL9NGUdfqAk9XstiEY 3sEQ4PgP50Nx7Z3YaYwq+KXRrQaOS0rD6uHN3wn+AKch4N4pP8rsBwWw8K+ZWGmb4isW YE1A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=9bnsPOxn9yGq928zTuAG9ePIv/5JkrABhmxyp7kCDgs=; b=RcRfz+g1/iZDHkRNdKpS6uHzl6tn5DVlOeQnm13XTaTVnXmgkKbuX8sfZNOE+snx8n Z0iXVY2ube+fCoy1Bs+dthXY3LLVsRHp0hOFoGrUmKG1ovPxYgUntLWlfk3MqQRTZ1Wr eMZ+fYE3mXfzPwJO+HbkFAbIdKBaapOKUcaMtC2ZzC8D5kslTHXKq3781ORPiR35TB61 SnVK59Xg/J/lM76c7Dox6n8IMQT0mZVRWx5b9FqXLZF75BXPn25srAeIYZ9jftTKrKCY wtTfa6ChytUc9oPA/gVQDfpq8Wm9OpWumeoPjMyluG8HkuwvLm/ihb/57YDulMLxop2B UUzg== X-Gm-Message-State: AOAM530sURAxnn/B0HGZ5/5yK8K3j2Fo52x/p85oq5fdS9OpIz2owuge xHUcHzheYmsIcOJVa9NAgNz7RAEUDqUbGHgg X-Google-Smtp-Source: ABdhPJzETxfQOiqTB15tW/fCe98/ypLF2uI3mbgefn2W2p6cqFwsV46hT/Ypd/7K3nRZPYbyiOyf9g== X-Received: by 2002:a1c:18b:: with SMTP id 133mr1119334wmb.157.1604514996877; Wed, 04 Nov 2020 10:36:36 -0800 (PST) Received: from localhost ([2a01:4b00:8523:2d03:c8d2:30f2:53c6:bc2]) by smtp.gmail.com with ESMTPSA id d8sm3267985wmb.11.2020.11.04.10.36.35 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 04 Nov 2020 10:36:35 -0800 (PST) From: David Brazdil To: kvmarm@lists.cs.columbia.edu Cc: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Marc Zyngier , James Morse , Julien Thierry , Suzuki K Poulose , Catalin Marinas , Will Deacon , Dennis Zhou , Tejun Heo , Christoph Lameter , Mark Rutland , Lorenzo Pieralisi , Quentin Perret , Andrew Scull , kernel-team@android.com, David Brazdil Subject: [RFC PATCH 00/26] kvm: arm64: Always-on nVHE hypervisor Date: Wed, 4 Nov 2020 18:36:04 +0000 Message-Id: <20201104183630.27513-1-dbrazdil@google.com> X-Mailer: git-send-email 2.29.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org As we progress towards being able to keep guest state private to the host running nVHE hypervisor, this series allows the hypervisor to install itself on newly booted CPUs before the host is allowed to run on them. To this end, the hypervisor starts trapping host SMCs and intercepting host's PSCI CPU_ON/OFF/SUSPEND calls. It replaces the host's entry point with its own, initializes the EL2 state of the new CPU and installs the nVHE hyp vector before ERETing to the host's entry point. Other PSCI SMCs are forwarded to EL3, though only the known set of SMCs implemented in the kernel is allowed. Non-PSCI SMCs are also forwarded to EL3. Future changes will need to ensure the safety of all SMCs wrt. private guests. The host is still allowed to reset EL2 back to the stub vector, eg. for hibernation or kexec, but will not disable nVHE when there are no VMs. Tested on Rock Pi 4b. Sending this as an RFC to get feedback on the following decisions: 1) The kernel checks new cores' features against the finalized system capabilities. To avoid the need to move this code/data to EL2, the implementation only allows to boot cores that were online at the time of KVM initialization. 2) Trapping and forwarding SMCs cannot be switched off. This could cause issues eg. if EL3 always returned to EL1. A kernel command line flag may be needed to turn the feature off on such platforms. -David David Brazdil (25): psci: Export configured PSCI version psci: Export configured PSCI function IDs psci: Export psci_cpu_suspend_feature arm64: Move MAIR_EL1_SET to asm/memory.h kvm: arm64: Initialize MAIR_EL2 using a constant kvm: arm64: Add .hyp.data ELF section kvm: arm64: Support per_cpu_ptr in nVHE hyp code kvm: arm64: Create nVHE copy of cpu_logical_map kvm: arm64: Move hyp-init params to a per-CPU struct kvm: arm64: Refactor handle_trap to use a switch kvm: arm64: Extract parts of el2_setup into a macro kvm: arm64: Add SMC handler in nVHE EL2 kvm: arm64: Bootstrap PSCI SMC handler in nVHE EL2 kvm: arm64: Forward safe PSCI SMCs coming from host kvm: arm64: Add offset for hyp VA <-> PA conversion kvm: arm64: Bootstrap PSCI power state of host CPUs kvm: arm64: Intercept PSCI_CPU_OFF host SMC calls kvm: arm64: Extract __do_hyp_init into a helper function kvm: arm64: Add CPU entry point in nVHE hyp kvm: arm64: Add function to enter host from KVM nVHE hyp code kvm: arm64: Intercept PSCI_CPU_ON host SMC calls kvm: arm64: Intercept host's CPU_SUSPEND PSCI SMCs kvm: arm64: Keep nVHE EL2 vector installed kvm: arm64: Trap host SMCs kvm: arm64: Fix EL2 mode availability checks Will Deacon (1): arm64: kvm: Add standalone ticket spinlock implementation for use at hyp arch/arm64/include/asm/kvm_arm.h | 3 +- arch/arm64/include/asm/kvm_asm.h | 142 +++++++++ arch/arm64/include/asm/kvm_hyp.h | 10 + arch/arm64/include/asm/memory.h | 13 + arch/arm64/include/asm/percpu.h | 6 + arch/arm64/include/asm/sections.h | 1 + arch/arm64/include/asm/virt.h | 16 + arch/arm64/kernel/asm-offsets.c | 5 + arch/arm64/kernel/head.S | 140 +-------- arch/arm64/kernel/image-vars.h | 3 + arch/arm64/kernel/vmlinux.lds.S | 10 + arch/arm64/kvm/arm.c | 109 ++++++- arch/arm64/kvm/hyp/include/nvhe/spinlock.h | 96 ++++++ arch/arm64/kvm/hyp/nvhe/Makefile | 3 +- arch/arm64/kvm/hyp/nvhe/host.S | 9 + arch/arm64/kvm/hyp/nvhe/hyp-init.S | 82 ++++- arch/arm64/kvm/hyp/nvhe/hyp-main.c | 57 +++- arch/arm64/kvm/hyp/nvhe/hyp.lds.S | 3 + arch/arm64/kvm/hyp/nvhe/percpu.c | 38 +++ arch/arm64/kvm/hyp/nvhe/psci.c | 333 +++++++++++++++++++++ arch/arm64/mm/proc.S | 13 - drivers/firmware/psci/psci.c | 27 +- include/linux/psci.h | 20 ++ include/uapi/linux/psci.h | 8 + 24 files changed, 948 insertions(+), 199 deletions(-) create mode 100644 arch/arm64/kvm/hyp/include/nvhe/spinlock.h create mode 100644 arch/arm64/kvm/hyp/nvhe/percpu.c create mode 100644 arch/arm64/kvm/hyp/nvhe/psci.c -- 2.29.1.341.ge80a0c044ae-goog