From: Rob Herring <robh@kernel.org>
To: Dan Murphy <dmurphy@ti.com>
Cc: "Marek Behún" <kabel@kernel.org>,
linux-leds@vger.kernel.org, "Pavel Machek" <pavel@ucw.cz>,
devicetree@vger.kernel.org
Subject: Re: [PATCH leds 4/5] dt-bindings: leds: leds-class-multicolor: use LED_COLOR_ID_RGB for now
Date: Wed, 4 Nov 2020 15:55:02 -0600 [thread overview]
Message-ID: <20201104215502.GA4184250@bogus> (raw)
In-Reply-To: <b22f8d21-7625-dcff-616c-0c68008b5ab2@ti.com>
On Fri, Oct 30, 2020 at 08:08:01AM -0500, Dan Murphy wrote:
> Marek
>
> On 10/29/20 9:39 PM, Marek Behún wrote:
> > Commit 77dce3a22e89 ("leds: disallow /sys/class/leds/*:multi:* for now")
> > disallows LED_COLOR_ID_MULTI for now, and instead LED_COLOR_ID_RGB
> > should be used. Fix this is leds-class-multicolor binding.
> >
> > After we have some usecases for non-RGB multicolor LEDs, this can be
> > changed.
> >
> > Signed-off-by: Marek Behún <kabel@kernel.org>
> > Fixes: 77dce3a22e89 ("leds: disallow /sys/class/leds/*:multi:* for now")
> > Cc: devicetree@vger.kernel.org
> > Cc: robh+dt@kernel.org
> > ---
> > .../devicetree/bindings/leds/cznic,turris-omnia-leds.yaml | 4 ++--
> > .../devicetree/bindings/leds/leds-class-multicolor.yaml | 4 ++--
> > 2 files changed, 4 insertions(+), 4 deletions(-)
> >
> > diff --git a/Documentation/devicetree/bindings/leds/cznic,turris-omnia-leds.yaml b/Documentation/devicetree/bindings/leds/cznic,turris-omnia-leds.yaml
> > index fe7fa25877fd..2015db9b7618 100644
> > --- a/Documentation/devicetree/bindings/leds/cznic,turris-omnia-leds.yaml
> > +++ b/Documentation/devicetree/bindings/leds/cznic,turris-omnia-leds.yaml
> > @@ -73,14 +73,14 @@ examples:
> > * LEDs.
> > */
> > reg = <0>;
> > - color = <LED_COLOR_ID_MULTI>;
> > + color = <LED_COLOR_ID_RGB>;
> > function = LED_FUNCTION_POWER;
> > linux,default-trigger = "heartbeat";
> > };
> > multi-led@a {
> > reg = <0xa>;
> > - color = <LED_COLOR_ID_MULTI>;
> > + color = <LED_COLOR_ID_RGB>;
> > function = LED_FUNCTION_INDICATOR;
> > function-enumerator = <1>;
> > };
> > diff --git a/Documentation/devicetree/bindings/leds/leds-class-multicolor.yaml b/Documentation/devicetree/bindings/leds/leds-class-multicolor.yaml
> > index b1a53f054b89..9faa3609a6bb 100644
> > --- a/Documentation/devicetree/bindings/leds/leds-class-multicolor.yaml
> > +++ b/Documentation/devicetree/bindings/leds/leds-class-multicolor.yaml
>
> Why are you resubmitting the multicolor.yaml?
>
> https://lore.kernel.org/patchwork/patch/1320863/
>
> This is waiting on DT review.
I'm expecting another version as you commented on it.
Rob
next prev parent reply other threads:[~2020-11-04 21:55 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-30 2:39 [PATCH leds 1/5] leds: turris-omnia: use constants instead of macros for color command Marek Behún
2020-10-30 2:39 ` [PATCH leds 2/5] leds: turris-omnia: wrap to 80 columns Marek Behún
2020-10-30 2:39 ` [PATCH leds 3/5] leds: turris-omnia: fix checkpatch warning Marek Behún
2020-10-30 2:39 ` [PATCH leds 4/5] dt-bindings: leds: leds-class-multicolor: use LED_COLOR_ID_RGB for now Marek Behún
2020-10-30 13:08 ` Dan Murphy
2020-10-30 21:46 ` Marek Behún
2020-11-04 21:55 ` Rob Herring [this message]
2020-11-04 21:58 ` Dan Murphy
2020-10-30 2:39 ` [PATCH leds 5/5] leds: turris-omnia: check for LED_COLOR_ID_RGB instead LED_COLOR_ID_MULTI Marek Behún
2020-11-25 12:25 ` Pavel Machek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201104215502.GA4184250@bogus \
--to=robh@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dmurphy@ti.com \
--cc=kabel@kernel.org \
--cc=linux-leds@vger.kernel.org \
--cc=pavel@ucw.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.