Re: [dpdk-dev] [PATCH v5 0/5] replace blacklist/whitelist with block/allow

[Stephen Hemminger <stephen@networkplumber.org>]

On Thu, 5 Nov 2020 09:27:59 +0100
David Marchand <david.marchand@redhat.com> wrote:

> On Sat, Oct 24, 2020 at 3:02 AM Stephen Hemminger
> <stephen@networkplumber.org> wrote:
> >
> > This is a revised version of the earlier RFC patch set for changing
> > the blacklist/whitelist terms in DPDK.
> >
> > The first patch is a duplicate from the other patch set about
> > use of master/slave in API.
> >
> > Note:
> > This may cause some warnings in existing programs in the CI
> > tests using the -w flag.
> >
> > It also causes checkpatch complaints because we are replacing
> > blacklist which is flagged by the current versions.
> >
> > v5 - rebase and fix conflicts in documentation
> >
> > Stephen Hemminger (5):
> >   eal: replace usage of blacklist/whitelist in enum
> >   drivers: replace references to blacklist
> >   eal: replace pci-whitelist/pci-blacklist options
> >   app/test: use new allowlist and blocklist
> >   doc: change references to blacklist and whitelist  
> 
> - This series does not implement what had been announced in the
> deprecation notice:
> https://git.dpdk.org/dpdk/commit/doc/guides/rel_notes/deprecation.rst?id=714e3e60014206cb616cd4157bf11a5209e7186f
> 
> From my pov, the implementation with ALLOWED/BLOCKED is as good as the
> one initially proposed so this is fine.
> But in this case, please stick to it, there are still some traces
> about "included" / "include" / "excluded" "exclude" devices, in
> comments and usage strings.
> Idem, please stick to a consistent wording in all patches, I noted
> "Blocklisted" "Blocked" "Marked as blocked".

Thanks fixed in next version

> - The release note and deprecation notice (which is missing) must both
> be updated atomically with the patches that change API.

Should I just remove the deprecation notice now?

> - Compilation is broken at patch1, since patch2 changes are required.

The compilation does work just produces lots of warnings.


> - The documentation patch has misses:
> doc/guides/nics/fail_safe.rst:         -w 81:00.0 -- -i
> doc/guides/nics/fail_safe.rst:      ./<build_dir>/app/dpdk-testpmd -c
> 0xff -n 4 -w ff:ff.f \
> doc/guides/sample_app_ug/vdpa.rst:                -w
> 0000:06:00.3,vdpa=1 -a 0000:06:00.4,vdpa=1 \

Fixed those

> - The documentation patch has a rebase issue in ice.rst, as flow mark
> devargs has been dropped in 62451c94ad - net/ice: remove devargs for
> flow mark (7 weeks ago) <Guinan Sun>

Fixed that as well