[radeon-alex:amd-staging-drm-next 1/2] drivers/gpu/drm/amd/display/dc/dcn30/dcn30_dpp.c:688:65-70: WARNING: conversion to bool not needed here

[radeon-alex:amd-staging-drm-next 1/2] drivers/gpu/drm/amd/display/dc/dcn30/dcn30_dpp.c:688:65-70: WARNING: conversion to bool not needed here

[kernel test robot]

[-- Attachment #1: Type: text/plain, Size: 1248 bytes --]

CC: kbuild-all(a)lists.01.org
CC: dri-devel(a)lists.freedesktop.org
TO: Alex Deucher <alexander.deucher@amd.com>
CC: Luben Tuikov <luben.tuikov@amd.com>

Hi Alex,

First bad commit (maybe != root cause):

tree:   git://people.freedesktop.org/~agd5f/linux.git amd-staging-drm-next
head:   26803606c5d6137fb24d8ecec9b326a99f890c91
commit: 2529f3eddf19be0f697c67b6e88fac702ad350ce [1/2] drm/amdgpu: fold CONFIG_DRM_AMD_DC_DCN3* into CONFIG_DRM_AMD_DC_DCN (v3)
:::::: branch date: 5 hours ago
:::::: commit date: 5 hours ago
config: x86_64-randconfig-c002-20201104 (attached as .config)
compiler: gcc-9 (Debian 9.3.0-15) 9.3.0

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>
Reported-by: Julia Lawall <julia.lawall@lip6.fr>


"coccinelle warnings: (new ones prefixed by >>)"
>> drivers/gpu/drm/amd/display/dc/dcn30/dcn30_dpp.c:688:65-70: WARNING: conversion to bool not needed here
   drivers/gpu/drm/amd/display/dc/dcn30/dcn30_dpp.c:1100:67-72: WARNING: conversion to bool not needed here

Please review and possibly fold the followup patch.

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org

[-- Attachment #2: config.gz --]
[-- Type: application/gzip, Size: 36330 bytes --]

[PATCH] drm/amdgpu: fix boolconv.cocci warnings

[kernel test robot]

[-- Attachment #1: Type: text/plain, Size: 2381 bytes --]

CC: kbuild-all(a)lists.01.org
CC: dri-devel(a)lists.freedesktop.org
TO: Alex Deucher <alexander.deucher@amd.com>
CC: Luben Tuikov <luben.tuikov@amd.com>
CC: Harry Wentland <harry.wentland@amd.com>
CC: Leo Li <sunpeng.li@amd.com>
CC: "Christian König" <christian.koenig@amd.com>
CC: David Airlie <airlied@linux.ie>
CC: Daniel Vetter <daniel@ffwll.ch>
CC: Tony Cheng <Tony.Cheng@amd.com>
CC: Rodrigo Siqueira <Rodrigo.Siqueira@amd.com>
CC: Noah Abradjian <noah.abradjian@amd.com>

From: kernel test robot <lkp@intel.com>

drivers/gpu/drm/amd/display/dc/dcn30/dcn30_dpp.c:688:65-70: WARNING: conversion to bool not needed here
drivers/gpu/drm/amd/display/dc/dcn30/dcn30_dpp.c:1100:67-72: WARNING: conversion to bool not needed here

 Remove unneeded conversion to bool

Semantic patch information:
 Relational and logical operators evaluate to bool,
 explicit conversion is overly verbose and unneeded.

Generated by: scripts/coccinelle/misc/boolconv.cocci

Fixes: 2529f3eddf19 ("drm/amdgpu: fold CONFIG_DRM_AMD_DC_DCN3* into CONFIG_DRM_AMD_DC_DCN (v3)")
Signed-off-by: kernel test robot <lkp@intel.com>
---

tree:   git://people.freedesktop.org/~agd5f/linux.git amd-staging-drm-next
head:   26803606c5d6137fb24d8ecec9b326a99f890c91
commit: 2529f3eddf19be0f697c67b6e88fac702ad350ce [1/2] drm/amdgpu: fold CONFIG_DRM_AMD_DC_DCN3* into CONFIG_DRM_AMD_DC_DCN (v3)
:::::: branch date: 5 hours ago
:::::: commit date: 5 hours ago

Please take the patch only if it's a positive warning. Thanks!

 dcn30_dpp.c |    4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

--- a/drivers/gpu/drm/amd/display/dc/dcn30/dcn30_dpp.c
+++ b/drivers/gpu/drm/amd/display/dc/dcn30/dcn30_dpp.c
@@ -685,7 +685,7 @@ bool dpp3_program_blnd_lut(
 		next_mode = LUT_RAM_B;
 
 	dpp3_power_on_blnd_lut(dpp_base, true);
-	dpp3_configure_blnd_lut(dpp_base, next_mode == LUT_RAM_A ? true:false);
+	dpp3_configure_blnd_lut(dpp_base, next_mode == LUT_RAM_A);
 
 	if (next_mode == LUT_RAM_A)
 		dpp3_program_blnd_luta_settings(dpp_base, params);
@@ -1097,7 +1097,7 @@ bool dpp3_program_shaper(
 	else
 		next_mode = LUT_RAM_A;
 
-	dpp3_configure_shaper_lut(dpp_base, next_mode == LUT_RAM_A ? true:false);
+	dpp3_configure_shaper_lut(dpp_base, next_mode == LUT_RAM_A);
 
 	if (next_mode == LUT_RAM_A)
 		dpp3_program_shaper_luta_settings(dpp_base, params);