From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.5 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C338BC388F2 for ; Fri, 6 Nov 2020 04:26:57 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 1E9BB20719 for ; Fri, 6 Nov 2020 04:26:57 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=ideasonboard.com header.i=@ideasonboard.com header.b="Hp7cQ1Cy" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 1E9BB20719 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=ideasonboard.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id E90CC6EA4E; Fri, 6 Nov 2020 04:26:55 +0000 (UTC) Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647]) by gabe.freedesktop.org (Postfix) with ESMTPS id C0C7F6EA4E for ; Fri, 6 Nov 2020 04:26:53 +0000 (UTC) Received: from pendragon.ideasonboard.com (62-78-145-57.bb.dnainternet.fi [62.78.145.57]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id 82AC4B16; Fri, 6 Nov 2020 05:26:51 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1604636811; bh=Dzy4k7oMrh6Qwr0FibbNWC+4whZQko79sRwDL+YBC5M=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=Hp7cQ1Cyu0ma0fKXMBujwp0zP6HjHtC7x3tNfOHBazC+xC9z/qrPFCj03UALtowE0 YQFP6oDJeY2jNiR1yNJ9Rr1VpM8K6Ry4DNagPN4Gsii0WTEv4uxlhaW/kA5PINLsWF H1LLmCc5JSyKR4PwbePZZZUW/cKHHYt0wyziJNEQ= Date: Fri, 6 Nov 2020 06:26:50 +0200 From: Laurent Pinchart To: Lee Jones Subject: Re: [PATCH 08/19] gpu: drm: omapdrm: dss: dsi: Rework and remove a few unused variables Message-ID: <20201106042650.GA16469@pendragon.ideasonboard.com> References: <20201105144517.1826692-1-lee.jones@linaro.org> <20201105144517.1826692-9-lee.jones@linaro.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20201105144517.1826692-9-lee.jones@linaro.org> X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: David Airlie , dri-devel@lists.freedesktop.org, Tomi Valkeinen , linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" SGkgTGVlLAoKVGhhbmsgeW91IGZvciB0aGUgcGF0Y2guCgpPbiBUaHUsIE5vdiAwNSwgMjAyMCBh dCAwMjo0NTowNlBNICswMDAwLCBMZWUgSm9uZXMgd3JvdGU6Cj4gRml4ZXMgdGhlIGZvbGxvd2lu ZyBXPTEga2VybmVsIGJ1aWxkIHdhcm5pbmcocyk6Cj4gCj4gIGRyaXZlcnMvZ3B1L2RybS9vbWFw ZHJtL2Rzcy9kc2kuYzogSW4gZnVuY3Rpb24g4oCYX2RzaV9wcmludF9yZXNldF9zdGF0dXPigJk6 Cj4gIGRyaXZlcnMvZ3B1L2RybS9vbWFwZHJtL2Rzcy9kc2kuYzoxMTMxOjY6IHdhcm5pbmc6IHZh cmlhYmxlIOKAmGzigJkgc2V0IGJ1dCBub3QgdXNlZCBbLVd1bnVzZWQtYnV0LXNldC12YXJpYWJs ZV0KPiAgZHJpdmVycy9ncHUvZHJtL29tYXBkcm0vZHNzL2RzaS5jOiBJbiBmdW5jdGlvbiDigJhk c2lfdXBkYXRl4oCZOgo+ICBkcml2ZXJzL2dwdS9kcm0vb21hcGRybS9kc3MvZHNpLmM6Mzk0Mzox MDogd2FybmluZzogdmFyaWFibGUg4oCYZGjigJkgc2V0IGJ1dCBub3QgdXNlZCBbLVd1bnVzZWQt YnV0LXNldC12YXJpYWJsZV0KPiAgZHJpdmVycy9ncHUvZHJtL29tYXBkcm0vZHNzL2RzaS5jOjM5 NDM6Njogd2FybmluZzogdmFyaWFibGUg4oCYZHfigJkgc2V0IGJ1dCBub3QgdXNlZCBbLVd1bnVz ZWQtYnV0LXNldC12YXJpYWJsZV0KPiAKPiBDYzogVG9taSBWYWxrZWluZW4gPHRvbWkudmFsa2Vp bmVuQHRpLmNvbT4KPiBDYzogRGF2aWQgQWlybGllIDxhaXJsaWVkQGxpbnV4LmllPgo+IENjOiBE YW5pZWwgVmV0dGVyIDxkYW5pZWxAZmZ3bGwuY2g+Cj4gQ2M6IExhdXJlbnQgUGluY2hhcnQgPGxh dXJlbnQucGluY2hhcnRAaWRlYXNvbmJvYXJkLmNvbT4KPiBDYzogZHJpLWRldmVsQGxpc3RzLmZy ZWVkZXNrdG9wLm9yZwo+IFNpZ25lZC1vZmYtYnk6IExlZSBKb25lcyA8bGVlLmpvbmVzQGxpbmFy by5vcmc+CgpSZXZpZXdlZC1ieTogTGF1cmVudCBQaW5jaGFydCA8bGF1cmVudC5waW5jaGFydEBp ZGVhc29uYm9hcmQuY29tPgoKPiAtLS0KPiAgZHJpdmVycy9ncHUvZHJtL29tYXBkcm0vZHNzL2Rz aS5jIHwgOSArKy0tLS0tLS0KPiAgMSBmaWxlIGNoYW5nZWQsIDIgaW5zZXJ0aW9ucygrKSwgNyBk ZWxldGlvbnMoLSkKPiAKPiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJtL29tYXBkcm0vZHNz L2RzaS5jIGIvZHJpdmVycy9ncHUvZHJtL29tYXBkcm0vZHNzL2RzaS5jCj4gaW5kZXggZWVjY2Y0 MGJhZTQxNi4uNTkyOWIzMjBiM2NmYSAxMDA2NDQKPiAtLS0gYS9kcml2ZXJzL2dwdS9kcm0vb21h cGRybS9kc3MvZHNpLmMKPiArKysgYi9kcml2ZXJzL2dwdS9kcm0vb21hcGRybS9kc3MvZHNpLmMK PiBAQCAtMTEyOCwxMyArMTEyOCwxMiBAQCBzdGF0aWMgdm9pZCBkc2lfcnVudGltZV9wdXQoc3Ry dWN0IGRzaV9kYXRhICpkc2kpCj4gIAo+ICBzdGF0aWMgdm9pZCBfZHNpX3ByaW50X3Jlc2V0X3N0 YXR1cyhzdHJ1Y3QgZHNpX2RhdGEgKmRzaSkKPiAgewo+IC0JdTMyIGw7Cj4gIAlpbnQgYjAsIGIx LCBiMjsKPiAgCj4gIAkvKiBBIGR1bW15IHJlYWQgdXNpbmcgdGhlIFNDUCBpbnRlcmZhY2UgdG8g YW55IERTSVBIWSByZWdpc3RlciBpcwo+ICAJICogcmVxdWlyZWQgYWZ0ZXIgRFNJUEhZIHJlc2V0 IHRvIGNvbXBsZXRlIHRoZSByZXNldCBvZiB0aGUgRFNJIGNvbXBsZXgKPiAgCSAqIEkvTy4gKi8K PiAtCWwgPSBkc2lfcmVhZF9yZWcoZHNpLCBEU0lfRFNJUEhZX0NGRzUpOwo+ICsJZHNpX3JlYWRf cmVnKGRzaSwgRFNJX0RTSVBIWV9DRkc1KTsKPiAgCj4gIAlpZiAoZHNpLT5kYXRhLT5xdWlya3Mg JiBEU0lfUVVJUktfUkVWRVJTRV9UWENMS0VTQykgewo+ICAJCWIwID0gMjg7Cj4gQEAgLTM5NDAs NyArMzkzOSw2IEBAIHN0YXRpYyBpbnQgZHNpX3VwZGF0ZShzdHJ1Y3Qgb21hcF9kc3NfZGV2aWNl ICpkc3NkZXYsIGludCBjaGFubmVsLAo+ICAJCXZvaWQgKCpjYWxsYmFjaykoaW50LCB2b2lkICop LCB2b2lkICpkYXRhKQo+ICB7Cj4gIAlzdHJ1Y3QgZHNpX2RhdGEgKmRzaSA9IHRvX2RzaV9kYXRh KGRzc2Rldik7Cj4gLQl1MTYgZHcsIGRoOwo+ICAKPiAgCWRzaV9wZXJmX21hcmtfc2V0dXAoZHNp KTsKPiAgCj4gQEAgLTM5NDksMTEgKzM5NDcsOCBAQCBzdGF0aWMgaW50IGRzaV91cGRhdGUoc3Ry dWN0IG9tYXBfZHNzX2RldmljZSAqZHNzZGV2LCBpbnQgY2hhbm5lbCwKPiAgCWRzaS0+ZnJhbWVk b25lX2NhbGxiYWNrID0gY2FsbGJhY2s7Cj4gIAlkc2ktPmZyYW1lZG9uZV9kYXRhID0gZGF0YTsK PiAgCj4gLQlkdyA9IGRzaS0+dm0uaGFjdGl2ZTsKPiAtCWRoID0gZHNpLT52bS52YWN0aXZlOwo+ IC0KPiAgI2lmZGVmIERTSV9QRVJGX01FQVNVUkUKPiAtCWRzaS0+dXBkYXRlX2J5dGVzID0gZHcg KiBkaCAqCj4gKwlkc2ktPnVwZGF0ZV9ieXRlcyA9IGRzaS0+dm0uaGFjdGl2ZSAqIGRzaS0+dm0u dmFjdGl2ZSAqCj4gIAkJZHNpX2dldF9waXhlbF9zaXplKGRzaS0+cGl4X2ZtdCkgLyA4Owo+ICAj ZW5kaWYKPiAgCWRzaV91cGRhdGVfc2NyZWVuX2Rpc3BjKGRzaSk7CgotLSAKUmVnYXJkcywKCkxh dXJlbnQgUGluY2hhcnQKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX18KZHJpLWRldmVsIG1haWxpbmcgbGlzdApkcmktZGV2ZWxAbGlzdHMuZnJlZWRlc2t0b3Au b3JnCmh0dHBzOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vZHJpLWRl dmVsCg== From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7AA4EC2D0A3 for ; Fri, 6 Nov 2020 04:26:57 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id C6F2120704 for ; Fri, 6 Nov 2020 04:26:56 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=ideasonboard.com header.i=@ideasonboard.com header.b="Hp7cQ1Cy" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1725979AbgKFE0z (ORCPT ); Thu, 5 Nov 2020 23:26:55 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34312 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725616AbgKFE0z (ORCPT ); Thu, 5 Nov 2020 23:26:55 -0500 Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 5406CC0613CF for ; Thu, 5 Nov 2020 20:26:55 -0800 (PST) Received: from pendragon.ideasonboard.com (62-78-145-57.bb.dnainternet.fi [62.78.145.57]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id 82AC4B16; Fri, 6 Nov 2020 05:26:51 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1604636811; bh=Dzy4k7oMrh6Qwr0FibbNWC+4whZQko79sRwDL+YBC5M=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=Hp7cQ1Cyu0ma0fKXMBujwp0zP6HjHtC7x3tNfOHBazC+xC9z/qrPFCj03UALtowE0 YQFP6oDJeY2jNiR1yNJ9Rr1VpM8K6Ry4DNagPN4Gsii0WTEv4uxlhaW/kA5PINLsWF H1LLmCc5JSyKR4PwbePZZZUW/cKHHYt0wyziJNEQ= Date: Fri, 6 Nov 2020 06:26:50 +0200 From: Laurent Pinchart To: Lee Jones Cc: linux-kernel@vger.kernel.org, Tomi Valkeinen , David Airlie , Daniel Vetter , dri-devel@lists.freedesktop.org Subject: Re: [PATCH 08/19] gpu: drm: omapdrm: dss: dsi: Rework and remove a few unused variables Message-ID: <20201106042650.GA16469@pendragon.ideasonboard.com> References: <20201105144517.1826692-1-lee.jones@linaro.org> <20201105144517.1826692-9-lee.jones@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20201105144517.1826692-9-lee.jones@linaro.org> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Lee, Thank you for the patch. On Thu, Nov 05, 2020 at 02:45:06PM +0000, Lee Jones wrote: > Fixes the following W=1 kernel build warning(s): > > drivers/gpu/drm/omapdrm/dss/dsi.c: In function ‘_dsi_print_reset_status’: > drivers/gpu/drm/omapdrm/dss/dsi.c:1131:6: warning: variable ‘l’ set but not used [-Wunused-but-set-variable] > drivers/gpu/drm/omapdrm/dss/dsi.c: In function ‘dsi_update’: > drivers/gpu/drm/omapdrm/dss/dsi.c:3943:10: warning: variable ‘dh’ set but not used [-Wunused-but-set-variable] > drivers/gpu/drm/omapdrm/dss/dsi.c:3943:6: warning: variable ‘dw’ set but not used [-Wunused-but-set-variable] > > Cc: Tomi Valkeinen > Cc: David Airlie > Cc: Daniel Vetter > Cc: Laurent Pinchart > Cc: dri-devel@lists.freedesktop.org > Signed-off-by: Lee Jones Reviewed-by: Laurent Pinchart > --- > drivers/gpu/drm/omapdrm/dss/dsi.c | 9 ++------- > 1 file changed, 2 insertions(+), 7 deletions(-) > > diff --git a/drivers/gpu/drm/omapdrm/dss/dsi.c b/drivers/gpu/drm/omapdrm/dss/dsi.c > index eeccf40bae416..5929b320b3cfa 100644 > --- a/drivers/gpu/drm/omapdrm/dss/dsi.c > +++ b/drivers/gpu/drm/omapdrm/dss/dsi.c > @@ -1128,13 +1128,12 @@ static void dsi_runtime_put(struct dsi_data *dsi) > > static void _dsi_print_reset_status(struct dsi_data *dsi) > { > - u32 l; > int b0, b1, b2; > > /* A dummy read using the SCP interface to any DSIPHY register is > * required after DSIPHY reset to complete the reset of the DSI complex > * I/O. */ > - l = dsi_read_reg(dsi, DSI_DSIPHY_CFG5); > + dsi_read_reg(dsi, DSI_DSIPHY_CFG5); > > if (dsi->data->quirks & DSI_QUIRK_REVERSE_TXCLKESC) { > b0 = 28; > @@ -3940,7 +3939,6 @@ static int dsi_update(struct omap_dss_device *dssdev, int channel, > void (*callback)(int, void *), void *data) > { > struct dsi_data *dsi = to_dsi_data(dssdev); > - u16 dw, dh; > > dsi_perf_mark_setup(dsi); > > @@ -3949,11 +3947,8 @@ static int dsi_update(struct omap_dss_device *dssdev, int channel, > dsi->framedone_callback = callback; > dsi->framedone_data = data; > > - dw = dsi->vm.hactive; > - dh = dsi->vm.vactive; > - > #ifdef DSI_PERF_MEASURE > - dsi->update_bytes = dw * dh * > + dsi->update_bytes = dsi->vm.hactive * dsi->vm.vactive * > dsi_get_pixel_size(dsi->pix_fmt) / 8; > #endif > dsi_update_screen_dispc(dsi); -- Regards, Laurent Pinchart