From: Christoph Hellwig <hch@lst.de>
To: Ralph Campbell <rcampbell@nvidia.com>
Cc: linux-mm@kvack.org, nouveau@lists.freedesktop.org,
linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org,
Jerome Glisse <jglisse@redhat.com>,
John Hubbard <jhubbard@nvidia.com>,
Alistair Popple <apopple@nvidia.com>,
Christoph Hellwig <hch@lst.de>, Jason Gunthorpe <jgg@nvidia.com>,
Bharata B Rao <bharata@linux.ibm.com>, Zi Yan <ziy@nvidia.com>,
"Kirill A . Shutemov" <kirill.shutemov@linux.intel.com>,
Yang Shi <yang.shi@linux.alibaba.com>,
Ben Skeggs <bskeggs@redhat.com>, Shuah Khan <shuah@kernel.org>,
Andrew Morton <akpm@linux-foundation.org>
Subject: Re: [PATCH v3 4/6] mm/thp: add THP allocation helper
Date: Fri, 6 Nov 2020 09:01:47 +0100 [thread overview]
Message-ID: <20201106080147.GD31341@lst.de> (raw)
In-Reply-To: <20201106005147.20113-5-rcampbell@nvidia.com>
> +#ifdef CONFIG_TRANSPARENT_HUGEPAGE
> +extern struct page *alloc_transhugepage(struct vm_area_struct *vma,
> + unsigned long addr);
No need for the extern. And also here: do we actually need the stub,
or can the caller make sure (using IS_ENABLED and similar) that the
compiler knows the code is dead?
> +struct page *alloc_transhugepage(struct vm_area_struct *vma,
> + unsigned long haddr)
> +{
> + gfp_t gfp;
> + struct page *page;
> +
> + gfp = alloc_hugepage_direct_gfpmask(vma);
> + page = alloc_hugepage_vma(gfp, vma, haddr, HPAGE_PMD_ORDER);
> + if (page)
> + prep_transhuge_page(page);
> + return page;
I think do_huge_pmd_anonymous_page should be switched to use this
helper as well.
next prev parent reply other threads:[~2020-11-06 8:01 UTC|newest]
Thread overview: 44+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-06 0:51 [PATCH v3 0/6] mm/hmm/nouveau: add THP migration to migrate_vma_* Ralph Campbell
2020-11-06 0:51 ` Ralph Campbell
2020-11-06 0:51 ` [PATCH v3 1/6] mm/thp: add prep_transhuge_device_private_page() Ralph Campbell
2020-11-06 0:51 ` Ralph Campbell
2020-11-06 7:55 ` Christoph Hellwig
2020-11-06 20:56 ` Ralph Campbell
2020-11-06 20:56 ` Ralph Campbell
2020-11-06 12:14 ` Matthew Wilcox
2020-11-06 12:14 ` Matthew Wilcox
2020-11-06 20:34 ` Ralph Campbell
2020-11-06 20:34 ` Ralph Campbell
2020-11-06 0:51 ` [PATCH v3 2/6] mm/migrate: move migrate_vma_collect_skip() Ralph Campbell
2020-11-06 0:51 ` Ralph Campbell
2020-11-06 7:56 ` Christoph Hellwig
2020-11-06 7:57 ` Christoph Hellwig
2020-11-06 0:51 ` [PATCH v3 3/6] mm: support THP migration to device private memory Ralph Campbell
2020-11-06 0:51 ` Ralph Campbell
2020-11-06 8:03 ` Christoph Hellwig
2020-11-06 8:03 ` Christoph Hellwig
2020-11-06 21:26 ` Ralph Campbell
2020-11-06 21:26 ` Ralph Campbell
2020-11-09 9:14 ` Christoph Hellwig
2020-11-09 21:34 ` Ralph Campbell
2020-11-09 21:34 ` Ralph Campbell
2020-11-11 23:38 ` Ralph Campbell
2020-11-11 23:38 ` Ralph Campbell
2020-11-20 20:01 ` Jason Gunthorpe
2020-11-20 20:01 ` Jason Gunthorpe
2020-12-02 10:08 ` Christoph Hellwig
2020-12-02 10:08 ` Christoph Hellwig
2020-12-05 8:22 ` Roger Pau Monné
2020-12-05 8:22 ` Roger Pau Monné
2020-12-02 10:14 ` Christoph Hellwig
2020-12-02 10:14 ` Christoph Hellwig
2020-12-02 18:01 ` Logan Gunthorpe
2020-12-02 18:01 ` Logan Gunthorpe
2020-11-06 0:51 ` [PATCH v3 4/6] mm/thp: add THP allocation helper Ralph Campbell
2020-11-06 0:51 ` Ralph Campbell
2020-11-06 8:01 ` Christoph Hellwig [this message]
2020-11-06 21:09 ` Ralph Campbell
2020-11-06 0:51 ` [PATCH v3 5/6] mm/hmm/test: add self tests for THP migration Ralph Campbell
2020-11-06 0:51 ` Ralph Campbell
2020-11-06 0:51 ` [PATCH v3 6/6] nouveau: support THP migration to private memory Ralph Campbell
2020-11-06 0:51 ` Ralph Campbell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201106080147.GD31341@lst.de \
--to=hch@lst.de \
--cc=akpm@linux-foundation.org \
--cc=apopple@nvidia.com \
--cc=bharata@linux.ibm.com \
--cc=bskeggs@redhat.com \
--cc=jgg@nvidia.com \
--cc=jglisse@redhat.com \
--cc=jhubbard@nvidia.com \
--cc=kirill.shutemov@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=nouveau@lists.freedesktop.org \
--cc=rcampbell@nvidia.com \
--cc=shuah@kernel.org \
--cc=yang.shi@linux.alibaba.com \
--cc=ziy@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.