From: Jiri Benc <jbenc@redhat.com>
To: Jakub Kicinski <kuba@kernel.org>
Cc: Andrii Nakryiko <andrii.nakryiko@gmail.com>,
Andrii Nakryiko <andriin@fb.com>, bpf <bpf@vger.kernel.org>,
Networking <netdev@vger.kernel.org>,
Alexei Starovoitov <ast@fb.com>,
Daniel Borkmann <daniel@iogearbox.net>,
Kernel Team <kernel-team@fb.com>
Subject: Re: [PATCH v3 bpf-next] bpf: make verifier log more relevant by default
Date: Fri, 6 Nov 2020 09:24:48 +0100 [thread overview]
Message-ID: <20201106092448.5c14808c@redhat.com> (raw)
In-Reply-To: <20201105145713.10af539e@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com>
On Thu, 5 Nov 2020 14:57:13 -0800, Jakub Kicinski wrote:
> If you're saying the driver message would still be there if
> verification or translation failed that's perfectly fine, we
> can definitely adjust the test. But some check that driver
> message reporting is working is needed, don't just remove it.
Should we change the test to fail the verification? Sounds reasonable
to me.
Jiri
next prev parent reply other threads:[~2020-11-06 8:25 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-23 19:58 [PATCH v3 bpf-next] bpf: make verifier log more relevant by default Andrii Nakryiko
2020-04-26 16:57 ` Alexei Starovoitov
2020-04-28 4:55 ` Andrii Nakryiko
2020-11-05 16:02 ` Jiri Benc
2020-11-05 21:22 ` Andrii Nakryiko
2020-11-05 21:53 ` Jakub Kicinski
2020-11-05 22:41 ` Andrii Nakryiko
2020-11-05 22:57 ` Jakub Kicinski
2020-11-06 8:24 ` Jiri Benc [this message]
2020-11-06 18:52 ` Jakub Kicinski
2020-11-06 8:26 ` Jiri Benc
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201106092448.5c14808c@redhat.com \
--to=jbenc@redhat.com \
--cc=andrii.nakryiko@gmail.com \
--cc=andriin@fb.com \
--cc=ast@fb.com \
--cc=bpf@vger.kernel.org \
--cc=daniel@iogearbox.net \
--cc=kernel-team@fb.com \
--cc=kuba@kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.