From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.5 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 62EA7C55178 for ; Fri, 6 Nov 2020 10:41:20 +0000 (UTC) Received: from fraxinus.osuosl.org (smtp4.osuosl.org [140.211.166.137]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id B2BAC2068D for ; Fri, 6 Nov 2020 10:41:19 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="LIIV1fye" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org B2BAC2068D Authentication-Results: mail.kernel.org; dmarc=pass (p=none dis=none) header.from=linuxfoundation.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=linux-kernel-mentees-bounces@lists.linuxfoundation.org Received: from localhost (localhost [127.0.0.1]) by fraxinus.osuosl.org (Postfix) with ESMTP id 288BB86463; Fri, 6 Nov 2020 10:41:19 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from fraxinus.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id ULWRtIPK5ldD; Fri, 6 Nov 2020 10:41:18 +0000 (UTC) Received: from lists.linuxfoundation.org (lf-lists.osuosl.org [140.211.9.56]) by fraxinus.osuosl.org (Postfix) with ESMTP id CE207860F0; Fri, 6 Nov 2020 10:41:18 +0000 (UTC) Received: from lf-lists.osuosl.org (localhost [127.0.0.1]) by lists.linuxfoundation.org (Postfix) with ESMTP id B3231C0893; Fri, 6 Nov 2020 10:41:18 +0000 (UTC) Received: from fraxinus.osuosl.org (smtp4.osuosl.org [140.211.166.137]) by lists.linuxfoundation.org (Postfix) with ESMTP id 03E29C0889 for ; Fri, 6 Nov 2020 10:41:17 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by fraxinus.osuosl.org (Postfix) with ESMTP id DF43986463 for ; Fri, 6 Nov 2020 10:41:17 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from fraxinus.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id RrbiKcelzckA for ; Fri, 6 Nov 2020 10:41:17 +0000 (UTC) X-Greylist: from auto-whitelisted by SQLgrey-1.7.6 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by fraxinus.osuosl.org (Postfix) with ESMTPS id 6EBBF860F0 for ; Fri, 6 Nov 2020 10:41:17 +0000 (UTC) Received: from localhost (83-86-74-64.cable.dynamic.v4.ziggo.nl [83.86.74.64]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 41E4B20702; Fri, 6 Nov 2020 10:41:16 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1604659276; bh=FZPOUxbRLfnd+t8CdYEkeO2TCpAs4UT0oND2nvpDiDU=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=LIIV1fyeLOQP3xvdO35mmMUbH6AnHfV2gll+R4VQt/8JMCXFuKE+oywvx2kFEpXkE gK9egVH44hTJgnK8pv+jk9SQW8DrJnh4b5t3AxKaEMb6J0KStHwH9K2Rf+6O5saVIu OnhkH6hhV8fuxh0NK96fZtx0Y7QPMV5DCTmJm3Cs= Date: Fri, 6 Nov 2020 11:42:03 +0100 From: Greg KH To: Rasmus Villemoes Message-ID: <20201106104203.GC2784089@kroah.com> References: <20201103111049.51916-1-98.arpi@gmail.com> <20201103113353.GC4077@smile.fi.intel.com> <20201103115223.GA268796@kroah.com> <20201103160728.GQ20201@alley> <57976ff4-7845-d721-ced1-1fe439000a9b@rasmusvillemoes.dk> <1b452380-53a5-f396-bf2f-97736db28afb@rasmusvillemoes.dk> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <1b452380-53a5-f396-bf2f-97736db28afb@rasmusvillemoes.dk> Cc: Arpitha Raghunandan <98.arpi@gmail.com>, alexandre.belloni@bootlin.com, Kees Cook , Petr Mladek , rdunlap@infradead.org, brendanhiggins@google.com, linux-kernel@vger.kernel.org, rostedt@goodmis.org, sergey.senozhatsky@gmail.com, linux-kselftest@vger.kernel.org, idryomov@gmail.com, Andy Shevchenko , linux-kernel-mentees@lists.linuxfoundation.org, kunit-dev@googlegroups.com Subject: Re: [Linux-kernel-mentees] [PATCH v3] lib: Convert test_printf.c to KUnit X-BeenThere: linux-kernel-mentees@lists.linuxfoundation.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: linux-kernel-mentees-bounces@lists.linuxfoundation.org Sender: "Linux-kernel-mentees" On Fri, Nov 06, 2020 at 11:31:43AM +0100, Rasmus Villemoes wrote: > On 06/11/2020 05.04, Arpitha Raghunandan wrote: > > > > The total number of "atoms" can be printed by maintaining a static variable > > total_count that can be incremented as is in the original test_printf test. > > But, the reporting of the random seed currently is done in kselftest and so > > will not show up with KUnit. I am not really sure which is better in this case. > > So my real questions are: Why do we have both kselftest and kunit? One is testing code within the kernel image testing it within kernelspace, and one is outside the kernel testing it from userspace. thanks, greg k-h _______________________________________________ Linux-kernel-mentees mailing list Linux-kernel-mentees@lists.linuxfoundation.org https://lists.linuxfoundation.org/mailman/listinfo/linux-kernel-mentees From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 62D61C55178 for ; Fri, 6 Nov 2020 10:41:18 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 0642B2087E for ; Fri, 6 Nov 2020 10:41:17 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1604659278; bh=FZPOUxbRLfnd+t8CdYEkeO2TCpAs4UT0oND2nvpDiDU=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=Z3Z1nV7AyIePpLo9HNwKPRTresVGQSJriOQGEDf2vExBv8iGfLoMS3s70j6L70eCJ YsVfoVAxzabVKr8ddddbZ0Zd6xn0ArgQG1Hst4Iz6tjwkm/O4xc5GqoXv01QACWL41 hpKZPTT27O4wlkuX0W79qvv1UsgRYrZju+ySMIAU= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726751AbgKFKlR (ORCPT ); Fri, 6 Nov 2020 05:41:17 -0500 Received: from mail.kernel.org ([198.145.29.99]:35022 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726201AbgKFKlR (ORCPT ); Fri, 6 Nov 2020 05:41:17 -0500 Received: from localhost (83-86-74-64.cable.dynamic.v4.ziggo.nl [83.86.74.64]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 41E4B20702; Fri, 6 Nov 2020 10:41:16 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1604659276; bh=FZPOUxbRLfnd+t8CdYEkeO2TCpAs4UT0oND2nvpDiDU=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=LIIV1fyeLOQP3xvdO35mmMUbH6AnHfV2gll+R4VQt/8JMCXFuKE+oywvx2kFEpXkE gK9egVH44hTJgnK8pv+jk9SQW8DrJnh4b5t3AxKaEMb6J0KStHwH9K2Rf+6O5saVIu OnhkH6hhV8fuxh0NK96fZtx0Y7QPMV5DCTmJm3Cs= Date: Fri, 6 Nov 2020 11:42:03 +0100 From: Greg KH To: Rasmus Villemoes Cc: Arpitha Raghunandan <98.arpi@gmail.com>, Petr Mladek , Andy Shevchenko , brendanhiggins@google.com, skhan@linuxfoundation.org, rostedt@goodmis.org, sergey.senozhatsky@gmail.com, alexandre.belloni@bootlin.com, rdunlap@infradead.org, idryomov@gmail.com, kunit-dev@googlegroups.com, linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org, linux-kernel-mentees@lists.linuxfoundation.org, Kees Cook Subject: Re: [PATCH v3] lib: Convert test_printf.c to KUnit Message-ID: <20201106104203.GC2784089@kroah.com> References: <20201103111049.51916-1-98.arpi@gmail.com> <20201103113353.GC4077@smile.fi.intel.com> <20201103115223.GA268796@kroah.com> <20201103160728.GQ20201@alley> <57976ff4-7845-d721-ced1-1fe439000a9b@rasmusvillemoes.dk> <1b452380-53a5-f396-bf2f-97736db28afb@rasmusvillemoes.dk> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1b452380-53a5-f396-bf2f-97736db28afb@rasmusvillemoes.dk> Precedence: bulk List-ID: X-Mailing-List: linux-kselftest@vger.kernel.org On Fri, Nov 06, 2020 at 11:31:43AM +0100, Rasmus Villemoes wrote: > On 06/11/2020 05.04, Arpitha Raghunandan wrote: > > > > The total number of "atoms" can be printed by maintaining a static variable > > total_count that can be incremented as is in the original test_printf test. > > But, the reporting of the random seed currently is done in kselftest and so > > will not show up with KUnit. I am not really sure which is better in this case. > > So my real questions are: Why do we have both kselftest and kunit? One is testing code within the kernel image testing it within kernelspace, and one is outside the kernel testing it from userspace. thanks, greg k-h