From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.8 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 46B9DC61DD8 for ; Fri, 6 Nov 2020 16:44:45 +0000 (UTC) Received: from mm01.cs.columbia.edu (mm01.cs.columbia.edu [128.59.11.253]) by mail.kernel.org (Postfix) with ESMTP id 964FF2222B for ; Fri, 6 Nov 2020 16:44:44 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="y0Knw6SX" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 964FF2222B Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=kvmarm-bounces@lists.cs.columbia.edu Received: from localhost (localhost [127.0.0.1]) by mm01.cs.columbia.edu (Postfix) with ESMTP id 1CB4F4B8B0; Fri, 6 Nov 2020 11:44:44 -0500 (EST) X-Virus-Scanned: at lists.cs.columbia.edu Authentication-Results: mm01.cs.columbia.edu (amavisd-new); dkim=softfail (fail, message has been altered) header.i=@kernel.org Received: from mm01.cs.columbia.edu ([127.0.0.1]) by localhost (mm01.cs.columbia.edu [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id Fai7zmtI+Hyg; Fri, 6 Nov 2020 11:44:43 -0500 (EST) Received: from mm01.cs.columbia.edu (localhost [127.0.0.1]) by mm01.cs.columbia.edu (Postfix) with ESMTP id 4FE744B8B6; Fri, 6 Nov 2020 11:44:42 -0500 (EST) Received: from localhost (localhost [127.0.0.1]) by mm01.cs.columbia.edu (Postfix) with ESMTP id C730C4B8A7 for ; Fri, 6 Nov 2020 11:44:40 -0500 (EST) X-Virus-Scanned: at lists.cs.columbia.edu Received: from mm01.cs.columbia.edu ([127.0.0.1]) by localhost (mm01.cs.columbia.edu [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id DvsEId+R4uWl for ; Fri, 6 Nov 2020 11:44:39 -0500 (EST) Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by mm01.cs.columbia.edu (Postfix) with ESMTPS id 811264B8A2 for ; Fri, 6 Nov 2020 11:44:39 -0500 (EST) Received: from disco-boy.misterjones.org (disco-boy.misterjones.org [51.254.78.96]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 8B5F9217A0; Fri, 6 Nov 2020 16:44:38 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1604681078; bh=t0K1Uzu+49PExG7zsJdALxOgNu8sv7rz5YDcQXoVCJY=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=y0Knw6SXwkuIvEg2uWUQ/PrrwXU0Cup7lBqjLmSlH3uf72/RKpQZ9dOI4ig17Uf4E NF9jRnOkkDZgCzsf1c4qRUJIXZQfhuFdoWmvBf85dshrgexy8qMYW6oFU70shSl1hx 13TGB/J7sIsA7MVpBxI3o7/48OIJ/3RYjg/9oYjs= Received: from 78.163-31-62.static.virginmediabusiness.co.uk ([62.31.163.78] helo=why.lan) by disco-boy.misterjones.org with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94) (envelope-from ) id 1kb4qq-008FYW-NV; Fri, 06 Nov 2020 16:44:36 +0000 From: Marc Zyngier To: Paolo Bonzini Subject: [PATCH 2/5] KVM: arm64: Don't hide ID registers from userspace Date: Fri, 6 Nov 2020 16:44:13 +0000 Message-Id: <20201106164416.326787-3-maz@kernel.org> X-Mailer: git-send-email 2.28.0 In-Reply-To: <20201106164416.326787-1-maz@kernel.org> References: <20201106164416.326787-1-maz@kernel.org> MIME-Version: 1.0 X-SA-Exim-Connect-IP: 62.31.163.78 X-SA-Exim-Rcpt-To: pbonzini@redhat.com, drjones@redhat.com, eric.auger@redhat.com, gshan@redhat.com, xu910121@sina.com, dave.martin@arm.com, james.morse@arm.com, julien.thierry.kdev@gmail.com, suzuki.poulose@arm.com, kvm@vger.kernel.org, kvmarm@lists.cs.columbia.edu, linux-arm-kernel@lists.infradead.org, stable@vger.kernel.org X-SA-Exim-Mail-From: maz@kernel.org X-SA-Exim-Scanned: No (on disco-boy.misterjones.org); SAEximRunCond expanded to false Cc: kvm@vger.kernel.org, stable@vger.kernel.org, kvmarm@lists.cs.columbia.edu, =?UTF-8?q?=E5=BC=A0=E4=B8=9C=E6=97=AD?= , linux-arm-kernel@lists.infradead.org, dave.martin@arm.com X-BeenThere: kvmarm@lists.cs.columbia.edu X-Mailman-Version: 2.1.14 Precedence: list List-Id: Where KVM/ARM decisions are made List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Errors-To: kvmarm-bounces@lists.cs.columbia.edu Sender: kvmarm-bounces@lists.cs.columbia.edu RnJvbTogQW5kcmV3IEpvbmVzIDxkcmpvbmVzQHJlZGhhdC5jb20+CgpJRCByZWdpc3RlcnMgYXJl IFJBWiB1bnRpbCB0aGV5J3ZlIGJlZW4gYWxsb2NhdGVkIGEgcHVycG9zZSwgYnV0CnRoYXQgZG9l c24ndCBtZWFuIHRoZXkgc2hvdWxkIGJlIHJlbW92ZWQgZnJvbSB0aGUgS1ZNX0dFVF9SRUdfTElT VApsaXN0LiBTbyBmYXIgd2Ugb25seSBoYXZlIG9uZSByZWdpc3RlciwgU1lTX0lEX0FBNjRaRlIw X0VMMSwgdGhhdAppcyBoaWRkZW4gZnJvbSB1c2Vyc3BhY2Ugd2hlbiBpdHMgZnVuY3Rpb24sIFNW RSwgaXMgbm90IHByZXNlbnQuCgpFeHBvc2UgU1lTX0lEX0FBNjRaRlIwX0VMMSB0byB1c2Vyc3Bh Y2UgYXMgUkFaIHdoZW4gU1ZFIGlzIG5vdAppbXBsZW1lbnRlZC4gUmVtb3ZpbmcgdGhlIHVzZXJz cGFjZSB2aXNpYmlsaXR5IGNoZWNrcyBpcyBlbm91Z2gKdG8gcmVleHBvc2UgaXQsIGFzIGl0IHdp bGwgYWxyZWFkeSByZXR1cm4gemVybyB0byB1c2Vyc3BhY2Ugd2hlbgpTVkUgaXMgbm90IHByZXNl bnQuIFRoZSByZWdpc3RlciBhbHJlYWR5IGJlaGF2ZXMgYXMgUkFaIGZvciB0aGUKZ3Vlc3Qgd2hl biBTVkUgaXMgbm90IHByZXNlbnQuCgpGaXhlczogNzM0MzM3NjJmY2FlICgiS1ZNOiBhcm02NC9z dmU6IFN5c3RlbSByZWdpc3RlciBjb250ZXh0IHN3aXRjaCBhbmQgYWNjZXNzIHN1cHBvcnQiKQpS ZXBvcnRlZC1ieTog5byg5Lic5petIDx4dTkxMDEyMUBzaW5hLmNvbT4KU2lnbmVkLW9mZi1ieTog QW5kcmV3IEpvbmVzIDxkcmpvbmVzQHJlZGhhdC5jb20+ClNpZ25lZC1vZmYtYnk6IE1hcmMgWnlu Z2llciA8bWF6QGtlcm5lbC5vcmc+CkNjOiBzdGFibGVAdmdlci5rZXJuZWwub3JnI3Y1LjIrCkxp bms6IGh0dHBzOi8vbG9yZS5rZXJuZWwub3JnL3IvMjAyMDExMDUwOTEwMjIuMTUzNzMtMi1kcmpv bmVzQHJlZGhhdC5jb20KLS0tCiBhcmNoL2FybTY0L2t2bS9zeXNfcmVncy5jIHwgMTggKy0tLS0t LS0tLS0tLS0tLS0tCiAxIGZpbGUgY2hhbmdlZCwgMSBpbnNlcnRpb24oKyksIDE3IGRlbGV0aW9u cygtKQoKZGlmZiAtLWdpdCBhL2FyY2gvYXJtNjQva3ZtL3N5c19yZWdzLmMgYi9hcmNoL2FybTY0 L2t2bS9zeXNfcmVncy5jCmluZGV4IDk4Mzk5NGYwMWE2My4uM2FmMzA2ZTZiOWNkIDEwMDY0NAot LS0gYS9hcmNoL2FybTY0L2t2bS9zeXNfcmVncy5jCisrKyBiL2FyY2gvYXJtNjQva3ZtL3N5c19y ZWdzLmMKQEAgLTExOTMsMTYgKzExOTMsNiBAQCBzdGF0aWMgdW5zaWduZWQgaW50IHN2ZV92aXNp YmlsaXR5KGNvbnN0IHN0cnVjdCBrdm1fdmNwdSAqdmNwdSwKIAlyZXR1cm4gUkVHX0hJRERFTl9V U0VSIHwgUkVHX0hJRERFTl9HVUVTVDsKIH0KIAotLyogVmlzaWJpbGl0eSBvdmVycmlkZXMgZm9y IFNWRS1zcGVjaWZpYyBJRCByZWdpc3RlcnMgKi8KLXN0YXRpYyB1bnNpZ25lZCBpbnQgc3ZlX2lk X3Zpc2liaWxpdHkoY29uc3Qgc3RydWN0IGt2bV92Y3B1ICp2Y3B1LAotCQkJCSAgICAgIGNvbnN0 IHN0cnVjdCBzeXNfcmVnX2Rlc2MgKnJkKQotewotCWlmICh2Y3B1X2hhc19zdmUodmNwdSkpCi0J CXJldHVybiAwOwotCi0JcmV0dXJuIFJFR19ISURERU5fVVNFUjsKLX0KLQogLyogR2VuZXJhdGUg dGhlIGVtdWxhdGVkIElEX0FBNjRaRlIwX0VMMSB2YWx1ZSBleHBvc2VkIHRvIHRoZSBndWVzdCAq Lwogc3RhdGljIHU2NCBndWVzdF9pZF9hYTY0emZyMF9lbDEoY29uc3Qgc3RydWN0IGt2bV92Y3B1 ICp2Y3B1KQogewpAQCAtMTIyOSw5ICsxMjE5LDYgQEAgc3RhdGljIGludCBnZXRfaWRfYWE2NHpm cjBfZWwxKHN0cnVjdCBrdm1fdmNwdSAqdmNwdSwKIHsKIAl1NjQgdmFsOwogCi0JaWYgKFdBUk5f T04oIXZjcHVfaGFzX3N2ZSh2Y3B1KSkpCi0JCXJldHVybiAtRU5PRU5UOwotCiAJdmFsID0gZ3Vl c3RfaWRfYWE2NHpmcjBfZWwxKHZjcHUpOwogCXJldHVybiByZWdfdG9fdXNlcih1YWRkciwgJnZh bCwgcmVnLT5pZCk7CiB9CkBAIC0xMjQ0LDkgKzEyMzEsNiBAQCBzdGF0aWMgaW50IHNldF9pZF9h YTY0emZyMF9lbDEoc3RydWN0IGt2bV92Y3B1ICp2Y3B1LAogCWludCBlcnI7CiAJdTY0IHZhbDsK IAotCWlmIChXQVJOX09OKCF2Y3B1X2hhc19zdmUodmNwdSkpKQotCQlyZXR1cm4gLUVOT0VOVDsK LQogCWVyciA9IHJlZ19mcm9tX3VzZXIoJnZhbCwgdWFkZHIsIGlkKTsKIAlpZiAoZXJyKQogCQly ZXR1cm4gZXJyOwpAQCAtMTUwOSw3ICsxNDkzLDcgQEAgc3RhdGljIGNvbnN0IHN0cnVjdCBzeXNf cmVnX2Rlc2Mgc3lzX3JlZ19kZXNjc1tdID0gewogCUlEX1NBTklUSVNFRChJRF9BQTY0UEZSMV9F TDEpLAogCUlEX1VOQUxMT0NBVEVEKDQsMiksCiAJSURfVU5BTExPQ0FURUQoNCwzKSwKLQl7IFNZ U19ERVNDKFNZU19JRF9BQTY0WkZSMF9FTDEpLCBhY2Nlc3NfaWRfYWE2NHpmcjBfZWwxLCAuZ2V0 X3VzZXIgPSBnZXRfaWRfYWE2NHpmcjBfZWwxLCAuc2V0X3VzZXIgPSBzZXRfaWRfYWE2NHpmcjBf ZWwxLCAudmlzaWJpbGl0eSA9IHN2ZV9pZF92aXNpYmlsaXR5IH0sCisJeyBTWVNfREVTQyhTWVNf SURfQUE2NFpGUjBfRUwxKSwgYWNjZXNzX2lkX2FhNjR6ZnIwX2VsMSwgLmdldF91c2VyID0gZ2V0 X2lkX2FhNjR6ZnIwX2VsMSwgLnNldF91c2VyID0gc2V0X2lkX2FhNjR6ZnIwX2VsMSwgfSwKIAlJ RF9VTkFMTE9DQVRFRCg0LDUpLAogCUlEX1VOQUxMT0NBVEVEKDQsNiksCiAJSURfVU5BTExPQ0FU RUQoNCw3KSwKLS0gCjIuMjguMAoKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX18Ka3ZtYXJtIG1haWxpbmcgbGlzdAprdm1hcm1AbGlzdHMuY3MuY29sdW1iaWEu ZWR1Cmh0dHBzOi8vbGlzdHMuY3MuY29sdW1iaWEuZWR1L21haWxtYW4vbGlzdGluZm8va3ZtYXJt Cg== From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 63B68C388F2 for ; Fri, 6 Nov 2020 16:45:19 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id E290A21556 for ; Fri, 6 Nov 2020 16:45:18 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="aq0Op5BO"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="y0Knw6SX" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org E290A21556 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To:Message-Id:Date: Subject:To:From:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=ImIbDCzZaFTxec1ftyh0rfzL+Wqr7gqwN7KS9vvXiw8=; b=aq0Op5BOBQVPUMDnsbBo/1fOV 0R1kNYbvsqVdZ+kCZ7ZhFHJ3mz0fI4rpKG+hAZeo+cL/SA70Qp7TCs+pUSnOJMKFKrJonPwLYon/A MVL1wFnICFLeLRRSxI1cSod21OV3B1gtG3bGvfUSJ2ck81gSz6aXHVBlyhbjTOuYAmaIrnnNL5gAJ cCaMg+/hvrqlI3N8+COVbVPJD4Q4oao0gx2Mr58MxvYC0kielAM7tmVhCmosFP7U2GlytUgrJc0Eu 2h+Q6nbyQfnTBngM7iAjqEGxAxsAeYzWrWZLjqWfQyZQQeEr2NJ7TuAdi/4mTBcUWp9ZuoJRKhz/Q wEe62E83Q==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kb4r0-00065w-7n; Fri, 06 Nov 2020 16:44:46 +0000 Received: from mail.kernel.org ([198.145.29.99]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kb4qt-00062x-BN for linux-arm-kernel@lists.infradead.org; Fri, 06 Nov 2020 16:44:40 +0000 Received: from disco-boy.misterjones.org (disco-boy.misterjones.org [51.254.78.96]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 8B5F9217A0; Fri, 6 Nov 2020 16:44:38 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1604681078; bh=t0K1Uzu+49PExG7zsJdALxOgNu8sv7rz5YDcQXoVCJY=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=y0Knw6SXwkuIvEg2uWUQ/PrrwXU0Cup7lBqjLmSlH3uf72/RKpQZ9dOI4ig17Uf4E NF9jRnOkkDZgCzsf1c4qRUJIXZQfhuFdoWmvBf85dshrgexy8qMYW6oFU70shSl1hx 13TGB/J7sIsA7MVpBxI3o7/48OIJ/3RYjg/9oYjs= Received: from 78.163-31-62.static.virginmediabusiness.co.uk ([62.31.163.78] helo=why.lan) by disco-boy.misterjones.org with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94) (envelope-from ) id 1kb4qq-008FYW-NV; Fri, 06 Nov 2020 16:44:36 +0000 From: Marc Zyngier To: Paolo Bonzini Subject: [PATCH 2/5] KVM: arm64: Don't hide ID registers from userspace Date: Fri, 6 Nov 2020 16:44:13 +0000 Message-Id: <20201106164416.326787-3-maz@kernel.org> X-Mailer: git-send-email 2.28.0 In-Reply-To: <20201106164416.326787-1-maz@kernel.org> References: <20201106164416.326787-1-maz@kernel.org> MIME-Version: 1.0 X-SA-Exim-Connect-IP: 62.31.163.78 X-SA-Exim-Rcpt-To: pbonzini@redhat.com, drjones@redhat.com, eric.auger@redhat.com, gshan@redhat.com, xu910121@sina.com, dave.martin@arm.com, james.morse@arm.com, julien.thierry.kdev@gmail.com, suzuki.poulose@arm.com, kvm@vger.kernel.org, kvmarm@lists.cs.columbia.edu, linux-arm-kernel@lists.infradead.org, stable@vger.kernel.org X-SA-Exim-Mail-From: maz@kernel.org X-SA-Exim-Scanned: No (on disco-boy.misterjones.org); SAEximRunCond expanded to false X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20201106_114439_548659_39022574 X-CRM114-Status: GOOD ( 18.29 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Andrew Jones , Gavin Shan , kvm@vger.kernel.org, Suzuki K Poulose , stable@vger.kernel.org, kvmarm@lists.cs.columbia.edu, Eric Auger , =?UTF-8?q?=E5=BC=A0=E4=B8=9C=E6=97=AD?= , linux-arm-kernel@lists.infradead.org, James Morse , dave.martin@arm.com, Julien Thierry Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org RnJvbTogQW5kcmV3IEpvbmVzIDxkcmpvbmVzQHJlZGhhdC5jb20+CgpJRCByZWdpc3RlcnMgYXJl IFJBWiB1bnRpbCB0aGV5J3ZlIGJlZW4gYWxsb2NhdGVkIGEgcHVycG9zZSwgYnV0CnRoYXQgZG9l c24ndCBtZWFuIHRoZXkgc2hvdWxkIGJlIHJlbW92ZWQgZnJvbSB0aGUgS1ZNX0dFVF9SRUdfTElT VApsaXN0LiBTbyBmYXIgd2Ugb25seSBoYXZlIG9uZSByZWdpc3RlciwgU1lTX0lEX0FBNjRaRlIw X0VMMSwgdGhhdAppcyBoaWRkZW4gZnJvbSB1c2Vyc3BhY2Ugd2hlbiBpdHMgZnVuY3Rpb24sIFNW RSwgaXMgbm90IHByZXNlbnQuCgpFeHBvc2UgU1lTX0lEX0FBNjRaRlIwX0VMMSB0byB1c2Vyc3Bh Y2UgYXMgUkFaIHdoZW4gU1ZFIGlzIG5vdAppbXBsZW1lbnRlZC4gUmVtb3ZpbmcgdGhlIHVzZXJz cGFjZSB2aXNpYmlsaXR5IGNoZWNrcyBpcyBlbm91Z2gKdG8gcmVleHBvc2UgaXQsIGFzIGl0IHdp bGwgYWxyZWFkeSByZXR1cm4gemVybyB0byB1c2Vyc3BhY2Ugd2hlbgpTVkUgaXMgbm90IHByZXNl bnQuIFRoZSByZWdpc3RlciBhbHJlYWR5IGJlaGF2ZXMgYXMgUkFaIGZvciB0aGUKZ3Vlc3Qgd2hl biBTVkUgaXMgbm90IHByZXNlbnQuCgpGaXhlczogNzM0MzM3NjJmY2FlICgiS1ZNOiBhcm02NC9z dmU6IFN5c3RlbSByZWdpc3RlciBjb250ZXh0IHN3aXRjaCBhbmQgYWNjZXNzIHN1cHBvcnQiKQpS ZXBvcnRlZC1ieTog5byg5Lic5petIDx4dTkxMDEyMUBzaW5hLmNvbT4KU2lnbmVkLW9mZi1ieTog QW5kcmV3IEpvbmVzIDxkcmpvbmVzQHJlZGhhdC5jb20+ClNpZ25lZC1vZmYtYnk6IE1hcmMgWnlu Z2llciA8bWF6QGtlcm5lbC5vcmc+CkNjOiBzdGFibGVAdmdlci5rZXJuZWwub3JnI3Y1LjIrCkxp bms6IGh0dHBzOi8vbG9yZS5rZXJuZWwub3JnL3IvMjAyMDExMDUwOTEwMjIuMTUzNzMtMi1kcmpv bmVzQHJlZGhhdC5jb20KLS0tCiBhcmNoL2FybTY0L2t2bS9zeXNfcmVncy5jIHwgMTggKy0tLS0t LS0tLS0tLS0tLS0tCiAxIGZpbGUgY2hhbmdlZCwgMSBpbnNlcnRpb24oKyksIDE3IGRlbGV0aW9u cygtKQoKZGlmZiAtLWdpdCBhL2FyY2gvYXJtNjQva3ZtL3N5c19yZWdzLmMgYi9hcmNoL2FybTY0 L2t2bS9zeXNfcmVncy5jCmluZGV4IDk4Mzk5NGYwMWE2My4uM2FmMzA2ZTZiOWNkIDEwMDY0NAot LS0gYS9hcmNoL2FybTY0L2t2bS9zeXNfcmVncy5jCisrKyBiL2FyY2gvYXJtNjQva3ZtL3N5c19y ZWdzLmMKQEAgLTExOTMsMTYgKzExOTMsNiBAQCBzdGF0aWMgdW5zaWduZWQgaW50IHN2ZV92aXNp YmlsaXR5KGNvbnN0IHN0cnVjdCBrdm1fdmNwdSAqdmNwdSwKIAlyZXR1cm4gUkVHX0hJRERFTl9V U0VSIHwgUkVHX0hJRERFTl9HVUVTVDsKIH0KIAotLyogVmlzaWJpbGl0eSBvdmVycmlkZXMgZm9y IFNWRS1zcGVjaWZpYyBJRCByZWdpc3RlcnMgKi8KLXN0YXRpYyB1bnNpZ25lZCBpbnQgc3ZlX2lk X3Zpc2liaWxpdHkoY29uc3Qgc3RydWN0IGt2bV92Y3B1ICp2Y3B1LAotCQkJCSAgICAgIGNvbnN0 IHN0cnVjdCBzeXNfcmVnX2Rlc2MgKnJkKQotewotCWlmICh2Y3B1X2hhc19zdmUodmNwdSkpCi0J CXJldHVybiAwOwotCi0JcmV0dXJuIFJFR19ISURERU5fVVNFUjsKLX0KLQogLyogR2VuZXJhdGUg dGhlIGVtdWxhdGVkIElEX0FBNjRaRlIwX0VMMSB2YWx1ZSBleHBvc2VkIHRvIHRoZSBndWVzdCAq Lwogc3RhdGljIHU2NCBndWVzdF9pZF9hYTY0emZyMF9lbDEoY29uc3Qgc3RydWN0IGt2bV92Y3B1 ICp2Y3B1KQogewpAQCAtMTIyOSw5ICsxMjE5LDYgQEAgc3RhdGljIGludCBnZXRfaWRfYWE2NHpm cjBfZWwxKHN0cnVjdCBrdm1fdmNwdSAqdmNwdSwKIHsKIAl1NjQgdmFsOwogCi0JaWYgKFdBUk5f T04oIXZjcHVfaGFzX3N2ZSh2Y3B1KSkpCi0JCXJldHVybiAtRU5PRU5UOwotCiAJdmFsID0gZ3Vl c3RfaWRfYWE2NHpmcjBfZWwxKHZjcHUpOwogCXJldHVybiByZWdfdG9fdXNlcih1YWRkciwgJnZh bCwgcmVnLT5pZCk7CiB9CkBAIC0xMjQ0LDkgKzEyMzEsNiBAQCBzdGF0aWMgaW50IHNldF9pZF9h YTY0emZyMF9lbDEoc3RydWN0IGt2bV92Y3B1ICp2Y3B1LAogCWludCBlcnI7CiAJdTY0IHZhbDsK IAotCWlmIChXQVJOX09OKCF2Y3B1X2hhc19zdmUodmNwdSkpKQotCQlyZXR1cm4gLUVOT0VOVDsK LQogCWVyciA9IHJlZ19mcm9tX3VzZXIoJnZhbCwgdWFkZHIsIGlkKTsKIAlpZiAoZXJyKQogCQly ZXR1cm4gZXJyOwpAQCAtMTUwOSw3ICsxNDkzLDcgQEAgc3RhdGljIGNvbnN0IHN0cnVjdCBzeXNf cmVnX2Rlc2Mgc3lzX3JlZ19kZXNjc1tdID0gewogCUlEX1NBTklUSVNFRChJRF9BQTY0UEZSMV9F TDEpLAogCUlEX1VOQUxMT0NBVEVEKDQsMiksCiAJSURfVU5BTExPQ0FURUQoNCwzKSwKLQl7IFNZ U19ERVNDKFNZU19JRF9BQTY0WkZSMF9FTDEpLCBhY2Nlc3NfaWRfYWE2NHpmcjBfZWwxLCAuZ2V0 X3VzZXIgPSBnZXRfaWRfYWE2NHpmcjBfZWwxLCAuc2V0X3VzZXIgPSBzZXRfaWRfYWE2NHpmcjBf ZWwxLCAudmlzaWJpbGl0eSA9IHN2ZV9pZF92aXNpYmlsaXR5IH0sCisJeyBTWVNfREVTQyhTWVNf SURfQUE2NFpGUjBfRUwxKSwgYWNjZXNzX2lkX2FhNjR6ZnIwX2VsMSwgLmdldF91c2VyID0gZ2V0 X2lkX2FhNjR6ZnIwX2VsMSwgLnNldF91c2VyID0gc2V0X2lkX2FhNjR6ZnIwX2VsMSwgfSwKIAlJ RF9VTkFMTE9DQVRFRCg0LDUpLAogCUlEX1VOQUxMT0NBVEVEKDQsNiksCiAJSURfVU5BTExPQ0FU RUQoNCw3KSwKLS0gCjIuMjguMAoKCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fCmxpbnV4LWFybS1rZXJuZWwgbWFpbGluZyBsaXN0CmxpbnV4LWFybS1rZXJu ZWxAbGlzdHMuaW5mcmFkZWFkLm9yZwpodHRwOi8vbGlzdHMuaW5mcmFkZWFkLm9yZy9tYWlsbWFu L2xpc3RpbmZvL2xpbnV4LWFybS1rZXJuZWwK From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.1 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A8EE8C5517A for ; Fri, 6 Nov 2020 16:44:41 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 55E632224A for ; Fri, 6 Nov 2020 16:44:41 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1604681081; bh=t0K1Uzu+49PExG7zsJdALxOgNu8sv7rz5YDcQXoVCJY=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=TCook22OOMnDiZdkd0P/yWvTsBQP2N7p8pg6vLG8ysSnh9BGzrlfnfaWcFRTzEIJM Hh7DwDjeHX5qRpyvXr/0mnJ2kYsGHB2cz33fVHWVCuCcLQUghPvLcE3BJl2hWZUCzW x8ey3lsglicfYVg5ZZH3eUuyba4AWPxDIpvTGADQ= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727270AbgKFQok (ORCPT ); Fri, 6 Nov 2020 11:44:40 -0500 Received: from mail.kernel.org ([198.145.29.99]:51592 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726415AbgKFQoj (ORCPT ); Fri, 6 Nov 2020 11:44:39 -0500 Received: from disco-boy.misterjones.org (disco-boy.misterjones.org [51.254.78.96]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 8B5F9217A0; Fri, 6 Nov 2020 16:44:38 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1604681078; bh=t0K1Uzu+49PExG7zsJdALxOgNu8sv7rz5YDcQXoVCJY=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=y0Knw6SXwkuIvEg2uWUQ/PrrwXU0Cup7lBqjLmSlH3uf72/RKpQZ9dOI4ig17Uf4E NF9jRnOkkDZgCzsf1c4qRUJIXZQfhuFdoWmvBf85dshrgexy8qMYW6oFU70shSl1hx 13TGB/J7sIsA7MVpBxI3o7/48OIJ/3RYjg/9oYjs= Received: from 78.163-31-62.static.virginmediabusiness.co.uk ([62.31.163.78] helo=why.lan) by disco-boy.misterjones.org with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94) (envelope-from ) id 1kb4qq-008FYW-NV; Fri, 06 Nov 2020 16:44:36 +0000 From: Marc Zyngier To: Paolo Bonzini Cc: Andrew Jones , Eric Auger , Gavin Shan , =?UTF-8?q?=E5=BC=A0=E4=B8=9C=E6=97=AD?= , dave.martin@arm.com, James Morse , Julien Thierry , Suzuki K Poulose , kvm@vger.kernel.org, kvmarm@lists.cs.columbia.edu, linux-arm-kernel@lists.infradead.org, stable@vger.kernel.org Subject: [PATCH 2/5] KVM: arm64: Don't hide ID registers from userspace Date: Fri, 6 Nov 2020 16:44:13 +0000 Message-Id: <20201106164416.326787-3-maz@kernel.org> X-Mailer: git-send-email 2.28.0 In-Reply-To: <20201106164416.326787-1-maz@kernel.org> References: <20201106164416.326787-1-maz@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-SA-Exim-Connect-IP: 62.31.163.78 X-SA-Exim-Rcpt-To: pbonzini@redhat.com, drjones@redhat.com, eric.auger@redhat.com, gshan@redhat.com, xu910121@sina.com, dave.martin@arm.com, james.morse@arm.com, julien.thierry.kdev@gmail.com, suzuki.poulose@arm.com, kvm@vger.kernel.org, kvmarm@lists.cs.columbia.edu, linux-arm-kernel@lists.infradead.org, stable@vger.kernel.org X-SA-Exim-Mail-From: maz@kernel.org X-SA-Exim-Scanned: No (on disco-boy.misterjones.org); SAEximRunCond expanded to false Precedence: bulk List-ID: X-Mailing-List: kvm@vger.kernel.org From: Andrew Jones ID registers are RAZ until they've been allocated a purpose, but that doesn't mean they should be removed from the KVM_GET_REG_LIST list. So far we only have one register, SYS_ID_AA64ZFR0_EL1, that is hidden from userspace when its function, SVE, is not present. Expose SYS_ID_AA64ZFR0_EL1 to userspace as RAZ when SVE is not implemented. Removing the userspace visibility checks is enough to reexpose it, as it will already return zero to userspace when SVE is not present. The register already behaves as RAZ for the guest when SVE is not present. Fixes: 73433762fcae ("KVM: arm64/sve: System register context switch and access support") Reported-by: 张东旭 Signed-off-by: Andrew Jones Signed-off-by: Marc Zyngier Cc: stable@vger.kernel.org#v5.2+ Link: https://lore.kernel.org/r/20201105091022.15373-2-drjones@redhat.com --- arch/arm64/kvm/sys_regs.c | 18 +----------------- 1 file changed, 1 insertion(+), 17 deletions(-) diff --git a/arch/arm64/kvm/sys_regs.c b/arch/arm64/kvm/sys_regs.c index 983994f01a63..3af306e6b9cd 100644 --- a/arch/arm64/kvm/sys_regs.c +++ b/arch/arm64/kvm/sys_regs.c @@ -1193,16 +1193,6 @@ static unsigned int sve_visibility(const struct kvm_vcpu *vcpu, return REG_HIDDEN_USER | REG_HIDDEN_GUEST; } -/* Visibility overrides for SVE-specific ID registers */ -static unsigned int sve_id_visibility(const struct kvm_vcpu *vcpu, - const struct sys_reg_desc *rd) -{ - if (vcpu_has_sve(vcpu)) - return 0; - - return REG_HIDDEN_USER; -} - /* Generate the emulated ID_AA64ZFR0_EL1 value exposed to the guest */ static u64 guest_id_aa64zfr0_el1(const struct kvm_vcpu *vcpu) { @@ -1229,9 +1219,6 @@ static int get_id_aa64zfr0_el1(struct kvm_vcpu *vcpu, { u64 val; - if (WARN_ON(!vcpu_has_sve(vcpu))) - return -ENOENT; - val = guest_id_aa64zfr0_el1(vcpu); return reg_to_user(uaddr, &val, reg->id); } @@ -1244,9 +1231,6 @@ static int set_id_aa64zfr0_el1(struct kvm_vcpu *vcpu, int err; u64 val; - if (WARN_ON(!vcpu_has_sve(vcpu))) - return -ENOENT; - err = reg_from_user(&val, uaddr, id); if (err) return err; @@ -1509,7 +1493,7 @@ static const struct sys_reg_desc sys_reg_descs[] = { ID_SANITISED(ID_AA64PFR1_EL1), ID_UNALLOCATED(4,2), ID_UNALLOCATED(4,3), - { SYS_DESC(SYS_ID_AA64ZFR0_EL1), access_id_aa64zfr0_el1, .get_user = get_id_aa64zfr0_el1, .set_user = set_id_aa64zfr0_el1, .visibility = sve_id_visibility }, + { SYS_DESC(SYS_ID_AA64ZFR0_EL1), access_id_aa64zfr0_el1, .get_user = get_id_aa64zfr0_el1, .set_user = set_id_aa64zfr0_el1, }, ID_UNALLOCATED(4,5), ID_UNALLOCATED(4,6), ID_UNALLOCATED(4,7), -- 2.28.0