From: Eric Biggers <ebiggers@kernel.org>
To: Greg KH <gregkh@linuxfoundation.org>
Cc: syzbot <syzbot+92340f7b2b4789907fdb@syzkaller.appspotmail.com>,
andreyknvl@google.com, linux-kernel@vger.kernel.org,
linux-usb@vger.kernel.org, rafael@kernel.org,
syzkaller-bugs@googlegroups.com
Subject: Re: WARNING in input_register_device
Date: Fri, 6 Nov 2020 09:03:14 -0800 [thread overview]
Message-ID: <20201106170314.GA845@sol.localdomain> (raw)
In-Reply-To: <20201106140336.GA3319902@kroah.com>
On Fri, Nov 06, 2020 at 03:03:36PM +0100, Greg KH wrote:
> On Fri, Nov 06, 2020 at 04:43:17AM -0800, syzbot wrote:
> > Hello,
> >
> > syzbot found the following issue on:
> >
> > HEAD commit: 9e39aef3 usb: misc: brcmstb-usb-pinmap: Make sync_all_pins..
> > git tree: https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/usb.git usb-testing
> > console output: https://syzkaller.appspot.com/x/log.txt?x=145ffa8a500000
> > kernel config: https://syzkaller.appspot.com/x/.config?x=a05f5efbb00b1465
> > dashboard link: https://syzkaller.appspot.com/bug?extid=92340f7b2b4789907fdb
> > compiler: gcc (GCC) 10.1.0-syz 20200507
> > syz repro: https://syzkaller.appspot.com/x/repro.syz?x=172ae7a8500000
> > C reproducer: https://syzkaller.appspot.com/x/repro.c?x=13b24746500000
> >
> > IMPORTANT: if you fix the issue, please add the following tag to the commit:
> > Reported-by: syzbot+92340f7b2b4789907fdb@syzkaller.appspotmail.com
> >
> > microsoft 0003:045E:07DA.0001: unknown main item tag 0x0
> > HID 045e:07da: Invalid code 65791 type 1
> > ------------[ cut here ]------------
> > init_uevent_argv: buffer size too small
> > WARNING: CPU: 0 PID: 5 at lib/kobject_uevent.c:259 init_uevent_argv lib/kobject_uevent.c:259 [inline]
> > WARNING: CPU: 0 PID: 5 at lib/kobject_uevent.c:259 kobject_uevent_env+0x1640/0x1680 lib/kobject_uevent.c:608
>
> You gave it a device with a buffer that was "too small", and it rejected
> it.
>
> Which, aside from the huge warning message, is to be expected, so I
> don't think this is really a bug here.
>
The purpose of WARN is for reporting recoverable kernel bugs. So a reachable
WARN is a bug. Either it is reporting one, or the bug is that the use of WARN
is wrong.
- Eric
next prev parent reply other threads:[~2020-11-06 17:03 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-06 12:43 WARNING in input_register_device syzbot
2020-11-06 14:03 ` Greg KH
2020-11-06 17:01 ` Alan Stern
2020-11-06 17:03 ` Eric Biggers [this message]
2020-11-07 8:22 ` Greg KH
2021-01-18 1:41 ` syzbot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201106170314.GA845@sol.localdomain \
--to=ebiggers@kernel.org \
--cc=andreyknvl@google.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=rafael@kernel.org \
--cc=syzbot+92340f7b2b4789907fdb@syzkaller.appspotmail.com \
--cc=syzkaller-bugs@googlegroups.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.