* [PATCH] ath11k: Remove unnecessary data sync to cpu on monitor buffer
@ 2020-10-15 6:47 ` Vasanthakumar Thiagarajan
0 siblings, 0 replies; 6+ messages in thread
From: Vasanthakumar Thiagarajan @ 2020-10-15 6:47 UTC (permalink / raw)
To: ath11k; +Cc: linux-wireless
Monitor ring Rx buffer is not really modified between dma map
and unmap. So remove the unnecssary data sync before dma unmap.
This does not fix any visible issue, found in code review.
Compile tested only.
Signed-off-by: Vasanthakumar Thiagarajan <vthiagar@codeaurora.org>
---
drivers/net/wireless/ath/ath11k/dp_rx.c | 4 ----
1 file changed, 4 deletions(-)
diff --git a/drivers/net/wireless/ath/ath11k/dp_rx.c b/drivers/net/wireless/ath/ath11k/dp_rx.c
index 0162532..4455e5af 100644
--- a/drivers/net/wireless/ath/ath11k/dp_rx.c
+++ b/drivers/net/wireless/ath/ath11k/dp_rx.c
@@ -2856,10 +2856,6 @@ static int ath11k_dp_rx_reap_mon_status_ring(struct ath11k_base *ab, int mac_id,
rxcb = ATH11K_SKB_RXCB(skb);
- dma_sync_single_for_cpu(ab->dev, rxcb->paddr,
- skb->len + skb_tailroom(skb),
- DMA_FROM_DEVICE);
-
dma_unmap_single(ab->dev, rxcb->paddr,
skb->len + skb_tailroom(skb),
DMA_BIDIRECTIONAL);
--
2.7.4
--
ath11k mailing list
ath11k@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/ath11k
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [PATCH] ath11k: Remove unnecessary data sync to cpu on monitor buffer
@ 2020-10-15 6:47 ` Vasanthakumar Thiagarajan
0 siblings, 0 replies; 6+ messages in thread
From: Vasanthakumar Thiagarajan @ 2020-10-15 6:47 UTC (permalink / raw)
To: ath11k; +Cc: linux-wireless
Monitor ring Rx buffer is not really modified between dma map
and unmap. So remove the unnecssary data sync before dma unmap.
This does not fix any visible issue, found in code review.
Compile tested only.
Signed-off-by: Vasanthakumar Thiagarajan <vthiagar@codeaurora.org>
---
drivers/net/wireless/ath/ath11k/dp_rx.c | 4 ----
1 file changed, 4 deletions(-)
diff --git a/drivers/net/wireless/ath/ath11k/dp_rx.c b/drivers/net/wireless/ath/ath11k/dp_rx.c
index 0162532..4455e5af 100644
--- a/drivers/net/wireless/ath/ath11k/dp_rx.c
+++ b/drivers/net/wireless/ath/ath11k/dp_rx.c
@@ -2856,10 +2856,6 @@ static int ath11k_dp_rx_reap_mon_status_ring(struct ath11k_base *ab, int mac_id,
rxcb = ATH11K_SKB_RXCB(skb);
- dma_sync_single_for_cpu(ab->dev, rxcb->paddr,
- skb->len + skb_tailroom(skb),
- DMA_FROM_DEVICE);
-
dma_unmap_single(ab->dev, rxcb->paddr,
skb->len + skb_tailroom(skb),
DMA_BIDIRECTIONAL);
--
2.7.4
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH] ath11k: Remove unnecessary data sync to cpu on monitor buffer
2020-10-15 6:47 ` Vasanthakumar Thiagarajan
(?)
@ 2020-11-07 7:59 ` Kalle Valo
-1 siblings, 0 replies; 6+ messages in thread
From: Kalle Valo @ 2020-11-07 7:59 UTC (permalink / raw)
To: Vasanthakumar Thiagarajan; +Cc: linux-wireless, ath11k
Vasanthakumar Thiagarajan <vthiagar@codeaurora.org> wrote:
> Monitor ring Rx buffer is not really modified between dma map
> and unmap. So remove the unnecssary data sync before dma unmap.
> This does not fix any visible issue, found in code review.
>
> Compile tested only.
>
> Signed-off-by: Vasanthakumar Thiagarajan <vthiagar@codeaurora.org>
> Signed-off-by: Kalle Valo <kvalo@codeaurora.org>
Patch applied to ath-next branch of ath.git, thanks.
bafdbd79aae4 ath11k: Remove unnecessary data sync to cpu on monitor buffer
--
https://patchwork.kernel.org/project/linux-wireless/patch/1602744454-22969-1-git-send-email-vthiagar@codeaurora.org/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
--
ath11k mailing list
ath11k@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/ath11k
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] ath11k: Remove unnecessary data sync to cpu on monitor buffer
2020-10-15 6:47 ` Vasanthakumar Thiagarajan
(?)
(?)
@ 2020-11-07 7:59 ` Kalle Valo
-1 siblings, 0 replies; 6+ messages in thread
From: Kalle Valo @ 2020-11-07 7:59 UTC (permalink / raw)
To: Vasanthakumar Thiagarajan; +Cc: ath11k, linux-wireless
Vasanthakumar Thiagarajan <vthiagar@codeaurora.org> wrote:
> Monitor ring Rx buffer is not really modified between dma map
> and unmap. So remove the unnecssary data sync before dma unmap.
> This does not fix any visible issue, found in code review.
>
> Compile tested only.
>
> Signed-off-by: Vasanthakumar Thiagarajan <vthiagar@codeaurora.org>
> Signed-off-by: Kalle Valo <kvalo@codeaurora.org>
Patch applied to ath-next branch of ath.git, thanks.
bafdbd79aae4 ath11k: Remove unnecessary data sync to cpu on monitor buffer
--
https://patchwork.kernel.org/project/linux-wireless/patch/1602744454-22969-1-git-send-email-vthiagar@codeaurora.org/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH] ath11k: Remove unnecessary data sync to cpu on monitor buffer
@ 2020-10-15 6:16 Vasanthakumar Thiagarajan
0 siblings, 0 replies; 6+ messages in thread
From: Vasanthakumar Thiagarajan @ 2020-10-15 6:16 UTC (permalink / raw)
To: ath11k
Monitor ring Rx buffer is not really modified between dma map
and unmap. So remove the unnecssary data sync before dma unmap.
This does not fix any visible issue, found in code review.
Compile tested only.
Signed-off-by: Vasanthakumar Thiagarajan <vthiagar@codeaurora.org>
---
drivers/net/wireless/ath/ath11k/dp_rx.c | 4 ----
1 file changed, 4 deletions(-)
diff --git a/drivers/net/wireless/ath/ath11k/dp_rx.c b/drivers/net/wireless/ath/ath11k/dp_rx.c
index 0162532..4455e5af 100644
--- a/drivers/net/wireless/ath/ath11k/dp_rx.c
+++ b/drivers/net/wireless/ath/ath11k/dp_rx.c
@@ -2856,10 +2856,6 @@ static int ath11k_dp_rx_reap_mon_status_ring(struct ath11k_base *ab, int mac_id,
rxcb = ATH11K_SKB_RXCB(skb);
- dma_sync_single_for_cpu(ab->dev, rxcb->paddr,
- skb->len + skb_tailroom(skb),
- DMA_FROM_DEVICE);
-
dma_unmap_single(ab->dev, rxcb->paddr,
skb->len + skb_tailroom(skb),
DMA_BIDIRECTIONAL);
--
2.7.4
--
ath11k mailing list
ath11k@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/ath11k
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [PATCH] ath11k: Remove unnecessary data sync to cpu on monitor buffer
@ 2020-10-08 11:10 Vasanthakumar Thiagarajan
0 siblings, 0 replies; 6+ messages in thread
From: Vasanthakumar Thiagarajan @ 2020-10-08 11:10 UTC (permalink / raw)
To: ath11k
Monitor ring Rx buffer is not really modified between dma map
and unmap. So remove the unnecssary data sync before dma unmap.
This does not fix any visible issue, found in code review.
Compile tested only.
Signed-off-by: Vasanthakumar Thiagarajan <vthiagar@codeaurora.org>
---
drivers/net/wireless/ath/ath11k/dp_rx.c | 4 ----
1 file changed, 4 deletions(-)
diff --git a/drivers/net/wireless/ath/ath11k/dp_rx.c b/drivers/net/wireless/ath/ath11k/dp_rx.c
index 0162532..4455e5af 100644
--- a/drivers/net/wireless/ath/ath11k/dp_rx.c
+++ b/drivers/net/wireless/ath/ath11k/dp_rx.c
@@ -2856,10 +2856,6 @@ static int ath11k_dp_rx_reap_mon_status_ring(struct ath11k_base *ab, int mac_id,
rxcb = ATH11K_SKB_RXCB(skb);
- dma_sync_single_for_cpu(ab->dev, rxcb->paddr,
- skb->len + skb_tailroom(skb),
- DMA_FROM_DEVICE);
-
dma_unmap_single(ab->dev, rxcb->paddr,
skb->len + skb_tailroom(skb),
DMA_BIDIRECTIONAL);
--
2.7.4
--
ath11k mailing list
ath11k@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/ath11k
^ permalink raw reply related [flat|nested] 6+ messages in thread
end of thread, other threads:[~2020-11-07 7:59 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2020-10-15 6:47 [PATCH] ath11k: Remove unnecessary data sync to cpu on monitor buffer Vasanthakumar Thiagarajan
2020-10-15 6:47 ` Vasanthakumar Thiagarajan
2020-11-07 7:59 ` Kalle Valo
2020-11-07 7:59 ` Kalle Valo
-- strict thread matches above, loose matches on Subject: below --
2020-10-15 6:16 Vasanthakumar Thiagarajan
2020-10-08 11:10 Vasanthakumar Thiagarajan
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.