From: Kalle Valo <kvalo@codeaurora.org>
To: WeitaoWangoc <WeitaoWang-oc@zhaoxin.com>
Cc: <pkshih@realtek.com>, <davem@davemloft.net>, <kuba@kernel.org>,
<linux-wireless@vger.kernel.org>, <netdev@vger.kernel.org>,
<linux-kernel@vger.kernel.org>, <tonywwang@zhaoxin.com>,
<weitaowang@zhaoxin.com>, <CobeChen@zhaoxin.com>,
<TimGuo@zhaoxin.com>, <wwt8723@163.com>
Subject: Re: [PATCH] rtlwifi: Fix non-canonical address access issues
Date: Sat, 7 Nov 2020 15:50:15 +0000 (UTC) [thread overview]
Message-ID: <20201107155015.27800C433C9@smtp.codeaurora.org> (raw)
In-Reply-To: <1603768580-2798-1-git-send-email-WeitaoWang-oc@zhaoxin.com>
WeitaoWangoc <WeitaoWang-oc@zhaoxin.com> wrote:
> During realtek USB wireless NIC initialization, it's unexpected
> disconnection will cause urb sumbmit fail. On the one hand,
> _rtl_usb_cleanup_rx will be called to clean up rx stuff, especially for
> rtl_wq. On the other hand, disconnection will cause rtl_usb_disconnect
> and _rtl_usb_cleanup_rx to be called. So, rtl_wq will be flush/destroy
> twice, which will cause non-canonical address 0xdead000000000122 access
> and general protection fault.
>
> Fixed this issue by remove _rtl_usb_cleanup_rx when urb sumbmit fail.
>
> Signed-off-by: WeitaoWangoc <WeitaoWang-oc@zhaoxin.com>
> Acked-by: Ping-Ke Shih <pkshih@realtek.com>
Patch applied to wireless-drivers-next.git, thanks.
c521d7e0ff05 rtlwifi: Fix non-canonical address access issues
--
https://patchwork.kernel.org/project/linux-wireless/patch/1603768580-2798-1-git-send-email-WeitaoWang-oc@zhaoxin.com/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
prev parent reply other threads:[~2020-11-07 15:50 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-27 3:16 [PATCH] rtlwifi: Fix non-canonical address access issues WeitaoWangoc
2020-10-27 3:28 ` Pkshih
2020-11-07 15:50 ` Kalle Valo [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201107155015.27800C433C9@smtp.codeaurora.org \
--to=kvalo@codeaurora.org \
--cc=CobeChen@zhaoxin.com \
--cc=TimGuo@zhaoxin.com \
--cc=WeitaoWang-oc@zhaoxin.com \
--cc=davem@davemloft.net \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pkshih@realtek.com \
--cc=tonywwang@zhaoxin.com \
--cc=weitaowang@zhaoxin.com \
--cc=wwt8723@163.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.