From: Kalle Valo <kvalo@codeaurora.org>
To: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
Cc: linux-wireless@vger.kernel.org, Jouni Malinen <j@w1.fi>,
Ping-Ke Shih <pkshih@realtek.com>,
Ulrich Kunitz <kune@deine-taler.de>,
Thomas Gleixner <tglx@linutronix.de>,
Sebastian Andrzej Siewior <bigeasy@linutronix.de>
Subject: Re: [PATCH 1/8] orinoco: Remove BUG_ON(in_interrupt/irq())
Date: Sat, 7 Nov 2020 15:52:58 +0000 (UTC) [thread overview]
Message-ID: <20201107155258.DA5B2C433CB@smtp.codeaurora.org> (raw)
In-Reply-To: <20201101211536.2966644-2-bigeasy@linutronix.de>
Sebastian Andrzej Siewior <bigeasy@linutronix.de> wrote:
> The usage of in_irq()/in_interrupt() in drivers is phased out and the
> BUG_ON()'s based on those are not covering all contexts in which these
> functions cannot be called.
>
> Aside of that BUG_ON() should only be used as last resort, which is clearly
> not the case here.
>
> A broad variety of checks in the invoked functions (always enabled or debug
> option dependent) cover these conditions already, so the BUG_ON()'s do not
> really provide additional value.
>
> Just remove them.
>
> Signed-off-by: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
> Cc: Kalle Valo <kvalo@codeaurora.org>
> Cc: linux-wireless@vger.kernel.org
8 patches applied to wireless-drivers-next.git, thanks.
ce4dd05cbba6 orinoco: Remove BUG_ON(in_interrupt/irq())
24bf941f2c96 airo: Invoke airo_read_wireless_stats() directly
49eb01995285 airo: Always use JOB_STATS and JOB_EVENT
494e46d08d35 airo: Replace in_atomic() usage.
7534fd5e5834 hostap: Remove in_atomic() check.
abcda807d868 zd1211rw: Remove in_atomic() usage.
317f688b0a54 rtlwifi: Remove in_interrupt() usage in is_any_client_connect_to_ap().
50c61ae15865 rtlwifi: Remove in_interrupt() usage in halbtc_send_bt_mp_operation()
--
https://patchwork.kernel.org/project/linux-wireless/patch/20201101211536.2966644-2-bigeasy@linutronix.de/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
next prev parent reply other threads:[~2020-11-07 15:53 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-01 21:15 [PATCH] in_interrupt() cleanup, part 2 (wireless) Sebastian Andrzej Siewior
2020-11-01 21:15 ` [PATCH 1/8] orinoco: Remove BUG_ON(in_interrupt/irq()) Sebastian Andrzej Siewior
2020-11-07 15:52 ` Kalle Valo [this message]
2020-11-01 21:15 ` [PATCH 2/8] airo: Invoke airo_read_wireless_stats() directly Sebastian Andrzej Siewior
2020-11-01 21:15 ` [PATCH 3/8] airo: Always use JOB_STATS and JOB_EVENT Sebastian Andrzej Siewior
2020-11-01 21:15 ` [PATCH 4/8] airo: Replace in_atomic() usage Sebastian Andrzej Siewior
2020-11-01 21:15 ` [PATCH 5/8] hostap: Remove in_atomic() check Sebastian Andrzej Siewior
2020-11-01 21:15 ` [PATCH 6/8] zd1211rw: Remove in_atomic() usage Sebastian Andrzej Siewior
2020-11-01 21:15 ` [PATCH 7/8] rtlwifi: Remove in_interrupt() usage in is_any_client_connect_to_ap() Sebastian Andrzej Siewior
2020-11-01 21:15 ` [PATCH 8/8] rtlwifi: Remove in_interrupt() usage in halbtc_send_bt_mp_operation() Sebastian Andrzej Siewior
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201107155258.DA5B2C433CB@smtp.codeaurora.org \
--to=kvalo@codeaurora.org \
--cc=bigeasy@linutronix.de \
--cc=j@w1.fi \
--cc=kune@deine-taler.de \
--cc=linux-wireless@vger.kernel.org \
--cc=pkshih@realtek.com \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.