From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.7 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 834D8C388F9 for ; Sat, 7 Nov 2020 19:33:18 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 30F5B20723 for ; Sat, 7 Nov 2020 19:33:18 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 30F5B20723 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=ravnborg.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 1D8BB6E117; Sat, 7 Nov 2020 19:33:17 +0000 (UTC) Received: from asavdk4.altibox.net (asavdk4.altibox.net [109.247.116.15]) by gabe.freedesktop.org (Postfix) with ESMTPS id 44DB86E117 for ; Sat, 7 Nov 2020 19:33:15 +0000 (UTC) Received: from ravnborg.org (unknown [188.228.123.71]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by asavdk4.altibox.net (Postfix) with ESMTPS id 846088052E; Sat, 7 Nov 2020 20:33:12 +0100 (CET) Date: Sat, 7 Nov 2020 20:33:11 +0100 From: Sam Ravnborg To: Paul Cercueil Subject: Re: [PATCH] drm/ingenic: ipu: Search for scaling coefs up to 102% of the screen Message-ID: <20201107193311.GB1039949@ravnborg.org> References: <20201105083905.8780-1-paul@crapouillou.net> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20201105083905.8780-1-paul@crapouillou.net> X-CMAE-Score: 0 X-CMAE-Analysis: v=2.3 cv=VafZwmh9 c=1 sm=1 tr=0 a=S6zTFyMACwkrwXSdXUNehg==:117 a=S6zTFyMACwkrwXSdXUNehg==:17 a=kj9zAlcOel0A:10 a=ER_8r6IbAAAA:8 a=7gkXJVJtAAAA:8 a=XnjrpGiWGA5PLGppdLwA:9 a=CjuIK1q_8ugA:10 a=9LHmKk7ezEChjTCyhBa9:22 a=E9Po1WZjFZOl8hwRPBS3:22 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: David Airlie , dri-devel@lists.freedesktop.org, od@zcrc.me, linux-kernel@vger.kernel.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" Hi Paul. On Thu, Nov 05, 2020 at 08:39:05AM +0000, Paul Cercueil wrote: > Increase the scaled image's theorical width/height until we find a > configuration that has valid scaling coefficients, up to 102% of the > screen's resolution. This makes sure that we can scale from almost > every resolution possible at the cost of a very small distorsion. > The CRTC_W / CRTC_H are not modified. > > This algorithm was already in place but would not try to go above the > screen's resolution, and as a result would only work if the CRTC_W / > CRTC_H were smaller than the screen resolution. It will now try until it > reaches 102% of the screen's resolution. > > Signed-off-by: Paul Cercueil Looks like the patch does what the descriptions says. So in other words - look OK to me. I am not confident enogh for a r-b but my code reading is enough to warrant an a-b: Acked-by: Sam Ravnborg _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.7 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2ACEFC388F7 for ; Sat, 7 Nov 2020 19:33:17 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id D9C6A20723 for ; Sat, 7 Nov 2020 19:33:16 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728620AbgKGTdQ (ORCPT ); Sat, 7 Nov 2020 14:33:16 -0500 Received: from asavdk4.altibox.net ([109.247.116.15]:35724 "EHLO asavdk4.altibox.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725836AbgKGTdP (ORCPT ); Sat, 7 Nov 2020 14:33:15 -0500 Received: from ravnborg.org (unknown [188.228.123.71]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by asavdk4.altibox.net (Postfix) with ESMTPS id 846088052E; Sat, 7 Nov 2020 20:33:12 +0100 (CET) Date: Sat, 7 Nov 2020 20:33:11 +0100 From: Sam Ravnborg To: Paul Cercueil Cc: David Airlie , Daniel Vetter , od@zcrc.me, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org Subject: Re: [PATCH] drm/ingenic: ipu: Search for scaling coefs up to 102% of the screen Message-ID: <20201107193311.GB1039949@ravnborg.org> References: <20201105083905.8780-1-paul@crapouillou.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20201105083905.8780-1-paul@crapouillou.net> X-CMAE-Score: 0 X-CMAE-Analysis: v=2.3 cv=VafZwmh9 c=1 sm=1 tr=0 a=S6zTFyMACwkrwXSdXUNehg==:117 a=S6zTFyMACwkrwXSdXUNehg==:17 a=kj9zAlcOel0A:10 a=ER_8r6IbAAAA:8 a=7gkXJVJtAAAA:8 a=XnjrpGiWGA5PLGppdLwA:9 a=CjuIK1q_8ugA:10 a=9LHmKk7ezEChjTCyhBa9:22 a=E9Po1WZjFZOl8hwRPBS3:22 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Paul. On Thu, Nov 05, 2020 at 08:39:05AM +0000, Paul Cercueil wrote: > Increase the scaled image's theorical width/height until we find a > configuration that has valid scaling coefficients, up to 102% of the > screen's resolution. This makes sure that we can scale from almost > every resolution possible at the cost of a very small distorsion. > The CRTC_W / CRTC_H are not modified. > > This algorithm was already in place but would not try to go above the > screen's resolution, and as a result would only work if the CRTC_W / > CRTC_H were smaller than the screen resolution. It will now try until it > reaches 102% of the screen's resolution. > > Signed-off-by: Paul Cercueil Looks like the patch does what the descriptions says. So in other words - look OK to me. I am not confident enogh for a r-b but my code reading is enough to warrant an a-b: Acked-by: Sam Ravnborg