From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.3 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 55D2DC55178 for ; Sun, 8 Nov 2020 09:57:43 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id CC93E206ED for ; Sun, 8 Nov 2020 09:57:42 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="Db4wTPQz"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=armlinux.org.uk header.i=@armlinux.org.uk header.b="CV5/QWIS" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org CC93E206ED Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=armlinux.org.uk Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-rockchip-bounces+linux-rockchip=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=AdHSaHcuAiHONjgPbMSPj2InbiDjNmuoIjduIrVMAX8=; b=Db4wTPQzdI87CGybiaLhuX84V USqqFLQGkC6/ROLFBfixdIJk5drARyQ1NDWf51Uclj9U1XU+aixTISaaRUlaGVe+lhkNOk+afNjH8 V5VQqDS38I8LkJIh1ItWL4lmoLkc6sZmFgNlp6vE8+oXvOl52hNZUxiGP5bFQKTj+FDlyct/4p47Q l+oSSgb1jwNTFdUCRmjkDs9+LARBGw5Q0WN/6tur3PVppADtqtEXtOya5PRdeb1CVSJziv/LENTgK Fb5p+83Fe2+nemrHnET7jOdiSCYzzmLuG5q5vg7fSC2McpL2R+L5pFBvbb8jZauuBrtj41usczV9v X8Bh0LZJQ==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kbhS6-0004wA-M2; Sun, 08 Nov 2020 09:57:38 +0000 Received: from pandora.armlinux.org.uk ([2001:4d48:ad52:32c8:5054:ff:fe00:142]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kbhS4-0004vd-7s; Sun, 08 Nov 2020 09:57:37 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=armlinux.org.uk; s=pandora-2019; h=Sender:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=Gu6W+SYNYwujRSnH/S/cqUbxFQBEVozmfEiGAZYOXTA=; b=CV5/QWIS9Q6yhKqIURS3jOiQr sTYBSt7zBvclZtLq9/AyhSNGwBonxuH2r2ePFH8J+7Xx5jqnPUmzQc4SH/mmz0W7mNqzbECRh+Zii anGEnoxZi3Oiac1yj2hm/+SGR5mYROn55SFyDixBQAdjv2wCxdzFKJjTsbl7mPPZUXH4zAEtjfMVd KC8+q9qJ3pWisOnBEhcJ1apqGtoHIB8xS3EWeuctgpJke1jD+8sDCvhuUBj0ZIdQf0WG+Y0jes3Wc y1021x5lFU0en/hGGD/wuAW5+FVgp9yVfPrj2X/thGkAUnVtGuzijUVgGjrdIs81zgdp0RHPdF2F6 VJg9lE4Hg==; Received: from shell.armlinux.org.uk ([fd8f:7570:feb6:1:5054:ff:fe00:4ec]:56562) by pandora.armlinux.org.uk with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kbhRy-0007Ez-TU; Sun, 08 Nov 2020 09:57:30 +0000 Received: from linux by shell.armlinux.org.uk with local (Exim 4.92) (envelope-from ) id 1kbhRt-0007jT-4M; Sun, 08 Nov 2020 09:57:25 +0000 Date: Sun, 8 Nov 2020 09:57:25 +0000 From: Russell King - ARM Linux admin To: Sam Ravnborg Subject: Re: [PATCH] drm: bridge: dw-hdmi: Avoid resetting force in the detect function Message-ID: <20201108095724.GW1551@shell.armlinux.org.uk> References: <20201031081747.372599-1-net147@gmail.com> <20201108095322.GA1129714@ravnborg.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20201108095322.GA1129714@ravnborg.org> User-Agent: Mutt/1.10.1 (2018-07-13) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20201108_045736_315600_ADCC1FF4 X-CRM114-Status: GOOD ( 17.27 ) X-BeenThere: linux-rockchip@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Upstream kernel work for Rockchip platforms List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Fabio Estevam , Jernej Skrabec , Jonathan Liu , Jonas Karlman , David Airlie , Neil Armstrong , linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, Andrzej Hajda , linux-rockchip@lists.infradead.org, Boris Brezillon , Laurent Pinchart , Liu Ying , linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "Linux-rockchip" Errors-To: linux-rockchip-bounces+linux-rockchip=archiver.kernel.org@lists.infradead.org On Sun, Nov 08, 2020 at 10:53:22AM +0100, Sam Ravnborg wrote: > Russell, > > On Sat, Oct 31, 2020 at 07:17:47PM +1100, Jonathan Liu wrote: > > It has been observed that resetting force in the detect function can > > result in the PHY being powered down in response to hot-plug detect > > being asserted, even when the HDMI connector is forced on. > > > > Enabling debug messages and adding a call to dump_stack() in > > dw_hdmi_phy_power_off() shows the following in dmesg: > > [ 160.637413] dwhdmi-rockchip ff940000.hdmi: EVENT=plugin > > [ 160.637433] dwhdmi-rockchip ff940000.hdmi: PHY powered down in 0 iterations > > > > Call trace: > > dw_hdmi_phy_power_off > > dw_hdmi_phy_disable > > dw_hdmi_update_power > > dw_hdmi_detect > > dw_hdmi_connector_detect > > drm_helper_probe_detect_ctx > > drm_helper_hpd_irq_event > > dw_hdmi_irq > > irq_thread_fn > > irq_thread > > kthread > > ret_from_fork > > > > Fixes: 381f05a7a842 ("drm: bridge/dw_hdmi: add connector mode forcing") > > Signed-off-by: Jonathan Liu > > you are the original author of this code - any comments on this patch? No further comments beyond what has already been discussed, and the long and short of it is it's been so long that I don't remember why that code was there. Given that, I'm not even in a position to ack the change. Sorry. -- RMK's Patch system: https://www.armlinux.org.uk/developer/patches/ FTTP is here! 40Mbps down 10Mbps up. Decent connectivity at last! _______________________________________________ Linux-rockchip mailing list Linux-rockchip@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-rockchip From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.3 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A4CF5C388F9 for ; Sun, 8 Nov 2020 09:58:47 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 32AE3206ED for ; Sun, 8 Nov 2020 09:58:47 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="FyZKfV6x"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=armlinux.org.uk header.i=@armlinux.org.uk header.b="CV5/QWIS" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 32AE3206ED Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=armlinux.org.uk Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=ujSev8UZaupPPJ0T3nw5lBmmwCI9d9CAq1mvP+APmWc=; b=FyZKfV6x7y1r4x6A/6krzXph8 n6JO/HHcrFXiRaPvm9j0F1lHUZxP5yi9/UDbhKQWWpxqmAlJ0bzEVJQtG6EuvNlm9Ho8a8LeVI8as HqamBBeKSXPcKxi02zrj/eR7gu7xtjQ9BS8gLMsYkQATIzztQhbmTIKNXUp04+H5LpM2QRPSsZgYY 35awmYXqp3A8aPpQgrajLppXFLdZqV1hBTMgbZhkUS1/qeVpt1l8oqlLdbDRdVxAurqGzLc004Ybj 3q8+abSx9gyzE+GQzNpRG8peUsixZdQRMieJnEWKWJ1l0ntRDelx6gWUa9KtP8x4SuR081iTCzicJ +k4qsWSGQ==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kbhS7-0004wW-FD; Sun, 08 Nov 2020 09:57:39 +0000 Received: from pandora.armlinux.org.uk ([2001:4d48:ad52:32c8:5054:ff:fe00:142]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kbhS4-0004vd-7s; Sun, 08 Nov 2020 09:57:37 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=armlinux.org.uk; s=pandora-2019; h=Sender:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=Gu6W+SYNYwujRSnH/S/cqUbxFQBEVozmfEiGAZYOXTA=; b=CV5/QWIS9Q6yhKqIURS3jOiQr sTYBSt7zBvclZtLq9/AyhSNGwBonxuH2r2ePFH8J+7Xx5jqnPUmzQc4SH/mmz0W7mNqzbECRh+Zii anGEnoxZi3Oiac1yj2hm/+SGR5mYROn55SFyDixBQAdjv2wCxdzFKJjTsbl7mPPZUXH4zAEtjfMVd KC8+q9qJ3pWisOnBEhcJ1apqGtoHIB8xS3EWeuctgpJke1jD+8sDCvhuUBj0ZIdQf0WG+Y0jes3Wc y1021x5lFU0en/hGGD/wuAW5+FVgp9yVfPrj2X/thGkAUnVtGuzijUVgGjrdIs81zgdp0RHPdF2F6 VJg9lE4Hg==; Received: from shell.armlinux.org.uk ([fd8f:7570:feb6:1:5054:ff:fe00:4ec]:56562) by pandora.armlinux.org.uk with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kbhRy-0007Ez-TU; Sun, 08 Nov 2020 09:57:30 +0000 Received: from linux by shell.armlinux.org.uk with local (Exim 4.92) (envelope-from ) id 1kbhRt-0007jT-4M; Sun, 08 Nov 2020 09:57:25 +0000 Date: Sun, 8 Nov 2020 09:57:25 +0000 From: Russell King - ARM Linux admin To: Sam Ravnborg Subject: Re: [PATCH] drm: bridge: dw-hdmi: Avoid resetting force in the detect function Message-ID: <20201108095724.GW1551@shell.armlinux.org.uk> References: <20201031081747.372599-1-net147@gmail.com> <20201108095322.GA1129714@ravnborg.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20201108095322.GA1129714@ravnborg.org> User-Agent: Mutt/1.10.1 (2018-07-13) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20201108_045736_315600_ADCC1FF4 X-CRM114-Status: GOOD ( 17.27 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Fabio Estevam , Jernej Skrabec , Jonathan Liu , Jonas Karlman , David Airlie , Neil Armstrong , linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, Andrzej Hajda , linux-rockchip@lists.infradead.org, Boris Brezillon , Laurent Pinchart , Liu Ying , linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Sun, Nov 08, 2020 at 10:53:22AM +0100, Sam Ravnborg wrote: > Russell, > > On Sat, Oct 31, 2020 at 07:17:47PM +1100, Jonathan Liu wrote: > > It has been observed that resetting force in the detect function can > > result in the PHY being powered down in response to hot-plug detect > > being asserted, even when the HDMI connector is forced on. > > > > Enabling debug messages and adding a call to dump_stack() in > > dw_hdmi_phy_power_off() shows the following in dmesg: > > [ 160.637413] dwhdmi-rockchip ff940000.hdmi: EVENT=plugin > > [ 160.637433] dwhdmi-rockchip ff940000.hdmi: PHY powered down in 0 iterations > > > > Call trace: > > dw_hdmi_phy_power_off > > dw_hdmi_phy_disable > > dw_hdmi_update_power > > dw_hdmi_detect > > dw_hdmi_connector_detect > > drm_helper_probe_detect_ctx > > drm_helper_hpd_irq_event > > dw_hdmi_irq > > irq_thread_fn > > irq_thread > > kthread > > ret_from_fork > > > > Fixes: 381f05a7a842 ("drm: bridge/dw_hdmi: add connector mode forcing") > > Signed-off-by: Jonathan Liu > > you are the original author of this code - any comments on this patch? No further comments beyond what has already been discussed, and the long and short of it is it's been so long that I don't remember why that code was there. Given that, I'm not even in a position to ack the change. Sorry. -- RMK's Patch system: https://www.armlinux.org.uk/developer/patches/ FTTP is here! 40Mbps down 10Mbps up. Decent connectivity at last! _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.1 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4CB58C388F2 for ; Sun, 8 Nov 2020 09:57:39 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 410EF206ED for ; Sun, 8 Nov 2020 09:57:38 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=armlinux.org.uk header.i=@armlinux.org.uk header.b="CV5/QWIS" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 410EF206ED Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=armlinux.org.uk Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id C946489F6F; Sun, 8 Nov 2020 09:57:37 +0000 (UTC) Received: from pandora.armlinux.org.uk (pandora.armlinux.org.uk [IPv6:2001:4d48:ad52:32c8:5054:ff:fe00:142]) by gabe.freedesktop.org (Postfix) with ESMTPS id 9AE0889F6F for ; Sun, 8 Nov 2020 09:57:37 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=armlinux.org.uk; s=pandora-2019; h=Sender:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=Gu6W+SYNYwujRSnH/S/cqUbxFQBEVozmfEiGAZYOXTA=; b=CV5/QWIS9Q6yhKqIURS3jOiQr sTYBSt7zBvclZtLq9/AyhSNGwBonxuH2r2ePFH8J+7Xx5jqnPUmzQc4SH/mmz0W7mNqzbECRh+Zii anGEnoxZi3Oiac1yj2hm/+SGR5mYROn55SFyDixBQAdjv2wCxdzFKJjTsbl7mPPZUXH4zAEtjfMVd KC8+q9qJ3pWisOnBEhcJ1apqGtoHIB8xS3EWeuctgpJke1jD+8sDCvhuUBj0ZIdQf0WG+Y0jes3Wc y1021x5lFU0en/hGGD/wuAW5+FVgp9yVfPrj2X/thGkAUnVtGuzijUVgGjrdIs81zgdp0RHPdF2F6 VJg9lE4Hg==; Received: from shell.armlinux.org.uk ([fd8f:7570:feb6:1:5054:ff:fe00:4ec]:56562) by pandora.armlinux.org.uk with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kbhRy-0007Ez-TU; Sun, 08 Nov 2020 09:57:30 +0000 Received: from linux by shell.armlinux.org.uk with local (Exim 4.92) (envelope-from ) id 1kbhRt-0007jT-4M; Sun, 08 Nov 2020 09:57:25 +0000 Date: Sun, 8 Nov 2020 09:57:25 +0000 From: Russell King - ARM Linux admin To: Sam Ravnborg Subject: Re: [PATCH] drm: bridge: dw-hdmi: Avoid resetting force in the detect function Message-ID: <20201108095724.GW1551@shell.armlinux.org.uk> References: <20201031081747.372599-1-net147@gmail.com> <20201108095322.GA1129714@ravnborg.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20201108095322.GA1129714@ravnborg.org> User-Agent: Mutt/1.10.1 (2018-07-13) X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Fabio Estevam , Jernej Skrabec , Jonathan Liu , Jonas Karlman , David Airlie , Neil Armstrong , linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, Andrzej Hajda , linux-rockchip@lists.infradead.org, Boris Brezillon , Laurent Pinchart , Liu Ying , linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" On Sun, Nov 08, 2020 at 10:53:22AM +0100, Sam Ravnborg wrote: > Russell, > > On Sat, Oct 31, 2020 at 07:17:47PM +1100, Jonathan Liu wrote: > > It has been observed that resetting force in the detect function can > > result in the PHY being powered down in response to hot-plug detect > > being asserted, even when the HDMI connector is forced on. > > > > Enabling debug messages and adding a call to dump_stack() in > > dw_hdmi_phy_power_off() shows the following in dmesg: > > [ 160.637413] dwhdmi-rockchip ff940000.hdmi: EVENT=plugin > > [ 160.637433] dwhdmi-rockchip ff940000.hdmi: PHY powered down in 0 iterations > > > > Call trace: > > dw_hdmi_phy_power_off > > dw_hdmi_phy_disable > > dw_hdmi_update_power > > dw_hdmi_detect > > dw_hdmi_connector_detect > > drm_helper_probe_detect_ctx > > drm_helper_hpd_irq_event > > dw_hdmi_irq > > irq_thread_fn > > irq_thread > > kthread > > ret_from_fork > > > > Fixes: 381f05a7a842 ("drm: bridge/dw_hdmi: add connector mode forcing") > > Signed-off-by: Jonathan Liu > > you are the original author of this code - any comments on this patch? No further comments beyond what has already been discussed, and the long and short of it is it's been so long that I don't remember why that code was there. Given that, I'm not even in a position to ack the change. Sorry. -- RMK's Patch system: https://www.armlinux.org.uk/developer/patches/ FTTP is here! 40Mbps down 10Mbps up. Decent connectivity at last! _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.1 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2532EC388F9 for ; Sun, 8 Nov 2020 09:57:41 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id D7318206ED for ; Sun, 8 Nov 2020 09:57:40 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=armlinux.org.uk header.i=@armlinux.org.uk header.b="CV5/QWIS" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728302AbgKHJ5k (ORCPT ); Sun, 8 Nov 2020 04:57:40 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:52450 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726144AbgKHJ5j (ORCPT ); Sun, 8 Nov 2020 04:57:39 -0500 Received: from pandora.armlinux.org.uk (pandora.armlinux.org.uk [IPv6:2001:4d48:ad52:32c8:5054:ff:fe00:142]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id CE437C0613CF for ; Sun, 8 Nov 2020 01:57:38 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=armlinux.org.uk; s=pandora-2019; h=Sender:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=Gu6W+SYNYwujRSnH/S/cqUbxFQBEVozmfEiGAZYOXTA=; b=CV5/QWIS9Q6yhKqIURS3jOiQr sTYBSt7zBvclZtLq9/AyhSNGwBonxuH2r2ePFH8J+7Xx5jqnPUmzQc4SH/mmz0W7mNqzbECRh+Zii anGEnoxZi3Oiac1yj2hm/+SGR5mYROn55SFyDixBQAdjv2wCxdzFKJjTsbl7mPPZUXH4zAEtjfMVd KC8+q9qJ3pWisOnBEhcJ1apqGtoHIB8xS3EWeuctgpJke1jD+8sDCvhuUBj0ZIdQf0WG+Y0jes3Wc y1021x5lFU0en/hGGD/wuAW5+FVgp9yVfPrj2X/thGkAUnVtGuzijUVgGjrdIs81zgdp0RHPdF2F6 VJg9lE4Hg==; Received: from shell.armlinux.org.uk ([fd8f:7570:feb6:1:5054:ff:fe00:4ec]:56562) by pandora.armlinux.org.uk with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kbhRy-0007Ez-TU; Sun, 08 Nov 2020 09:57:30 +0000 Received: from linux by shell.armlinux.org.uk with local (Exim 4.92) (envelope-from ) id 1kbhRt-0007jT-4M; Sun, 08 Nov 2020 09:57:25 +0000 Date: Sun, 8 Nov 2020 09:57:25 +0000 From: Russell King - ARM Linux admin To: Sam Ravnborg Cc: Jonathan Liu , linux-rockchip@lists.infradead.org, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Fabio Estevam , Jernej Skrabec , Jonas Karlman , David Airlie , Neil Armstrong , Andrzej Hajda , Boris Brezillon , Laurent Pinchart , Liu Ying Subject: Re: [PATCH] drm: bridge: dw-hdmi: Avoid resetting force in the detect function Message-ID: <20201108095724.GW1551@shell.armlinux.org.uk> References: <20201031081747.372599-1-net147@gmail.com> <20201108095322.GA1129714@ravnborg.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20201108095322.GA1129714@ravnborg.org> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: Russell King - ARM Linux admin Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, Nov 08, 2020 at 10:53:22AM +0100, Sam Ravnborg wrote: > Russell, > > On Sat, Oct 31, 2020 at 07:17:47PM +1100, Jonathan Liu wrote: > > It has been observed that resetting force in the detect function can > > result in the PHY being powered down in response to hot-plug detect > > being asserted, even when the HDMI connector is forced on. > > > > Enabling debug messages and adding a call to dump_stack() in > > dw_hdmi_phy_power_off() shows the following in dmesg: > > [ 160.637413] dwhdmi-rockchip ff940000.hdmi: EVENT=plugin > > [ 160.637433] dwhdmi-rockchip ff940000.hdmi: PHY powered down in 0 iterations > > > > Call trace: > > dw_hdmi_phy_power_off > > dw_hdmi_phy_disable > > dw_hdmi_update_power > > dw_hdmi_detect > > dw_hdmi_connector_detect > > drm_helper_probe_detect_ctx > > drm_helper_hpd_irq_event > > dw_hdmi_irq > > irq_thread_fn > > irq_thread > > kthread > > ret_from_fork > > > > Fixes: 381f05a7a842 ("drm: bridge/dw_hdmi: add connector mode forcing") > > Signed-off-by: Jonathan Liu > > you are the original author of this code - any comments on this patch? No further comments beyond what has already been discussed, and the long and short of it is it's been so long that I don't remember why that code was there. Given that, I'm not even in a position to ack the change. Sorry. -- RMK's Patch system: https://www.armlinux.org.uk/developer/patches/ FTTP is here! 40Mbps down 10Mbps up. Decent connectivity at last!