From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D44ECC388F9 for ; Sun, 8 Nov 2020 18:49:23 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 631DD20731 for ; Sun, 8 Nov 2020 18:49:23 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="LpEATItS" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 631DD20731 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=juVBykDvhuBVbyNn0ELsF93OMCw2XroYBazLUl2XEdY=; b=LpEATItS4WYEXQ0VSK/BMjROL F0oki8TnuI5OltG7hqSPv5/6WocjfxwzURx2tQeDYczY7eM7YUPG59uDFpwm++la+Af0H9zudEeQS Bw9V23SnfYcJ0rLaeA44ykqcCCbNIcVnQB6UiCae5uroqgsc/q/FR0Xybrs//f7x6gWr9e67T9GYO Q0QCurpgU8CeMqyCKMF87A9Pw6DKj1oRKcbHTXatt4Um+q2mEMqCJoJoDFowcyqeZGs5yG5et0QY0 9WPv1Y+OhzwOQ7tCQNVliBFzahbui7umx2pAg0pSoPvGg1zLhQSdGb/Ht2QT0L3sCDCtQGnvBaiza 17bfnD1Cw==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kbpjg-0002On-0X; Sun, 08 Nov 2020 18:48:20 +0000 Received: from mail-ej1-f65.google.com ([209.85.218.65]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kbpjd-0002L1-2L for linux-arm-kernel@lists.infradead.org; Sun, 08 Nov 2020 18:48:17 +0000 Received: by mail-ej1-f65.google.com with SMTP id s25so9157679ejy.6 for ; Sun, 08 Nov 2020 10:48:16 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=e4MFmro9LRzZqM00MSLpje3m5vP1BDJdx4WIA1ubdow=; b=eYBoi83JYa37ESpW2jO+C0XQf0rxvkNpXZdDnhafLnZvYJAtbYeQl/OyKHqf2eJuvS 87VAqhE5UMAYWE6DmYJSAVTchVNwtGJygZDevkg5O8itKSt5L41cPgaaBgJ93SHYEJfE azAAHfRnQ7PSjPLYFm0sW1D9a4mrsvE+OVTkykHaNULanA4P/veXDyldzpFcO9MXNaLO Uj6TPbeK7UGqc7J/JfyYEzWx9/YmxqDuAA+i5uwKOjwYzovM+goDbi5Pg3gsVeA0iSHh aGSWIeAShtN5LLI5qncqhh54cruOmpN/B1HKpw6lqTcsUmNGtHjcjBcvg7WBCsyXFSpE sTlg== X-Gm-Message-State: AOAM531iQPss2FVx/WU2QLYAncTpEEl/m2x6tgdjZL5WppZMAjrL1uuN 5hoW/FLhTayqBfqTHGiUmRk= X-Google-Smtp-Source: ABdhPJybxe86P3/r3o9BXNWCXrIOkAU1VasfBNaZH9VotvbwckDMDeAI6+VnIdMDrHItkHNXmDtwbQ== X-Received: by 2002:a17:906:85c1:: with SMTP id i1mr12060491ejy.157.1604861296017; Sun, 08 Nov 2020 10:48:16 -0800 (PST) Received: from kozik-lap (adsl-84-226-167-205.adslplus.ch. [84.226.167.205]) by smtp.googlemail.com with ESMTPSA id q8sm6754088ejy.102.2020.11.08.10.48.14 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 08 Nov 2020 10:48:14 -0800 (PST) Date: Sun, 8 Nov 2020 19:48:13 +0100 From: Krzysztof Kozlowski To: Adam Ford Subject: Re: [PATCH V2 5/5] arm64: dts: imx8mn: Add GPU node Message-ID: <20201108184813.GD7078@kozik-lap> References: <20201107140026.1974312-1-aford173@gmail.com> <20201107140026.1974312-5-aford173@gmail.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20201107140026.1974312-5-aford173@gmail.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20201108_134817_127371_6E63C714 X-CRM114-Status: GOOD ( 20.70 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: devicetree@vger.kernel.org, Andrey Smirnov , Fabio Estevam , Sascha Hauer , aford@beaconembedded.com, linux-kernel@vger.kernel.org, Rob Herring , NXP Linux Team , Pengutronix Kernel Team , Shawn Guo , linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Sat, Nov 07, 2020 at 08:00:25AM -0600, Adam Ford wrote: > According to the documentation from NXP, the i.MX8M Nano has a > Vivante GC7000 Ultra Lite as its GPU core. > > With this patch, the Etnaviv driver presents the GPU as: > etnaviv-gpu 38000000.gpu: model: GC7000, revision: 6203 > > The stock operating voltage for the i.MX8M Nano is .85V which means > the GPU needs to run at 400MHz. For boards where the operating > voltage is higher, this can be increased. > > Signed-off-by: Adam Ford > --- > V2: Move into this series > Update clocking description > > arch/arm64/boot/dts/freescale/imx8mn.dtsi | 25 +++++++++++++++++++++++ > 1 file changed, 25 insertions(+) > > diff --git a/arch/arm64/boot/dts/freescale/imx8mn.dtsi b/arch/arm64/boot/dts/freescale/imx8mn.dtsi > index 5e4b6934de40..6e650ea422a7 100644 > --- a/arch/arm64/boot/dts/freescale/imx8mn.dtsi > +++ b/arch/arm64/boot/dts/freescale/imx8mn.dtsi > @@ -1008,6 +1008,31 @@ gpmi: nand-controller@33002000 { > status = "disabled"; > }; > > + gpu: gpu@38000000 { > + compatible = "vivante,gc"; > + reg = <0x38000000 0x8000>; > + interrupts = ; > + clocks = <&clk IMX8MN_CLK_GPU_AHB>, > + <&clk IMX8MN_CLK_GPU_BUS_ROOT>, > + <&clk IMX8MN_CLK_GPU_CORE_ROOT>, > + <&clk IMX8MN_CLK_GPU_SHADER_DIV>; > + clock-names = "reg", "bus", "core", "shader"; > + assigned-clocks = <&clk IMX8MN_CLK_GPU_CORE_SRC>, > + <&clk IMX8MN_CLK_GPU_SHADER_SRC>, > + <&clk IMX8MN_CLK_GPU_AXI>, > + <&clk IMX8MN_CLK_GPU_AHB>, > + <&clk IMX8MN_GPU_PLL>, > + <&clk IMX8MN_CLK_GPU_CORE_DIV>, > + <&clk IMX8MN_CLK_GPU_SHADER_DIV>; > + assigned-clock-parents = <&clk IMX8MN_GPU_PLL_OUT>, > + <&clk IMX8MN_GPU_PLL_OUT>, > + <&clk IMX8MN_SYS_PLL1_800M>, > + <&clk IMX8MN_SYS_PLL1_800M>; > + assigned-clock-rates = <0>, <0>, <800000000>, <400000000>, <1200000000>, > + <400000000>, <400000000>; It would be nice to align indentation here to <0> above. Reviewed-by: Krzysztof Kozlowski Best regards, Krzysztof _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.1 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 08352C388F9 for ; Sun, 8 Nov 2020 18:48:19 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id C7B7820773 for ; Sun, 8 Nov 2020 18:48:18 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1604861298; bh=72nhC9XctfnM5eUWowQbR9s2jxEfu2UNdSV2PH9Xl1I=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=n9+lLgPoWMVSFaP9ybEi0ph6+R6IpdUfQd9fcFCob2cHs6JcYcGXPE/LF65PhzXSs /qYCprj/CqkYH/uJ6fJc1M57NRakEa7LzovZhz6FR2/wIj/X5VELL8sxhjE6IqG9rQ DuV2thpCqA5hNQ9+5UuQVdGiQrbs+k1ePD9GHRhU= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727929AbgKHSsS (ORCPT ); Sun, 8 Nov 2020 13:48:18 -0500 Received: from mail-ej1-f68.google.com ([209.85.218.68]:35598 "EHLO mail-ej1-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727570AbgKHSsS (ORCPT ); Sun, 8 Nov 2020 13:48:18 -0500 Received: by mail-ej1-f68.google.com with SMTP id f23so2509998ejk.2; Sun, 08 Nov 2020 10:48:16 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=e4MFmro9LRzZqM00MSLpje3m5vP1BDJdx4WIA1ubdow=; b=s6GSTn8H+FVYnSwPPpC11opJlBDUZWGeZtZA8V7/GtBiXKPn0mJ/8jEjSMF4FtU9jq PHXSZumsUggnU+VG9T81emvWOCg1R1CrF+ZdRjTcw2jnBrWK2WIUknm92+XsrJFuXVq5 pSbKkjhwB65iSBdG88zx93PUdve9qFaCa8w8lvKIlwEfSm7oB+DzGYVrBwISizzhEzp6 M/QLcnkCRQ/yfAur0xGC58uNzx1rCozbuweas0740rL/kxyG398cRyfo7vpkXAaZ0BOx NH0leQNcOCJhj3fzLQQvL8kJ6YtF1PBNfSB8Nlswg8RChHrcQ8t4wj5z1vuRgoC9NVN1 ZbRg== X-Gm-Message-State: AOAM530IJyG1JT5bFHsL9KdrPCggNvh/PlHPM6gY05cvAAz6tdTeyacw pjjowrNgyOP99fbvTi4HkMo= X-Google-Smtp-Source: ABdhPJybxe86P3/r3o9BXNWCXrIOkAU1VasfBNaZH9VotvbwckDMDeAI6+VnIdMDrHItkHNXmDtwbQ== X-Received: by 2002:a17:906:85c1:: with SMTP id i1mr12060491ejy.157.1604861296017; Sun, 08 Nov 2020 10:48:16 -0800 (PST) Received: from kozik-lap (adsl-84-226-167-205.adslplus.ch. [84.226.167.205]) by smtp.googlemail.com with ESMTPSA id q8sm6754088ejy.102.2020.11.08.10.48.14 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 08 Nov 2020 10:48:14 -0800 (PST) Date: Sun, 8 Nov 2020 19:48:13 +0100 From: Krzysztof Kozlowski To: Adam Ford Cc: linux-arm-kernel@lists.infradead.org, aford@beaconembedded.com, Rob Herring , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , NXP Linux Team , Andrey Smirnov , devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH V2 5/5] arm64: dts: imx8mn: Add GPU node Message-ID: <20201108184813.GD7078@kozik-lap> References: <20201107140026.1974312-1-aford173@gmail.com> <20201107140026.1974312-5-aford173@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20201107140026.1974312-5-aford173@gmail.com> Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On Sat, Nov 07, 2020 at 08:00:25AM -0600, Adam Ford wrote: > According to the documentation from NXP, the i.MX8M Nano has a > Vivante GC7000 Ultra Lite as its GPU core. > > With this patch, the Etnaviv driver presents the GPU as: > etnaviv-gpu 38000000.gpu: model: GC7000, revision: 6203 > > The stock operating voltage for the i.MX8M Nano is .85V which means > the GPU needs to run at 400MHz. For boards where the operating > voltage is higher, this can be increased. > > Signed-off-by: Adam Ford > --- > V2: Move into this series > Update clocking description > > arch/arm64/boot/dts/freescale/imx8mn.dtsi | 25 +++++++++++++++++++++++ > 1 file changed, 25 insertions(+) > > diff --git a/arch/arm64/boot/dts/freescale/imx8mn.dtsi b/arch/arm64/boot/dts/freescale/imx8mn.dtsi > index 5e4b6934de40..6e650ea422a7 100644 > --- a/arch/arm64/boot/dts/freescale/imx8mn.dtsi > +++ b/arch/arm64/boot/dts/freescale/imx8mn.dtsi > @@ -1008,6 +1008,31 @@ gpmi: nand-controller@33002000 { > status = "disabled"; > }; > > + gpu: gpu@38000000 { > + compatible = "vivante,gc"; > + reg = <0x38000000 0x8000>; > + interrupts = ; > + clocks = <&clk IMX8MN_CLK_GPU_AHB>, > + <&clk IMX8MN_CLK_GPU_BUS_ROOT>, > + <&clk IMX8MN_CLK_GPU_CORE_ROOT>, > + <&clk IMX8MN_CLK_GPU_SHADER_DIV>; > + clock-names = "reg", "bus", "core", "shader"; > + assigned-clocks = <&clk IMX8MN_CLK_GPU_CORE_SRC>, > + <&clk IMX8MN_CLK_GPU_SHADER_SRC>, > + <&clk IMX8MN_CLK_GPU_AXI>, > + <&clk IMX8MN_CLK_GPU_AHB>, > + <&clk IMX8MN_GPU_PLL>, > + <&clk IMX8MN_CLK_GPU_CORE_DIV>, > + <&clk IMX8MN_CLK_GPU_SHADER_DIV>; > + assigned-clock-parents = <&clk IMX8MN_GPU_PLL_OUT>, > + <&clk IMX8MN_GPU_PLL_OUT>, > + <&clk IMX8MN_SYS_PLL1_800M>, > + <&clk IMX8MN_SYS_PLL1_800M>; > + assigned-clock-rates = <0>, <0>, <800000000>, <400000000>, <1200000000>, > + <400000000>, <400000000>; It would be nice to align indentation here to <0> above. Reviewed-by: Krzysztof Kozlowski Best regards, Krzysztof