From: Petr Vorel <pvorel@suse.cz>
To: ltp@lists.linux.it
Subject: [LTP] [PATCH 1/1] fanotify16: Introduce SAFE_FANOTIFY_MARK() macro
Date: Sun, 8 Nov 2020 22:43:06 +0100 [thread overview]
Message-ID: <20201108214306.GA115861@pevik> (raw)
In-Reply-To: <CAOQ4uxgAk_k8de0XTewYoFKYYr2Ykpe3Ww5vy7Xfqy9hbUb7VA@mail.gmail.com>
Hi Amir,
> On Tue, Oct 20, 2020 at 10:00 AM Petr Vorel <pvorel@suse.cz> wrote:
> > Hi Amir,
> > thanks for your suggestions, I'll send v2 shortly.
> > I've been thinking about it for a while and agree it's better to simplify
> > safe_fanotify_mark() hints.
> > I'll also separate fixes into more commits to be more readable.
> Hi Petr,
> I guess v2 got delayed,
Yes, I'm sorry. While being in the middle of the work, but higher priority work
arrived :). I'll try to get to v2 soon, but just let me know if it block you and
you're going to implement the cleanup yourself.
> so while at it let me ask -
> Did you maybe consider also moving the checks for
> "FAN_REPORT_FID not supported in kernel?" and
> "FAN_REPORT_NAME not supported in kernel?"
> into safe_fanotify_init()?
Sure.
> The reason I am asking is because I am working on adding a test case
> to fanotify09 [1], which involves converting SAFE_FANOTIFY_INIT()
> to fanotify_init(), due to pottenitally unsupported init flags in the kernel.
I see, third patch.
Kind regards,
Petr
> Thanks,
> Amir.
> [1] https://github.com/amir73il/ltp/commits/fsnotify-fixes
prev parent reply other threads:[~2020-11-08 21:43 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-16 11:24 [LTP] [PATCH 1/1] fanotify16: Introduce SAFE_FANOTIFY_MARK() macro Petr Vorel
2020-10-17 10:56 ` Amir Goldstein
2020-10-20 7:00 ` Petr Vorel
2020-11-08 8:43 ` Amir Goldstein
2020-11-08 21:43 ` Petr Vorel [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201108214306.GA115861@pevik \
--to=pvorel@suse.cz \
--cc=ltp@lists.linux.it \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.