From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.0 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, UNWANTED_LANGUAGE_BODY,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8592BC2D0A3 for ; Mon, 9 Nov 2020 08:44:29 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 2853020719 for ; Mon, 9 Nov 2020 08:44:29 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=ideasonboard.com header.i=@ideasonboard.com header.b="fI18fIhW" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726176AbgKIIo2 (ORCPT ); Mon, 9 Nov 2020 03:44:28 -0500 Received: from perceval.ideasonboard.com ([213.167.242.64]:39572 "EHLO perceval.ideasonboard.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726127AbgKIIo2 (ORCPT ); Mon, 9 Nov 2020 03:44:28 -0500 Received: from pendragon.ideasonboard.com (62-78-145-57.bb.dnainternet.fi [62.78.145.57]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id C92482FE; Mon, 9 Nov 2020 09:44:26 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1604911467; bh=uil22SZmzLA9OiW5GKh7qc4WY2JG3YWY5xYTjmchaiY=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=fI18fIhWap6DfiPeFKFnX8BXjk9WukyWLqPFmgaTbFtsAGD2MDDJA32X3LwkZOOTF bf7Awh6KeK0zdWniFBAFDs6DFwZZVbjsIXexAbplhG8ekXiNImIuuYKMgxB9OG0otf 0g6dBxbSS0cxVASnxm4mwEVcV4f8Dczbt1FmORPM= Date: Mon, 9 Nov 2020 10:44:23 +0200 From: Laurent Pinchart To: Tomi Valkeinen Cc: Sebastian Reichel , Nikhil Devshatwar , linux-omap@vger.kernel.org, dri-devel@lists.freedesktop.org, Sekhar Nori , Tony Lindgren , "H . Nikolaus Schaller" , Sebastian Reichel Subject: Re: [PATCH v3 17/56] drm/omap: panel-dsi-cm: use common MIPI DCS 1.3 defines Message-ID: <20201109084423.GN6029@pendragon.ideasonboard.com> References: <20201105120333.947408-1-tomi.valkeinen@ti.com> <20201105120333.947408-18-tomi.valkeinen@ti.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20201105120333.947408-18-tomi.valkeinen@ti.com> Precedence: bulk List-ID: X-Mailing-List: linux-omap@vger.kernel.org Hi Tomi and Sebastian, Thank you for the patch. On Thu, Nov 05, 2020 at 02:02:54PM +0200, Tomi Valkeinen wrote: > From: Sebastian Reichel > > Drop local definition of common MIPI DCS 1.3 defines. > > Signed-off-by: Sebastian Reichel > Signed-off-by: Tomi Valkeinen > --- > drivers/gpu/drm/omapdrm/displays/panel-dsi-cm.c | 12 ++++++------ > 1 file changed, 6 insertions(+), 6 deletions(-) > > diff --git a/drivers/gpu/drm/omapdrm/displays/panel-dsi-cm.c b/drivers/gpu/drm/omapdrm/displays/panel-dsi-cm.c > index 25183744a61d..a7236d9c3046 100644 > --- a/drivers/gpu/drm/omapdrm/displays/panel-dsi-cm.c > +++ b/drivers/gpu/drm/omapdrm/displays/panel-dsi-cm.c > @@ -28,8 +28,6 @@ > #include "../dss/omapdss.h" > > #define DCS_READ_NUM_ERRORS 0x05 > -#define DCS_BRIGHTNESS 0x51 > -#define DCS_CTRL_DISPLAY 0x53 > #define DCS_GET_ID1 0xda > #define DCS_GET_ID2 0xdb > #define DCS_GET_ID3 0xdc > @@ -333,8 +331,10 @@ static int dsicm_bl_update_status(struct backlight_device *dev) > src->ops->dsi.bus_lock(src); > > r = dsicm_wake_up(ddata); > - if (!r) > - r = dsicm_dcs_write_1(ddata, DCS_BRIGHTNESS, level); > + if (!r) { > + r = dsicm_dcs_write_1(ddata, > + MIPI_DCS_SET_DISPLAY_BRIGHTNESS, level); > + } Weird indentation, and no need for curly brackets, but no big deal. Reviewed-by: Laurent Pinchart > > src->ops->dsi.bus_unlock(src); > } > @@ -597,11 +597,11 @@ static int dsicm_power_on(struct panel_drv_data *ddata) > if (r) > goto err; > > - r = dsicm_dcs_write_1(ddata, DCS_BRIGHTNESS, 0xff); > + r = dsicm_dcs_write_1(ddata, MIPI_DCS_SET_DISPLAY_BRIGHTNESS, 0xff); > if (r) > goto err; > > - r = dsicm_dcs_write_1(ddata, DCS_CTRL_DISPLAY, > + r = dsicm_dcs_write_1(ddata, MIPI_DCS_WRITE_CONTROL_DISPLAY, > (1<<2) | (1<<5)); /* BL | BCTRL */ > if (r) > goto err; -- Regards, Laurent Pinchart From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.6 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4B733C55ABD for ; Mon, 9 Nov 2020 08:44:31 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id C1AD1206ED for ; Mon, 9 Nov 2020 08:44:30 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=ideasonboard.com header.i=@ideasonboard.com header.b="fI18fIhW" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org C1AD1206ED Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=ideasonboard.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 0CA0C8924F; Mon, 9 Nov 2020 08:44:30 +0000 (UTC) Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [213.167.242.64]) by gabe.freedesktop.org (Postfix) with ESMTPS id 57FE88924F for ; Mon, 9 Nov 2020 08:44:28 +0000 (UTC) Received: from pendragon.ideasonboard.com (62-78-145-57.bb.dnainternet.fi [62.78.145.57]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id C92482FE; Mon, 9 Nov 2020 09:44:26 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1604911467; bh=uil22SZmzLA9OiW5GKh7qc4WY2JG3YWY5xYTjmchaiY=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=fI18fIhWap6DfiPeFKFnX8BXjk9WukyWLqPFmgaTbFtsAGD2MDDJA32X3LwkZOOTF bf7Awh6KeK0zdWniFBAFDs6DFwZZVbjsIXexAbplhG8ekXiNImIuuYKMgxB9OG0otf 0g6dBxbSS0cxVASnxm4mwEVcV4f8Dczbt1FmORPM= Date: Mon, 9 Nov 2020 10:44:23 +0200 From: Laurent Pinchart To: Tomi Valkeinen Subject: Re: [PATCH v3 17/56] drm/omap: panel-dsi-cm: use common MIPI DCS 1.3 defines Message-ID: <20201109084423.GN6029@pendragon.ideasonboard.com> References: <20201105120333.947408-1-tomi.valkeinen@ti.com> <20201105120333.947408-18-tomi.valkeinen@ti.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20201105120333.947408-18-tomi.valkeinen@ti.com> X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Tony Lindgren , "H . Nikolaus Schaller" , Sekhar Nori , Sebastian Reichel , dri-devel@lists.freedesktop.org, Sebastian Reichel , linux-omap@vger.kernel.org, Nikhil Devshatwar Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" Hi Tomi and Sebastian, Thank you for the patch. On Thu, Nov 05, 2020 at 02:02:54PM +0200, Tomi Valkeinen wrote: > From: Sebastian Reichel > > Drop local definition of common MIPI DCS 1.3 defines. > > Signed-off-by: Sebastian Reichel > Signed-off-by: Tomi Valkeinen > --- > drivers/gpu/drm/omapdrm/displays/panel-dsi-cm.c | 12 ++++++------ > 1 file changed, 6 insertions(+), 6 deletions(-) > > diff --git a/drivers/gpu/drm/omapdrm/displays/panel-dsi-cm.c b/drivers/gpu/drm/omapdrm/displays/panel-dsi-cm.c > index 25183744a61d..a7236d9c3046 100644 > --- a/drivers/gpu/drm/omapdrm/displays/panel-dsi-cm.c > +++ b/drivers/gpu/drm/omapdrm/displays/panel-dsi-cm.c > @@ -28,8 +28,6 @@ > #include "../dss/omapdss.h" > > #define DCS_READ_NUM_ERRORS 0x05 > -#define DCS_BRIGHTNESS 0x51 > -#define DCS_CTRL_DISPLAY 0x53 > #define DCS_GET_ID1 0xda > #define DCS_GET_ID2 0xdb > #define DCS_GET_ID3 0xdc > @@ -333,8 +331,10 @@ static int dsicm_bl_update_status(struct backlight_device *dev) > src->ops->dsi.bus_lock(src); > > r = dsicm_wake_up(ddata); > - if (!r) > - r = dsicm_dcs_write_1(ddata, DCS_BRIGHTNESS, level); > + if (!r) { > + r = dsicm_dcs_write_1(ddata, > + MIPI_DCS_SET_DISPLAY_BRIGHTNESS, level); > + } Weird indentation, and no need for curly brackets, but no big deal. Reviewed-by: Laurent Pinchart > > src->ops->dsi.bus_unlock(src); > } > @@ -597,11 +597,11 @@ static int dsicm_power_on(struct panel_drv_data *ddata) > if (r) > goto err; > > - r = dsicm_dcs_write_1(ddata, DCS_BRIGHTNESS, 0xff); > + r = dsicm_dcs_write_1(ddata, MIPI_DCS_SET_DISPLAY_BRIGHTNESS, 0xff); > if (r) > goto err; > > - r = dsicm_dcs_write_1(ddata, DCS_CTRL_DISPLAY, > + r = dsicm_dcs_write_1(ddata, MIPI_DCS_WRITE_CONTROL_DISPLAY, > (1<<2) | (1<<5)); /* BL | BCTRL */ > if (r) > goto err; -- Regards, Laurent Pinchart _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel