From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.8 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 34754C2D0A3 for ; Mon, 9 Nov 2020 10:36:06 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id C43AA2083B for ; Mon, 9 Nov 2020 10:36:05 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1604918165; bh=SM+6eV/g7OP/MMAwSNFCdCRNGoiKXfSSU3Fd/r+uyV4=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=tcgwF20D+BJ4g1FnQkLHc4jptrWFOs+/Ri6c2D9Og8WOqDc3Fq96SWHHBlUrgXrkW 5Icp/+KerfE+/lw/Kl8OJ7VyZ3kFAtYRcJhr7dWCRGiC40PNR0FvAJREQdQ/9CIYHA VO7xK6mtu+gaJhrPMDGlFk2evw4MTUaf1PyvX74Q= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729195AbgKIKgE (ORCPT ); Mon, 9 Nov 2020 05:36:04 -0500 Received: from mail.kernel.org ([198.145.29.99]:42218 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726646AbgKIKgE (ORCPT ); Mon, 9 Nov 2020 05:36:04 -0500 Received: from localhost (83-86-74-64.cable.dynamic.v4.ziggo.nl [83.86.74.64]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 5A273206B2; Mon, 9 Nov 2020 10:36:03 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1604918164; bh=SM+6eV/g7OP/MMAwSNFCdCRNGoiKXfSSU3Fd/r+uyV4=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=VN81xgKXJ/c1bkxqX9lFnc0F8bTOHD8ufUm0z9FH/Xx5qa0y1criFJ4pT5y1XpuZ2 dWr0C9CK7SiQgBMF4JK/4E0QXDUpToe3agIiubwMtPIuyxAVSS010/Aixk+KK48san Wl5Bbjp1nmLUxh5rrEOA8D/ZP8U/9RbD2XcwcidU= Date: Mon, 9 Nov 2020 11:37:03 +0100 From: Greg Kroah-Hartman To: Sudip Mukherjee Cc: "Rafael J . Wysocki" , linux-kernel , Shawn Guo , Stephen Boyd , Dong Aisheng Subject: Re: [PATCH RESEND] driver core: export device_is_bound() to fix build failure Message-ID: <20201109103703.GA1310551@kroah.com> References: <20201107224727.11015-1-sudipm.mukherjee@gmail.com> <20201108082317.GA40741@kroah.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Nov 09, 2020 at 10:14:46AM +0000, Sudip Mukherjee wrote: > Hi Greg, > > On Sun, Nov 8, 2020 at 8:23 AM Greg Kroah-Hartman > wrote: > > > > On Sat, Nov 07, 2020 at 10:47:27PM +0000, Sudip Mukherjee wrote: > > > When CONFIG_MXC_CLK_SCU is configured as 'm' the build fails as it > > > is unable to find device_is_bound(). The error being: > > > ERROR: modpost: "device_is_bound" [drivers/clk/imx/clk-imx-scu.ko] > > > undefined! > > > > > > Export the symbol so that the module finds it. > > > > > > Fixes: 77d8f3068c63 ("clk: imx: scu: add two cells binding support") > > > Signed-off-by: Sudip Mukherjee > > > --- > > > > > > resending with the Fixes: tag. > > > > > > drivers/base/dd.c | 1 + > > > 1 file changed, 1 insertion(+) > > > > > > diff --git a/drivers/base/dd.c b/drivers/base/dd.c > > > index 148e81969e04..a796a57e5efb 100644 > > > --- a/drivers/base/dd.c > > > +++ b/drivers/base/dd.c > > > @@ -353,6 +353,7 @@ bool device_is_bound(struct device *dev) > > > { > > > return dev->p && klist_node_attached(&dev->p->knode_driver); > > > } > > > +EXPORT_SYMBOL(device_is_bound); > > > > EXPORT_SYMBOL_GPL() please, like all the other exports in this file. > > > > Also, wait, no, don't call this, are you sure you are calling it in a > > race-free way? And what branch/tree is the above commit in? > > I have not checked fully but since it is being called from probe() I > assume the lock will be held at that time. probe() should never call this function as it makes no sense at all at that point in time. The driver should be fixed. This function should not be exported, sorry. thanks, greg k-h