From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 883E5C2D0A3 for ; Mon, 9 Nov 2020 10:50:25 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 2B83C2080C for ; Mon, 9 Nov 2020 10:50:25 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=ideasonboard.com header.i=@ideasonboard.com header.b="mewQUYVU" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729100AbgKIKuY (ORCPT ); Mon, 9 Nov 2020 05:50:24 -0500 Received: from perceval.ideasonboard.com ([213.167.242.64]:40964 "EHLO perceval.ideasonboard.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728016AbgKIKuY (ORCPT ); Mon, 9 Nov 2020 05:50:24 -0500 Received: from pendragon.ideasonboard.com (62-78-145-57.bb.dnainternet.fi [62.78.145.57]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id 56E6CB2B; Mon, 9 Nov 2020 11:50:22 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1604919022; bh=GnoUeQgbf+aZv8fknGUgGHYuTFNpR2waFnJSIlAk5ng=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=mewQUYVUd9mjm/JUSnIsWHUJBaE2DXd7m2QGwjS5AvF2MQzSKoXfQdugNqCpUFvCi rJIn4HaZ70mMzFXBRe5kdCX52Hs0b0OV4ytBWMBb4d+c5px/EDNrRc25fK5jgIvUlw CA6GR/oD8PkODgXjWh+tT34QFM229LcbgqBJUtbg= Date: Mon, 9 Nov 2020 12:50:18 +0200 From: Laurent Pinchart To: Tomi Valkeinen Cc: Sebastian Reichel , Nikhil Devshatwar , linux-omap@vger.kernel.org, dri-devel@lists.freedesktop.org, Sekhar Nori , Tony Lindgren , "H . Nikolaus Schaller" , Sebastian Reichel Subject: Re: [PATCH v3 38/56] drm/omap: panel-dsi-cm: fix remove() Message-ID: <20201109105018.GI6029@pendragon.ideasonboard.com> References: <20201105120333.947408-1-tomi.valkeinen@ti.com> <20201105120333.947408-39-tomi.valkeinen@ti.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20201105120333.947408-39-tomi.valkeinen@ti.com> Precedence: bulk List-ID: X-Mailing-List: linux-omap@vger.kernel.org Hi Tomi and Sebastian, Thank you for the patch. On Thu, Nov 05, 2020 at 02:03:15PM +0200, Tomi Valkeinen wrote: > From: Sebastian Reichel > > Do not try to reset the panel after DSI has been > detached, since the DSI clocks may have been disabled > at this point. The panel will be disabled and unprepared > before being removed and a reset will be done when being > probed again. > > Signed-off-by: Sebastian Reichel > Signed-off-by: Tomi Valkeinen Reviewed-by: Laurent Pinchart > --- > drivers/gpu/drm/omapdrm/displays/panel-dsi-cm.c | 3 --- > 1 file changed, 3 deletions(-) > > diff --git a/drivers/gpu/drm/omapdrm/displays/panel-dsi-cm.c b/drivers/gpu/drm/omapdrm/displays/panel-dsi-cm.c > index 086c7d71fe17..795db22d148d 100644 > --- a/drivers/gpu/drm/omapdrm/displays/panel-dsi-cm.c > +++ b/drivers/gpu/drm/omapdrm/displays/panel-dsi-cm.c > @@ -622,9 +622,6 @@ static int dsicm_remove(struct mipi_dsi_device *dsi) > if (ddata->extbldev) > put_device(&ddata->extbldev->dev); > > - /* reset, to be sure that the panel is in a valid state */ > - dsicm_hw_reset(ddata); > - > return 0; > } > -- Regards, Laurent Pinchart From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.6 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2AC3BC388F7 for ; Mon, 9 Nov 2020 10:50:27 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id AD8B22080C for ; Mon, 9 Nov 2020 10:50:26 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=ideasonboard.com header.i=@ideasonboard.com header.b="mewQUYVU" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org AD8B22080C Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=ideasonboard.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id D3B61898CA; Mon, 9 Nov 2020 10:50:25 +0000 (UTC) Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [213.167.242.64]) by gabe.freedesktop.org (Postfix) with ESMTPS id 5DCC0898CA for ; Mon, 9 Nov 2020 10:50:24 +0000 (UTC) Received: from pendragon.ideasonboard.com (62-78-145-57.bb.dnainternet.fi [62.78.145.57]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id 56E6CB2B; Mon, 9 Nov 2020 11:50:22 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1604919022; bh=GnoUeQgbf+aZv8fknGUgGHYuTFNpR2waFnJSIlAk5ng=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=mewQUYVUd9mjm/JUSnIsWHUJBaE2DXd7m2QGwjS5AvF2MQzSKoXfQdugNqCpUFvCi rJIn4HaZ70mMzFXBRe5kdCX52Hs0b0OV4ytBWMBb4d+c5px/EDNrRc25fK5jgIvUlw CA6GR/oD8PkODgXjWh+tT34QFM229LcbgqBJUtbg= Date: Mon, 9 Nov 2020 12:50:18 +0200 From: Laurent Pinchart To: Tomi Valkeinen Subject: Re: [PATCH v3 38/56] drm/omap: panel-dsi-cm: fix remove() Message-ID: <20201109105018.GI6029@pendragon.ideasonboard.com> References: <20201105120333.947408-1-tomi.valkeinen@ti.com> <20201105120333.947408-39-tomi.valkeinen@ti.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20201105120333.947408-39-tomi.valkeinen@ti.com> X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Tony Lindgren , "H . Nikolaus Schaller" , Sekhar Nori , Sebastian Reichel , dri-devel@lists.freedesktop.org, Sebastian Reichel , linux-omap@vger.kernel.org, Nikhil Devshatwar Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" Hi Tomi and Sebastian, Thank you for the patch. On Thu, Nov 05, 2020 at 02:03:15PM +0200, Tomi Valkeinen wrote: > From: Sebastian Reichel > > Do not try to reset the panel after DSI has been > detached, since the DSI clocks may have been disabled > at this point. The panel will be disabled and unprepared > before being removed and a reset will be done when being > probed again. > > Signed-off-by: Sebastian Reichel > Signed-off-by: Tomi Valkeinen Reviewed-by: Laurent Pinchart > --- > drivers/gpu/drm/omapdrm/displays/panel-dsi-cm.c | 3 --- > 1 file changed, 3 deletions(-) > > diff --git a/drivers/gpu/drm/omapdrm/displays/panel-dsi-cm.c b/drivers/gpu/drm/omapdrm/displays/panel-dsi-cm.c > index 086c7d71fe17..795db22d148d 100644 > --- a/drivers/gpu/drm/omapdrm/displays/panel-dsi-cm.c > +++ b/drivers/gpu/drm/omapdrm/displays/panel-dsi-cm.c > @@ -622,9 +622,6 @@ static int dsicm_remove(struct mipi_dsi_device *dsi) > if (ddata->extbldev) > put_device(&ddata->extbldev->dev); > > - /* reset, to be sure that the panel is in a valid state */ > - dsicm_hw_reset(ddata); > - > return 0; > } > -- Regards, Laurent Pinchart _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel