From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.5 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8E3C9C4741F for ; Mon, 9 Nov 2020 13:57:10 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 14A2520789 for ; Mon, 9 Nov 2020 13:57:09 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="TKPmIbHz" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 14A2520789 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=amd-gfx-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 70C6D899F3; Mon, 9 Nov 2020 13:57:09 +0000 (UTC) Received: from mail-wm1-x343.google.com (mail-wm1-x343.google.com [IPv6:2a00:1450:4864:20::343]) by gabe.freedesktop.org (Postfix) with ESMTPS id 933E989916 for ; Mon, 9 Nov 2020 11:06:12 +0000 (UTC) Received: by mail-wm1-x343.google.com with SMTP id h2so7579384wmm.0 for ; Mon, 09 Nov 2020 03:06:12 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to; bh=/TTLN5u5ntD12Tf50xVKp1qDLZNw1PZvWBuHFthUL88=; b=TKPmIbHz/sJNchjhXki9tBdowYhfzhopEljHcLDYcu2bt52SrzWKjteWCU58KX353a /P/wKKssgcalNm6WMoiInsUU0tYzqmWTdvvP1x2IC4lMkbZRYpg+8gP5TNFHScYSbQbf zNFvHFuDW2gZ2fs7lZw50G9oLfMph4J7tRayNoOEWmnQba2vledcJcf/7z8jURCZlZ7a q1nHIvFPWzIZXH/8EdX8up20/kjt7+d1ENZ+xWOQBxc7IIpx9GwZzr2Y1ubWdpjsgzd2 Ul6YISZB4Gbk64r1IG9P7c6sH25ulfmr2nRzCJeRtHvEfs63vwtVjnue1xJMXbGaFrRS Tfug== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to; bh=/TTLN5u5ntD12Tf50xVKp1qDLZNw1PZvWBuHFthUL88=; b=h355plvxVWQ58PR9MQdrudv1Tnwp3Nz5Z21KTRbGXM/GYhJ0fj+UKvT0kboalzJ6G0 TsjQtV+xaN8Y9Bfl2btwHHWf6089a+N68hbnePZKGyo/hgMLUAuLOw+LXwTTuJoIbKRj jiblbqHRrJyfNzhfCEZsMl6qnnujejO1ZKPbbMSIowCq2WPx9Bqh2jFpE9pOPlssx0CT oaPWjdq7zKoy83t6SceyKrOjGR03kur3KpNWkwlWqqxJbsJl5hdYlRFRg1/ODTJkg5lq 8aZbDEN6AteZt+37Hixha6qmt0oevXmFXbG7m/QirYJqBrctFMrY3agzrN0FX2qbQoZl 2Uow== X-Gm-Message-State: AOAM533K4HHWP5MeNnVTUbIIDrH5tZ1LHK0KOiLjOSpRFS/pzN7RVrpz bcCyUktdbv39tPKNfnv/fjnbSQ== X-Google-Smtp-Source: ABdhPJwCQni2iqmE/lW8/SqfwjZzXNoAzBmb14stJp2vUaJpNmwq4rT99zQtmmQXUZir2cge7Fg/tA== X-Received: by 2002:a1c:67d5:: with SMTP id b204mr14273334wmc.92.1604919971242; Mon, 09 Nov 2020 03:06:11 -0800 (PST) Received: from dell ([91.110.221.180]) by smtp.gmail.com with ESMTPSA id h62sm13193538wrh.82.2020.11.09.03.06.07 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 09 Nov 2020 03:06:10 -0800 (PST) Date: Mon, 9 Nov 2020 11:06:03 +0000 From: Lee Jones To: Sam Ravnborg Subject: Re: [PATCH 10/19] drm/radeon/radeon: Move prototype into shared header Message-ID: <20201109110603.GV2063125@dell> References: <20201106214949.2042120-1-lee.jones@linaro.org> <20201106214949.2042120-11-lee.jones@linaro.org> <20201107142651.GA1014611@ravnborg.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20201107142651.GA1014611@ravnborg.org> X-Mailman-Approved-At: Mon, 09 Nov 2020 13:57:08 +0000 X-BeenThere: amd-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Discussion list for AMD gfx List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: David Airlie , linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, linaro-mm-sig@lists.linaro.org, amd-gfx@lists.freedesktop.org, Alex Deucher , Christian =?iso-8859-1?Q?K=F6nig?= , linux-media@vger.kernel.org Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Errors-To: amd-gfx-bounces@lists.freedesktop.org Sender: "amd-gfx" T24gU2F0LCAwNyBOb3YgMjAyMCwgU2FtIFJhdm5ib3JnIHdyb3RlOgoKPiBIaSBMZWUsCj4gCj4g T24gRnJpLCBOb3YgMDYsIDIwMjAgYXQgMDk6NDk6NDBQTSArMDAwMCwgTGVlIEpvbmVzIHdyb3Rl Ogo+ID4gVW5mb3J0dW5hdGVseSwgYSBzdWl0YWJsZSBvbmUgZGlkbid0IGFscmVhZHkgZXhpc3Qu Cj4gPiAKPiA+IEZpeGVzIHRoZSBmb2xsb3dpbmcgVz0xIGtlcm5lbCBidWlsZCB3YXJuaW5nKHMp Ogo+ID4gCj4gPiAgZHJpdmVycy9ncHUvZHJtL3JhZGVvbi9yYWRlb25fZGV2aWNlLmM6NjM3OjY6 IHdhcm5pbmc6IG5vIHByZXZpb3VzIHByb3RvdHlwZSBmb3Ig4oCYcmFkZW9uX2RldmljZV9pc192 aXJ0dWFs4oCZIFstV21pc3NpbmctcHJvdG90eXBlc10KPiA+ICA2MzcgfCBib29sIHJhZGVvbl9k ZXZpY2VfaXNfdmlydHVhbCh2b2lkKQo+ID4gIHwgXn5+fn5+fn5+fn5+fn5+fn5+fn5+fn5+Cj4g PiAKPiA+IENjOiBBbGV4IERldWNoZXIgPGFsZXhhbmRlci5kZXVjaGVyQGFtZC5jb20+Cj4gPiBD YzogIkNocmlzdGlhbiBLw7ZuaWciIDxjaHJpc3RpYW4ua29lbmlnQGFtZC5jb20+Cj4gPiBDYzog RGF2aWQgQWlybGllIDxhaXJsaWVkQGxpbnV4LmllPgo+ID4gQ2M6IERhbmllbCBWZXR0ZXIgPGRh bmllbEBmZndsbC5jaD4KPiA+IENjOiBTdW1pdCBTZW13YWwgPHN1bWl0LnNlbXdhbEBsaW5hcm8u b3JnPgo+ID4gQ2M6IGFtZC1nZnhAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCj4gPiBDYzogZHJpLWRl dmVsQGxpc3RzLmZyZWVkZXNrdG9wLm9yZwo+ID4gQ2M6IGxpbnV4LW1lZGlhQHZnZXIua2VybmVs Lm9yZwo+ID4gQ2M6IGxpbmFyby1tbS1zaWdAbGlzdHMubGluYXJvLm9yZwo+ID4gU2lnbmVkLW9m Zi1ieTogTGVlIEpvbmVzIDxsZWUuam9uZXNAbGluYXJvLm9yZz4KPiA+IC0tLQo+ID4gIGRyaXZl cnMvZ3B1L2RybS9yYWRlb24vcmFkZW9uX2RldmljZS5jIHwgIDEgKwo+ID4gIGRyaXZlcnMvZ3B1 L2RybS9yYWRlb24vcmFkZW9uX2RldmljZS5oIHwgMzIgKysrKysrKysrKysrKysrKysrKysrKysr KysKPiA+ICBkcml2ZXJzL2dwdS9kcm0vcmFkZW9uL3JhZGVvbl9kcnYuYyAgICB8ICAzICstLQo+ ID4gIDMgZmlsZXMgY2hhbmdlZCwgMzQgaW5zZXJ0aW9ucygrKSwgMiBkZWxldGlvbnMoLSkKPiA+ ICBjcmVhdGUgbW9kZSAxMDA2NDQgZHJpdmVycy9ncHUvZHJtL3JhZGVvbi9yYWRlb25fZGV2aWNl LmgKPiAKPiBPdGhlciBwdWJsaWMgZnVuY3Rpb25zIGluIHJhZGVvbl9kZXZpY2UuYyBoYXZlIHRo ZWlyIHByb3RvdHlwZSBpbgo+IHJhZGVvbi5oIC0gZm9yIGV4YW1wbGUgcmFkZW9uX2lzX3B4KCkK PiAKPiBBZGQgcmFkZW9uX2RldmljZV9pc192aXJ0dWFsKCkgdGhlcmUgc28gd2UgYXZvaWlkIHRo aXMgbmV3IGhlYWRlci4KCk9oIHllcywgSSByZW1lbWJlciB3aHkgdGhpcyB3YXNuJ3QgYSBzdWl0 YWJsZSBzb2x1dGlvbiBub3c6CgpUaGUgbWFjcm8gInJhZGVvbl9pbml0IiBpbiByYWRlb24uaCBj bGFzaGVzIHdpdGggdGhlIGluaXQgZnVuY3Rpb24gb2YKdGhlIHNhbWUgbmFtZSBpbiByYWRlb25f ZHJ2LmM6CgogIEluIGZpbGUgaW5jbHVkZWQgZnJvbSBkcml2ZXJzL2dwdS9kcm0vcmFkZW9uL3Jh ZGVvbl9kcnYuYzo1MzoKICBkcml2ZXJzL2dwdS9kcm0vcmFkZW9uL3JhZGVvbl9kcnYuYzo2MjA6 MzE6IGVycm9yOiBleHBlY3RlZCBpZGVudGlmaWVyIG9yIOKAmCjigJkgYmVmb3JlIOKAmHZvaWTi gJkKICA2MjAgfCBzdGF0aWMgaW50IF9faW5pdCByYWRlb25faW5pdCh2b2lkKQogIHwgXn5+fgog IGRyaXZlcnMvZ3B1L2RybS9yYWRlb24vcmFkZW9uLmg6MjcwNToyODogbm90ZTogaW4gZGVmaW5p dGlvbiBvZiBtYWNybyDigJhyYWRlb25faW5pdOKAmQogIDI3MDUgfCAjZGVmaW5lIHJhZGVvbl9p bml0KHJkZXYpIChyZGV2KS0+YXNpYy0+aW5pdCgocmRldikpCiAgfCBefn5+CiAgSW4gZmlsZSBp bmNsdWRlZCBmcm9tIGRyaXZlcnMvZ3B1L2RybS9yYWRlb24vcmFkZW9uX2Rydi5jOjM1OgogIGRy aXZlcnMvZ3B1L2RybS9yYWRlb24vcmFkZW9uX2Rydi5jOiBJbiBmdW5jdGlvbiDigJhfX2luaXR0 ZXN04oCZOgogIGRyaXZlcnMvZ3B1L2RybS9yYWRlb24vcmFkZW9uX2Rydi5jOjY1MzoxMzogZXJy b3I6IOKAmHJhZGVvbl9pbml04oCZIHVuZGVjbGFyZWQgKGZpcnN0IHVzZSBpbiB0aGlzIGZ1bmN0 aW9uKTsgZGlkIHlvdSBtZWFuIOKAmHJhZGVvbl9leGl04oCZPwogIDY1MyB8IG1vZHVsZV9pbml0 KHJhZGVvbl9pbml0KTsKICB8IF5+fn5+fn5+fn5+CiAgaW5jbHVkZS9saW51eC9tb2R1bGUuaDox MzM6MTE6IG5vdGU6IGluIGRlZmluaXRpb24gb2YgbWFjcm8g4oCYbW9kdWxlX2luaXTigJkKICAx MzMgfCB7IHJldHVybiBpbml0Zm47IH0gfCBefn5+fn4KICBkcml2ZXJzL2dwdS9kcm0vcmFkZW9u L3JhZGVvbl9kcnYuYzo2NTM6MTM6IG5vdGU6IGVhY2ggdW5kZWNsYXJlZCBpZGVudGlmaWVyIGlz IHJlcG9ydGVkIG9ubHkgb25jZSBmb3IgZWFjaCBmdW5jdGlvbiBpdCBhcHBlYXJzIGluCiAgNjUz IHwgbW9kdWxlX2luaXQocmFkZW9uX2luaXQpOwogIHwgXn5+fn5+fn5+fn4KICBpbmNsdWRlL2xp bnV4L21vZHVsZS5oOjEzMzoxMTogbm90ZTogaW4gZGVmaW5pdGlvbiBvZiBtYWNybyDigJhtb2R1 bGVfaW5pdOKAmQogIDEzMyB8IHsgcmV0dXJuIGluaXRmbjsgfSB8IF5+fn5+fgogIEluIGZpbGUg aW5jbHVkZWQgZnJvbSBpbmNsdWRlL2xpbnV4L2NvbXBpbGVyX3R5cGVzLmg6NjUsCiAgZnJvbSA8 Y29tbWFuZC1saW5lPjoKICBkcml2ZXJzL2dwdS9kcm0vcmFkZW9uL3JhZGVvbl9kcnYuYzogQXQg dG9wIGxldmVsOgogIGRyaXZlcnMvZ3B1L2RybS9yYWRlb24vcmFkZW9uX2Rydi5jOjY1MzoxMzog ZXJyb3I6IOKAmHJhZGVvbl9pbml04oCZIHVuZGVjbGFyZWQgaGVyZSAobm90IGluIGEgZnVuY3Rp b24pOyBkaWQgeW91IG1lYW4g4oCYcmFkZW9uX2V4aXTigJk/CiAgNjUzIHwgbW9kdWxlX2luaXQo cmFkZW9uX2luaXQpOwogIHwgXn5+fn5+fn5+fn4KICBpbmNsdWRlL2xpbnV4L2NvbXBpbGVyX2F0 dHJpYnV0ZXMuaDoxMDk6NjU6IG5vdGU6IGluIGRlZmluaXRpb24gb2YgbWFjcm8g4oCYX19jb3B5 4oCZCiAgMTA5IHwgIyBkZWZpbmUgX19jb3B5KHN5bWJvbCkgX19hdHRyaWJ1dGVfXygoX19jb3B5 X18oc3ltYm9sKSkpCiAgfCBefn5+fn4KICBkcml2ZXJzL2dwdS9kcm0vcmFkZW9uL3JhZGVvbl9k cnYuYzo2NTM6MTogbm90ZTogaW4gZXhwYW5zaW9uIG9mIG1hY3JvIOKAmG1vZHVsZV9pbml04oCZ CiAgNjUzIHwgbW9kdWxlX2luaXQocmFkZW9uX2luaXQpOwogIHwgXn5+fn5+fn5+fn4KICBJbiBm aWxlIGluY2x1ZGVkIGZyb20gZHJpdmVycy9ncHUvZHJtL3JhZGVvbi9yYWRlb25fZHJ2LmM6MzU6 CiAgaW5jbHVkZS9saW51eC9tb2R1bGUuaDoxMzQ6NjogZXJyb3I6IOKAmGluaXRfbW9kdWxl4oCZ IGFsaWFzZWQgdG8gdW5kZWZpbmVkIHN5bWJvbCDigJhyYWRlb25faW5pdOKAmQogIDEzNCB8IGlu dCBpbml0X21vZHVsZSh2b2lkKSBfX2NvcHkoaW5pdGZuKSBfX2F0dHJpYnV0ZV9fKChhbGlhcygj aW5pdGZuKSkpOwogIHwgXn5+fn5+fn5+fn4KICBkcml2ZXJzL2dwdS9kcm0vcmFkZW9uL3JhZGVv bl9kcnYuYzo2NTM6MTogbm90ZTogaW4gZXhwYW5zaW9uIG9mIG1hY3JvIOKAmG1vZHVsZV9pbml0 4oCZCiAgNjUzIHwgbW9kdWxlX2luaXQocmFkZW9uX2luaXQpOwogIHwgXn5+fn5+fn5+fn4KCkhv dyB3b3VsZCB5b3UgbGlrZSBtZSB0byBtb3ZlIGZvcndhcmQ/CgotLSAKTGVlIEpvbmVzIFvmnY7n kLzmlq9dClNlbmlvciBUZWNobmljYWwgTGVhZCAtIERldmVsb3BlciBTZXJ2aWNlcwpMaW5hcm8u b3JnIOKUgiBPcGVuIHNvdXJjZSBzb2Z0d2FyZSBmb3IgQXJtIFNvQ3MKRm9sbG93IExpbmFybzog RmFjZWJvb2sgfCBUd2l0dGVyIHwgQmxvZwpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fXwphbWQtZ2Z4IG1haWxpbmcgbGlzdAphbWQtZ2Z4QGxpc3RzLmZyZWVk ZXNrdG9wLm9yZwpodHRwczovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZv L2FtZC1nZngK From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.5 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CEB19C388F7 for ; Mon, 9 Nov 2020 11:06:14 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 5452720897 for ; Mon, 9 Nov 2020 11:06:14 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="TKPmIbHz" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 5452720897 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id A8102898F5; Mon, 9 Nov 2020 11:06:13 +0000 (UTC) Received: from mail-wm1-x343.google.com (mail-wm1-x343.google.com [IPv6:2a00:1450:4864:20::343]) by gabe.freedesktop.org (Postfix) with ESMTPS id 9391189919 for ; Mon, 9 Nov 2020 11:06:12 +0000 (UTC) Received: by mail-wm1-x343.google.com with SMTP id c9so7573088wml.5 for ; Mon, 09 Nov 2020 03:06:12 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to; bh=/TTLN5u5ntD12Tf50xVKp1qDLZNw1PZvWBuHFthUL88=; b=TKPmIbHz/sJNchjhXki9tBdowYhfzhopEljHcLDYcu2bt52SrzWKjteWCU58KX353a /P/wKKssgcalNm6WMoiInsUU0tYzqmWTdvvP1x2IC4lMkbZRYpg+8gP5TNFHScYSbQbf zNFvHFuDW2gZ2fs7lZw50G9oLfMph4J7tRayNoOEWmnQba2vledcJcf/7z8jURCZlZ7a q1nHIvFPWzIZXH/8EdX8up20/kjt7+d1ENZ+xWOQBxc7IIpx9GwZzr2Y1ubWdpjsgzd2 Ul6YISZB4Gbk64r1IG9P7c6sH25ulfmr2nRzCJeRtHvEfs63vwtVjnue1xJMXbGaFrRS Tfug== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to; bh=/TTLN5u5ntD12Tf50xVKp1qDLZNw1PZvWBuHFthUL88=; b=mCc2Pzt8t/z0jHTbX0J5ca0vV2ee2kxxLNDzQ9QSb9OwFBXfRPx2GnD5G14Ei11uTY RK/HUVfTqPhP7kMNEL+/Oqf59otqG4aEv15gP4X09hb6goKm5o7JEto/jlFwGxHapKQm sl9tcOtIjFpncuGW3Wc0fmTx7wu4BlRb9R59me0ZAUvV+ym3llDlb7LzQ1qHjIAT0K+8 6x9ncXu4FzQ8bRoiaD2XfseM/2xGEbKAMv1fIYhaMcehIJ/dl/2FvrW8oCHD4Y1qy+cR 3hU8NrXgCxX9RwgoP1EzALzhhLTnGASh1qgvh0KsJisCrT4g17XZwITntR8D3zeuHLis UtZg== X-Gm-Message-State: AOAM532OV7LhLfalEQnM25YM8Efjco26J4i0DHFBtXlOkxaVdP1MH1cd KxhDacw7qpGqdCWkeMXS6mBMdQ== X-Google-Smtp-Source: ABdhPJwCQni2iqmE/lW8/SqfwjZzXNoAzBmb14stJp2vUaJpNmwq4rT99zQtmmQXUZir2cge7Fg/tA== X-Received: by 2002:a1c:67d5:: with SMTP id b204mr14273334wmc.92.1604919971242; Mon, 09 Nov 2020 03:06:11 -0800 (PST) Received: from dell ([91.110.221.180]) by smtp.gmail.com with ESMTPSA id h62sm13193538wrh.82.2020.11.09.03.06.07 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 09 Nov 2020 03:06:10 -0800 (PST) Date: Mon, 9 Nov 2020 11:06:03 +0000 From: Lee Jones To: Sam Ravnborg Subject: Re: [PATCH 10/19] drm/radeon/radeon: Move prototype into shared header Message-ID: <20201109110603.GV2063125@dell> References: <20201106214949.2042120-1-lee.jones@linaro.org> <20201106214949.2042120-11-lee.jones@linaro.org> <20201107142651.GA1014611@ravnborg.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20201107142651.GA1014611@ravnborg.org> X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: David Airlie , linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, linaro-mm-sig@lists.linaro.org, amd-gfx@lists.freedesktop.org, Alex Deucher , Christian =?iso-8859-1?Q?K=F6nig?= , linux-media@vger.kernel.org Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" T24gU2F0LCAwNyBOb3YgMjAyMCwgU2FtIFJhdm5ib3JnIHdyb3RlOgoKPiBIaSBMZWUsCj4gCj4g T24gRnJpLCBOb3YgMDYsIDIwMjAgYXQgMDk6NDk6NDBQTSArMDAwMCwgTGVlIEpvbmVzIHdyb3Rl Ogo+ID4gVW5mb3J0dW5hdGVseSwgYSBzdWl0YWJsZSBvbmUgZGlkbid0IGFscmVhZHkgZXhpc3Qu Cj4gPiAKPiA+IEZpeGVzIHRoZSBmb2xsb3dpbmcgVz0xIGtlcm5lbCBidWlsZCB3YXJuaW5nKHMp Ogo+ID4gCj4gPiAgZHJpdmVycy9ncHUvZHJtL3JhZGVvbi9yYWRlb25fZGV2aWNlLmM6NjM3OjY6 IHdhcm5pbmc6IG5vIHByZXZpb3VzIHByb3RvdHlwZSBmb3Ig4oCYcmFkZW9uX2RldmljZV9pc192 aXJ0dWFs4oCZIFstV21pc3NpbmctcHJvdG90eXBlc10KPiA+ICA2MzcgfCBib29sIHJhZGVvbl9k ZXZpY2VfaXNfdmlydHVhbCh2b2lkKQo+ID4gIHwgXn5+fn5+fn5+fn5+fn5+fn5+fn5+fn5+Cj4g PiAKPiA+IENjOiBBbGV4IERldWNoZXIgPGFsZXhhbmRlci5kZXVjaGVyQGFtZC5jb20+Cj4gPiBD YzogIkNocmlzdGlhbiBLw7ZuaWciIDxjaHJpc3RpYW4ua29lbmlnQGFtZC5jb20+Cj4gPiBDYzog RGF2aWQgQWlybGllIDxhaXJsaWVkQGxpbnV4LmllPgo+ID4gQ2M6IERhbmllbCBWZXR0ZXIgPGRh bmllbEBmZndsbC5jaD4KPiA+IENjOiBTdW1pdCBTZW13YWwgPHN1bWl0LnNlbXdhbEBsaW5hcm8u b3JnPgo+ID4gQ2M6IGFtZC1nZnhAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCj4gPiBDYzogZHJpLWRl dmVsQGxpc3RzLmZyZWVkZXNrdG9wLm9yZwo+ID4gQ2M6IGxpbnV4LW1lZGlhQHZnZXIua2VybmVs Lm9yZwo+ID4gQ2M6IGxpbmFyby1tbS1zaWdAbGlzdHMubGluYXJvLm9yZwo+ID4gU2lnbmVkLW9m Zi1ieTogTGVlIEpvbmVzIDxsZWUuam9uZXNAbGluYXJvLm9yZz4KPiA+IC0tLQo+ID4gIGRyaXZl cnMvZ3B1L2RybS9yYWRlb24vcmFkZW9uX2RldmljZS5jIHwgIDEgKwo+ID4gIGRyaXZlcnMvZ3B1 L2RybS9yYWRlb24vcmFkZW9uX2RldmljZS5oIHwgMzIgKysrKysrKysrKysrKysrKysrKysrKysr KysKPiA+ICBkcml2ZXJzL2dwdS9kcm0vcmFkZW9uL3JhZGVvbl9kcnYuYyAgICB8ICAzICstLQo+ ID4gIDMgZmlsZXMgY2hhbmdlZCwgMzQgaW5zZXJ0aW9ucygrKSwgMiBkZWxldGlvbnMoLSkKPiA+ ICBjcmVhdGUgbW9kZSAxMDA2NDQgZHJpdmVycy9ncHUvZHJtL3JhZGVvbi9yYWRlb25fZGV2aWNl LmgKPiAKPiBPdGhlciBwdWJsaWMgZnVuY3Rpb25zIGluIHJhZGVvbl9kZXZpY2UuYyBoYXZlIHRo ZWlyIHByb3RvdHlwZSBpbgo+IHJhZGVvbi5oIC0gZm9yIGV4YW1wbGUgcmFkZW9uX2lzX3B4KCkK PiAKPiBBZGQgcmFkZW9uX2RldmljZV9pc192aXJ0dWFsKCkgdGhlcmUgc28gd2UgYXZvaWlkIHRo aXMgbmV3IGhlYWRlci4KCk9oIHllcywgSSByZW1lbWJlciB3aHkgdGhpcyB3YXNuJ3QgYSBzdWl0 YWJsZSBzb2x1dGlvbiBub3c6CgpUaGUgbWFjcm8gInJhZGVvbl9pbml0IiBpbiByYWRlb24uaCBj bGFzaGVzIHdpdGggdGhlIGluaXQgZnVuY3Rpb24gb2YKdGhlIHNhbWUgbmFtZSBpbiByYWRlb25f ZHJ2LmM6CgogIEluIGZpbGUgaW5jbHVkZWQgZnJvbSBkcml2ZXJzL2dwdS9kcm0vcmFkZW9uL3Jh ZGVvbl9kcnYuYzo1MzoKICBkcml2ZXJzL2dwdS9kcm0vcmFkZW9uL3JhZGVvbl9kcnYuYzo2MjA6 MzE6IGVycm9yOiBleHBlY3RlZCBpZGVudGlmaWVyIG9yIOKAmCjigJkgYmVmb3JlIOKAmHZvaWTi gJkKICA2MjAgfCBzdGF0aWMgaW50IF9faW5pdCByYWRlb25faW5pdCh2b2lkKQogIHwgXn5+fgog IGRyaXZlcnMvZ3B1L2RybS9yYWRlb24vcmFkZW9uLmg6MjcwNToyODogbm90ZTogaW4gZGVmaW5p dGlvbiBvZiBtYWNybyDigJhyYWRlb25faW5pdOKAmQogIDI3MDUgfCAjZGVmaW5lIHJhZGVvbl9p bml0KHJkZXYpIChyZGV2KS0+YXNpYy0+aW5pdCgocmRldikpCiAgfCBefn5+CiAgSW4gZmlsZSBp bmNsdWRlZCBmcm9tIGRyaXZlcnMvZ3B1L2RybS9yYWRlb24vcmFkZW9uX2Rydi5jOjM1OgogIGRy aXZlcnMvZ3B1L2RybS9yYWRlb24vcmFkZW9uX2Rydi5jOiBJbiBmdW5jdGlvbiDigJhfX2luaXR0 ZXN04oCZOgogIGRyaXZlcnMvZ3B1L2RybS9yYWRlb24vcmFkZW9uX2Rydi5jOjY1MzoxMzogZXJy b3I6IOKAmHJhZGVvbl9pbml04oCZIHVuZGVjbGFyZWQgKGZpcnN0IHVzZSBpbiB0aGlzIGZ1bmN0 aW9uKTsgZGlkIHlvdSBtZWFuIOKAmHJhZGVvbl9leGl04oCZPwogIDY1MyB8IG1vZHVsZV9pbml0 KHJhZGVvbl9pbml0KTsKICB8IF5+fn5+fn5+fn5+CiAgaW5jbHVkZS9saW51eC9tb2R1bGUuaDox MzM6MTE6IG5vdGU6IGluIGRlZmluaXRpb24gb2YgbWFjcm8g4oCYbW9kdWxlX2luaXTigJkKICAx MzMgfCB7IHJldHVybiBpbml0Zm47IH0gfCBefn5+fn4KICBkcml2ZXJzL2dwdS9kcm0vcmFkZW9u L3JhZGVvbl9kcnYuYzo2NTM6MTM6IG5vdGU6IGVhY2ggdW5kZWNsYXJlZCBpZGVudGlmaWVyIGlz IHJlcG9ydGVkIG9ubHkgb25jZSBmb3IgZWFjaCBmdW5jdGlvbiBpdCBhcHBlYXJzIGluCiAgNjUz IHwgbW9kdWxlX2luaXQocmFkZW9uX2luaXQpOwogIHwgXn5+fn5+fn5+fn4KICBpbmNsdWRlL2xp bnV4L21vZHVsZS5oOjEzMzoxMTogbm90ZTogaW4gZGVmaW5pdGlvbiBvZiBtYWNybyDigJhtb2R1 bGVfaW5pdOKAmQogIDEzMyB8IHsgcmV0dXJuIGluaXRmbjsgfSB8IF5+fn5+fgogIEluIGZpbGUg aW5jbHVkZWQgZnJvbSBpbmNsdWRlL2xpbnV4L2NvbXBpbGVyX3R5cGVzLmg6NjUsCiAgZnJvbSA8 Y29tbWFuZC1saW5lPjoKICBkcml2ZXJzL2dwdS9kcm0vcmFkZW9uL3JhZGVvbl9kcnYuYzogQXQg dG9wIGxldmVsOgogIGRyaXZlcnMvZ3B1L2RybS9yYWRlb24vcmFkZW9uX2Rydi5jOjY1MzoxMzog ZXJyb3I6IOKAmHJhZGVvbl9pbml04oCZIHVuZGVjbGFyZWQgaGVyZSAobm90IGluIGEgZnVuY3Rp b24pOyBkaWQgeW91IG1lYW4g4oCYcmFkZW9uX2V4aXTigJk/CiAgNjUzIHwgbW9kdWxlX2luaXQo cmFkZW9uX2luaXQpOwogIHwgXn5+fn5+fn5+fn4KICBpbmNsdWRlL2xpbnV4L2NvbXBpbGVyX2F0 dHJpYnV0ZXMuaDoxMDk6NjU6IG5vdGU6IGluIGRlZmluaXRpb24gb2YgbWFjcm8g4oCYX19jb3B5 4oCZCiAgMTA5IHwgIyBkZWZpbmUgX19jb3B5KHN5bWJvbCkgX19hdHRyaWJ1dGVfXygoX19jb3B5 X18oc3ltYm9sKSkpCiAgfCBefn5+fn4KICBkcml2ZXJzL2dwdS9kcm0vcmFkZW9uL3JhZGVvbl9k cnYuYzo2NTM6MTogbm90ZTogaW4gZXhwYW5zaW9uIG9mIG1hY3JvIOKAmG1vZHVsZV9pbml04oCZ CiAgNjUzIHwgbW9kdWxlX2luaXQocmFkZW9uX2luaXQpOwogIHwgXn5+fn5+fn5+fn4KICBJbiBm aWxlIGluY2x1ZGVkIGZyb20gZHJpdmVycy9ncHUvZHJtL3JhZGVvbi9yYWRlb25fZHJ2LmM6MzU6 CiAgaW5jbHVkZS9saW51eC9tb2R1bGUuaDoxMzQ6NjogZXJyb3I6IOKAmGluaXRfbW9kdWxl4oCZ IGFsaWFzZWQgdG8gdW5kZWZpbmVkIHN5bWJvbCDigJhyYWRlb25faW5pdOKAmQogIDEzNCB8IGlu dCBpbml0X21vZHVsZSh2b2lkKSBfX2NvcHkoaW5pdGZuKSBfX2F0dHJpYnV0ZV9fKChhbGlhcygj aW5pdGZuKSkpOwogIHwgXn5+fn5+fn5+fn4KICBkcml2ZXJzL2dwdS9kcm0vcmFkZW9uL3JhZGVv bl9kcnYuYzo2NTM6MTogbm90ZTogaW4gZXhwYW5zaW9uIG9mIG1hY3JvIOKAmG1vZHVsZV9pbml0 4oCZCiAgNjUzIHwgbW9kdWxlX2luaXQocmFkZW9uX2luaXQpOwogIHwgXn5+fn5+fn5+fn4KCkhv dyB3b3VsZCB5b3UgbGlrZSBtZSB0byBtb3ZlIGZvcndhcmQ/CgotLSAKTGVlIEpvbmVzIFvmnY7n kLzmlq9dClNlbmlvciBUZWNobmljYWwgTGVhZCAtIERldmVsb3BlciBTZXJ2aWNlcwpMaW5hcm8u b3JnIOKUgiBPcGVuIHNvdXJjZSBzb2Z0d2FyZSBmb3IgQXJtIFNvQ3MKRm9sbG93IExpbmFybzog RmFjZWJvb2sgfCBUd2l0dGVyIHwgQmxvZwpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fXwpkcmktZGV2ZWwgbWFpbGluZyBsaXN0CmRyaS1kZXZlbEBsaXN0cy5m cmVlZGVza3RvcC5vcmcKaHR0cHM6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0 aW5mby9kcmktZGV2ZWwK From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 86A73C4741F for ; Mon, 9 Nov 2020 11:06:17 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 27D632222B for ; Mon, 9 Nov 2020 11:06:17 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="TKPmIbHz" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729302AbgKILGN (ORCPT ); Mon, 9 Nov 2020 06:06:13 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59342 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727774AbgKILGM (ORCPT ); Mon, 9 Nov 2020 06:06:12 -0500 Received: from mail-wm1-x343.google.com (mail-wm1-x343.google.com [IPv6:2a00:1450:4864:20::343]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 8162DC0613D3 for ; Mon, 9 Nov 2020 03:06:12 -0800 (PST) Received: by mail-wm1-x343.google.com with SMTP id p22so7569195wmg.3 for ; Mon, 09 Nov 2020 03:06:12 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to; bh=/TTLN5u5ntD12Tf50xVKp1qDLZNw1PZvWBuHFthUL88=; b=TKPmIbHz/sJNchjhXki9tBdowYhfzhopEljHcLDYcu2bt52SrzWKjteWCU58KX353a /P/wKKssgcalNm6WMoiInsUU0tYzqmWTdvvP1x2IC4lMkbZRYpg+8gP5TNFHScYSbQbf zNFvHFuDW2gZ2fs7lZw50G9oLfMph4J7tRayNoOEWmnQba2vledcJcf/7z8jURCZlZ7a q1nHIvFPWzIZXH/8EdX8up20/kjt7+d1ENZ+xWOQBxc7IIpx9GwZzr2Y1ubWdpjsgzd2 Ul6YISZB4Gbk64r1IG9P7c6sH25ulfmr2nRzCJeRtHvEfs63vwtVjnue1xJMXbGaFrRS Tfug== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to; bh=/TTLN5u5ntD12Tf50xVKp1qDLZNw1PZvWBuHFthUL88=; b=sIQRykMOe4LOtaNpa2gChpD85+BUo+7BdrlXfOngFS8t6BxFCpntWW9vyQwX0uQq2H h1EdT0NlC1lI3psKS5Gn3zH8iU2ZzB69dj0VvizaMFR6gxDtsT0sy/RCVTNO2a5mDW4L SZFTAOBD0nHGEdEzj+af6/q46tUlOx12UJuPdDZrWBwvxzSyfYmSy3YOA8SSwNlKOV1L t191ib+4gKnumTZNwCRsdzZo8PAzRCaKf6q6FqXwb6scbzUST9PgPlw/XFiKsR4fDMsW BDa67QcuD54eWCOoNFnc6OMs2/8AvLu8XedcLI745edW6ySsdyQeBjgPIcjzGRZOSOXU cWhA== X-Gm-Message-State: AOAM532WD9MDp2q1GI5odH+YahpLPfL0RZYfVvCVitKnX2GlYJsMCqzk 2Lg5A4DPqes+lwmGms8wZpybsg== X-Google-Smtp-Source: ABdhPJwCQni2iqmE/lW8/SqfwjZzXNoAzBmb14stJp2vUaJpNmwq4rT99zQtmmQXUZir2cge7Fg/tA== X-Received: by 2002:a1c:67d5:: with SMTP id b204mr14273334wmc.92.1604919971242; Mon, 09 Nov 2020 03:06:11 -0800 (PST) Received: from dell ([91.110.221.180]) by smtp.gmail.com with ESMTPSA id h62sm13193538wrh.82.2020.11.09.03.06.07 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 09 Nov 2020 03:06:10 -0800 (PST) Date: Mon, 9 Nov 2020 11:06:03 +0000 From: Lee Jones To: Sam Ravnborg Cc: David Airlie , linux-kernel@vger.kernel.org, amd-gfx@lists.freedesktop.org, Christian =?iso-8859-1?Q?K=F6nig?= , linaro-mm-sig@lists.linaro.org, dri-devel@lists.freedesktop.org, Alex Deucher , linux-media@vger.kernel.org Subject: Re: [PATCH 10/19] drm/radeon/radeon: Move prototype into shared header Message-ID: <20201109110603.GV2063125@dell> References: <20201106214949.2042120-1-lee.jones@linaro.org> <20201106214949.2042120-11-lee.jones@linaro.org> <20201107142651.GA1014611@ravnborg.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20201107142651.GA1014611@ravnborg.org> Precedence: bulk List-ID: X-Mailing-List: linux-media@vger.kernel.org On Sat, 07 Nov 2020, Sam Ravnborg wrote: > Hi Lee, > > On Fri, Nov 06, 2020 at 09:49:40PM +0000, Lee Jones wrote: > > Unfortunately, a suitable one didn't already exist. > > > > Fixes the following W=1 kernel build warning(s): > > > > drivers/gpu/drm/radeon/radeon_device.c:637:6: warning: no previous prototype for ‘radeon_device_is_virtual’ [-Wmissing-prototypes] > > 637 | bool radeon_device_is_virtual(void) > > | ^~~~~~~~~~~~~~~~~~~~~~~~ > > > > Cc: Alex Deucher > > Cc: "Christian König" > > Cc: David Airlie > > Cc: Daniel Vetter > > Cc: Sumit Semwal > > Cc: amd-gfx@lists.freedesktop.org > > Cc: dri-devel@lists.freedesktop.org > > Cc: linux-media@vger.kernel.org > > Cc: linaro-mm-sig@lists.linaro.org > > Signed-off-by: Lee Jones > > --- > > drivers/gpu/drm/radeon/radeon_device.c | 1 + > > drivers/gpu/drm/radeon/radeon_device.h | 32 ++++++++++++++++++++++++++ > > drivers/gpu/drm/radeon/radeon_drv.c | 3 +-- > > 3 files changed, 34 insertions(+), 2 deletions(-) > > create mode 100644 drivers/gpu/drm/radeon/radeon_device.h > > Other public functions in radeon_device.c have their prototype in > radeon.h - for example radeon_is_px() > > Add radeon_device_is_virtual() there so we avoiid this new header. Oh yes, I remember why this wasn't a suitable solution now: The macro "radeon_init" in radeon.h clashes with the init function of the same name in radeon_drv.c: In file included from drivers/gpu/drm/radeon/radeon_drv.c:53: drivers/gpu/drm/radeon/radeon_drv.c:620:31: error: expected identifier or ‘(’ before ‘void’ 620 | static int __init radeon_init(void) | ^~~~ drivers/gpu/drm/radeon/radeon.h:2705:28: note: in definition of macro ‘radeon_init’ 2705 | #define radeon_init(rdev) (rdev)->asic->init((rdev)) | ^~~~ In file included from drivers/gpu/drm/radeon/radeon_drv.c:35: drivers/gpu/drm/radeon/radeon_drv.c: In function ‘__inittest’: drivers/gpu/drm/radeon/radeon_drv.c:653:13: error: ‘radeon_init’ undeclared (first use in this function); did you mean ‘radeon_exit’? 653 | module_init(radeon_init); | ^~~~~~~~~~~ include/linux/module.h:133:11: note: in definition of macro ‘module_init’ 133 | { return initfn; } | ^~~~~~ drivers/gpu/drm/radeon/radeon_drv.c:653:13: note: each undeclared identifier is reported only once for each function it appears in 653 | module_init(radeon_init); | ^~~~~~~~~~~ include/linux/module.h:133:11: note: in definition of macro ‘module_init’ 133 | { return initfn; } | ^~~~~~ In file included from include/linux/compiler_types.h:65, from : drivers/gpu/drm/radeon/radeon_drv.c: At top level: drivers/gpu/drm/radeon/radeon_drv.c:653:13: error: ‘radeon_init’ undeclared here (not in a function); did you mean ‘radeon_exit’? 653 | module_init(radeon_init); | ^~~~~~~~~~~ include/linux/compiler_attributes.h:109:65: note: in definition of macro ‘__copy’ 109 | # define __copy(symbol) __attribute__((__copy__(symbol))) | ^~~~~~ drivers/gpu/drm/radeon/radeon_drv.c:653:1: note: in expansion of macro ‘module_init’ 653 | module_init(radeon_init); | ^~~~~~~~~~~ In file included from drivers/gpu/drm/radeon/radeon_drv.c:35: include/linux/module.h:134:6: error: ‘init_module’ aliased to undefined symbol ‘radeon_init’ 134 | int init_module(void) __copy(initfn) __attribute__((alias(#initfn))); | ^~~~~~~~~~~ drivers/gpu/drm/radeon/radeon_drv.c:653:1: note: in expansion of macro ‘module_init’ 653 | module_init(radeon_init); | ^~~~~~~~~~~ How would you like me to move forward? -- Lee Jones [李琼斯] Senior Technical Lead - Developer Services Linaro.org │ Open source software for Arm SoCs Follow Linaro: Facebook | Twitter | Blog