From: Florian Westphal <fw at strlen.de>
To: mptcp at lists.01.org
Subject: [MPTCP] Re: [PATCH MPTCP 1/5] tcp: make two mptcp helpers available to tcp stack
Date: Mon, 09 Nov 2020 15:51:25 +0100 [thread overview]
Message-ID: <20201109145125.GD23619@breakpoint.cc> (raw)
In-Reply-To: CA+WQbwuy3+ivf=WB6c5b18NduzS8Fg2Wv8DAuGXmM-7Z3G5sKg@mail.gmail.com
[-- Attachment #1: Type: text/plain, Size: 655 bytes --]
Geliang Tang <geliangtang(a)gmail.com> wrote:
> > +static inline __be32 mptcp_option(u8 subopt, u8 len, u8 nib, u8 field)
> > +{
> > + return htonl((TCPOPT_MPTCP << 24) | (len << 16) | (subopt << 12) |
> > + ((nib & 0xF) << 8) | field);
> > +}
>
> I think we should avoid adding code in tcp.h, should it be better to define a
> wrapper function of mptcp_option(MPTCPOPT_RST, TCPOLEN_MPTCP_RST, ..., ...)
> in net/mptcp/options.c and export it in include/net/mptcp.h? ... ...
Can be done but it adds a function call to create a 32 bit number.
Sending RST isn't performance critical so it could be done that way too.
next reply other threads:[~2020-11-09 14:51 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-09 14:51 Florian Westphal [this message]
-- strict thread matches above, loose matches on Subject: below --
2020-11-09 4:54 [MPTCP] Re: [PATCH MPTCP 1/5] tcp: make two mptcp helpers available to tcp stack Geliang Tang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201109145125.GD23619@breakpoint.cc \
--to=unknown@example.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.