From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.6 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9FEF4C55ABD for ; Mon, 9 Nov 2020 17:18:04 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 1EFE4221F9 for ; Mon, 9 Nov 2020 17:18:03 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="Rgu23x6W" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 1EFE4221F9 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 5272689B42; Mon, 9 Nov 2020 17:18:03 +0000 (UTC) Received: from mail-wr1-x442.google.com (mail-wr1-x442.google.com [IPv6:2a00:1450:4864:20::442]) by gabe.freedesktop.org (Postfix) with ESMTPS id E05F889B42 for ; Mon, 9 Nov 2020 17:18:01 +0000 (UTC) Received: by mail-wr1-x442.google.com with SMTP id j7so2289074wrp.3 for ; Mon, 09 Nov 2020 09:18:01 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to; bh=pupQObYmQEtHTXVN7G7VurpDOLGGYw2zG5xqU4Y7meA=; b=Rgu23x6Wa5spdDHboUtOo7j/CazI9cyGc5s5MjjvOIiGx49lA7jsVIybw8c9300iEl IHbNRpcF/glLYizIlMVmP73hLsvF7kiqYx+WlSCwJkiT4BwVDFBOLKFmQtl6XpPBHbjS 6vW2c66R3+hEMIe2mRWcg8mvI+LPkyqQzex245p9wJGAnTWuHBb95AUrr9b6cxYB/2wU jrdwFa8Zy1PNeRg4cf8GZr/+sfnVRtOHVzoeSl6EvtNWdQLjFwE+4WuUTrZjK1NAqtGx vOmdXnMP+gxGR3v4EdZJ6zuEqbMqDdsQnoiM7xFUAiQPYpjH+/P1XkmmU5jxvKKgUcC0 TG/w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to; bh=pupQObYmQEtHTXVN7G7VurpDOLGGYw2zG5xqU4Y7meA=; b=KQk0wfe/30BFc7xSCWtgBfrcbmLA6EeoMIYxkvoAfxcQwlN7d0e8JZmJmeiLSkzlja FXfkgZbWbWhimKxexl/JOsfy9F6MgsxfkgZaj5I8DlB6mPATMEmWlG98kpXG70VzryEx sp+si8EDOOKQd7GtXgOgrF4p380Nrm30jOkol5sRfujvZQtfFAt3R88kpyFPQCfECF8M qvcwgwM+xT2sSAWcmQYiB2cDD8grMhxfErOHqIdAuutzJZF7rpgSFxEQu4shF2+RDFQl YwkT12PRdoPC7j94jUJ/VufKDrTmW7ePOj71IsYwzBhUYl+al/KqZKE3zMKeJLWPtwXA LzHg== X-Gm-Message-State: AOAM5326kb8nrE3dRXe25wiZ6mUzk3dIDt4vLcw+M/m3C+550NgDWpKe tQdp9wcTOACg6Fg6fl6r0dDZgA== X-Google-Smtp-Source: ABdhPJxVpcnhhKw4+HYsJ4c7hCat9vFVLF5ci5YzUbDbVnH7wGQHjAINH4wGbFi2Tru601OdJ/MOCg== X-Received: by 2002:a5d:4ac1:: with SMTP id y1mr19713270wrs.27.1604942280560; Mon, 09 Nov 2020 09:18:00 -0800 (PST) Received: from dell ([91.110.221.180]) by smtp.gmail.com with ESMTPSA id n123sm55069wmn.38.2020.11.09.09.17.59 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 09 Nov 2020 09:17:59 -0800 (PST) Date: Mon, 9 Nov 2020 17:17:56 +0000 From: Lee Jones To: Ville =?iso-8859-1?Q?Syrj=E4l=E4?= Subject: Re: [PATCH 14/19] gpu: drm: selftests: test-drm_dp_mst_helper: Place 'struct drm_dp_sideband_msg_req_body' onto the heap Message-ID: <20201109171756.GA2063125@dell> References: <20201105144517.1826692-1-lee.jones@linaro.org> <20201105144517.1826692-15-lee.jones@linaro.org> <20201109151937.GF6112@intel.com> <20201109161258.GX2063125@dell> <20201109162015.GH6112@intel.com> <20201109164004.GZ2063125@dell> <20201109170324.GJ6112@intel.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20201109170324.GJ6112@intel.com> X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: David Airlie , David Francis , linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" T24gTW9uLCAwOSBOb3YgMjAyMCwgVmlsbGUgU3lyasOkbMOkIHdyb3RlOgoKPiBPbiBNb24sIE5v diAwOSwgMjAyMCBhdCAwNDo0MDowNFBNICswMDAwLCBMZWUgSm9uZXMgd3JvdGU6Cj4gPiBPbiBN b24sIDA5IE5vdiAyMDIwLCBWaWxsZSBTeXJqw6Rsw6Qgd3JvdGU6Cj4gPiAKPiA+ID4gT24gTW9u LCBOb3YgMDksIDIwMjAgYXQgMDQ6MTI6NThQTSArMDAwMCwgTGVlIEpvbmVzIHdyb3RlOgo+ID4g PiA+IE9uIE1vbiwgMDkgTm92IDIwMjAsIFZpbGxlIFN5cmrDpGzDpCB3cm90ZToKPiA+ID4gPiAK PiA+ID4gPiA+IE9uIFRodSwgTm92IDA1LCAyMDIwIGF0IDAyOjQ1OjEyUE0gKzAwMDAsIExlZSBK b25lcyB3cm90ZToKPiA+ID4gPiA+ID4gVGhlIHN0YWNrIGlzIHRvbyBmdWxsLgo+ID4gPiA+ID4g PiAKPiA+ID4gPiA+ID4gRml4ZXMgdGhlIGZvbGxvd2luZyBXPTEga2VybmVsIGJ1aWxkIHdhcm5p bmcocyk6Cj4gPiA+ID4gPiA+IAo+ID4gPiA+ID4gPiAgZHJpdmVycy9ncHUvZHJtL3NlbGZ0ZXN0 cy90ZXN0LWRybV9kcF9tc3RfaGVscGVyLmM6IEluIGZ1bmN0aW9uIOKAmHNpZGViYW5kX21zZ19y ZXFfZW5jb2RlX2RlY29kZeKAmToKPiA+ID4gPiA+ID4gIGRyaXZlcnMvZ3B1L2RybS9zZWxmdGVz dHMvdGVzdC1kcm1fZHBfbXN0X2hlbHBlci5jOjE2MToxOiB3YXJuaW5nOiB0aGUgZnJhbWUgc2l6 ZSBvZiAxMTc2IGJ5dGVzIGlzIGxhcmdlciB0aGFuIDEwMjQgYnl0ZXMgWy1XZnJhbWUtbGFyZ2Vy LXRoYW49XQo+ID4gPiA+ID4gPiAKPiA+ID4gPiA+ID4gQ2M6IERhdmlkIEFpcmxpZSA8YWlybGll ZEBsaW51eC5pZT4KPiA+ID4gPiA+ID4gQ2M6IERhbmllbCBWZXR0ZXIgPGRhbmllbEBmZndsbC5j aD4KPiA+ID4gPiA+ID4gQ2M6IEx5dWRlIFBhdWwgPGx5dWRlQHJlZGhhdC5jb20+Cj4gPiA+ID4g PiA+IENjOiBEYXZpZCBGcmFuY2lzIDxEYXZpZC5GcmFuY2lzQGFtZC5jb20+Cj4gPiA+ID4gPiA+ IENjOiBkcmktZGV2ZWxAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCj4gPiA+ID4gPiA+IFNpZ25lZC1v ZmYtYnk6IExlZSBKb25lcyA8bGVlLmpvbmVzQGxpbmFyby5vcmc+Cj4gPiA+ID4gPiA+IC0tLQo+ ID4gPiA+ID4gPiAgLi4uL2RybS9zZWxmdGVzdHMvdGVzdC1kcm1fZHBfbXN0X2hlbHBlci5jICAg IHwgMjkgKysrKysrKysrKysrLS0tLS0tLQo+ID4gPiA+ID4gPiAgMSBmaWxlIGNoYW5nZWQsIDE4 IGluc2VydGlvbnMoKyksIDExIGRlbGV0aW9ucygtKQo+ID4gPiA+ID4gPiAKPiA+ID4gPiA+ID4g ZGlmZiAtLWdpdCBhL2RyaXZlcnMvZ3B1L2RybS9zZWxmdGVzdHMvdGVzdC1kcm1fZHBfbXN0X2hl bHBlci5jIGIvZHJpdmVycy9ncHUvZHJtL3NlbGZ0ZXN0cy90ZXN0LWRybV9kcF9tc3RfaGVscGVy LmMKPiA+ID4gPiA+ID4gaW5kZXggMWQ2OTZlYzAwMWNmZi4uMGE1Mzk0NTZmNjg2NCAxMDA2NDQK PiA+ID4gPiA+ID4gLS0tIGEvZHJpdmVycy9ncHUvZHJtL3NlbGZ0ZXN0cy90ZXN0LWRybV9kcF9t c3RfaGVscGVyLmMKPiA+ID4gPiA+ID4gKysrIGIvZHJpdmVycy9ncHUvZHJtL3NlbGZ0ZXN0cy90 ZXN0LWRybV9kcF9tc3RfaGVscGVyLmMKPiA+ID4gPiA+ID4gQEAgLTEyMCw0NCArMTIwLDUxIEBA IHNpZGViYW5kX21zZ19yZXFfZXF1YWwoY29uc3Qgc3RydWN0IGRybV9kcF9zaWRlYmFuZF9tc2df cmVxX2JvZHkgKmluLAo+ID4gPiA+ID4gPiAgc3RhdGljIGJvb2wKPiA+ID4gPiA+ID4gIHNpZGVi YW5kX21zZ19yZXFfZW5jb2RlX2RlY29kZShzdHJ1Y3QgZHJtX2RwX3NpZGViYW5kX21zZ19yZXFf Ym9keSAqaW4pCj4gPiA+ID4gPiA+ICB7Cj4gPiA+ID4gPiA+IC0Jc3RydWN0IGRybV9kcF9zaWRl YmFuZF9tc2dfcmVxX2JvZHkgb3V0ID0gezB9Owo+ID4gPiA+ID4gPiArCXN0cnVjdCBkcm1fZHBf c2lkZWJhbmRfbXNnX3JlcV9ib2R5ICpvdXQ7Cj4gPiA+ID4gPiAKPiA+ID4gPiA+IEhvdyBiaWcg aXMgaXQ/IEFuZCB3aHkgaXMgaXQgdGhhdCBiaWc/Cj4gPiA+ID4gCj4gPiA+ID4gSXQncyBhIHN0 cnVjdCBvZiBhIHVuaW9uIG9mIHN0cnVjdHMuCj4gPiA+ID4gCj4gPiA+ID4gQW5kIGl0J3MgYWxs IGFsbG9jYXRlZCBvbiB0aGUgc3RhY2suICBCYWQgbmV3cyEKPiA+ID4gCj4gPiA+IFRoYXQgZG9l c24ndCBhbnN3ZXIgbXkgcXVlc3Rpb25zLgo+ID4gCj4gPiBJdCBhbnN3ZXJzIHRoZSBzZWNvbmQg cXVlc3Rpb24uCj4gCj4gTm90IHJlYWxseS4gQSBjb21iaW5hdGlvbiBvZiBzdHJ1Y3RzIGFuZCB1 bmlvbnMgY291bGQgYmUKPiBwcmV0dHkgbXVjaCBhbnkgc2l6ZS4KPiAKPiA+IAo+ID4gVGhlIGFu c3dlciB0byB0aGUgZmlyc3QgcXVlc3Rpb24geW91IGNhbiBgZ3JlcGAgZm9yIHlvdXJzZWxmLiA7 KQo+IAo+IEkgd291bGQgcmF0aGVyIHJ1biBwYWhvbGUgb24gaXQuIEJ1dCB3aHkgd291bGQgeW91 IHJlcXVpcmUKPiByZXZpZXdlcnMgdG8ganVtcCB0aHJvdWdoIHN1Y2ggZXh0cmEgaG9vcHMgd2hl biB5b3UgY291bGQKPiBqdXN0IHB1dCB0aGF0IGluZm9ybWF0aW9uIGludG8gdGhlIGNvbW1pdCBt ZXNzYWdlPyBXaXRoIHRoYXQKPiBhbnlvbmUgY291bGQgcmV2aWV3IHRoaXMgd2l0aG91dCBoYXZp bmcgdG8gZG8gYSBsb3Qgb2YgZXh0cmEKPiB3b3JrLgoKQmVjYXVzZSB0aGUgZXhhY3QgbnVtYmVy cyBhcmVuJ3QgYWxsIHRoYXQgcmVsZXZhbnQuCgpCZWZvcmUgdGhlIHBhdGNoIGlzIGFwcGxpZWQs IHRoZSBsb2NhbCB2YXJpYWJsZXMgdGFrZSB0aGUgZnJhbWUgc2l6ZQpvdmVyIHRoZSBhY2NlcHRl ZCB0aHJlc2hvbGQuICBUaGUgcGF0Y2ggYnJpbmdzIHRoZSBzaXplIGJhY2sgZG93biB0bwphbiBh Y2NlcHRlZCBsZXZlbC4KCkknbSBub3QgYWN0dWFsbHkgYXdhcmUgb2YgdGhlIGV4YWN0IG51bWJl cnMsIGJ1dCB5b3UgY2FuIHNlZSBieSB0YWtpbmcKYSBxdWljayBsb29rIHRoYXQgJ3N0cnVjdCBk cm1fZHBfc2lkZWJhbmRfbXNnX3JlcV9ib2R5JyBpcyBsYXJnZQplbm91Z2ggdG8gbWFrZSBhIHNp Z25pZmljYW50IGltcHJvdmVtZW50IG9uY2Ugc2hpZnRlZCBvbnRvIHRoZSBoZWFwLgoKLS0gCkxl ZSBKb25lcyBb5p2O55C85pavXQpTZW5pb3IgVGVjaG5pY2FsIExlYWQgLSBEZXZlbG9wZXIgU2Vy dmljZXMKTGluYXJvLm9yZyDilIIgT3BlbiBzb3VyY2Ugc29mdHdhcmUgZm9yIEFybSBTb0NzCkZv bGxvdyBMaW5hcm86IEZhY2Vib29rIHwgVHdpdHRlciB8IEJsb2cKX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX18KZHJpLWRldmVsIG1haWxpbmcgbGlzdApkcmkt ZGV2ZWxAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3Jn L21haWxtYW4vbGlzdGluZm8vZHJpLWRldmVsCg== From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6E57EC2D0A3 for ; Mon, 9 Nov 2020 17:18:04 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 081DD21D93 for ; Mon, 9 Nov 2020 17:18:03 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="Rgu23x6W" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730292AbgKIRSC (ORCPT ); Mon, 9 Nov 2020 12:18:02 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:32878 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729432AbgKIRSC (ORCPT ); Mon, 9 Nov 2020 12:18:02 -0500 Received: from mail-wr1-x441.google.com (mail-wr1-x441.google.com [IPv6:2a00:1450:4864:20::441]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E87D9C0613CF for ; Mon, 9 Nov 2020 09:18:01 -0800 (PST) Received: by mail-wr1-x441.google.com with SMTP id l1so5130638wrb.9 for ; Mon, 09 Nov 2020 09:18:01 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to; bh=pupQObYmQEtHTXVN7G7VurpDOLGGYw2zG5xqU4Y7meA=; b=Rgu23x6Wa5spdDHboUtOo7j/CazI9cyGc5s5MjjvOIiGx49lA7jsVIybw8c9300iEl IHbNRpcF/glLYizIlMVmP73hLsvF7kiqYx+WlSCwJkiT4BwVDFBOLKFmQtl6XpPBHbjS 6vW2c66R3+hEMIe2mRWcg8mvI+LPkyqQzex245p9wJGAnTWuHBb95AUrr9b6cxYB/2wU jrdwFa8Zy1PNeRg4cf8GZr/+sfnVRtOHVzoeSl6EvtNWdQLjFwE+4WuUTrZjK1NAqtGx vOmdXnMP+gxGR3v4EdZJ6zuEqbMqDdsQnoiM7xFUAiQPYpjH+/P1XkmmU5jxvKKgUcC0 TG/w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to; bh=pupQObYmQEtHTXVN7G7VurpDOLGGYw2zG5xqU4Y7meA=; b=IC+SQf4i2r2oj0tVAku+p6hRPjn6k7EwUXrvgufUK2GdvCZ3Nml+Fffw7L1eVbrHFr FKlGwJFyg33ZA3aFEuOdRCrmN4ljYgbc/INuAjm1bTf2jMmJYJLxKAKjJoW6O3Df1bQ4 kCs/DNBhvn1wKPtNnEwKsff2Xlw3zee2qESneYKLhL0TiHND/qZlml11J+voANN5iPj2 BnTLc0GzOiPHouu4B4XECURMf8W1YajKRzaHnWncaZYf8Es5qWHFzEihiazVlQkYrYiB qgiqhabPKMOWq1jeU8vTI9PjE7MS7ds4fieaJ1vkYndS5/aHRKxRhBly9cgB6iXhfbvR aGEg== X-Gm-Message-State: AOAM5322PPsgSkWG/h0dcrpByn1yPFnmayHaMjhBCmoC/EGMOTTTmaAL nJdoDCq3RaVaxFxZN9u8Qh+SafsTOYeNabCw X-Google-Smtp-Source: ABdhPJxVpcnhhKw4+HYsJ4c7hCat9vFVLF5ci5YzUbDbVnH7wGQHjAINH4wGbFi2Tru601OdJ/MOCg== X-Received: by 2002:a5d:4ac1:: with SMTP id y1mr19713270wrs.27.1604942280560; Mon, 09 Nov 2020 09:18:00 -0800 (PST) Received: from dell ([91.110.221.180]) by smtp.gmail.com with ESMTPSA id n123sm55069wmn.38.2020.11.09.09.17.59 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 09 Nov 2020 09:17:59 -0800 (PST) Date: Mon, 9 Nov 2020 17:17:56 +0000 From: Lee Jones To: Ville =?iso-8859-1?Q?Syrj=E4l=E4?= Cc: David Airlie , David Francis , linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org Subject: Re: [PATCH 14/19] gpu: drm: selftests: test-drm_dp_mst_helper: Place 'struct drm_dp_sideband_msg_req_body' onto the heap Message-ID: <20201109171756.GA2063125@dell> References: <20201105144517.1826692-1-lee.jones@linaro.org> <20201105144517.1826692-15-lee.jones@linaro.org> <20201109151937.GF6112@intel.com> <20201109161258.GX2063125@dell> <20201109162015.GH6112@intel.com> <20201109164004.GZ2063125@dell> <20201109170324.GJ6112@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20201109170324.GJ6112@intel.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 09 Nov 2020, Ville Syrjälä wrote: > On Mon, Nov 09, 2020 at 04:40:04PM +0000, Lee Jones wrote: > > On Mon, 09 Nov 2020, Ville Syrjälä wrote: > > > > > On Mon, Nov 09, 2020 at 04:12:58PM +0000, Lee Jones wrote: > > > > On Mon, 09 Nov 2020, Ville Syrjälä wrote: > > > > > > > > > On Thu, Nov 05, 2020 at 02:45:12PM +0000, Lee Jones wrote: > > > > > > The stack is too full. > > > > > > > > > > > > Fixes the following W=1 kernel build warning(s): > > > > > > > > > > > > drivers/gpu/drm/selftests/test-drm_dp_mst_helper.c: In function ‘sideband_msg_req_encode_decode’: > > > > > > drivers/gpu/drm/selftests/test-drm_dp_mst_helper.c:161:1: warning: the frame size of 1176 bytes is larger than 1024 bytes [-Wframe-larger-than=] > > > > > > > > > > > > Cc: David Airlie > > > > > > Cc: Daniel Vetter > > > > > > Cc: Lyude Paul > > > > > > Cc: David Francis > > > > > > Cc: dri-devel@lists.freedesktop.org > > > > > > Signed-off-by: Lee Jones > > > > > > --- > > > > > > .../drm/selftests/test-drm_dp_mst_helper.c | 29 ++++++++++++------- > > > > > > 1 file changed, 18 insertions(+), 11 deletions(-) > > > > > > > > > > > > diff --git a/drivers/gpu/drm/selftests/test-drm_dp_mst_helper.c b/drivers/gpu/drm/selftests/test-drm_dp_mst_helper.c > > > > > > index 1d696ec001cff..0a539456f6864 100644 > > > > > > --- a/drivers/gpu/drm/selftests/test-drm_dp_mst_helper.c > > > > > > +++ b/drivers/gpu/drm/selftests/test-drm_dp_mst_helper.c > > > > > > @@ -120,44 +120,51 @@ sideband_msg_req_equal(const struct drm_dp_sideband_msg_req_body *in, > > > > > > static bool > > > > > > sideband_msg_req_encode_decode(struct drm_dp_sideband_msg_req_body *in) > > > > > > { > > > > > > - struct drm_dp_sideband_msg_req_body out = {0}; > > > > > > + struct drm_dp_sideband_msg_req_body *out; > > > > > > > > > > How big is it? And why is it that big? > > > > > > > > It's a struct of a union of structs. > > > > > > > > And it's all allocated on the stack. Bad news! > > > > > > That doesn't answer my questions. > > > > It answers the second question. > > Not really. A combination of structs and unions could be > pretty much any size. > > > > > The answer to the first question you can `grep` for yourself. ;) > > I would rather run pahole on it. But why would you require > reviewers to jump through such extra hoops when you could > just put that information into the commit message? With that > anyone could review this without having to do a lot of extra > work. Because the exact numbers aren't all that relevant. Before the patch is applied, the local variables take the frame size over the accepted threshold. The patch brings the size back down to an accepted level. I'm not actually aware of the exact numbers, but you can see by taking a quick look that 'struct drm_dp_sideband_msg_req_body' is large enough to make a significant improvement once shifted onto the heap. -- Lee Jones [李琼斯] Senior Technical Lead - Developer Services Linaro.org │ Open source software for Arm SoCs Follow Linaro: Facebook | Twitter | Blog