All of lore.kernel.org
 help / color / mirror / Atom feed
From: Ilias Apalodimas <ilias.apalodimas@linaro.org>
To: u-boot@lists.denx.de
Subject: [PATCH 2/3 v2] tpm: Add some headers from the spec
Date: Mon, 9 Nov 2020 22:31:55 +0200	[thread overview]
Message-ID: <20201109203155.GA21994@apalos.home> (raw)
In-Reply-To: <20201108135830.GB1058236@apalos.home>

Hi Heinrich, 

[...]
> 
> > > + */
> > > +#define TPM2_NUM_PCR_BANKS 16
> > > +
> > > +/* Definition of (UINT32) TPM2_CAP Constants */
> > > +#define TPM2_CAP_PCRS 0x00000005U
> > > +#define TPM2_CAP_TPM_PROPERTIES 0x00000006U
> > > +
> > > +/* Definition of (UINT32) TPM2_PT Constants */
> > > +#define PT_GROUP                   (u32)(0x00000100)
> > > +#define PT_FIXED                   (u32)(PT_GROUP * 1)
> > > +#define TPM2_PT_MANUFACTURER        (u32)(PT_FIXED + 5)
> > > +#define TPM2_PT_PCR_COUNT           (u32)(PT_FIXED + 18)
> > > +#define TPM2_PT_MAX_COMMAND_SIZE    (u32)(PT_FIXED + 30)
> > > +#define TPM2_PT_MAX_RESPONSE_SIZE   (u32)(PT_FIXED + 31)
> > 
> > All these definitions are all copied from the "TCG TSS2.0 Overview and
> > Common Structures Specification". I am missing a reference to the
> > copyright notice of the spec. I think the best thing to do would be
> > placing the TCG copyrighted code into a separate include that is
> > included in tpm_v2.h. Please, check with Tom if the license contradicts
> > GPL. Especially the following sentence seems problematic:
> > 
> > "THE COPYRIGHT LICENSES SET FORTH ABOVE DO NOT REPRESENT ANY FORM OF
> > LICENSE OR WAIVER, EXPRESS OR IMPLIED, BY ESTOPPEL OR OTHERWISE, WITH
> > RESPECT TO PATENT RIGHTS HELD BY TCG MEMBERS (OR OTHER THIRD PARTIES)
> > THAT MAY BE NECESSARY TO IMPLEMENT THIS SPECIFICATION OR OTHERWISE."
> > 
> > Cf. https://fedoraproject.org/wiki/Licensing/TCGL
> > 
> 
> Ok will do

So I talked to Tom and he suggested we have a look at linux, or any other project
that uses those. I can't find any copyright claims in include/linux/tpm.h, apart
from a pointer to the spec.
I don't think splitting the changes to a new file is a good idea. Most of the 
existing definitions of the file are part of the same document. Maybe just 
updating the copyright properly is the right thing to do?

[...]

Regards
/Ilias

  reply	other threads:[~2020-11-09 20:31 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-11-05 21:58 [PATCH 1/3 v2] tpm: Change response length of tpm2_get_capability() Ilias Apalodimas
2020-11-05 21:58 ` [PATCH 2/3 v2] tpm: Add some headers from the spec Ilias Apalodimas
2020-11-07 20:33   ` Heinrich Schuchardt
2020-11-08 13:58     ` Ilias Apalodimas
2020-11-09 20:31       ` Ilias Apalodimas [this message]
2020-11-05 21:58 ` [PATCH 3/3 v2] efi: Add basic EFI_TCG2_PROTOCOL support Ilias Apalodimas
2020-11-07 21:08   ` Heinrich Schuchardt
2020-11-08 13:55     ` Ilias Apalodimas
2020-11-11 14:32 ` [PATCH 1/3 v2] tpm: Change response length of tpm2_get_capability() Simon Glass

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20201109203155.GA21994@apalos.home \
    --to=ilias.apalodimas@linaro.org \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.