From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.7 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id F3FDDC388F7 for ; Tue, 10 Nov 2020 08:13:25 +0000 (UTC) Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 18433208CA for ; Tue, 10 Nov 2020 08:13:24 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=alsa-project.org header.i=@alsa-project.org header.b="LAdFYUqI"; dkim=temperror (0-bit key) header.d=sakamocchi.jp header.i=@sakamocchi.jp header.b="FTPc/fhL"; dkim=temperror (0-bit key) header.d=messagingengine.com header.i=@messagingengine.com header.b="jzDwyVq3" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 18433208CA Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=sakamocchi.jp Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=alsa-devel-bounces@alsa-project.org Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id 43F0616C9; Tue, 10 Nov 2020 09:12:32 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz 43F0616C9 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1604996002; bh=6ZrvfE7Ze2PK3ksLyvJCUPNt6Oik+V4p/wavks6ZSZ8=; h=Date:From:To:Subject:References:In-Reply-To:Cc:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=LAdFYUqI/XqvJ3MG+jwl9ahN/IsK0DLylh/NhI62Rvfp+uPZqtW03ABmp4UQraCUo ymvBW6U2iPHNRqTLn4xYMhBItCftp47a4oZO8oEe1kwW1bwBUtMt8S6U5mMiD/GWbw TR9Kdf42RQVFXrzeOg0jVngMk5oM5hM4z0uyGCHo= Received: from alsa1.perex.cz (localhost.localdomain [127.0.0.1]) by alsa1.perex.cz (Postfix) with ESMTP id C5A1DF80161; Tue, 10 Nov 2020 09:12:31 +0100 (CET) Received: by alsa1.perex.cz (Postfix, from userid 50401) id 7FD19F801D5; Tue, 10 Nov 2020 09:12:30 +0100 (CET) Received: from out4-smtp.messagingengine.com (out4-smtp.messagingengine.com [66.111.4.28]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id E0264F800AE for ; Tue, 10 Nov 2020 09:12:23 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz E0264F800AE Authentication-Results: alsa1.perex.cz; dkim=pass (2048-bit key) header.d=sakamocchi.jp header.i=@sakamocchi.jp header.b="FTPc/fhL"; dkim=pass (2048-bit key) header.d=messagingengine.com header.i=@messagingengine.com header.b="jzDwyVq3" Received: from compute4.internal (compute4.nyi.internal [10.202.2.44]) by mailout.nyi.internal (Postfix) with ESMTP id D3A4B5C0180; Tue, 10 Nov 2020 03:12:21 -0500 (EST) Received: from mailfrontend2 ([10.202.2.163]) by compute4.internal (MEProxy); Tue, 10 Nov 2020 03:12:21 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sakamocchi.jp; h=date:from:to:cc:subject:message-id:references:mime-version :content-type:in-reply-to; s=fm3; bh=U1LfiC5Xa/E1oIfmlMHoNEZwb+i nOk2P6HGJve+Wjqs=; b=FTPc/fhL77+zD5OahwzAQueOBSarEzpSfubCMBgKUhz JJwofjjQeXu7p6mWe3mSzwk9W+vDZX27NLGyHto1woOmcfQi1h+bCGL44g+vxWLr ga2eFHbF0g+12PjjKoffZeBbKsE3mjCb73PFadVb+gTGwYyX5LaUb3UhnKOIo/2A hAYA45elLVRHG0fMgwFqb0CwW4S6dJU4R6dqLa9f9EH2EqvDYaUUzE5gs7XplLat h10xK7o0arW7kGiG9fNjzaj3C5Q41dRMcEfR20sVT3gYapeuOEyVIMEBMo9XWDfO 85AO29itaPzYFNg7v9e7f7LPzmJvLlQqK3COwh3Yp/g== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm1; bh=U1LfiC 5Xa/E1oIfmlMHoNEZwb+inOk2P6HGJve+Wjqs=; b=jzDwyVq30MthjCAju/F3md f+bT5ikVV2oNiWQtJFT2LVWEPzRRQbeIOvUylkgRPi7ws4VL8cJWGtUgByjelK/2 nffC+mGube0FO0aAWWMiW7trvkQztvTPD2nVxNf5lzTJiy6Zv4bLrMBIrW/GI0i9 2q7zP2yuYF+YHxLRFU/0g1zhKh5pqIZzv4XM19a1nj83qwxM8jg6C2shyJZBlijk 7esWPQNNWgQ8tQo7eufv+i6/hOZ5PpFGjOPrFZHahwaGgsfc+XV+RTMKSVyr1uZz 6gmUXKngpReKt1zyvCHGSu3moX6rXEkiYXJIwlD9OBRzgLwub9sbFipxJzLslIjw == X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedujedrudduiedguddulecutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfgh necuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmd enucfjughrpeffhffvuffkfhggtggujgesthdtredttddtvdenucfhrhhomhepvfgrkhgr shhhihcuufgrkhgrmhhothhouceoohdqthgrkhgrshhhihesshgrkhgrmhhotggthhhird hjpheqnecuggftrfgrthhtvghrnheplefhueegvdejgfejgfdukeefudetvddtuddtueei vedttdegteejkedvfeegfefhnecukfhppedugedrfedrieegrddvtdejnecuvehluhhsth gvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomhepohdqthgrkhgrshhhihes shgrkhgrmhhotggthhhirdhjph X-ME-Proxy: Received: from workstation (ae064207.dynamic.ppp.asahi-net.or.jp [14.3.64.207]) by mail.messagingengine.com (Postfix) with ESMTPA id DFBF13063080; Tue, 10 Nov 2020 03:12:19 -0500 (EST) Date: Tue, 10 Nov 2020 17:12:17 +0900 From: Takashi Sakamoto To: Takashi Iwai Subject: Re: [PATCH] ALSA: firewire: fix comparison to bool warning Message-ID: <20201110081217.GA50128@workstation> Mail-Followup-To: Takashi Iwai , xiakaixu1987@gmail.com, linux-kernel@vger.kernel.org, alsa-devel@alsa-project.org, Kaixu Xia , tiwai@suse.com References: <1604765611-8209-1-git-send-email-kaixuxia@tencent.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Cc: alsa-devel@alsa-project.org, Kaixu Xia , linux-kernel@vger.kernel.org, xiakaixu1987@gmail.com, tiwai@suse.com X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" On Tue, Nov 10, 2020 at 09:06:29AM +0100, Takashi Iwai wrote: > On Sat, 07 Nov 2020 17:13:31 +0100, > xiakaixu1987@gmail.com wrote: > > > > From: Kaixu Xia > > > > Fix the following coccicheck warning: > > > > ./sound/firewire/amdtp-stream.h:273:6-19: WARNING: Comparison to bool > > > > Reported-by: Tosk Robot > > Signed-off-by: Kaixu Xia The message seems not to reach my mailbox. Anyway: Acked-by: Takashi Sakamoto > Thanks, applied. > > > Takashi > > > --- > > sound/firewire/amdtp-stream.h | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/sound/firewire/amdtp-stream.h b/sound/firewire/amdtp-stream.h > > index 2ceb57d1d58e..a3daa1f2c1c4 100644 > > --- a/sound/firewire/amdtp-stream.h > > +++ b/sound/firewire/amdtp-stream.h > > @@ -270,7 +270,7 @@ static inline bool amdtp_stream_wait_callback(struct amdtp_stream *s, > > unsigned int timeout) > > { > > return wait_event_timeout(s->callback_wait, > > - s->callbacked == true, > > + s->callbacked, > > msecs_to_jiffies(timeout)) > 0; > > } > > > > -- > > 2.20.0 Regards Takashi Sakamoto From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 37C3BC388F7 for ; Tue, 10 Nov 2020 08:12:25 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id CA0D320829 for ; Tue, 10 Nov 2020 08:12:24 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731771AbgKJIMX (ORCPT ); Tue, 10 Nov 2020 03:12:23 -0500 Received: from out4-smtp.messagingengine.com ([66.111.4.28]:48569 "EHLO out4-smtp.messagingengine.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726467AbgKJIMX (ORCPT ); Tue, 10 Nov 2020 03:12:23 -0500 Received: from compute4.internal (compute4.nyi.internal [10.202.2.44]) by mailout.nyi.internal (Postfix) with ESMTP id D3A4B5C0180; Tue, 10 Nov 2020 03:12:21 -0500 (EST) Received: from mailfrontend2 ([10.202.2.163]) by compute4.internal (MEProxy); Tue, 10 Nov 2020 03:12:21 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sakamocchi.jp; h=date:from:to:cc:subject:message-id:references:mime-version :content-type:in-reply-to; s=fm3; bh=U1LfiC5Xa/E1oIfmlMHoNEZwb+i nOk2P6HGJve+Wjqs=; b=FTPc/fhL77+zD5OahwzAQueOBSarEzpSfubCMBgKUhz JJwofjjQeXu7p6mWe3mSzwk9W+vDZX27NLGyHto1woOmcfQi1h+bCGL44g+vxWLr ga2eFHbF0g+12PjjKoffZeBbKsE3mjCb73PFadVb+gTGwYyX5LaUb3UhnKOIo/2A hAYA45elLVRHG0fMgwFqb0CwW4S6dJU4R6dqLa9f9EH2EqvDYaUUzE5gs7XplLat h10xK7o0arW7kGiG9fNjzaj3C5Q41dRMcEfR20sVT3gYapeuOEyVIMEBMo9XWDfO 85AO29itaPzYFNg7v9e7f7LPzmJvLlQqK3COwh3Yp/g== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm1; bh=U1LfiC 5Xa/E1oIfmlMHoNEZwb+inOk2P6HGJve+Wjqs=; b=jzDwyVq30MthjCAju/F3md f+bT5ikVV2oNiWQtJFT2LVWEPzRRQbeIOvUylkgRPi7ws4VL8cJWGtUgByjelK/2 nffC+mGube0FO0aAWWMiW7trvkQztvTPD2nVxNf5lzTJiy6Zv4bLrMBIrW/GI0i9 2q7zP2yuYF+YHxLRFU/0g1zhKh5pqIZzv4XM19a1nj83qwxM8jg6C2shyJZBlijk 7esWPQNNWgQ8tQo7eufv+i6/hOZ5PpFGjOPrFZHahwaGgsfc+XV+RTMKSVyr1uZz 6gmUXKngpReKt1zyvCHGSu3moX6rXEkiYXJIwlD9OBRzgLwub9sbFipxJzLslIjw == X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedujedrudduiedguddulecutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfgh necuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmd enucfjughrpeffhffvuffkfhggtggujgesthdtredttddtvdenucfhrhhomhepvfgrkhgr shhhihcuufgrkhgrmhhothhouceoohdqthgrkhgrshhhihesshgrkhgrmhhotggthhhird hjpheqnecuggftrfgrthhtvghrnheplefhueegvdejgfejgfdukeefudetvddtuddtueei vedttdegteejkedvfeegfefhnecukfhppedugedrfedrieegrddvtdejnecuvehluhhsth gvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomhepohdqthgrkhgrshhhihes shgrkhgrmhhotggthhhirdhjph X-ME-Proxy: Received: from workstation (ae064207.dynamic.ppp.asahi-net.or.jp [14.3.64.207]) by mail.messagingengine.com (Postfix) with ESMTPA id DFBF13063080; Tue, 10 Nov 2020 03:12:19 -0500 (EST) Date: Tue, 10 Nov 2020 17:12:17 +0900 From: Takashi Sakamoto To: Takashi Iwai Cc: xiakaixu1987@gmail.com, linux-kernel@vger.kernel.org, alsa-devel@alsa-project.org, Kaixu Xia , tiwai@suse.com Subject: Re: [PATCH] ALSA: firewire: fix comparison to bool warning Message-ID: <20201110081217.GA50128@workstation> Mail-Followup-To: Takashi Iwai , xiakaixu1987@gmail.com, linux-kernel@vger.kernel.org, alsa-devel@alsa-project.org, Kaixu Xia , tiwai@suse.com References: <1604765611-8209-1-git-send-email-kaixuxia@tencent.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Nov 10, 2020 at 09:06:29AM +0100, Takashi Iwai wrote: > On Sat, 07 Nov 2020 17:13:31 +0100, > xiakaixu1987@gmail.com wrote: > > > > From: Kaixu Xia > > > > Fix the following coccicheck warning: > > > > ./sound/firewire/amdtp-stream.h:273:6-19: WARNING: Comparison to bool > > > > Reported-by: Tosk Robot > > Signed-off-by: Kaixu Xia The message seems not to reach my mailbox. Anyway: Acked-by: Takashi Sakamoto > Thanks, applied. > > > Takashi > > > --- > > sound/firewire/amdtp-stream.h | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/sound/firewire/amdtp-stream.h b/sound/firewire/amdtp-stream.h > > index 2ceb57d1d58e..a3daa1f2c1c4 100644 > > --- a/sound/firewire/amdtp-stream.h > > +++ b/sound/firewire/amdtp-stream.h > > @@ -270,7 +270,7 @@ static inline bool amdtp_stream_wait_callback(struct amdtp_stream *s, > > unsigned int timeout) > > { > > return wait_event_timeout(s->callback_wait, > > - s->callbacked == true, > > + s->callbacked, > > msecs_to_jiffies(timeout)) > 0; > > } > > > > -- > > 2.20.0 Regards Takashi Sakamoto