Re: [PATCH v2] tcp: fix race condition when creating child sockets from syncookies

[kernel test robot <lkp@intel.com>]

[-- Attachment #1: Type: text/plain, Size: 6092 bytes --]

CC: kbuild-all(a)lists.01.org
In-Reply-To: <20201109161146.GA629827@rdias-suse-pc.lan>
References: <20201109161146.GA629827@rdias-suse-pc.lan>
TO: Ricardo Dias <rdias@singlestore.com>
TO: davem(a)davemloft.net
TO: kuba(a)kernel.org
TO: kuznet(a)ms2.inr.ac.ru
TO: yoshfuji(a)linux-ipv6.org
TO: edumazet(a)google.com
CC: netdev(a)vger.kernel.org
CC: linux-kernel(a)vger.kernel.org

Hi Ricardo,

Thank you for the patch! Perhaps something to improve:

[auto build test WARNING on net-next/master]
[also build test WARNING on net/master linus/master sparc-next/master v5.10-rc3 next-20201109]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]

url:    https://github.com/0day-ci/linux/commits/Ricardo-Dias/tcp-fix-race-condition-when-creating-child-sockets-from-syncookies/20201110-001214
base:   https://git.kernel.org/pub/scm/linux/kernel/git/davem/net-next.git bff6f1db91e330d7fba56f815cdbc412c75fe163
:::::: branch date: 15 hours ago
:::::: commit date: 15 hours ago
config: powerpc-randconfig-s032-20201109 (attached as .config)
compiler: powerpc64-linux-gcc (GCC) 9.3.0
reproduce:
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # apt-get install sparse
        # sparse version: v0.6.3-76-gf680124b-dirty
        # https://github.com/0day-ci/linux/commit/52d4b7238a3e63643168c08c1496e59c41d33091
        git remote add linux-review https://github.com/0day-ci/linux
        git fetch --no-tags linux-review Ricardo-Dias/tcp-fix-race-condition-when-creating-child-sockets-from-syncookies/20201110-001214
        git checkout 52d4b7238a3e63643168c08c1496e59c41d33091
        # save the attached .config to linux build tree
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross C=1 CF='-fdiagnostic-prefix -D__CHECK_ENDIAN__' ARCH=powerpc 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>


"sparse warnings: (new ones prefixed by >>)"
   net/ipv4/tcp_ipv4.c:2802:41: sparse: sparse: incorrect type in argument 1 (different address spaces) @@     expected void const *data @@     got struct tcp_congestion_ops const [noderef] __rcu *tcp_congestion_control @@
   net/ipv4/tcp_ipv4.c:2802:41: sparse:     expected void const *data
   net/ipv4/tcp_ipv4.c:2802:41: sparse:     got struct tcp_congestion_ops const [noderef] __rcu *tcp_congestion_control
   net/ipv4/tcp_ipv4.c:2911:45: sparse: sparse: incorrect type in argument 1 (different address spaces) @@     expected void const *data @@     got struct tcp_congestion_ops const [noderef] __rcu *extern [addressable] [toplevel] tcp_congestion_control @@
   net/ipv4/tcp_ipv4.c:2911:45: sparse:     expected void const *data
   net/ipv4/tcp_ipv4.c:2911:45: sparse:     got struct tcp_congestion_ops const [noderef] __rcu *extern [addressable] [toplevel] tcp_congestion_control
   net/ipv4/tcp_ipv4.c:2915:50: sparse: sparse: incorrect type in assignment (different address spaces) @@     expected struct tcp_congestion_ops const [noderef] __rcu *tcp_congestion_control @@     got struct tcp_congestion_ops * @@
   net/ipv4/tcp_ipv4.c:2915:50: sparse:     expected struct tcp_congestion_ops const [noderef] __rcu *tcp_congestion_control
   net/ipv4/tcp_ipv4.c:2915:50: sparse:     got struct tcp_congestion_ops *
   net/ipv4/tcp_ipv4.c: note: in included file (through arch/powerpc/include/asm/mmiowb.h, include/linux/spinlock.h, include/linux/mmzone.h, ...):
>> include/asm-generic/mmiowb.h:58:9: sparse: sparse: context imbalance in 'tcp_v4_syn_recv_sock' - unexpected unlock
   include/asm-generic/mmiowb.h:58:9: sparse: sparse: context imbalance in 'tcp_add_backlog' - unexpected unlock
   net/ipv4/tcp_ipv4.c:2081:21: sparse: sparse: context imbalance in 'tcp_v4_rcv' - different lock contexts for basic block
   include/asm-generic/mmiowb.h:58:9: sparse: sparse: context imbalance in 'listening_get_next' - unexpected unlock
   net/ipv4/tcp_ipv4.c:2343:9: sparse: sparse: context imbalance in 'established_get_first' - wrong count at exit
   net/ipv4/tcp_ipv4.c:2371:40: sparse: sparse: context imbalance in 'established_get_next' - unexpected unlock
   include/asm-generic/mmiowb.h:58:9: sparse: sparse: context imbalance in 'tcp_seq_stop' - unexpected unlock
   net/ipv4/tcp_ipv4.c:2803:41: sparse: sparse: dereference of noderef expression
   net/ipv4/tcp_ipv4.c:2803:41: sparse: sparse: dereference of noderef expression
   net/ipv4/tcp_ipv4.c:2912:45: sparse: sparse: dereference of noderef expression
   net/ipv4/tcp_ipv4.c:2912:45: sparse: sparse: dereference of noderef expression
--
   net/ipv6/tcp_ipv6.c: note: in included file (through arch/powerpc/include/asm/mmiowb.h, include/linux/spinlock.h, include/linux/mmzone.h, ...):
>> include/asm-generic/mmiowb.h:58:9: sparse: sparse: context imbalance in 'tcp_v6_syn_recv_sock' - unexpected unlock
   net/ipv6/tcp_ipv6.c:1742:21: sparse: sparse: context imbalance in 'tcp_v6_rcv' - different lock contexts for basic block

vim +/tcp_v4_syn_recv_sock +58 include/asm-generic/mmiowb.h

d1be6a28b13ce6d Will Deacon 2019-02-22  48  
d1be6a28b13ce6d Will Deacon 2019-02-22  49  static inline void mmiowb_spin_unlock(void)
d1be6a28b13ce6d Will Deacon 2019-02-22  50  {
d1be6a28b13ce6d Will Deacon 2019-02-22  51  	struct mmiowb_state *ms = __mmiowb_state();
d1be6a28b13ce6d Will Deacon 2019-02-22  52  
d1be6a28b13ce6d Will Deacon 2019-02-22  53  	if (unlikely(ms->mmiowb_pending)) {
d1be6a28b13ce6d Will Deacon 2019-02-22  54  		ms->mmiowb_pending = 0;
d1be6a28b13ce6d Will Deacon 2019-02-22  55  		mmiowb();
d1be6a28b13ce6d Will Deacon 2019-02-22  56  	}
d1be6a28b13ce6d Will Deacon 2019-02-22  57  
d1be6a28b13ce6d Will Deacon 2019-02-22 @58  	ms->nesting_count--;

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org

[-- Attachment #2: config.gz --]
[-- Type: application/gzip, Size: 24455 bytes --]