All of lore.kernel.org
 help / color / mirror / Atom feed
From: Bartosz Golaszewski <brgl@bgdev.pl>
To: Linus Walleij <linus.walleij@linaro.org>,
	Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
	Jan Kiszka <jan.kiszka@siemens.com>,
	David Laight <David.Laight@aculab.com>
Cc: linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org,
	Bartosz Golaszewski <bgolaszewski@baylibre.com>
Subject: [PATCH v4 0/7] gpio: exar: refactor the driver
Date: Tue, 10 Nov 2020 15:55:45 +0100	[thread overview]
Message-ID: <20201110145552.23024-1-brgl@bgdev.pl> (raw)

From: Bartosz Golaszewski <bgolaszewski@baylibre.com>

I just wanted to convert the driver to using simpler IDA API but ended up
quickly converting it to using regmap. Unfortunately I don't have the HW
to test it so marking the patches that introduce functional change as RFT
and Cc'ing the original author.

v1 -> v2:
- add new regmap helper: regmap_assign_bits()
- fix lvl vs sel register access
- set value in direction_output callback

v2 -> v3:
- drop the regmap helper from series

v3 -> v4:
- renamed the regmap variable to 'regmap' as leaving the old name caused me
  to miss an assignment leading to a crash (culprit spotted by Andy Shevchenko)

Bartosz Golaszewski (7):
  gpio: exar: add a newline after the copyright notice
  gpio: exar: include idr.h
  gpio: exar: switch to a simpler IDA interface
  gpio: exar: use a helper variable for &pdev->dev
  gpio: exar: unduplicate address and offset computation
  gpio: exar: switch to using regmap
  gpio: exar: use devm action for freeing the IDA and drop remove()

 drivers/gpio/Kconfig     |   1 +
 drivers/gpio/gpio-exar.c | 155 +++++++++++++++++++--------------------
 2 files changed, 77 insertions(+), 79 deletions(-)

-- 
2.29.1


             reply	other threads:[~2020-11-10 14:57 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-11-10 14:55 Bartosz Golaszewski [this message]
2020-11-10 14:55 ` [PATCH v4 1/7] gpio: exar: add a newline after the copyright notice Bartosz Golaszewski
2020-11-10 14:55 ` [PATCH v4 2/7] gpio: exar: include idr.h Bartosz Golaszewski
2020-11-10 14:55 ` [PATCH v4 3/7] gpio: exar: switch to a simpler IDA interface Bartosz Golaszewski
2020-11-10 14:55 ` [PATCH v4 4/7] gpio: exar: use a helper variable for &pdev->dev Bartosz Golaszewski
2020-11-10 14:55 ` [PATCH v4 5/7] gpio: exar: unduplicate address and offset computation Bartosz Golaszewski
2020-11-10 14:55 ` [PATCH v4 6/7] gpio: exar: switch to using regmap Bartosz Golaszewski
2020-11-10 15:04   ` Andy Shevchenko
2020-11-10 15:10     ` Andy Shevchenko
2020-11-10 15:12       ` Bartosz Golaszewski
2020-11-10 16:12         ` Andy Shevchenko
2020-11-10 16:36           ` Bartosz Golaszewski
2020-11-10 16:44             ` Andy Shevchenko
2020-11-10 16:52               ` Bartosz Golaszewski
2020-11-10 17:08                 ` Andy Shevchenko
2020-11-10 14:55 ` [PATCH v4 7/7] gpio: exar: use devm action for freeing the IDA and drop remove() Bartosz Golaszewski
2020-11-10 15:07 ` [PATCH v4 0/7] gpio: exar: refactor the driver Andy Shevchenko
2020-11-10 16:19   ` Andy Shevchenko

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20201110145552.23024-1-brgl@bgdev.pl \
    --to=brgl@bgdev.pl \
    --cc=David.Laight@aculab.com \
    --cc=andriy.shevchenko@linux.intel.com \
    --cc=bgolaszewski@baylibre.com \
    --cc=jan.kiszka@siemens.com \
    --cc=linus.walleij@linaro.org \
    --cc=linux-gpio@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.