From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Bartosz Golaszewski <bgolaszewski@baylibre.com>
Cc: Jan Kiszka <jan.kiszka@siemens.com>,
Bartosz Golaszewski <brgl@bgdev.pl>,
Linus Walleij <linus.walleij@linaro.org>,
David Laight <David.Laight@aculab.com>,
linux-gpio <linux-gpio@vger.kernel.org>,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v3 6/7] gpio: exar: switch to using regmap
Date: Tue, 10 Nov 2020 17:01:43 +0200 [thread overview]
Message-ID: <20201110150143.GV4077@smile.fi.intel.com> (raw)
In-Reply-To: <CAMpxmJW1j9+KAj12OKs3njUWy+UA5B993Pyd=xmo4k8LM-8GUw@mail.gmail.com>
On Tue, Nov 10, 2020 at 03:52:00PM +0100, Bartosz Golaszewski wrote:
> On Tue, Nov 10, 2020 at 3:50 PM Jan Kiszka <jan.kiszka@siemens.com> wrote:
> > On 10.11.20 15:30, Bartosz Golaszewski wrote:
...
> > Removing the line that Andy found made things work here. And switching
> > to 16 for reg_bits didn't make things worse again.
> >
> > Jan
>
> Alright! I'll send a v4 with these things fixed then.
Hold on, the registers are 16-bit wide, but their halves are sparsed!
So, I guess 8 and 8 with helpers to get hi and lo parts are essential.
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2020-11-10 15:00 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-10 12:33 [PATCH v3 0/7] gpio: exar: refactor the driver Bartosz Golaszewski
2020-11-10 12:34 ` [PATCH v3 1/7] gpio: exar: add a newline after the copyright notice Bartosz Golaszewski
2020-11-10 12:34 ` [PATCH v3 2/7] gpio: exar: include idr.h Bartosz Golaszewski
2020-11-10 12:34 ` [PATCH v3 3/7] gpio: exar: switch to a simpler IDA interface Bartosz Golaszewski
2020-11-10 12:34 ` [PATCH v3 4/7] gpio: exar: use a helper variable for &pdev->dev Bartosz Golaszewski
2020-11-10 12:34 ` [PATCH v3 5/7] gpio: exar: unduplicate address and offset computation Bartosz Golaszewski
2020-11-10 12:34 ` [PATCH v3 6/7] gpio: exar: switch to using regmap Bartosz Golaszewski
2020-11-10 13:23 ` Jan Kiszka
2020-11-10 13:29 ` Bartosz Golaszewski
2020-11-10 13:51 ` Jan Kiszka
2020-11-10 14:11 ` Andy Shevchenko
2020-11-10 14:24 ` Bartosz Golaszewski
2020-11-10 14:26 ` Andy Shevchenko
2020-11-10 14:27 ` Andy Shevchenko
2020-11-10 14:30 ` Bartosz Golaszewski
2020-11-10 14:50 ` Jan Kiszka
2020-11-10 14:52 ` Bartosz Golaszewski
2020-11-10 15:01 ` Andy Shevchenko [this message]
2020-11-10 12:34 ` [PATCH v3 7/7] gpio: exar: use devm action for freeing the IDA and drop remove() Bartosz Golaszewski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201110150143.GV4077@smile.fi.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=David.Laight@aculab.com \
--cc=bgolaszewski@baylibre.com \
--cc=brgl@bgdev.pl \
--cc=jan.kiszka@siemens.com \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.