From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.5 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B853EC388F7 for ; Tue, 10 Nov 2020 20:48:19 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 1B02020665 for ; Tue, 10 Nov 2020 20:48:19 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="Uu3nN2xw" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 1B02020665 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:45610 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kcaYr-0002yJ-V0 for qemu-devel@archiver.kernel.org; Tue, 10 Nov 2020 15:48:17 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:42218) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kcaW6-0001KX-Ql for qemu-devel@nongnu.org; Tue, 10 Nov 2020 15:45:26 -0500 Received: from us-smtp-delivery-124.mimecast.com ([216.205.24.124]:59432) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.90_1) (envelope-from ) id 1kcaW4-0001WN-Po for qemu-devel@nongnu.org; Tue, 10 Nov 2020 15:45:26 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1605041123; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=TjnaMYix/usFJTFiELwlsyeDoBWEqlB2cBfA/xmwJJI=; b=Uu3nN2xwZ0IKoVS99ECPH1nT1WVPZ2U0/lMa0Bjulmy4D6HmPPF10bDXTkClT9Lfil7GQA W4LdwapX0kAX1UdqQefwJNZ0bDKQfUqgrKozOAGuXndbpPM8VeYq0bObjIPY9DWUcdQ1UB LGvKfqKFyGWtf7vF/6yz5+DqExtwuqg= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-409-wTOtia0CNDmfuNSqZ1eq2w-1; Tue, 10 Nov 2020 15:45:22 -0500 X-MC-Unique: wTOtia0CNDmfuNSqZ1eq2w-1 Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.phx2.redhat.com [10.5.11.22]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 24F8B188C12F; Tue, 10 Nov 2020 20:45:20 +0000 (UTC) Received: from localhost (ovpn-114-68.rdu2.redhat.com [10.10.114.68]) by smtp.corp.redhat.com (Postfix) with ESMTP id 9469410013DB; Tue, 10 Nov 2020 20:45:16 +0000 (UTC) Date: Tue, 10 Nov 2020 15:45:15 -0500 From: Eduardo Habkost To: Paolo Bonzini Subject: Re: [RFC v1 09/10] i386: split cpu.c and defer x86 models registration Message-ID: <20201110204515.GM5733@habkost.net> References: <20201109172755.16500-1-cfontana@suse.de> <20201109172755.16500-10-cfontana@suse.de> <20201109180302.GB814975@redhat.com> <971cfde9-d24e-a3dc-6389-8a7c9e477f63@suse.de> <20201110100438.GF866671@redhat.com> <20201110152314.GF5733@habkost.net> <8bc35f55-159f-5037-3355-12bf4fd48e74@redhat.com> <20201110175520.GI5733@habkost.net> MIME-Version: 1.0 In-Reply-To: X-Scanned-By: MIMEDefang 2.84 on 10.5.11.22 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=ehabkost@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Received-SPF: pass client-ip=216.205.24.124; envelope-from=ehabkost@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-detected-operating-system: by eggs.gnu.org: First seen = 2020/11/10 02:00:53 X-ACL-Warn: Detected OS = Linux 2.2.x-3.x [generic] [fuzzy] X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Laurent Vivier , Wenchao Wang , Thomas Huth , Stefano Stabellini , Daniel =?utf-8?B?UC4gQmVycmFuZ8Op?= , Paul Durrant , Jason Wang , Marcelo Tosatti , qemu-devel@nongnu.org, Peter Xu , Dario Faggioli , Roman Bolshakov , Cameron Esfahani , haxm-team@intel.com, Claudio Fontana , Anthony Perard , Sunil Muthuswamy , Bruce Rogers , Philippe =?utf-8?Q?Mathieu-Daud=C3=A9?= , Richard Henderson , Colin Xu Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On Tue, Nov 10, 2020 at 09:39:37PM +0100, Paolo Bonzini wrote: > On 10/11/20 18:55, Eduardo Habkost wrote: > > > I think we should not try yo implement interfaces conditionally (i.e. have > > > TYPE_X86_ACCEL implemented only on qemu-system-{i386,x86_64} and not > > > qemu-system-arm), even if technically the accel/ objects are per-target > > > (specific_ss) rather than common. > > If the accel objects are already per target, it seems appropriate > > to have a QOM type hierarchy that reflects that. > > > > `qemu-system-x86_64 -accel kvm` would create a kvm-x86_64-accel > > object, but `qemu-system-arm -accel kvm` would create a > > kvm-arm-accel. > > ... and fall back to kvm-accel? So accel_find would be the only place to > change. Sounds good. This way we don't need to convert all accelerators or all targets at the same time. -- Eduardo