From: Petr Vorel <pvorel@suse.cz>
To: ltp@lists.linux.it
Subject: [LTP] [PATCH 1/1] m4: Remove workaround for old pkg-config
Date: Wed, 11 Nov 2020 12:48:43 +0100 [thread overview]
Message-ID: <20201111114843.GA14760@pevik> (raw)
In-Reply-To: <CAEemH2c4qTU1f99MBXTyVgvX-L=LNRneRJvmctkF9YiQ68u_-Q@mail.gmail.com>
Hi Li,
> On Wed, Nov 11, 2020 at 5:56 PM Petr Vorel <pvorel@suse.cz> wrote:
> > Hi,
> > > On Wed, Nov 11, 2020 at 5:38 PM Cyril Hrubis <chrubis@suse.cz> wrote:
> > > > Hi!
> > > > Looks good to me, let's apply this unless anybody complains.
> > > Hold on, please.
> > > Seems we have to replace TIRPC_LIBS/TIRPC_CFLAGS with LIBTIRPC_* in all
> > > respective Makefiles? Otherwise, it will fail like the Travis CI job I
> > > guess.
> > Correct, currently would fail without it.
> > https://travis-ci.org/github/pevik/ltp/builds/742685737
> > I'll send v2 where I implement this.
> Thanks, I modified base on your patch, test result FYI
> https://github.com/wangli5665/ltp/commit/dad10021771101e7fdd416af894be7484fcb7a52
> https://travis-ci.org/github/wangli5665/ltp/builds/742909686
You implemented it, thank you. Please push it after Travis finishes.
Just an explanation, why I introduced TIRPC_{CFLAGS,LIBS}: there was Sun-RPC
implementation in glibc, which I wanted to test. Thus variable name without
"LIB" to say, that it could be also glibc.
But Sun-RPC is broken, was deprecated and my patchset which removes it from
glibc was accepted and released in glibc 2.32. Thus I'm going to send patch
which reverts the commit 60b20c428060b20c428 ("rpc: Enable and fix build basic
RPC tests with glibc SunRPC").
My long term goal: fix and cleanup RPC tests (some are failing also with
libtirpc), move these tests to libtirpc sources (they needs to be cleaned. And
also I'd prefer to not put there whole LTP library, but just needed subset).
Kind regards,
Petr
next prev parent reply other threads:[~2020-11-11 11:48 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-10 12:09 [LTP] [PATCH 1/1] m4: Remove workaround for old pkg-config Petr Vorel
2020-11-11 9:39 ` Cyril Hrubis
2020-11-11 9:51 ` Li Wang
2020-11-11 9:55 ` Petr Vorel
2020-11-11 10:51 ` Li Wang
2020-11-11 11:48 ` Petr Vorel [this message]
2020-11-11 12:47 ` Li Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201111114843.GA14760@pevik \
--to=pvorel@suse.cz \
--cc=ltp@lists.linux.it \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.