From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.5 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 84175C388F9 for ; Wed, 11 Nov 2020 12:17:58 +0000 (UTC) Received: from lists.ozlabs.org (lists.ozlabs.org [203.11.71.2]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 5D9DF206D9 for ; Wed, 11 Nov 2020 12:17:57 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=stwcx.xyz header.i=@stwcx.xyz header.b="dOyPhESK"; dkim=temperror (0-bit key) header.d=messagingengine.com header.i=@messagingengine.com header.b="T8f0WwPG" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 5D9DF206D9 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=stwcx.xyz Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=openbmc-bounces+openbmc=archiver.kernel.org@lists.ozlabs.org Received: from bilbo.ozlabs.org (lists.ozlabs.org [IPv6:2401:3900:2:1::3]) by lists.ozlabs.org (Postfix) with ESMTP id 4CWNzP4jVnzDqs2 for ; Wed, 11 Nov 2020 23:17:53 +1100 (AEDT) Authentication-Results: lists.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=stwcx.xyz (client-ip=66.111.4.27; helo=out3-smtp.messagingengine.com; envelope-from=patrick@stwcx.xyz; receiver=) Authentication-Results: lists.ozlabs.org; dmarc=none (p=none dis=none) header.from=stwcx.xyz Authentication-Results: lists.ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=stwcx.xyz header.i=@stwcx.xyz header.a=rsa-sha256 header.s=fm3 header.b=dOyPhESK; dkim=pass (2048-bit key; unprotected) header.d=messagingengine.com header.i=@messagingengine.com header.a=rsa-sha256 header.s=fm1 header.b=T8f0WwPG; dkim-atps=neutral Received: from out3-smtp.messagingengine.com (out3-smtp.messagingengine.com [66.111.4.27]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 4CWNvg6JzFzDqNK for ; Wed, 11 Nov 2020 23:14:38 +1100 (AEDT) Received: from compute4.internal (compute4.nyi.internal [10.202.2.44]) by mailout.nyi.internal (Postfix) with ESMTP id 7AC695C032E; Wed, 11 Nov 2020 07:14:34 -0500 (EST) Received: from mailfrontend1 ([10.202.2.162]) by compute4.internal (MEProxy); Wed, 11 Nov 2020 07:14:34 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=stwcx.xyz; h= date:from:to:cc:subject:message-id:references:mime-version :content-type:in-reply-to; s=fm3; bh=wHEkg/DT+OXmb+GHMvCTuXfU10X aeNCUlTbRNTXy0Qc=; b=dOyPhESKZn8+kWRKB+s9RmCIoxpOunFE5AN92W/Zv4N K3nTRJQaovR5rOYylV2iopFnI5UGemJioInrK4OAvrnaKGITioMLbYScK1/YYyIR dY0QEJ5tMbbvRoN0pTOogd/GjNPY6WfmHg8hMSy4N/AbK1klMYdRq8Ea8Mfz6MpM kwe2+72mTlVRhvwX1LdmRqZ8IYINJOmRn5aiXZueX9p29rY9QexEpynyLlpgDDGP VVjz8QqnaOpPHPruK+z9FmETg1AyMN6pnuUKfHonLNyykco5rFwPVbuUnOc9Gokk jovSofPu+DHSKwKKlmhX2Eeh6hoU1R+/C+UpJ9dLMkw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm1; bh=wHEkg/ DT+OXmb+GHMvCTuXfU10XaeNCUlTbRNTXy0Qc=; b=T8f0WwPGLPO9CrcImtzXCw wFvNSWSKOvQje2qFKl4HNDeGQxwTuXEjbP8zZN3d2RciBjEsUCHKFnPgCOMIfBnj cXmri9Qil18SUpg9aevjXkmoI1+rDlhJyrotjcuMRR0uLRVUbq3crGieq1hQMUiY WGA9Zyd6FwCUfYcYFLWdtFvJvIAdChfM0fhCsOLFp2PJnz+Fe5RTCxdFacq83MVW mRoC3NXOouYUt3LSCJfpyJxpaj/jvJ3zSW3viwSs1uVNrbaD66YuUeA1mfAjoIWf 1rPyffwgN1S4HD25okdmuiA+obJIeG13+nr3fSWBn3m/494ijCxLorivFYwItV0g == X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedujedrudduledgudegjecutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfgh necuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmd enfghrlhcuvffnffculdefhedmnecujfgurhepfffhvffukfhfgggtuggjsehgtderredt tddvnecuhfhrohhmpefrrghtrhhitghkucghihhllhhirghmshcuoehprghtrhhitghkse hsthiftgigrdighiiiqeenucggtffrrghtthgvrhhnpeduudefleeuhefhleehjeejgfeu jeehhfdtledufeehkeduudevkeeiuddugfegkeenucffohhmrghinhepohhpvghnsghmtg dqphhrohhjvggtthdrgiihiienucfkphepjeeirddvhedtrdekgedrvdefieenucevlhhu shhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpehprghtrhhitghkse hsthiftgigrdighiii X-ME-Proxy: Received: from localhost (76-250-84-236.lightspeed.austtx.sbcglobal.net [76.250.84.236]) by mail.messagingengine.com (Postfix) with ESMTPA id 2621A3280065; Wed, 11 Nov 2020 07:14:32 -0500 (EST) Date: Wed, 11 Nov 2020 06:14:31 -0600 From: Patrick Williams To: William Kennington Subject: Re: Request to create repository google-ipmi-bmc-health Message-ID: <20201111121431.GI3614@heinlein> References: <20201007014324.GG6152@heinlein> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="WR+jf/RUebEcofwt" Content-Disposition: inline In-Reply-To: X-BeenThere: openbmc@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Development list for OpenBMC List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: OpenBMC Maillist , Vijay Khemka , Sui Chen Errors-To: openbmc-bounces+openbmc=archiver.kernel.org@lists.ozlabs.org Sender: "openbmc" --WR+jf/RUebEcofwt Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Tue, Nov 10, 2020 at 10:38:55PM -0800, William Kennington wrote: > My 2c... We have plenty of blob handlers that have their own repos to keep > maintainership and purposes separate. The phosphor-ipmi-blobs > repository intends to provide a framework, not specific implementations. Thanks William for the background on phosphor-ipmi-blobs intentions. > On Tue, Nov 10, 2020 at 10:35 PM Vijay Khemka wrote: > > <11/5/20, 3:55 PM, "Sui Chen" wrote: > > The "health monitoring IPMI Blob Handler" (that the request in the > > first email in this thread was indended for) was a monolithic IPMI > > blob handler; it used to both generate metrics and handle IPMI > > requests. > > In the last month, I had de-coupled these two functions so the IPMI > > blob handler does not generate metrics but reads metrics from the > > daemon in phosphor-health-monitor via DBus. In other words, the > > "monolithic" > > handler has now become a thin layer. On the other hand, > > phosphor-health-monitor will have to be significantly modified to > > generate the metrics that are in a different format from what it's > > generating right now, and Vijay and I are working on that. I had > > create a chain > > of changes > > https://gerrit.openbmc-project.xyz/c/openbmc/phosphor-health-monitor/+/= 37659 > > to illustrate what I intend to do. > > As a result, there comes the question of where the IPMI blob handler > > should live, and it appears I have the following choices: > > 1. in phosphor-health-monitor, or > > 2. some centralized location, along with many other IPMI blob > > handlers, or > > 3. as a separate, new repository, or > > 4. something else? Sui, Now that the design has been separated so that the majority of the metric implementation is in p-h-m and the protobuf-ipmi-specific parts just do light-weight dbus operations, it seems reasonable to me to create a new repository to hold that part. That part seems fairly unique to what Google intends to do and I don't think we should burden the maintainers of another repository with that effort. I don't have a strong opinion on the IPMI blob handlers being all in one vs spread out in individual repositories, as long as those repositories are light-weight translations from the dbus APIs to the specific IPMI blob format. --=20 Patrick Williams --WR+jf/RUebEcofwt Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCAAdFiEEBGD9ii4LE9cNbqJBqwNHzC0AwRkFAl+r1aUACgkQqwNHzC0A wRl4bRAAiVuBr58YQvGoedzK8WJKWKjWtEWlt11raGX7Wd2j1ANJB3WwwZ1kRd5A eGdkeph7X7hSXSYCKEYC3VuxKwzqErgt7BeXbtjY+TCKyaYOmEHZxLz2RllySFnB k959scnU4sHViW8+1HZOlJcOtvGQUNnn9BHti3Td1UnWJZSr3XOkL4Z65YRk9oCL GYPAJM+wykIr8lfg+DPAnrgxv0m5Izpe4bYd6XTupMgODdPCSvPmDB/BFrfrCKDJ 8lRou9PA/4JduDHExGsiozlRFNtKcqBrdiluaiw48R4gf4/sbInnQz1Ikua9d0Ne QkTADpv5ByEqsPD8xVyxE3EMI6ORPyBsaRKHk4Kz2a/sh/xNUWxYDgsmfEb1yaHe BCCRE+qXBq7WIdSyFBA5Txq+aANl9h2A6xMv3grJ+rW/CVYJ5SDPtmG67yB94ESV TIUZGoMsqrWrA5WcBLlH+pR7ra2LrJX9gxUR82UiRUTwSOpkjB8JelB36QXcHJlF nTODUv5y8WqbJKy/gLTTBntXisLXKoL/z6mYurLtgfYmmUkhP5YytAgtNcMn3tjI opmZhEzXQTbDy3IvdGmiW6nyFCmMw+x0fDWvq8zJx82wE7a63445a+WvkC/UM/Op DlL3whf52Sv0Xj0/C6fvJusm18Zg0aaWB/0IwTY0Nh5HR7q9hLU= =6IIt -----END PGP SIGNATURE----- --WR+jf/RUebEcofwt--