From: Arnaldo Carvalho de Melo <acme@kernel.org>
To: Daniel Borkmann <daniel@iogearbox.net>
Cc: Jiri Olsa <jolsa@kernel.org>, Alexei Starovoitov <ast@kernel.org>,
Andrii Nakryiko <andriin@fb.com>, Yonghong Song <yhs@fb.com>,
netdev@vger.kernel.org, bpf@vger.kernel.org,
Martin KaFai Lau <kafai@fb.com>, Song Liu <songliubraving@fb.com>,
John Fastabend <john.fastabend@gmail.com>,
KP Singh <kpsingh@chromium.org>
Subject: Re: [PATCHv6 bpf] bpf: Move iterator functions into special init section
Date: Wed, 11 Nov 2020 09:38:20 -0300 [thread overview]
Message-ID: <20201111123820.GF355344@kernel.org> (raw)
In-Reply-To: <20201111123738.GE355344@kernel.org>
Em Wed, Nov 11, 2020 at 09:37:38AM -0300, Arnaldo Carvalho de Melo escreveu:
> Em Wed, Nov 11, 2020 at 12:26:29PM +0100, Daniel Borkmann escreveu:
> > On 11/10/20 4:40 PM, Jiri Olsa wrote:
> > > With upcoming changes to pahole, that change the way how and
> > > which kernel functions are stored in BTF data, we need a way
> > > to recognize iterator functions.
> > >
> > > Iterator functions need to be in BTF data, but have no real
> > > body and are currently placed in .init.text section, so they
> > > are freed after kernel init and are filtered out of BTF data
> > > because of that.
> > >
> > > The solution is to place these functions under new section:
> > > .init.bpf.preserve_type
> > >
> > > And add 2 new symbols to mark that area:
> > > __init_bpf_preserve_type_begin
> > > __init_bpf_preserve_type_end
> > >
> > > The code in pahole responsible for picking up the functions will
> > > be able to recognize functions from this section and add them to
> > > the BTF data and filter out all other .init.text functions.
> > >
> > > Cc: Arnaldo Carvalho de Melo <acme@kernel.org>
> > > Suggested-by: Yonghong Song <yhs@fb.com>
> > > Signed-off-by: Jiri Olsa <jolsa@redhat.com>
> >
> > LGTM, applied, thanks! Also added a reference to the pahole commit
>
> Applied to what branch? I'm trying to test it now :-)
Nevermind, bpf/master, I was looking at bpf-next/master.
- Arnaldo
next prev parent reply other threads:[~2020-11-11 12:38 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-10 15:40 [PATCHv6 bpf] bpf: Move iterator functions into special init section Jiri Olsa
2020-11-11 11:26 ` Daniel Borkmann
2020-11-11 11:51 ` Jiri Olsa
2020-11-11 12:37 ` Arnaldo Carvalho de Melo
2020-11-11 12:38 ` Arnaldo Carvalho de Melo [this message]
2020-11-11 20:09 ` Alexei Starovoitov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201111123820.GF355344@kernel.org \
--to=acme@kernel.org \
--cc=andriin@fb.com \
--cc=ast@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=daniel@iogearbox.net \
--cc=john.fastabend@gmail.com \
--cc=jolsa@kernel.org \
--cc=kafai@fb.com \
--cc=kpsingh@chromium.org \
--cc=netdev@vger.kernel.org \
--cc=songliubraving@fb.com \
--cc=yhs@fb.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.