From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: virtio-comment-return-1509-cohuck=redhat.com@lists.oasis-open.org Sender: List-Post: List-Help: List-Unsubscribe: List-Subscribe: Received: from lists.oasis-open.org (oasis-open.org [10.110.1.242]) by lists.oasis-open.org (Postfix) with ESMTP id 91A3A986073 for ; Thu, 12 Nov 2020 07:45:20 +0000 (UTC) Date: Thu, 12 Nov 2020 08:45:01 +0100 From: Cornelia Huck Message-ID: <20201112084501.491f3d6b.cohuck@redhat.com> In-Reply-To: References: <159836664741.231431.2775539890399592989.stgit@ahduyck-workstation> <159836670239.231431.14835898822569373567.stgit@ahduyck-workstation> <2faa1a86-fc9c-f325-00f0-99df49b2421d@siemens.com> <20200914081355.71f0d3f7.cohuck@redhat.com> <20200916092827-mutt-send-email-mst@kernel.org> <20201111190337.1bf64e7a.cohuck@redhat.com> MIME-Version: 1.0 Subject: Re: [virtio-comment] Re: [virtio-dev] [PATCH v8 1/3] content: Document balloon feature free page hints Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit To: Alexander Duyck Cc: "Michael S. Tsirkin" , Jan Kiszka , David Hildenbrand , virtio-comment@lists.oasis-open.org, virtio-dev@lists.oasis-open.org, "Wang, Wei W" List-ID: On Wed, 11 Nov 2020 14:09:23 -0800 Alexander Duyck wrote: > On Wed, Nov 11, 2020 at 10:03 AM Cornelia Huck wrote: > > > > On Wed, 16 Sep 2020 09:28:34 -0400 > > "Michael S. Tsirkin" wrote: > > > > > On Mon, Sep 14, 2020 at 08:13:55AM +0200, Cornelia Huck wrote: > > > > On Fri, 11 Sep 2020 08:11:15 -0700 > > > > Alexander Duyck wrote: > > > > > > > > > On Thu, Sep 10, 2020 at 10:28 PM Jan Kiszka wrote: > > > > > > > > > > > > On 04.09.20 18:56, Alexander Duyck wrote: > > > > > > > On Fri, Sep 4, 2020 at 8:20 AM Jan Kiszka wrote: > > > > > > >> > > > > > > >> On 25.08.20 16:45, Alexander Duyck wrote: > > > > > > > > > > >>> @@ -5042,13 +5049,17 @@ \subsection{Feature bits}\label{sec:Device Types / Memory Balloon Device / Featu > > > > > > >>> VIRTIO_BALLOON_F_MUST_TELL_HOST is not negotiated. > > > > > > >>> > > > > > > >>> \subsection{Device configuration layout}\label{sec:Device Types / Memory Balloon Device / Device configuration layout} > > > > > > >>> - Both fields of this configuration > > > > > > >>> - are always available. > > > > > > >>> + \field{num_pages} and \field{actual} are always available. > > > > > > >>> + > > > > > > >>> + \field{free_page_hint_cmd_id} is available if > > > > > > >>> + VIRTIO_BALLOON_F_FREE_PAGE_HINT has been negotiated and is read-only by > > > > > > >>> + the driver. > > > > > > >> > > > > > > >> This reads at least to me like "...if VIRTIO_BALLOON_F_FREE_PAGE_HINT > > > > > > >> ... is read-only by the driver". I suspect you rather meant > > > > > > >> "free_page_hint_cmd_id is read-only...". Maybe split up into two sentences? > > > > > > > > > > > > > > Yes, the intention is: > > > > > > > 1. free_page_hint_cmd_id is only available if > > > > > > > VIRTIO_BALLOON_F_FREE_PAGE_HINT has been negotiated > > > > > > > 2. free_page_hint_cmd_id is read only by the driver > > > > > > > > > > > > > > If needed I suppose we could break it up by splitting it into two > > > > > > > sentences, or adding "the field" after the "and". > > > > > > > > > > > > > > > > > > > I'm fine with both options but please adjust this - on top (Michael just > > > > > > opened the voting for this version again due to the formal typo in round 1). > > > > > > > > > > > > Jan > > > > > > > > > > Since the patch set is being voted on is there a preferred method for > > > > > making this sort of update? I'm just wondering if I should do an > > > > > additional incremental patch, just submit a replacement for this > > > > > patch, or make the change and resubmit the entire patch set? > > > > > > > > I think doing an additional patch on top and then doing another vote on > > > > that is the best way to handle this. (Or maybe it is minor enough to > > > > simply merge the incremental patch?) > > > > > > yes, this sounds good to me > > > > Which one of the options, actually? I'd be happy to merge a proper > > patch on top (which I'd consider a trivial fix.) > > I had submitted a 4/3 for this set that was meant to fix it, but > looking it over I don't think it would apply cleanly as I think I had > only applied the patch it fixed and didn't have the poison patch > applied when I generated it. If you need I can resubmit that patch as > a trivial fix since it is only a 2 line change. Thanks, that would be great. > > Thanks. > > - Alex > This publicly archived list offers a means to provide input to the OASIS Virtual I/O Device (VIRTIO) TC. In order to verify user consent to the Feedback License terms and to minimize spam in the list archive, subscription is required before posting. Subscribe: virtio-comment-subscribe@lists.oasis-open.org Unsubscribe: virtio-comment-unsubscribe@lists.oasis-open.org List help: virtio-comment-help@lists.oasis-open.org List archive: https://lists.oasis-open.org/archives/virtio-comment/ Feedback License: https://www.oasis-open.org/who/ipr/feedback_license.pdf List Guidelines: https://www.oasis-open.org/policies-guidelines/mailing-lists Committee: https://www.oasis-open.org/committees/virtio/ Join OASIS: https://www.oasis-open.org/join/