From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.5 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,FSL_HELO_FAKE,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1D221C388F7 for ; Fri, 13 Nov 2020 08:38:22 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 9D66220B80 for ; Fri, 13 Nov 2020 08:38:21 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b="Uxfg/gsx" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 9D66220B80 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=chromium.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id D935C6E44F; Fri, 13 Nov 2020 08:38:03 +0000 (UTC) Received: from mail-pg1-x52f.google.com (mail-pg1-x52f.google.com [IPv6:2607:f8b0:4864:20::52f]) by gabe.freedesktop.org (Postfix) with ESMTPS id A58B96E10D for ; Thu, 12 Nov 2020 09:10:01 +0000 (UTC) Received: by mail-pg1-x52f.google.com with SMTP id z24so3661280pgk.3 for ; Thu, 12 Nov 2020 01:10:01 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=k4jNN4/h3s3NV1F+0Q0WzcgOTkCPpVphwH4WUMWMcI8=; b=Uxfg/gsxqnYTbyI4zPBy3DPpJCBbX5CGLrrfi0KExaYAzoThCHOXOQ1hSI5ZnPSrcG RJR3eefL0HKhCqAy/F05y5EGaSVgtQ6y0uXVxdInxuOtfEn8chJarRQdl5pZ2mShd+04 K7nhMZzkl5H0kRqWrFwe6zbKKxRPTMY5qVttw= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=k4jNN4/h3s3NV1F+0Q0WzcgOTkCPpVphwH4WUMWMcI8=; b=r4+b0BbXmciy87LTcAn3t8T86D8w6SeYbxIy4gQls3iivxj3SADm1T28zEbwjJx2b2 938I48jqZNKmT8S0Ey5YGR6L4qnJaQEs60dx8MEIoQu7/eLT/rS0YkeeGgZZOi+SBWKg zGB5953g2NkE2nHh4cOye04rC+dDk5JZcMjeA2Q/ZW4SOXctKWFajUgxOBxYZzBhA+G7 9Fst1z2E38prFr3gsJsJP2j/jnjqMJGL2ziMtikwGpA++ly2GergbPRU8sRarAD2q7lZ Tb9om3XdKFPUh3ffqdiyIuueMooym6HoEosPPha8qCasKDgHUxCRiU//XTqSKezGIVmD KaRQ== X-Gm-Message-State: AOAM531z2b0EMH0rkmb+fBjefsDwHgTw9Vcck5MgYPwpwACuPkGLsdqG iwF5N841/GfWwx9brAIIstBb2w== X-Google-Smtp-Source: ABdhPJywHYqw1gmRPzduqhVbO8h5JLcgcIW+D9FrFiL5xpMLx94ZxY7IQYZKNYP9xrsabRAKTh4tpg== X-Received: by 2002:a17:90a:6b0d:: with SMTP id v13mr8609605pjj.206.1605172201298; Thu, 12 Nov 2020 01:10:01 -0800 (PST) Received: from google.com ([2620:15c:202:201:a28c:fdff:fef0:49dd]) by smtp.gmail.com with ESMTPSA id e10sm5427187pfh.38.2020.11.12.01.10.00 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 12 Nov 2020 01:10:00 -0800 (PST) Date: Thu, 12 Nov 2020 01:09:59 -0800 From: Prashant Malani To: Pi-Hsun Shih Subject: Re: [PATCH] drm/bridge: anx7625: Add anx7625 port switching. Message-ID: <20201112090959.GC1367855@google.com> References: <20201112064051.3716968-1-pihsun@chromium.org> <20201112085920.GB1367855@google.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-Mailman-Approved-At: Fri, 13 Nov 2020 08:38:02 +0000 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Jernej Skrabec , Nicolas Boichat , Jonas Karlman , David Airlie , Neil Armstrong , open list , "open list:DRM DRIVERS" , Andrzej Hajda , heikki.krogerus@linux.intel.com, Laurent Pinchart , Sam Ravnborg , Xin Ji Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" On Thu, Nov 12, 2020 at 05:07:05PM +0800, Pi-Hsun Shih wrote: > Hi Prashant, > > Please see inline reply as below. > > On Thu, Nov 12, 2020 at 4:59 PM Prashant Malani wrote: > > > > Hi Pi-Hsun, > > > > I haven't gone through the code, but did have a high-level comment > > (kindly see inline) > > > > On Thu, Nov 12, 2020 at 02:40:40PM +0800, Pi-Hsun Shih wrote: > > > When output 2 lanes DP data, anx7625 can output to either TX1/RX1 or > > > TX2/RX2. In typical usage, these two TX/RX pairs corresponds to two > > > orientations of typec. > > > > > > On some board one anx7625 is used as DPI to DP converter for two typec > > > ports. In this case, the TX1/RX1 and TX2/RX2 are connected to two usb > > > muxes, which mux the DP data with the rest of the USB3 data, and > > > connects to the two typec ports. > > > > > > This patch adds option for anx7625 to acts as a usb typec switch and > > > switch output lanes based on the typec orientation, or acts as two usb > > > typec mux and switch output lanes depending on whether the two ports > > > currently has DP enabled. > > > > > > Signed-off-by: Pi-Hsun Shih > > > > > > ==================================================================== > > > > > > This is an attempt to use typec framework with how we're using anx7625 > > > on Chrome OS asurada board. > > > > > > An example of the dts for the two ports case can be found at > > > https://crrev.com/c/2507199/6 > > > > Do you plan on submitting DT schemas & bindings documentation for the switch(es) > > that are intended to be used? > > Yes I plan to submit corresponding DT schemas & bindings documentation > changes if this change looks good. > That's great. Thanks for confirming :) BR, -Prashant _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,FSL_HELO_FAKE, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7CC3EC2D0A3 for ; Thu, 12 Nov 2020 09:10:04 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 102A1206E3 for ; Thu, 12 Nov 2020 09:10:04 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b="Uxfg/gsx" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727290AbgKLJKD (ORCPT ); Thu, 12 Nov 2020 04:10:03 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37582 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726061AbgKLJKC (ORCPT ); Thu, 12 Nov 2020 04:10:02 -0500 Received: from mail-pg1-x532.google.com (mail-pg1-x532.google.com [IPv6:2607:f8b0:4864:20::532]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id ACADBC0613D1 for ; Thu, 12 Nov 2020 01:10:01 -0800 (PST) Received: by mail-pg1-x532.google.com with SMTP id i13so3636120pgm.9 for ; Thu, 12 Nov 2020 01:10:01 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=k4jNN4/h3s3NV1F+0Q0WzcgOTkCPpVphwH4WUMWMcI8=; b=Uxfg/gsxqnYTbyI4zPBy3DPpJCBbX5CGLrrfi0KExaYAzoThCHOXOQ1hSI5ZnPSrcG RJR3eefL0HKhCqAy/F05y5EGaSVgtQ6y0uXVxdInxuOtfEn8chJarRQdl5pZ2mShd+04 K7nhMZzkl5H0kRqWrFwe6zbKKxRPTMY5qVttw= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=k4jNN4/h3s3NV1F+0Q0WzcgOTkCPpVphwH4WUMWMcI8=; b=kwPyXljoLL3aZddZ4Jk7/LkdHkFx/6GN3a2+6xiqDOjs4wdylNAedF2EKde2l3LRM5 riXkdDXovh7mPyC4qkvvztfYYd2M1xgjZJjT24tUMB5TEi2AxvzAPFZC2IuRl6fdHynN 6p14hi62p+LI1ESUH2XAu3mIe6ujUsrtwoR20FJd6iyxgzA1Fbp3t/eOxq+Xel3EgoCr QwT5IJbkESi670E4suvcoBr8w+NKJP9yV0+Zd4SaDXMtR0s1/5pVtZ/fh3AhFy/WVsVW UC24sZGbS3g7C4UbMTDAv9TlbDfU5EIIVoO5fMynHt5aOyQqV7XoHrmVVeBaffTYgzwL 9Ruw== X-Gm-Message-State: AOAM531d6y+BsvdAcHPEXh/xvucIsrmWGjqbgU/QxJgEkI9SkbUPSQG9 YLr/uuc0DPD6ChjU69ZQC7CHxw== X-Google-Smtp-Source: ABdhPJywHYqw1gmRPzduqhVbO8h5JLcgcIW+D9FrFiL5xpMLx94ZxY7IQYZKNYP9xrsabRAKTh4tpg== X-Received: by 2002:a17:90a:6b0d:: with SMTP id v13mr8609605pjj.206.1605172201298; Thu, 12 Nov 2020 01:10:01 -0800 (PST) Received: from google.com ([2620:15c:202:201:a28c:fdff:fef0:49dd]) by smtp.gmail.com with ESMTPSA id e10sm5427187pfh.38.2020.11.12.01.10.00 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 12 Nov 2020 01:10:00 -0800 (PST) Date: Thu, 12 Nov 2020 01:09:59 -0800 From: Prashant Malani To: Pi-Hsun Shih Cc: Nicolas Boichat , Andrzej Hajda , Neil Armstrong , Laurent Pinchart , Jonas Karlman , Jernej Skrabec , David Airlie , Daniel Vetter , Xin Ji , Sam Ravnborg , "open list:DRM DRIVERS" , open list , heikki.krogerus@linux.intel.com Subject: Re: [PATCH] drm/bridge: anx7625: Add anx7625 port switching. Message-ID: <20201112090959.GC1367855@google.com> References: <20201112064051.3716968-1-pihsun@chromium.org> <20201112085920.GB1367855@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Nov 12, 2020 at 05:07:05PM +0800, Pi-Hsun Shih wrote: > Hi Prashant, > > Please see inline reply as below. > > On Thu, Nov 12, 2020 at 4:59 PM Prashant Malani wrote: > > > > Hi Pi-Hsun, > > > > I haven't gone through the code, but did have a high-level comment > > (kindly see inline) > > > > On Thu, Nov 12, 2020 at 02:40:40PM +0800, Pi-Hsun Shih wrote: > > > When output 2 lanes DP data, anx7625 can output to either TX1/RX1 or > > > TX2/RX2. In typical usage, these two TX/RX pairs corresponds to two > > > orientations of typec. > > > > > > On some board one anx7625 is used as DPI to DP converter for two typec > > > ports. In this case, the TX1/RX1 and TX2/RX2 are connected to two usb > > > muxes, which mux the DP data with the rest of the USB3 data, and > > > connects to the two typec ports. > > > > > > This patch adds option for anx7625 to acts as a usb typec switch and > > > switch output lanes based on the typec orientation, or acts as two usb > > > typec mux and switch output lanes depending on whether the two ports > > > currently has DP enabled. > > > > > > Signed-off-by: Pi-Hsun Shih > > > > > > ==================================================================== > > > > > > This is an attempt to use typec framework with how we're using anx7625 > > > on Chrome OS asurada board. > > > > > > An example of the dts for the two ports case can be found at > > > https://crrev.com/c/2507199/6 > > > > Do you plan on submitting DT schemas & bindings documentation for the switch(es) > > that are intended to be used? > > Yes I plan to submit corresponding DT schemas & bindings documentation > changes if this change looks good. > That's great. Thanks for confirming :) BR, -Prashant