From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 856C0C2D0A3 for ; Thu, 12 Nov 2020 09:40:40 +0000 (UTC) Received: from silver.osuosl.org (smtp3.osuosl.org [140.211.166.136]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 988D8221FC for ; Thu, 12 Nov 2020 09:40:39 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 988D8221FC Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=lst.de Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=iommu-bounces@lists.linux-foundation.org Received: from localhost (localhost [127.0.0.1]) by silver.osuosl.org (Postfix) with ESMTP id 1440420463; Thu, 12 Nov 2020 09:40:39 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from silver.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id dXRdnnfyuo-j; Thu, 12 Nov 2020 09:40:38 +0000 (UTC) Received: from lists.linuxfoundation.org (lf-lists.osuosl.org [140.211.9.56]) by silver.osuosl.org (Postfix) with ESMTP id 1127020348; Thu, 12 Nov 2020 09:40:38 +0000 (UTC) Received: from lf-lists.osuosl.org (localhost [127.0.0.1]) by lists.linuxfoundation.org (Postfix) with ESMTP id EACF6C08A1; Thu, 12 Nov 2020 09:40:37 +0000 (UTC) Received: from fraxinus.osuosl.org (smtp4.osuosl.org [140.211.166.137]) by lists.linuxfoundation.org (Postfix) with ESMTP id 975ADC0889 for ; Thu, 12 Nov 2020 09:40:36 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by fraxinus.osuosl.org (Postfix) with ESMTP id 85F6986E64 for ; Thu, 12 Nov 2020 09:40:36 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from fraxinus.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id GB2Qy11hbfmw for ; Thu, 12 Nov 2020 09:40:35 +0000 (UTC) X-Greylist: from auto-whitelisted by SQLgrey-1.7.6 Received: from verein.lst.de (verein.lst.de [213.95.11.211]) by fraxinus.osuosl.org (Postfix) with ESMTPS id 356EC86E59 for ; Thu, 12 Nov 2020 09:40:35 +0000 (UTC) Received: by verein.lst.de (Postfix, from userid 2407) id 1A9D367373; Thu, 12 Nov 2020 10:40:31 +0100 (CET) Date: Thu, 12 Nov 2020 10:40:30 +0100 From: Christoph Hellwig To: Jason Gunthorpe Subject: Re: remove dma_virt_ops v2 Message-ID: <20201112094030.GA19550@lst.de> References: <20201106181941.1878556-1-hch@lst.de> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20201106181941.1878556-1-hch@lst.de> User-Agent: Mutt/1.5.17 (2007-11-01) Cc: rds-devel@oss.oracle.com, Zhu Yanjun , Dennis Dalessandro , linux-rdma@vger.kernel.org, linux-pci@vger.kernel.org, Mike Marciniszyn , iommu@lists.linux-foundation.org, Bjorn Helgaas , Bernard Metzler , Logan Gunthorpe , Santosh Shilimkar X-BeenThere: iommu@lists.linux-foundation.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: Development issues for Linux IOMMU support List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: iommu-bounces@lists.linux-foundation.org Sender: "iommu" ping? On Fri, Nov 06, 2020 at 07:19:31PM +0100, Christoph Hellwig wrote: > Hi Jason, > > this series switches the RDMA core to opencode the special case of > devices bypassing the DMA mapping in the RDMA ULPs. The virt ops > have caused a bit of trouble due to the P2P code node working with > them due to the fact that we'd do two dma mapping iterations for a > single I/O, but also are a bit of layering violation and lead to > more code than necessary. > > Tested with nvme-rdma over rxe. > > Note that the rds changes are untested, as I could not find any > simple rds test setup. > > Changes since v2: > - simplify the INFINIBAND_VIRT_DMA dependencies > - add a ib_uses_virt_dma helper > - use ib_uses_virt_dma in nvmet-rdma to disable p2p for virt_dma devices > - use ib_dma_max_seg_size in umem > - stop using dmapool in rds > > Changes since v1: > - disable software RDMA drivers for highmem configs > - update the PCI commit logs ---end quoted text--- _______________________________________________ iommu mailing list iommu@lists.linux-foundation.org https://lists.linuxfoundation.org/mailman/listinfo/iommu From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 45B3CC2D0A3 for ; Thu, 12 Nov 2020 09:40:35 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id E592C221FC for ; Thu, 12 Nov 2020 09:40:34 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726028AbgKLJke (ORCPT ); Thu, 12 Nov 2020 04:40:34 -0500 Received: from verein.lst.de ([213.95.11.211]:42940 "EHLO verein.lst.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725928AbgKLJke (ORCPT ); Thu, 12 Nov 2020 04:40:34 -0500 Received: by verein.lst.de (Postfix, from userid 2407) id 1A9D367373; Thu, 12 Nov 2020 10:40:31 +0100 (CET) Date: Thu, 12 Nov 2020 10:40:30 +0100 From: Christoph Hellwig To: Jason Gunthorpe Cc: Bjorn Helgaas , Bernard Metzler , Zhu Yanjun , Logan Gunthorpe , Dennis Dalessandro , Mike Marciniszyn , Santosh Shilimkar , linux-rdma@vger.kernel.org, rds-devel@oss.oracle.com, linux-pci@vger.kernel.org, iommu@lists.linux-foundation.org Subject: Re: remove dma_virt_ops v2 Message-ID: <20201112094030.GA19550@lst.de> References: <20201106181941.1878556-1-hch@lst.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20201106181941.1878556-1-hch@lst.de> User-Agent: Mutt/1.5.17 (2007-11-01) Precedence: bulk List-ID: X-Mailing-List: linux-pci@vger.kernel.org ping? On Fri, Nov 06, 2020 at 07:19:31PM +0100, Christoph Hellwig wrote: > Hi Jason, > > this series switches the RDMA core to opencode the special case of > devices bypassing the DMA mapping in the RDMA ULPs. The virt ops > have caused a bit of trouble due to the P2P code node working with > them due to the fact that we'd do two dma mapping iterations for a > single I/O, but also are a bit of layering violation and lead to > more code than necessary. > > Tested with nvme-rdma over rxe. > > Note that the rds changes are untested, as I could not find any > simple rds test setup. > > Changes since v2: > - simplify the INFINIBAND_VIRT_DMA dependencies > - add a ib_uses_virt_dma helper > - use ib_uses_virt_dma in nvmet-rdma to disable p2p for virt_dma devices > - use ib_dma_max_seg_size in umem > - stop using dmapool in rds > > Changes since v1: > - disable software RDMA drivers for highmem configs > - update the PCI commit logs ---end quoted text---