From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E2D84C2D0A3 for ; Thu, 12 Nov 2020 13:22:23 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 616DA207BB for ; Thu, 12 Nov 2020 13:22:23 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="OPC+OLcr"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="ChYlv/qg" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 616DA207BB Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=OSG96QWPJYnGH/NeGygcwGT4QyIc94pD+xpBHYRmzCI=; b=OPC+OLcrlIJR45oVS4HkBWrY2 MTSu9TEVfeYHu0TLbYBB1hBWBPKNb1GJC3hF0mO32HTzZwV9rkL5nmYpPKXb/YI9QGc8TIWiNxwNj 9r624fYrRmYMQdxsgbJNZt2Ac1giDoXjPpHB3EtqS+c36/pKCO2LyVaPBE0Ekyc3JtgIrGI5TzW3/ lDlJE790uDRPLxBiw0C6Ic1w10LjZH6inykaoFw4QNj7YqAIykjbszdQxgu11xuINEvTUIQghGtQf zgGMouTDh7zzSwBswpnL20vAgoenr2H22LDjz3jeGKcF1FD4985TA/0BcuQV1p56AjSYD+AV8zoZq J3piJOdzw==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kdCXw-0002Rg-LG; Thu, 12 Nov 2020 13:21:52 +0000 Received: from mail-wm1-x341.google.com ([2a00:1450:4864:20::341]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kdCXs-0002Pm-VL for linux-arm-kernel@lists.infradead.org; Thu, 12 Nov 2020 13:21:50 +0000 Received: by mail-wm1-x341.google.com with SMTP id a3so5479250wmb.5 for ; Thu, 12 Nov 2020 05:21:48 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to; bh=t9OC41HUdp70sOva3B5Vc7/7aPmDJPqNV434fyKFWd8=; b=ChYlv/qgnWkGwE4gX1d9DmQt6LtEp0m6NV8y03tQDfbaQqzh4kPhBJ36iK0zIABNs/ GrgZFdcJ6+LMqBqUK4Mn3NcWSi9Mpsa5apDJzuHmT+dFLVi4LawGT9DkjLcC3lu6k2Ah OEAuBZ1qCpotgOqL0kBlV41VUzUBesC3j1Jr+8BASn1bGwrTMY82iV2xrgoEnY2FK735 14qrCGNH9020dbVa2cMzCy+bQZUOU3dhQBKKJSlF9da5hLLZ1Wed68SfC/oCYNLX/k0t cV/+x21+8O5GZ3IstzC6rITx1cHmOcol9ZSMZSoHrFhdI9TXEuyKmzoDiCrdJyjkFfqo a7gg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to; bh=t9OC41HUdp70sOva3B5Vc7/7aPmDJPqNV434fyKFWd8=; b=gxqihXmz053QcAf0IZNfMhK19BpHAnTELxZ5dVrmeSsoUrjT6i2gLN3SxhKH5GHk3e 9vMBs1VpeoPQ0Yuh3Lya26uw9lOgcy2UWOYLt+kRfXaF4ZMk92/QkYo0iGu0s2FGmrtq E9U0NUlYTKAgUUhDxoNkyFt+dp8XIsEQAMHrCAYGkGSCjIPwnfKskYmyNvATHmzMGNJA ZucvPmt6LKG6ZD8fDMxt8SPWbzRi3d0qe39muowxtnOp7Ir5fs3n/vqEe31brR+mP7Su 5Jv7dOHCiHOc4OW2a6Oi2+O5rBeMI7+i+/J3vOMSRQdI4C/QkRfM774hd1BkfNmFDcoZ csBQ== X-Gm-Message-State: AOAM530cNbMoU8O3x4uBHPYmmuZvQ6TflWD+lvJjTZx+n3J8U8ya79IT dxQflkbue0NnWMyMrV7FoY033w== X-Google-Smtp-Source: ABdhPJx+wFwlN4lWlCgL8nnuzrTwqxxyou9TYpunw0FdVf+yGZpzZZ69I4ffNfwwUzhYAludRve/OQ== X-Received: by 2002:a1c:3d4:: with SMTP id 203mr9441354wmd.52.1605187307871; Thu, 12 Nov 2020 05:21:47 -0800 (PST) Received: from dell ([91.110.221.159]) by smtp.gmail.com with ESMTPSA id g66sm6496468wmg.37.2020.11.12.05.21.46 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 12 Nov 2020 05:21:47 -0800 (PST) Date: Thu, 12 Nov 2020 13:21:45 +0000 From: Lee Jones To: Tero Kristo Subject: Re: [PATCH 06/25] soc: ti: knav_qmss_queue: Remove set but unchecked variable 'ret' Message-ID: <20201112132145.GI1997862@dell> References: <20201103152838.1290217-1-lee.jones@linaro.org> <20201103152838.1290217-7-lee.jones@linaro.org> <20201112103130.GD1997862@dell> <30ad256b-07f0-f01e-ec4f-c12cf9dbe426@ti.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <30ad256b-07f0-f01e-ec4f-c12cf9dbe426@ti.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20201112_082149_050006_340A2B5D X-CRM114-Status: GOOD ( 16.41 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-kernel@vger.kernel.org, kishon@ti.com, tomi.valkeinen@ti.com, dmurphy@ti.com, Santosh Shilimkar , linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org T24gVGh1LCAxMiBOb3YgMjAyMCwgVGVybyBLcmlzdG8gd3JvdGU6Cgo+IE9uIDEyLzExLzIwMjAg MTI6MzEsIExlZSBKb25lcyB3cm90ZToKPiA+IENjOmluZyBhIGZldyBwZW9wbGUgSSBrbm93Lgo+ ID4gCj4gPiBPbiBUdWUsIDAzIE5vdiAyMDIwLCBMZWUgSm9uZXMgd3JvdGU6Cj4gPiAKPiA+ID4g Rml4ZXMgdGhlIGZvbGxvd2luZyBXPTEga2VybmVsIGJ1aWxkIHdhcm5pbmcocyk6Cj4gPiA+IAo+ ID4gPiAgIGRyaXZlcnMvc29jL3RpL2tuYXZfcW1zc19xdWV1ZS5jOiBJbiBmdW5jdGlvbiDigJhr bmF2X3NldHVwX3F1ZXVlX3Bvb2xz4oCZOgo+ID4gPiAgIGRyaXZlcnMvc29jL3RpL2tuYXZfcW1z c19xdWV1ZS5jOjEzMTA6Njogd2FybmluZzogdmFyaWFibGUg4oCYcmV04oCZIHNldCBidXQgbm90 IHVzZWQgWy1XdW51c2VkLWJ1dC1zZXQtdmFyaWFibGVdCj4gPiA+IAo+ID4gPiBDYzogU2FudG9z aCBTaGlsaW1rYXIgPHNzYW50b3NoQGtlcm5lbC5vcmc+Cj4gPiA+IENjOiBTYW5kZWVwIE5haXIg PHNhbmRlZXBfbkB0aS5jb20+Cj4gPiA+IENjOiBDeXJpbCBDaGVtcGFyYXRoeSA8Y3lyaWxAdGku Y29tPgo+ID4gPiBTaWduZWQtb2ZmLWJ5OiBMZWUgSm9uZXMgPGxlZS5qb25lc0BsaW5hcm8ub3Jn Pgo+ID4gPiAtLS0KPiA+ID4gICBkcml2ZXJzL3NvYy90aS9rbmF2X3Ftc3NfcXVldWUuYyB8IDMg Ky0tCj4gPiA+ICAgMSBmaWxlIGNoYW5nZWQsIDEgaW5zZXJ0aW9uKCspLCAyIGRlbGV0aW9ucygt KQo+ID4gCj4gPiBBbnkgaWRlYSB3aG8gd2lsbCB0YWtlIHRoZXNlIFRJIHBhdGNoZXM/Cj4gPiAK PiA+IGh0dHBzOi8vbG9yZS5rZXJuZWwub3JnL2xpbnV4LWFybS1rZXJuZWwvMjAyMDExMTEwNTI1 NDAuR0gxNzM5NDhAYnVpbGRlci5sYW4vCj4gPiAKPiAKPiAoRHJvcHBlZCBhIGZldyBpbmFjdGl2 ZSBlbWFpbHMgZnJvbSBkZWxpdmVyeS4pCj4gCj4gU2FudG9zaCBpcyB0aGUgbWFpbnRhaW5lciBm b3IgdGhlIHN1YnN5c3RlbSwgc28gbXkgdm90ZSB3b3VsZCBnbyBmb3IgaGltLgoKVGhhbmtzIGZv ciB5b3VyIHByb21wdCByZXBseSBUZXJvLgoKSXQgbG9va3MgYXMgdGhvdWdoIFNhbnRvc2ggaGFz IGJlZW4gb24gQ2Mgc2luY2UgdGhlIHN0YXJ0LiAgSGUgbXVzdApqdXN0IGJlIGJ1c3kuICBJJ2xs IGdpdmUgaGltIGEgbGl0dGxlIHdoaWxlIGxvbmdlciBiZWZvcmUgc3VibWl0dGluZyBhCltSRVNF TkRdLgoKLS0gCkxlZSBKb25lcyBb5p2O55C85pavXQpTZW5pb3IgVGVjaG5pY2FsIExlYWQgLSBE ZXZlbG9wZXIgU2VydmljZXMKTGluYXJvLm9yZyDilIIgT3BlbiBzb3VyY2Ugc29mdHdhcmUgZm9y IEFybSBTb0NzCkZvbGxvdyBMaW5hcm86IEZhY2Vib29rIHwgVHdpdHRlciB8IEJsb2cKCl9fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCmxpbnV4LWFybS1rZXJu ZWwgbWFpbGluZyBsaXN0CmxpbnV4LWFybS1rZXJuZWxAbGlzdHMuaW5mcmFkZWFkLm9yZwpodHRw Oi8vbGlzdHMuaW5mcmFkZWFkLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2xpbnV4LWFybS1rZXJuZWwK From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5AD25C61DD8 for ; Thu, 12 Nov 2020 13:21:51 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id EFDC42220B for ; Thu, 12 Nov 2020 13:21:50 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="ChYlv/qg" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728361AbgKLNVt (ORCPT ); Thu, 12 Nov 2020 08:21:49 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:48650 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727646AbgKLNVt (ORCPT ); Thu, 12 Nov 2020 08:21:49 -0500 Received: from mail-wm1-x341.google.com (mail-wm1-x341.google.com [IPv6:2a00:1450:4864:20::341]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 319A8C0613D1 for ; Thu, 12 Nov 2020 05:21:49 -0800 (PST) Received: by mail-wm1-x341.google.com with SMTP id a65so5510917wme.1 for ; Thu, 12 Nov 2020 05:21:49 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to; bh=t9OC41HUdp70sOva3B5Vc7/7aPmDJPqNV434fyKFWd8=; b=ChYlv/qgnWkGwE4gX1d9DmQt6LtEp0m6NV8y03tQDfbaQqzh4kPhBJ36iK0zIABNs/ GrgZFdcJ6+LMqBqUK4Mn3NcWSi9Mpsa5apDJzuHmT+dFLVi4LawGT9DkjLcC3lu6k2Ah OEAuBZ1qCpotgOqL0kBlV41VUzUBesC3j1Jr+8BASn1bGwrTMY82iV2xrgoEnY2FK735 14qrCGNH9020dbVa2cMzCy+bQZUOU3dhQBKKJSlF9da5hLLZ1Wed68SfC/oCYNLX/k0t cV/+x21+8O5GZ3IstzC6rITx1cHmOcol9ZSMZSoHrFhdI9TXEuyKmzoDiCrdJyjkFfqo a7gg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to; bh=t9OC41HUdp70sOva3B5Vc7/7aPmDJPqNV434fyKFWd8=; b=kTKhEB8DTTh253XyWZqrlKgahQ8iCUFR9Fi67pVhoYOCWeW0C8WcDzyOeAhOt6B83o ZH+vNNJe1XUvnFZkAAxrtHZxz/V8EDA8JugWmYTIobjeUbSwj+SkqBCU8Nn9V5EGUdHP P6BqjtL1e5ydsB8IYhd2V+fSX/Wdb4g/h8XZA+gj3ZA7rFzhr0CF0MBLzbkS75SPOKyk pSCTsMiV5V7JFGsj7zw/BrGunw6n8+qQfl4dPcWxxau+1+z7SYQ1bzZb1DRDy0cI6hyk 4313lcx01jt6WVuJH+gD7vU8JYc+cYXwomIB94LFV1VslnFPVyvgZpPP4t9tI+dIUbXJ xd6w== X-Gm-Message-State: AOAM530SQdB1axEqDwWLW+IdZd4HuXvoo5JQGQ8AiDddijcN5y3mPNMU /6vOqVWMeD6l+0SNVSbqtOY2Cw== X-Google-Smtp-Source: ABdhPJx+wFwlN4lWlCgL8nnuzrTwqxxyou9TYpunw0FdVf+yGZpzZZ69I4ffNfwwUzhYAludRve/OQ== X-Received: by 2002:a1c:3d4:: with SMTP id 203mr9441354wmd.52.1605187307871; Thu, 12 Nov 2020 05:21:47 -0800 (PST) Received: from dell ([91.110.221.159]) by smtp.gmail.com with ESMTPSA id g66sm6496468wmg.37.2020.11.12.05.21.46 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 12 Nov 2020 05:21:47 -0800 (PST) Date: Thu, 12 Nov 2020 13:21:45 +0000 From: Lee Jones To: Tero Kristo Cc: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Santosh Shilimkar , tomi.valkeinen@ti.com, kishon@ti.com, dmurphy@ti.com, s-anna@ti.com Subject: Re: [PATCH 06/25] soc: ti: knav_qmss_queue: Remove set but unchecked variable 'ret' Message-ID: <20201112132145.GI1997862@dell> References: <20201103152838.1290217-1-lee.jones@linaro.org> <20201103152838.1290217-7-lee.jones@linaro.org> <20201112103130.GD1997862@dell> <30ad256b-07f0-f01e-ec4f-c12cf9dbe426@ti.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <30ad256b-07f0-f01e-ec4f-c12cf9dbe426@ti.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 12 Nov 2020, Tero Kristo wrote: > On 12/11/2020 12:31, Lee Jones wrote: > > Cc:ing a few people I know. > > > > On Tue, 03 Nov 2020, Lee Jones wrote: > > > > > Fixes the following W=1 kernel build warning(s): > > > > > > drivers/soc/ti/knav_qmss_queue.c: In function ‘knav_setup_queue_pools’: > > > drivers/soc/ti/knav_qmss_queue.c:1310:6: warning: variable ‘ret’ set but not used [-Wunused-but-set-variable] > > > > > > Cc: Santosh Shilimkar > > > Cc: Sandeep Nair > > > Cc: Cyril Chemparathy > > > Signed-off-by: Lee Jones > > > --- > > > drivers/soc/ti/knav_qmss_queue.c | 3 +-- > > > 1 file changed, 1 insertion(+), 2 deletions(-) > > > > Any idea who will take these TI patches? > > > > https://lore.kernel.org/linux-arm-kernel/20201111052540.GH173948@builder.lan/ > > > > (Dropped a few inactive emails from delivery.) > > Santosh is the maintainer for the subsystem, so my vote would go for him. Thanks for your prompt reply Tero. It looks as though Santosh has been on Cc since the start. He must just be busy. I'll give him a little while longer before submitting a [RESEND]. -- Lee Jones [李琼斯] Senior Technical Lead - Developer Services Linaro.org │ Open source software for Arm SoCs Follow Linaro: Facebook | Twitter | Blog