From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.7 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7B883C5519F for ; Thu, 12 Nov 2020 19:22:29 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 1A65621D7F for ; Thu, 12 Nov 2020 19:22:29 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726633AbgKLTW2 (ORCPT ); Thu, 12 Nov 2020 14:22:28 -0500 Received: from mx2.suse.de ([195.135.220.15]:35714 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726255AbgKLTW1 (ORCPT ); Thu, 12 Nov 2020 14:22:27 -0500 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id 9C79EAFF8; Thu, 12 Nov 2020 19:22:25 +0000 (UTC) Date: Thu, 12 Nov 2020 20:22:23 +0100 From: Petr Vorel To: Christoph Hellwig Cc: Jens Axboe , Justin Sanders , Josef Bacik , Ilya Dryomov , Jack Wang , "Michael S. Tsirkin" , Jason Wang , Paolo Bonzini , Stefan Hajnoczi , Konrad Rzeszutek Wilk , Roger Pau =?iso-8859-2?Q?Monn=E9?= , Minchan Kim , Mike Snitzer , Song Liu , "Martin K. Petersen" , dm-devel@redhat.com, linux-block@vger.kernel.org, drbd-dev@lists.linbit.com, nbd@other.debian.org, ceph-devel@vger.kernel.org, xen-devel@lists.xenproject.org, linux-raid@vger.kernel.org, linux-nvme@lists.infradead.org, linux-scsi@vger.kernel.org, linux-fsdevel@vger.kernel.org Subject: Re: [PATCH 05/24] block: remove the update_bdev parameter from set_capacity_revalidate_and_notify Message-ID: <20201112192223.GA17194@pevik> Reply-To: Petr Vorel References: <20201111082658.3401686-1-hch@lst.de> <20201111082658.3401686-6-hch@lst.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20201111082658.3401686-6-hch@lst.de> Precedence: bulk List-ID: X-Mailing-List: ceph-devel@vger.kernel.org Hi Christoph, > The update_bdev argument is always set to true, so remove it. Also > rename the function to the slighly less verbose set_capacity_and_notify, > as propagating the disk size to the block device isn't really > revalidation. > Signed-off-by: Christoph Hellwig Reviewed-by: Petr Vorel Nice cleanup. Kind regards, Petr From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.7 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BBD64C388F7 for ; Fri, 13 Nov 2020 08:03:34 +0000 (UTC) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [63.128.21.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 0BE1220857 for ; Fri, 13 Nov 2020 08:03:33 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 0BE1220857 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=suse.cz Authentication-Results: mail.kernel.org; spf=tempfail smtp.mailfrom=dm-devel-bounces@redhat.com Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-568-m4kpTY4iPzKX2NIUJIWojg-1; Fri, 13 Nov 2020 03:03:31 -0500 X-MC-Unique: m4kpTY4iPzKX2NIUJIWojg-1 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 1A8716D240; Fri, 13 Nov 2020 08:03:27 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.20]) by smtp.corp.redhat.com (Postfix) with ESMTPS id ECE8F5C1C2; Fri, 13 Nov 2020 08:03:26 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id C0B85181A06B; Fri, 13 Nov 2020 08:03:26 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.rdu2.redhat.com [10.11.54.3]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id 0ACJXqBI024138 for ; Thu, 12 Nov 2020 14:33:52 -0500 Received: by smtp.corp.redhat.com (Postfix) id 008BB1175401; Thu, 12 Nov 2020 19:33:52 +0000 (UTC) Received: from mimecast-mx02.redhat.com (mimecast04.extmail.prod.ext.rdu2.redhat.com [10.11.55.20]) by smtp.corp.redhat.com (Postfix) with ESMTPS id EFEEB11753FF for ; Thu, 12 Nov 2020 19:33:47 +0000 (UTC) Received: from us-smtp-1.mimecast.com (us-smtp-1.mimecast.com [207.211.31.81]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-SHA384 (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id A3054102F1E2 for ; Thu, 12 Nov 2020 19:33:47 +0000 (UTC) Received: from mx2.suse.de (mx2.suse.de [195.135.220.15]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-113-RyEjmz2nNC6x3xEiDC2Ppw-1; Thu, 12 Nov 2020 14:33:42 -0500 X-MC-Unique: RyEjmz2nNC6x3xEiDC2Ppw-1 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id 9C79EAFF8; Thu, 12 Nov 2020 19:22:25 +0000 (UTC) Date: Thu, 12 Nov 2020 20:22:23 +0100 From: Petr Vorel To: Christoph Hellwig Message-ID: <20201112192223.GA17194@pevik> References: <20201111082658.3401686-1-hch@lst.de> <20201111082658.3401686-6-hch@lst.de> MIME-Version: 1.0 In-Reply-To: <20201111082658.3401686-6-hch@lst.de> X-Mimecast-Impersonation-Protect: Policy=CLT - Impersonation Protection Definition; Similar Internal Domain=false; Similar Monitored External Domain=false; Custom External Domain=false; Mimecast External Domain=false; Newly Observed Domain=false; Internal User Name=false; Custom Display Name List=false; Reply-to Address Mismatch=false; Targeted Threat Dictionary=false; Mimecast Threat Dictionary=false; Custom Threat Dictionary=false X-Scanned-By: MIMEDefang 2.78 on 10.11.54.3 X-loop: dm-devel@redhat.com X-Mailman-Approved-At: Fri, 13 Nov 2020 03:02:15 -0500 Cc: Justin Sanders , Mike Snitzer , "Michael S. Tsirkin" , Jason Wang , linux-nvme@lists.infradead.org, Song Liu , dm-devel@redhat.com, linux-scsi@vger.kernel.org, xen-devel@lists.xenproject.org, Ilya Dryomov , Jack Wang , Konrad Rzeszutek Wilk , Josef Bacik , nbd@other.debian.org, linux-raid@vger.kernel.org, Stefan Hajnoczi , drbd-dev@tron.linbit.com, ceph-devel@vger.kernel.org, Jens Axboe , linux-block@vger.kernel.org, "Martin K. Petersen" , Minchan Kim , linux-fsdevel@vger.kernel.org, Paolo Bonzini , Roger Pau =?iso-8859-2?Q?Monn=E9?= Subject: Re: [dm-devel] [PATCH 05/24] block: remove the update_bdev parameter from set_capacity_revalidate_and_notify X-BeenThere: dm-devel@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk Reply-To: Petr Vorel List-Id: device-mapper development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: dm-devel-bounces@redhat.com Errors-To: dm-devel-bounces@redhat.com X-Scanned-By: MIMEDefang 2.79 on 10.5.11.16 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=dm-devel-bounces@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Disposition: inline Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Hi Christoph, > The update_bdev argument is always set to true, so remove it. Also > rename the function to the slighly less verbose set_capacity_and_notify, > as propagating the disk size to the block device isn't really > revalidation. > Signed-off-by: Christoph Hellwig Reviewed-by: Petr Vorel Nice cleanup. Kind regards, Petr -- dm-devel mailing list dm-devel@redhat.com https://www.redhat.com/mailman/listinfo/dm-devel From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 13009C5519F for ; Thu, 12 Nov 2020 19:22:46 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 6ADBA20B80 for ; Thu, 12 Nov 2020 19:22:45 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="h0ei1qAG" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 6ADBA20B80 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=suse.cz Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-nvme-bounces+linux-nvme=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:Reply-To:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=xIj6i8krqzjLv5Ihg7b1EsRX66iAleuURFZ3FKv10R0=; b=h0ei1qAGlo47aUDbysweV8jLt+ APLroFEKfYerzG1Q95uu9d0UWaPb1p6kusoR22840U9WdO7gPK2wrBrhtkYCtrj0DUSLgua1LrQ34 QVHAzcMoA4QGuS4A81W3esgc2zdXbpk7xuQtk8FW0UysfbUuq4mbKI5b3fk266bXlMgXurqppVkLP u7yTVvksEL/7h5du4FcmW7YfhEql5VHoNlRMXOS3MCLGED+aYE7I8Jrcong31fAIdFR1R+oSRiPm5 qxH426iK0mHM5B7DNXOg7/scc1B2n4AHreFyDqQM5N5J9jBJ2VpoXBiL1gsjTcz9EMEMnU/n9GaZE gsvY9KBA==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kdIAx-0008Ne-9o; Thu, 12 Nov 2020 19:22:31 +0000 Received: from mx2.suse.de ([195.135.220.15]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kdIAu-0008My-92 for linux-nvme@lists.infradead.org; Thu, 12 Nov 2020 19:22:29 +0000 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id 9C79EAFF8; Thu, 12 Nov 2020 19:22:25 +0000 (UTC) Date: Thu, 12 Nov 2020 20:22:23 +0100 From: Petr Vorel To: Christoph Hellwig Subject: Re: [PATCH 05/24] block: remove the update_bdev parameter from set_capacity_revalidate_and_notify Message-ID: <20201112192223.GA17194@pevik> References: <20201111082658.3401686-1-hch@lst.de> <20201111082658.3401686-6-hch@lst.de> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20201111082658.3401686-6-hch@lst.de> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20201112_142228_468143_D720C138 X-CRM114-Status: GOOD ( 12.74 ) X-BeenThere: linux-nvme@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Petr Vorel Cc: Justin Sanders , Mike Snitzer , "Michael S. Tsirkin" , Jason Wang , linux-nvme@lists.infradead.org, Song Liu , dm-devel@redhat.com, drbd-dev@lists.linbit.com, linux-scsi@vger.kernel.org, xen-devel@lists.xenproject.org, Ilya Dryomov , Jack Wang , Konrad Rzeszutek Wilk , Josef Bacik , nbd@other.debian.org, linux-raid@vger.kernel.org, Stefan Hajnoczi , ceph-devel@vger.kernel.org, Jens Axboe , linux-block@vger.kernel.org, "Martin K. Petersen" , Minchan Kim , linux-fsdevel@vger.kernel.org, Paolo Bonzini , Roger Pau =?iso-8859-2?Q?Monn=E9?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "Linux-nvme" Errors-To: linux-nvme-bounces+linux-nvme=archiver.kernel.org@lists.infradead.org Hi Christoph, > The update_bdev argument is always set to true, so remove it. Also > rename the function to the slighly less verbose set_capacity_and_notify, > as propagating the disk size to the block device isn't really > revalidation. > Signed-off-by: Christoph Hellwig Reviewed-by: Petr Vorel Nice cleanup. Kind regards, Petr _______________________________________________ Linux-nvme mailing list Linux-nvme@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-nvme From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx2.suse.de (mx2.suse.de [195.135.220.15]) by mail19.linbit.com (LINBIT Mail Daemon) with ESMTP id 3209B420356 for ; Thu, 12 Nov 2020 20:33:40 +0100 (CET) Date: Thu, 12 Nov 2020 20:22:23 +0100 From: Petr Vorel To: Christoph Hellwig Message-ID: <20201112192223.GA17194@pevik> References: <20201111082658.3401686-1-hch@lst.de> <20201111082658.3401686-6-hch@lst.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20201111082658.3401686-6-hch@lst.de> Cc: Justin Sanders , Mike Snitzer , "Michael S. Tsirkin" , Jason Wang , linux-nvme@lists.infradead.org, Song Liu , dm-devel@redhat.com, drbd-dev@lists.linbit.com, linux-scsi@vger.kernel.org, xen-devel@lists.xenproject.org, Ilya Dryomov , Jack Wang , Konrad Rzeszutek Wilk , Josef Bacik , nbd@other.debian.org, linux-raid@vger.kernel.org, Stefan Hajnoczi , ceph-devel@vger.kernel.org, Jens Axboe , linux-block@vger.kernel.org, "Martin K. Petersen" , Minchan Kim , linux-fsdevel@vger.kernel.org, Paolo Bonzini , Roger Pau =?iso-8859-2?Q?Monn=E9?= Subject: Re: [Drbd-dev] [PATCH 05/24] block: remove the update_bdev parameter from set_capacity_revalidate_and_notify Reply-To: Petr Vorel List-Id: "*Coordination* of development, patches, contributions -- *Questions* \(even to developers\) go to drbd-user, please." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Hi Christoph, > The update_bdev argument is always set to true, so remove it. Also > rename the function to the slighly less verbose set_capacity_and_notify, > as propagating the disk size to the block device isn't really > revalidation. > Signed-off-by: Christoph Hellwig Reviewed-by: Petr Vorel Nice cleanup. Kind regards, Petr