From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.7 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8D3B6C55ABD for ; Thu, 12 Nov 2020 19:31:18 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 2E95420715 for ; Thu, 12 Nov 2020 19:31:17 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 2E95420715 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=ravnborg.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 50A156E405; Thu, 12 Nov 2020 19:31:17 +0000 (UTC) Received: from asavdk3.altibox.net (asavdk3.altibox.net [109.247.116.14]) by gabe.freedesktop.org (Postfix) with ESMTPS id 139B06E405 for ; Thu, 12 Nov 2020 19:31:16 +0000 (UTC) Received: from ravnborg.org (unknown [188.228.123.71]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by asavdk3.altibox.net (Postfix) with ESMTPS id 55E4320026; Thu, 12 Nov 2020 20:31:14 +0100 (CET) Date: Thu, 12 Nov 2020 20:31:13 +0100 From: Sam Ravnborg To: Lee Jones Subject: Re: [PATCH 01/30] drm/savage/savage_bci: Remove set but never used 'aper_rsrc' and 'fb_rsrc' Message-ID: <20201112193113.GD3287572@ravnborg.org> References: <20201112190039.2785914-1-lee.jones@linaro.org> <20201112190039.2785914-2-lee.jones@linaro.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20201112190039.2785914-2-lee.jones@linaro.org> X-CMAE-Score: 0 X-CMAE-Analysis: v=2.3 cv=VbvZwmh9 c=1 sm=1 tr=0 a=S6zTFyMACwkrwXSdXUNehg==:117 a=S6zTFyMACwkrwXSdXUNehg==:17 a=IkcTkHD0fZMA:10 a=e5mUnYsNAAAA:8 a=KKAkSRfTAAAA:8 a=lw-3Ehi1VaNlIoHz8JQA:9 a=QEXdDO2ut3YA:10 a=Vxmtnl_E_bksehYqCbjh:22 a=cvBusfyB2V15izCimMoJ:22 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: David Airlie , linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" T24gVGh1LCBOb3YgMTIsIDIwMjAgYXQgMDc6MDA6MTBQTSArMDAwMCwgTGVlIEpvbmVzIHdyb3Rl Ogo+IFRoZSBjb21tZW50IGFib3V0IHRoZW0gKGFsc28gcmVtb3ZlZCkgc2F5czoKPiAKPiAgLyog ZmJfcnNyYyBhbmQgYXBlcl9yc3JjIGFyZW4ndCByZWFsbHkgdXNlZCBjdXJyZW50bHksIGJ1dCBz dGlsbCBleGlzdAo+ICAgKiBpbiBjYXNlIHdlIGRlY2lkZSB3ZSBuZWVkIGluZm9ybWF0aW9uIG9u IHRoZSBCQVIgZm9yIEJTRCBpbiB0aGUKPiAgICogZnV0dXJlLgo+ICAgKi8KPiAKPiBXZWxsIHRo YXQgd2FzIHdyaXR0ZW4gMTIgeWVhcnMgYWdvIGluIDIwMDguICBXZSBhcmUgbm93IGluIHRoZSBm dXR1cmUKPiBhbmQgdGhleSBhcmUgc3RpbGwgc3VwZXJmbHVvdXMuICBXZSBjYW4gYWx3YXlzIGFk ZCB0aGVtIGFnYWluIGF0IGEKPiBsYXRlciBkYXRlIGlmIHRoZXkgYXJlIGV2ZXIgcmVxdWlyZWQu Cj4gCj4gRml4ZXMgdGhlIGZvbGxvd2luZyBXPTEga2VybmVsIGJ1aWxkIHdhcm5pbmcocyk6Cj4g Cj4gIGRyaXZlcnMvZ3B1L2RybS9zYXZhZ2Uvc2F2YWdlX2JjaS5jOiBJbiBmdW5jdGlvbiDigJhz YXZhZ2VfZHJpdmVyX2ZpcnN0b3BlbuKAmToKPiAgZHJpdmVycy9ncHUvZHJtL3NhdmFnZS9zYXZh Z2VfYmNpLmM6NTgwOjI0OiB3YXJuaW5nOiB2YXJpYWJsZSDigJhhcGVyX3JzcmPigJkgc2V0IGJ1 dCBub3QgdXNlZCBbLVd1bnVzZWQtYnV0LXNldC12YXJpYWJsZV0KPiAgZHJpdmVycy9ncHUvZHJt L3NhdmFnZS9zYXZhZ2VfYmNpLmM6NTgwOjE1OiB3YXJuaW5nOiB2YXJpYWJsZSDigJhmYl9yc3Jj 4oCZIHNldCBidXQgbm90IHVzZWQgWy1XdW51c2VkLWJ1dC1zZXQtdmFyaWFibGVdCj4gCj4gQ2M6 IERhdmlkIEFpcmxpZSA8YWlybGllZEBsaW51eC5pZT4KPiBDYzogRGFuaWVsIFZldHRlciA8ZGFu aWVsQGZmd2xsLmNoPgo+IENjOiBkcmktZGV2ZWxAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCj4gU2ln bmVkLW9mZi1ieTogTGVlIEpvbmVzIDxsZWUuam9uZXNAbGluYXJvLm9yZz4KPiAtLS0KClRoYW5r cywgYXBwbGllZCB0byBkcm0tbWlzYy1uZXh0LgoKICAgICAgICBTYW0KCl9fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCmRyaS1kZXZlbCBtYWlsaW5nIGxpc3QK ZHJpLWRldmVsQGxpc3RzLmZyZWVkZXNrdG9wLm9yZwpodHRwczovL2xpc3RzLmZyZWVkZXNrdG9w Lm9yZy9tYWlsbWFuL2xpc3RpbmZvL2RyaS1kZXZlbAo= From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.7 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C6E03C2D0E4 for ; Thu, 12 Nov 2020 19:31:17 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 70EA62222F for ; Thu, 12 Nov 2020 19:31:17 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726826AbgKLTbQ (ORCPT ); Thu, 12 Nov 2020 14:31:16 -0500 Received: from asavdk3.altibox.net ([109.247.116.14]:41996 "EHLO asavdk3.altibox.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726648AbgKLTbQ (ORCPT ); Thu, 12 Nov 2020 14:31:16 -0500 Received: from ravnborg.org (unknown [188.228.123.71]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by asavdk3.altibox.net (Postfix) with ESMTPS id 55E4320026; Thu, 12 Nov 2020 20:31:14 +0100 (CET) Date: Thu, 12 Nov 2020 20:31:13 +0100 From: Sam Ravnborg To: Lee Jones Cc: David Airlie , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 01/30] drm/savage/savage_bci: Remove set but never used 'aper_rsrc' and 'fb_rsrc' Message-ID: <20201112193113.GD3287572@ravnborg.org> References: <20201112190039.2785914-1-lee.jones@linaro.org> <20201112190039.2785914-2-lee.jones@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20201112190039.2785914-2-lee.jones@linaro.org> X-CMAE-Score: 0 X-CMAE-Analysis: v=2.3 cv=VbvZwmh9 c=1 sm=1 tr=0 a=S6zTFyMACwkrwXSdXUNehg==:117 a=S6zTFyMACwkrwXSdXUNehg==:17 a=IkcTkHD0fZMA:10 a=e5mUnYsNAAAA:8 a=KKAkSRfTAAAA:8 a=lw-3Ehi1VaNlIoHz8JQA:9 a=QEXdDO2ut3YA:10 a=Vxmtnl_E_bksehYqCbjh:22 a=cvBusfyB2V15izCimMoJ:22 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Nov 12, 2020 at 07:00:10PM +0000, Lee Jones wrote: > The comment about them (also removed) says: > > /* fb_rsrc and aper_rsrc aren't really used currently, but still exist > * in case we decide we need information on the BAR for BSD in the > * future. > */ > > Well that was written 12 years ago in 2008. We are now in the future > and they are still superfluous. We can always add them again at a > later date if they are ever required. > > Fixes the following W=1 kernel build warning(s): > > drivers/gpu/drm/savage/savage_bci.c: In function ‘savage_driver_firstopen’: > drivers/gpu/drm/savage/savage_bci.c:580:24: warning: variable ‘aper_rsrc’ set but not used [-Wunused-but-set-variable] > drivers/gpu/drm/savage/savage_bci.c:580:15: warning: variable ‘fb_rsrc’ set but not used [-Wunused-but-set-variable] > > Cc: David Airlie > Cc: Daniel Vetter > Cc: dri-devel@lists.freedesktop.org > Signed-off-by: Lee Jones > --- Thanks, applied to drm-misc-next. Sam