From: Stephen Hemminger <stephen@networkplumber.org>
To: Russell Strong <russell@strong.id.au>
Cc: netdev@vger.kernel.org
Subject: Re: [PATCH net-next] net: DSCP in IPv4 routing
Date: Thu, 12 Nov 2020 19:36:56 -0800 [thread overview]
Message-ID: <20201112193656.73621cd5@hermes.local> (raw)
In-Reply-To: <20201113120637.39c45f3f@192-168-1-16.tpgi.com.au>
On Fri, 13 Nov 2020 12:06:37 +1000
Russell Strong <russell@strong.id.au> wrote:
> diff --git a/include/uapi/linux/in_route.h
> b/include/uapi/linux/in_route.h index 0cc2c23b47f8..db5d236b9c50 100644
> --- a/include/uapi/linux/in_route.h
> +++ b/include/uapi/linux/in_route.h
> @@ -28,6 +28,6 @@
>
> #define RTCF_NAT (RTCF_DNAT|RTCF_SNAT)
>
> -#define RT_TOS(tos) ((tos)&IPTOS_TOS_MASK)
> +#define RT_TOS(tos) ((tos)&IPTOS_DS_MASK)
>
Changing behavior of existing header files risks breaking applications.
> diff --git a/net/ipv4/fib_rules.c b/net/ipv4/fib_rules.c
> index ce54a30c2ef1..1499105d1efd 100644
> --- a/net/ipv4/fib_rules.c
> +++ b/net/ipv4/fib_rules.c
> @@ -229,7 +229,7 @@ static int fib4_rule_configure(struct fib_rule
> *rule, struct sk_buff *skb, int err = -EINVAL;
> struct fib4_rule *rule4 = (struct fib4_rule *) rule;
>
> - if (frh->tos & ~IPTOS_TOS_MASK) {
> + if (frh->tos & ~IPTOS_RT_MASK) {
This needs to be behind a sysctl and the default has to be to keep
the old behavior
next prev parent reply other threads:[~2020-11-13 3:37 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-13 2:06 [PATCH net-next] net: DSCP in IPv4 routing Russell Strong
2020-11-13 3:36 ` Stephen Hemminger [this message]
2020-11-13 9:02 ` Guillaume Nault
2020-11-14 23:03 ` Russell Strong
2020-11-14 23:09 ` Russell Strong
2020-11-14 23:10 ` Russell Strong
2020-11-17 0:21 ` kernel test robot
2020-11-17 0:21 ` kernel test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201112193656.73621cd5@hermes.local \
--to=stephen@networkplumber.org \
--cc=netdev@vger.kernel.org \
--cc=russell@strong.id.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.