From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.5 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D55F1C5519F for ; Thu, 12 Nov 2020 20:08:59 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 5828C20825 for ; Thu, 12 Nov 2020 20:08:59 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="SGdJxSQD" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 5828C20825 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 9EB796E420; Thu, 12 Nov 2020 20:08:58 +0000 (UTC) Received: from mail-wm1-x343.google.com (mail-wm1-x343.google.com [IPv6:2a00:1450:4864:20::343]) by gabe.freedesktop.org (Postfix) with ESMTPS id C377C6E420 for ; Thu, 12 Nov 2020 20:08:57 +0000 (UTC) Received: by mail-wm1-x343.google.com with SMTP id 19so6347486wmf.1 for ; Thu, 12 Nov 2020 12:08:57 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to; bh=NdNkzlDaSwMULZwdt2G9+gSnA797TK1gCTMOnWVTmic=; b=SGdJxSQDiO/tnKMKOXGBrZdx4N8+4uGeEJZeArx9q3b8gl/6puets3SXatZ24xOzUG 5V4HB5CkMr+hZ4MpidHT2pEscVwmvhBM9UGWQGfB71Qr5xgM+I/XJbw/vMDCFkzHpavL P1dBYBiiOYYXO4qs2HhiZgc0ImkGm745k0AQJc1z4UbipSOKVd6xLVQMNUSZByVOrFlw yJVGNf5ZASBtBthAo6HFvTk4xM+Z6zPtU+JEBTktOUYsmoX8WZVy2tDmN1xNk/L3HOuN z73rFsT0OKQR4T/2Y2aKoMOBqeLpc82FAeQROYZ5OCgqutPBxw2hpJA4vevxVlvGN2dE +ntQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to; bh=NdNkzlDaSwMULZwdt2G9+gSnA797TK1gCTMOnWVTmic=; b=NRc9lI6Jsqp47MN0tA9jCE9oGi5YGtuMrc9HEvcG5D+wrrTJlwE2dmku6CcDvlKK4P nKhA8FBqxcZ9PqJ+9fr7mIetVcqhfY2pFRS7zRdLDco4h5m9+BbbhbCNjfov5zSbJs3m VXzw2Sp5LhR1YCz7MrXz8T9C5oV+jCJda446rhcpgW8O/UuJUUL1Ix43+xYM3IFP6IQe rdzmDNuMhdbcach9AWfidLvw1NUCCWrprv9boGLCpZBIPwCfnee7Uep7FMKSiMibHbiM 5yOW6nCZGXLemxD+1av2SGF+fZruEshT56+2HY+khf7shXw5KBuDNZXGNKnbkJQYcL5n +QUQ== X-Gm-Message-State: AOAM530u3Rb3qIhrUYlZBEtdaZBL2VNbsNUZqVVCWnF2LYVO0En7BQQD yygqPZnxbbN9kcS5klhne+b9AA== X-Google-Smtp-Source: ABdhPJytznGMi4YliKX3CB1LkC8RxmcXA4z6KnpfzORZmdGQuZFO+h1pMrtQhOCaNPKGhmoSFb3Lmg== X-Received: by 2002:a1c:c286:: with SMTP id s128mr1346590wmf.88.1605211734707; Thu, 12 Nov 2020 12:08:54 -0800 (PST) Received: from dell ([91.110.221.159]) by smtp.gmail.com with ESMTPSA id x6sm8081055wmc.48.2020.11.12.12.08.53 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 12 Nov 2020 12:08:54 -0800 (PST) Date: Thu, 12 Nov 2020 20:08:52 +0000 From: Lee Jones To: Sam Ravnborg Subject: Re: [PATCH 01/30] drm/savage/savage_bci: Remove set but never used 'aper_rsrc' and 'fb_rsrc' Message-ID: <20201112200852.GB2787115@dell> References: <20201112190039.2785914-1-lee.jones@linaro.org> <20201112190039.2785914-2-lee.jones@linaro.org> <20201112193113.GD3287572@ravnborg.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20201112193113.GD3287572@ravnborg.org> X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: David Airlie , linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" T24gVGh1LCAxMiBOb3YgMjAyMCwgU2FtIFJhdm5ib3JnIHdyb3RlOgoKPiBPbiBUaHUsIE5vdiAx MiwgMjAyMCBhdCAwNzowMDoxMFBNICswMDAwLCBMZWUgSm9uZXMgd3JvdGU6Cj4gPiBUaGUgY29t bWVudCBhYm91dCB0aGVtIChhbHNvIHJlbW92ZWQpIHNheXM6Cj4gPiAKPiA+ICAvKiBmYl9yc3Jj IGFuZCBhcGVyX3JzcmMgYXJlbid0IHJlYWxseSB1c2VkIGN1cnJlbnRseSwgYnV0IHN0aWxsIGV4 aXN0Cj4gPiAgICogaW4gY2FzZSB3ZSBkZWNpZGUgd2UgbmVlZCBpbmZvcm1hdGlvbiBvbiB0aGUg QkFSIGZvciBCU0QgaW4gdGhlCj4gPiAgICogZnV0dXJlLgo+ID4gICAqLwo+ID4gCj4gPiBXZWxs IHRoYXQgd2FzIHdyaXR0ZW4gMTIgeWVhcnMgYWdvIGluIDIwMDguICBXZSBhcmUgbm93IGluIHRo ZSBmdXR1cmUKPiA+IGFuZCB0aGV5IGFyZSBzdGlsbCBzdXBlcmZsdW91cy4gIFdlIGNhbiBhbHdh eXMgYWRkIHRoZW0gYWdhaW4gYXQgYQo+ID4gbGF0ZXIgZGF0ZSBpZiB0aGV5IGFyZSBldmVyIHJl cXVpcmVkLgo+ID4gCj4gPiBGaXhlcyB0aGUgZm9sbG93aW5nIFc9MSBrZXJuZWwgYnVpbGQgd2Fy bmluZyhzKToKPiA+IAo+ID4gIGRyaXZlcnMvZ3B1L2RybS9zYXZhZ2Uvc2F2YWdlX2JjaS5jOiBJ biBmdW5jdGlvbiDigJhzYXZhZ2VfZHJpdmVyX2ZpcnN0b3BlbuKAmToKPiA+ICBkcml2ZXJzL2dw dS9kcm0vc2F2YWdlL3NhdmFnZV9iY2kuYzo1ODA6MjQ6IHdhcm5pbmc6IHZhcmlhYmxlIOKAmGFw ZXJfcnNyY+KAmSBzZXQgYnV0IG5vdCB1c2VkIFstV3VudXNlZC1idXQtc2V0LXZhcmlhYmxlXQo+ ID4gIGRyaXZlcnMvZ3B1L2RybS9zYXZhZ2Uvc2F2YWdlX2JjaS5jOjU4MDoxNTogd2FybmluZzog dmFyaWFibGUg4oCYZmJfcnNyY+KAmSBzZXQgYnV0IG5vdCB1c2VkIFstV3VudXNlZC1idXQtc2V0 LXZhcmlhYmxlXQo+ID4gCj4gPiBDYzogRGF2aWQgQWlybGllIDxhaXJsaWVkQGxpbnV4LmllPgo+ ID4gQ2M6IERhbmllbCBWZXR0ZXIgPGRhbmllbEBmZndsbC5jaD4KPiA+IENjOiBkcmktZGV2ZWxA bGlzdHMuZnJlZWRlc2t0b3Aub3JnCj4gPiBTaWduZWQtb2ZmLWJ5OiBMZWUgSm9uZXMgPGxlZS5q b25lc0BsaW5hcm8ub3JnPgo+ID4gLS0tCj4gCj4gVGhhbmtzLCBhcHBsaWVkIHRvIGRybS1taXNj LW5leHQuCgpUaGFua3MgZm9yIHlvdXIgcHJvbXB0IHJlc3BvbnNlIFNhbS4gIE11Y2ggYXBwcmVj aWF0ZWQuCgotLSAKTGVlIEpvbmVzIFvmnY7nkLzmlq9dClNlbmlvciBUZWNobmljYWwgTGVhZCAt IERldmVsb3BlciBTZXJ2aWNlcwpMaW5hcm8ub3JnIOKUgiBPcGVuIHNvdXJjZSBzb2Z0d2FyZSBm b3IgQXJtIFNvQ3MKRm9sbG93IExpbmFybzogRmFjZWJvb2sgfCBUd2l0dGVyIHwgQmxvZwpfX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpkcmktZGV2ZWwgbWFp bGluZyBsaXN0CmRyaS1kZXZlbEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0cHM6Ly9saXN0cy5m cmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9kcmktZGV2ZWwK From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 09F34C2D0E4 for ; Thu, 12 Nov 2020 20:08:58 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 9339F20825 for ; Thu, 12 Nov 2020 20:08:57 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="SGdJxSQD" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727003AbgKLUI4 (ORCPT ); Thu, 12 Nov 2020 15:08:56 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55526 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726854AbgKLUI4 (ORCPT ); Thu, 12 Nov 2020 15:08:56 -0500 Received: from mail-wm1-x344.google.com (mail-wm1-x344.google.com [IPv6:2a00:1450:4864:20::344]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 12E56C0613D1 for ; Thu, 12 Nov 2020 12:08:56 -0800 (PST) Received: by mail-wm1-x344.google.com with SMTP id a3so6561352wmb.5 for ; Thu, 12 Nov 2020 12:08:56 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to; bh=NdNkzlDaSwMULZwdt2G9+gSnA797TK1gCTMOnWVTmic=; b=SGdJxSQDiO/tnKMKOXGBrZdx4N8+4uGeEJZeArx9q3b8gl/6puets3SXatZ24xOzUG 5V4HB5CkMr+hZ4MpidHT2pEscVwmvhBM9UGWQGfB71Qr5xgM+I/XJbw/vMDCFkzHpavL P1dBYBiiOYYXO4qs2HhiZgc0ImkGm745k0AQJc1z4UbipSOKVd6xLVQMNUSZByVOrFlw yJVGNf5ZASBtBthAo6HFvTk4xM+Z6zPtU+JEBTktOUYsmoX8WZVy2tDmN1xNk/L3HOuN z73rFsT0OKQR4T/2Y2aKoMOBqeLpc82FAeQROYZ5OCgqutPBxw2hpJA4vevxVlvGN2dE +ntQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to; bh=NdNkzlDaSwMULZwdt2G9+gSnA797TK1gCTMOnWVTmic=; b=MMSEIrZzh3gePzeeSOlL7BNCTjibPvJ7Vdl4+OevcMcxLHGILTd06GLNMiufolRur3 xujwO3kWwFp4DmQPaZhwBOb9oIUjNJ3DWL/EqmG80ueti9MzhNwENGLips4AJJKqiNQg XJA/mxPNj2TgrGI3vr37N5QRi07077SXE2Ra70oJY0Fcjim2T1UvLI8yt2rzVhBSAB74 MRpZdAipNI8ge+kdC83qOR/9Ago3Ll3JY9stJI6FugOSmhC8KKnutbrdjjZPxareVIw7 sWgehn5tlsL3TDQmVFABuefTnbldL2yPTCG4hDsZunwiui41cAA/7ACdtMp8+rlNDB4X Capg== X-Gm-Message-State: AOAM533rKzvUpD5M1wO7ozUOc3WEBzVC/ebAVIgEVgRfkilnND0VpOBy 9e1zLof+JHjnlHtLDaW8Yj06I+CZSEqdFMHx X-Google-Smtp-Source: ABdhPJytznGMi4YliKX3CB1LkC8RxmcXA4z6KnpfzORZmdGQuZFO+h1pMrtQhOCaNPKGhmoSFb3Lmg== X-Received: by 2002:a1c:c286:: with SMTP id s128mr1346590wmf.88.1605211734707; Thu, 12 Nov 2020 12:08:54 -0800 (PST) Received: from dell ([91.110.221.159]) by smtp.gmail.com with ESMTPSA id x6sm8081055wmc.48.2020.11.12.12.08.53 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 12 Nov 2020 12:08:54 -0800 (PST) Date: Thu, 12 Nov 2020 20:08:52 +0000 From: Lee Jones To: Sam Ravnborg Cc: David Airlie , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 01/30] drm/savage/savage_bci: Remove set but never used 'aper_rsrc' and 'fb_rsrc' Message-ID: <20201112200852.GB2787115@dell> References: <20201112190039.2785914-1-lee.jones@linaro.org> <20201112190039.2785914-2-lee.jones@linaro.org> <20201112193113.GD3287572@ravnborg.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20201112193113.GD3287572@ravnborg.org> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 12 Nov 2020, Sam Ravnborg wrote: > On Thu, Nov 12, 2020 at 07:00:10PM +0000, Lee Jones wrote: > > The comment about them (also removed) says: > > > > /* fb_rsrc and aper_rsrc aren't really used currently, but still exist > > * in case we decide we need information on the BAR for BSD in the > > * future. > > */ > > > > Well that was written 12 years ago in 2008. We are now in the future > > and they are still superfluous. We can always add them again at a > > later date if they are ever required. > > > > Fixes the following W=1 kernel build warning(s): > > > > drivers/gpu/drm/savage/savage_bci.c: In function ‘savage_driver_firstopen’: > > drivers/gpu/drm/savage/savage_bci.c:580:24: warning: variable ‘aper_rsrc’ set but not used [-Wunused-but-set-variable] > > drivers/gpu/drm/savage/savage_bci.c:580:15: warning: variable ‘fb_rsrc’ set but not used [-Wunused-but-set-variable] > > > > Cc: David Airlie > > Cc: Daniel Vetter > > Cc: dri-devel@lists.freedesktop.org > > Signed-off-by: Lee Jones > > --- > > Thanks, applied to drm-misc-next. Thanks for your prompt response Sam. Much appreciated. -- Lee Jones [李琼斯] Senior Technical Lead - Developer Services Linaro.org │ Open source software for Arm SoCs Follow Linaro: Facebook | Twitter | Blog