From: Hui Su <sh_def@163.com>
To: tglx@linutronix.de, mingo@redhat.com, bp@alien8.de,
x86@kernel.org, hpa@zytor.com, 0x7f454c46@gmail.com,
jroedel@suse.de, akpm@linux-foundation.org, pmladek@suse.com,
jannh@google.com, mark.mossberg@gmail.com,
linux-kernel@vger.kernel.org
Cc: sh_def@163.com
Subject: [PATCH] x86/dumpstack: make show_trace_log_lvl() static
Date: Fri, 13 Nov 2020 21:39:43 +0800 [thread overview]
Message-ID: <20201113133943.GA136221@rlk> (raw)
show_trace_log_lvl() won't be used by other files, so
make it static and remove the declaration from the header
file.
Signed-off-by: Hui Su <sh_def@163.com>
---
arch/x86/include/asm/stacktrace.h | 3 ---
arch/x86/kernel/dumpstack.c | 2 +-
2 files changed, 1 insertion(+), 4 deletions(-)
diff --git a/arch/x86/include/asm/stacktrace.h b/arch/x86/include/asm/stacktrace.h
index 49600643faba..f248eb2ac2d4 100644
--- a/arch/x86/include/asm/stacktrace.h
+++ b/arch/x86/include/asm/stacktrace.h
@@ -88,9 +88,6 @@ get_stack_pointer(struct task_struct *task, struct pt_regs *regs)
return (unsigned long *)task->thread.sp;
}
-void show_trace_log_lvl(struct task_struct *task, struct pt_regs *regs,
- unsigned long *stack, const char *log_lvl);
-
/* The form of the top of the frame on the stack */
struct stack_frame {
struct stack_frame *next_frame;
diff --git a/arch/x86/kernel/dumpstack.c b/arch/x86/kernel/dumpstack.c
index 25c06b67e7e0..067de0d0fa4f 100644
--- a/arch/x86/kernel/dumpstack.c
+++ b/arch/x86/kernel/dumpstack.c
@@ -168,7 +168,7 @@ static void show_regs_if_on_stack(struct stack_info *info, struct pt_regs *regs,
}
}
-void show_trace_log_lvl(struct task_struct *task, struct pt_regs *regs,
+static void show_trace_log_lvl(struct task_struct *task, struct pt_regs *regs,
unsigned long *stack, const char *log_lvl)
{
struct unwind_state state;
--
2.29.0
next reply other threads:[~2020-11-13 13:43 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-13 13:39 Hui Su [this message]
2020-11-17 18:24 ` [tip: x86/cleanups] x86/dumpstack: Make show_trace_log_lvl() static tip-bot2 for Hui Su
2020-11-20 9:50 ` [PATCH] x86/dumpstack: make " Petr Mladek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201113133943.GA136221@rlk \
--to=sh_def@163.com \
--cc=0x7f454c46@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=bp@alien8.de \
--cc=hpa@zytor.com \
--cc=jannh@google.com \
--cc=jroedel@suse.de \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.mossberg@gmail.com \
--cc=mingo@redhat.com \
--cc=pmladek@suse.com \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.