Re: [PATCH v4 05/10] ASoC: SOF: Intel: Define ops for client registration

[kernel test robot <lkp@intel.com>]

[-- Attachment #1: Type: text/plain, Size: 3349 bytes --]

Hi Dave,

I love your patch! Perhaps something to improve:

[auto build test WARNING on driver-core/driver-core-testing]
[also build test WARNING on sound/for-next linus/master v5.10-rc3]
[cannot apply to asoc/for-next next-20201113]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]

url:    https://github.com/0day-ci/linux/commits/Dave-Ertman/Auxiliary-bus-implementation-and-SOF-multi-client-support/20201114-002359
base:   https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/driver-core.git 33c0c9bdf7a59051a654cd98b7d2b48ce0080967
config: xtensa-allyesconfig (attached as .config)
compiler: xtensa-linux-gcc (GCC) 9.3.0
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # https://github.com/0day-ci/linux/commit/f37759ce865d124754c1cbdd42cd5e9d77924af8
        git remote add linux-review https://github.com/0day-ci/linux
        git fetch --no-tags linux-review Dave-Ertman/Auxiliary-bus-implementation-and-SOF-multi-client-support/20201114-002359
        git checkout f37759ce865d124754c1cbdd42cd5e9d77924af8
        # save the attached .config to linux build tree
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=xtensa 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>

All warnings (new ones prefixed by >>):

>> sound/soc/sof/intel/apl.c:158:1: warning: data definition has no type or storage class
     158 | MODULE_IMPORT_NS(SND_SOC_SOF_INTEL_CLIENT);
         | ^~~~~~~~~~~~~~~~
   sound/soc/sof/intel/apl.c:158:1: error: type defaults to 'int' in declaration of 'MODULE_IMPORT_NS' [-Werror=implicit-int]
>> sound/soc/sof/intel/apl.c:158:1: warning: parameter names (without types) in function declaration
   cc1: some warnings being treated as errors
--
>> sound/soc/sof/intel/cnl.c:411:1: warning: data definition has no type or storage class
     411 | MODULE_IMPORT_NS(SND_SOC_SOF_INTEL_CLIENT);
         | ^~~~~~~~~~~~~~~~
   sound/soc/sof/intel/cnl.c:411:1: error: type defaults to 'int' in declaration of 'MODULE_IMPORT_NS' [-Werror=implicit-int]
>> sound/soc/sof/intel/cnl.c:411:1: warning: parameter names (without types) in function declaration
   cc1: some warnings being treated as errors

vim +158 sound/soc/sof/intel/apl.c

   142	
   143	const struct sof_intel_dsp_desc apl_chip_info = {
   144		/* Apollolake */
   145		.cores_num = 2,
   146		.init_core_mask = 1,
   147		.host_managed_cores_mask = GENMASK(1, 0),
   148		.ipc_req = HDA_DSP_REG_HIPCI,
   149		.ipc_req_mask = HDA_DSP_REG_HIPCI_BUSY,
   150		.ipc_ack = HDA_DSP_REG_HIPCIE,
   151		.ipc_ack_mask = HDA_DSP_REG_HIPCIE_DONE,
   152		.ipc_ctl = HDA_DSP_REG_HIPCCTL,
   153		.rom_init_timeout	= 150,
   154		.ssp_count = APL_SSP_COUNT,
   155		.ssp_base_offset = APL_SSP_BASE_OFFSET,
   156	};
   157	EXPORT_SYMBOL_NS(apl_chip_info, SND_SOC_SOF_INTEL_HDA_COMMON);
 > 158	MODULE_IMPORT_NS(SND_SOC_SOF_INTEL_CLIENT);

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org

[-- Attachment #2: config.gz --]
[-- Type: application/gzip, Size: 66176 bytes --]