Re: [RFC PATCH] mmc: sdhci: tegra: fix wrong unit with busy_timeout

[kernel test robot <lkp@intel.com>]

[-- Attachment #1: Type: text/plain, Size: 3403 bytes --]

Hi Wolfram,

[FYI, it's a private test report for your RFC patch.]
[auto build test ERROR on tegra/for-next]
[also build test ERROR on v5.10-rc3 next-20201113]
[cannot apply to ulf.hansson-mmc/next mmc/mmc-next]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]

url:    https://github.com/0day-ci/linux/commits/Wolfram-Sang/mmc-sdhci-tegra-fix-wrong-unit-with-busy_timeout/20201113-205511
base:   https://git.kernel.org/pub/scm/linux/kernel/git/tegra/linux.git for-next
config: h8300-randconfig-c004-20201113 (attached as .config)
compiler: h8300-linux-gcc (GCC) 9.3.0
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # https://github.com/0day-ci/linux/commit/d5481f1c9768ea4e5a43617ef5a853dd716d00f1
        git remote add linux-review https://github.com/0day-ci/linux
        git fetch --no-tags linux-review Wolfram-Sang/mmc-sdhci-tegra-fix-wrong-unit-with-busy_timeout/20201113-205511
        git checkout d5481f1c9768ea4e5a43617ef5a853dd716d00f1
        # save the attached .config to linux build tree
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=h8300 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>

All errors (new ones prefixed by >>):

   drivers/mmc/host/sdhci-tegra.c: In function 'tegra_sdhci_set_timeout':
>> drivers/mmc/host/sdhci-tegra.c:1275:39: error: 'MSECS_PER_SEC' undeclared (first use in this function); did you mean 'MSEC_PER_SEC'?
    1275 |  if (cmd && cmd->busy_timeout >= 11 * MSECS_PER_SEC)
         |                                       ^~~~~~~~~~~~~
         |                                       MSEC_PER_SEC
   drivers/mmc/host/sdhci-tegra.c:1275:39: note: each undeclared identifier is reported only once for each function it appears in

vim +1275 drivers/mmc/host/sdhci-tegra.c

  1255	
  1256	static void tegra_sdhci_set_timeout(struct sdhci_host *host,
  1257					    struct mmc_command *cmd)
  1258	{
  1259		u32 val;
  1260	
  1261		/*
  1262		 * HW busy detection timeout is based on programmed data timeout
  1263		 * counter and maximum supported timeout is 11s which may not be
  1264		 * enough for long operations like cache flush, sleep awake, erase.
  1265		 *
  1266		 * ERASE_TIMEOUT_LIMIT bit of VENDOR_MISC_CTRL register allows
  1267		 * host controller to wait for busy state until the card is busy
  1268		 * without HW timeout.
  1269		 *
  1270		 * So, use infinite busy wait mode for operations that may take
  1271		 * more than maximum HW busy timeout of 11s otherwise use finite
  1272		 * busy wait mode.
  1273		 */
  1274		val = sdhci_readl(host, SDHCI_TEGRA_VENDOR_MISC_CTRL);
> 1275		if (cmd && cmd->busy_timeout >= 11 * MSECS_PER_SEC)
  1276			val |= SDHCI_MISC_CTRL_ERASE_TIMEOUT_LIMIT;
  1277		else
  1278			val &= ~SDHCI_MISC_CTRL_ERASE_TIMEOUT_LIMIT;
  1279		sdhci_writel(host, val, SDHCI_TEGRA_VENDOR_MISC_CTRL);
  1280	
  1281		__sdhci_set_timeout(host, cmd);
  1282	}
  1283	

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org

[-- Attachment #2: config.gz --]
[-- Type: application/gzip, Size: 32021 bytes --]